Changes in gr2d.c

e70140ba - Get rid of 'remove_new' relic from platform driver struct

Sun, 01 Dec 2024 23:12:43 +0000

Get rid of 'remove_new' relic from platform driver structThe continual trickle of small conversion patches is grating on me, andis really not helping. Just get rid of the 'remove_new' memberfunction, which is just an alias for the plain 'remove', and had acomment to that effect: /* * .remove_new() is a relic from a prototype conversion of .remove(). * New drivers are supposed to implement .remove(). Once all drivers are * converted to not use .remove_new any more, it will be dropped. */This was just a tree-wide 'sed' script that replaced '.remove_new' with'.remove', with some care taken to turn a subsequent tab into two tabsto make things line up.I did do some minimal manual whitespace adjustment for places that usedspaces to line things up.Then I just removed the old (sic) .remove_new member function, and thisis the end result. No more unnecessary conversion noise.Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/gpu/drm/tegra/gr2d.c

62fa0a98 - drm/tegra: Enable runtime PM during probe

Tue, 13 Jun 2023 09:52:14 +0000

drm/tegra: Enable runtime PM during probeCurrently, engine drivers only enable runtime PM during the host1xinit callback. This can happen slightly later than the probe, whichcan cause the power domain to intermittently not be turned off afterprobe.My hypothesis is that there is a race condition between the post-probepower domain poweroff that is done from a queued work, and thepm_runtime_enable call happening in the host1x init callback.If the pm_runtime_enable call happens first, everything is OK andthe power off work can disable the power domain as PM runtime isenabled and the device is runtime suspended. If power off work runsfirst, PM runtime is still disabled for the device and the domainmust be kept powered.Resolve the issue by moving the runtime PM enablement to theprobe function.Signed-off-by: Mikko Perttunen Signed-off-by: Thierry Reding Link: https://patchwork.freedesktop.org/patch/msgid/20230613095215.2497004-1-cyndis@kapsi.fi List of files: /linux-6.15/drivers/gpu/drm/tegra/gr2d.c

722d4f06 - drm: Explicitly include correct DT includes

Fri, 14 Jul 2023 17:45:34 +0000

drm: Explicitly include correct DT includesThe DT of_device.h and of_platform.h date back to the separateof_platform_bus_type before it as merged into the regular platform bus.As part of that merge prepping Arm DT support 13 years ago, they"temporarily" include each other. They also include platform_device.hand of.h. As a result, there's a pretty much random mix of those includefiles used throughout the tree. In order to detangle these headers andreplace the implicit includes with struct declarations, users need toexplicitly include the correct includes.Signed-off-by: Rob Herring Acked-by: Sam Ravnborg Reviewed-by: Steven Price Acked-by: Liviu Dudau Reviewed-by: Kieran Bingham Acked-by: Robert Foss Signed-off-by: Thierry Reding Link: https://patchwork.freedesktop.org/patch/msgid/20230714174545.4056287-1-robh@kernel.org List of files: /linux-6.15/drivers/gpu/drm/tegra/gr2d.c

e12ce931 - drm/tegra: gr2d: Convert to platform remove callback returning void

Wed, 22 Mar 2023 17:02:17 +0000

drm/tegra: gr2d: Convert to platform remove callback returning voidThe .remove() callback for a platform driver returns an int which makesmany driver authors wrongly assume it's possible to do error handling byreturning an error code. However the value returned is (mostly) ignoredand this typically results in resource leaks. To improve here there is aquest to make the remove callback return void. In the first step of thisquest all drivers are converted to .remove_new() which already returnsvoid.Trivially convert this driver from always returning zero in the removecallback to the void returning variant.Signed-off-by: Uwe Kleine-König Signed-off-by: Thierry Reding List of files: /linux-6.15/drivers/gpu/drm/tegra/gr2d.c

1d83d1a2 - gpu: host1x: Make host1x_client_unregister() return void

Wed, 22 Mar 2023 17:02:12 +0000

gpu: host1x: Make host1x_client_unregister() return voidThis function returned zero unconditionally. Make it return no value andsimplify all callers accordingly.Signed-off-by: Uwe Kleine-König Acked-by: Hans Verkuil Signed-off-by: Thierry Reding List of files: /linux-6.15/drivers/gpu/drm/tegra/gr2d.c

58ed47ad - drm/tegra: Consolidate runtime PM management of older UAPI codepath

Tue, 30 Nov 2021 23:23:25 +0000

drm/tegra: Consolidate runtime PM management of older UAPI codepathMove runtime PM management of older UAPI code paths into the common place.This removes boilerplate code from client drivers.Signed-off-by: Dmitry Osipenko Signed-off-by: Thierry Reding List of files: /linux-6.15/drivers/gpu/drm/tegra/gr2d.c

e4e4a710 - drm/tegra: gr2d: Support generic power domain and runtime PM

Tue, 30 Nov 2021 23:23:20 +0000

drm/tegra: gr2d: Support generic power domain and runtime PMAdd runtime power management and support generic power domains.Reviewed-by: Ulf Hansson Tested-by: Peter Geis # Ouya T30Tested-by: Paul Fertser # PAZ00 T20Tested-by: Nicolas Chauvet # PAZ00 T20 and TK1 T124Tested-by: Matt Merhar # Ouya T30Signed-off-by: Dmitry Osipenko Signed-off-by: Thierry Reding List of files: /linux-6.15/drivers/gpu/drm/tegra/gr2d.c

271fca02 - drm/tegra: gr2d: Explicitly control module reset

Thu, 08 Jul 2021 14:37:36 +0000

drm/tegra: gr2d: Explicitly control module resetAs of commit 4782c0a5dd88 ("clk: tegra: Don't deassert reset on enablingclocks"), module resets are no longer automatically deasserted when themodule clock is enabled. To make sure that the gr2d module continues towork, we need to explicitly control the module reset.Fixes: 4782c0a5dd88 ("clk: tegra: Don't deassert reset on enabling clocks")Signed-off-by: Thierry Reding List of files: /linux-6.15/drivers/gpu/drm/tegra/gr2d.c

2aed4f5a - gpu: host1x: Cleanup and refcounting for syncpoints

Mon, 29 Mar 2021 13:38:32 +0000

gpu: host1x: Cleanup and refcounting for syncpointsAdd reference counting for allocated syncpoints to allow keepingthem allocated while jobs are referencing them. Additionally,clean up various places using syncpoint IDs to use host1x_syncptpointers instead.Signed-off-by: Mikko Perttunen Signed-off-by: Thierry Reding List of files: /linux-6.15/drivers/gpu/drm/tegra/gr2d.c

3ef170c2 - drm/tegra: gr2d: Add compatible for Tegra114

Tue, 12 Jan 2021 18:14:21 +0000

drm/tegra: gr2d: Add compatible for Tegra114Tegra114 has GR2D hardware block, support it by the 2D driver.Tested-by: Anton Bambura Signed-off-by: Dmitry Osipenko Signed-off-by: Thierry Reding List of files: /linux-6.15/drivers/gpu/drm/tegra/gr2d.c

efc8a109 - drm/tegra: gr2d: Correct swapped device-tree compatibles

Tue, 12 Jan 2021 18:14:20 +0000

drm/tegra: gr2d: Correct swapped device-tree compatiblesThe device-tree compatibles are swapped in the code, correct them.Tested-by: Peter Geis Tested-by: Nicolas Chauvet Tested-by: Matt Merhar Signed-off-by: Dmitry Osipenko Signed-off-by: Thierry Reding List of files: /linux-6.15/drivers/gpu/drm/tegra/gr2d.c

5c9b969f - drm/tegra: gr2d: Add tiled PATBASE address register

Mon, 29 Jun 2020 03:18:38 +0000

drm/tegra: gr2d: Add tiled PATBASE address registerThere are two PATBASE address registers, one for linear layout and otherfor tiled. The driver's address registers list misses the tiled PATBASEregister.Signed-off-by: Dmitry Osipenko Signed-off-by: Thierry Reding List of files: /linux-6.15/drivers/gpu/drm/tegra/gr2d.c

608f43ad - gpu: host1x: Rename "parent" to "host"

Mon, 02 Dec 2019 09:51:58 +0000

gpu: host1x: Rename "parent" to "host"Rename the host1x clients' parent to "host" because that more closelydescribes what it is. The parent can be confused with the parent devicein terms of the device hierarchy. Subsequent patches will add a newmember that refers to the parent in that hierarchy.Signed-off-by: Thierry Reding List of files: /linux-6.15/drivers/gpu/drm/tegra/gr2d.c

7edd7961 - drm/tegra: Simplify IOMMU group selection

Mon, 28 Oct 2019 12:37:08 +0000

drm/tegra: Simplify IOMMU group selectionAll the devices that make up the DRM device are now part of the sameIOMMU group. This simplifies the handling of the IOMMU attachment andalso avoids exhausting the number of IOMMUs available on early TegraSoC generations.Signed-off-by: Thierry Reding List of files: /linux-6.15/drivers/gpu/drm/tegra/gr2d.c

aacdf198 - drm/tegra: Move IOMMU group into host1x client

Fri, 08 Feb 2019 13:35:13 +0000

drm/tegra: Move IOMMU group into host1x clientHandling of the IOMMU group attachment is common to all clients, so movethe group into the client to simplify code.Signed-off-by: Thierry Reding List of files: /linux-6.15/drivers/gpu/drm/tegra/gr2d.c

caccddcf - gpu: host1x: Request channels for clients, not devices

Mon, 18 Jun 2018 12:01:51 +0000

gpu: host1x: Request channels for clients, not devicesA struct device doesn't carry much information that a channel might beinterested in, but the client very much does. Request channels for theclients rather than their parent devices and store a pointer to themin order to have that information available when needed.Signed-off-by: Thierry Reding List of files: /linux-6.15/drivers/gpu/drm/tegra/gr2d.c

eb1df694 - drm/tegra: drop use of drmP.h

Sun, 04 Aug 2019 09:41:30 +0000

drm/tegra: drop use of drmP.hDrop use of the deprecated drmP.h header file.For all touched files divide include files into blocks,and sort them within the blocks.Fix fallout.Signed-off-by: Sam Ravnborg Reviewed-by: Thierry Reding Cc: Thierry Reding Cc: Jonathan Hunter Cc: linux-tegra@vger.kernel.orgLink: https://patchwork.freedesktop.org/patch/msgid/20190804094132.29463-3-sam@ravnborg.org List of files: /linux-6.15/drivers/gpu/drm/tegra/gr2d.c

d2912cb1 - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500

Tue, 04 Jun 2019 08:11:33 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500Based on 2 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation #extracted by the scancode license scanner the SPDX license identifier GPL-2.0-onlyhas been chosen to replace the boilerplate/reference in 4122 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Enrico Weigelt Reviewed-by: Kate Stewart Reviewed-by: Allison Randal Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190604081206.933168790@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/gpu/drm/tegra/gr2d.c

840fd213 - drm/tegra: gr2d: Track interface version

Wed, 16 May 2018 15:06:36 +0000

drm/tegra: gr2d: Track interface versionSet the interface version implemented by the gr2d module. This allowsuserspace to pass the correct command stream when programming the gr2dmodule.Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko Signed-off-by: Thierry Reding List of files: /linux-6.15/drivers/gpu/drm/tegra/gr2d.c

0c407de5 - drm/tegra: Refactor IOMMU attach/detach

Fri, 04 May 2018 13:02:24 +0000

drm/tegra: Refactor IOMMU attach/detachAttaching to and detaching from an IOMMU uses the same code sequence inevery driver, so factor it out into separate helpers.Reviewed-by: Dmitry Osipenko Signed-off-by: Thierry Reding List of files: /linux-6.15/drivers/gpu/drm/tegra/gr2d.c