Changes in gem.c

cdd30ebb - module: Convert symbol namespace to string literal

Mon, 02 Dec 2024 14:59:47 +0000

module: Convert symbol namespace to string literalClean up the existing export namespace code along the same lines ofcommit 33def8498fdd ("treewide: Convert macro and uses of __section(foo)to __section("foo")") and for the same reason, it is not desired for thenamespace argument to be a macro expansion itself.Scripted using git grep -l -e MODULE_IMPORT_NS -e EXPORT_SYMBOL_NS | while read file; do awk -i inplace ' /^#define EXPORT_SYMBOL_NS/ { gsub(/__stringify$ns$/, "ns"); print; next; } /^#define MODULE_IMPORT_NS/ { gsub(/__stringify$ns$/, "ns"); print; next; } /MODULE_IMPORT_NS/ { $0 = gensub(/MODULE_IMPORT_NS$([^)]*)$/, "MODULE_IMPORT_NS(\"\\1\")", "g"); } /EXPORT_SYMBOL_NS/ { if ($0 ~ /(EXPORT_SYMBOL_NS[^(]*)$([^,]+),/) { if ($0 !~ /(EXPORT_SYMBOL_NS[^(]*)\(([^,]+), ([^)]+)$/ && $0 !~ /(EXPORT_SYMBOL_NS[^(]*)/ && $0 !~ /^my/) { getline line; gsub(/[[:space:]]*\\$/, ""); gsub(/[[:space:]]/, "", line); $0 = $0 " " line; } $0 = gensub(/(EXPORT_SYMBOL_NS[^(]*)$([^,]+), ([^)]+)$/, "\\1(\\2, \"\\3\")", "g"); } } { print }' $file; doneRequested-by: Masahiro Yamada Signed-off-by: Peter Zijlstra (Intel) Link: https://mail.google.com/mail/u/2/#inbox/FMfcgzQXKWgMmjdFwwdsfgxzKpVHWPlcAcked-by: Greg KH Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/gpu/drm/tegra/gem.c

f5b8794e - drm/tegra: gem: Don't attach dma-bufs when not needed

Wed, 24 Apr 2024 05:13:35 +0000

drm/tegra: gem: Don't attach dma-bufs when not neededThe dma-buf import code currently attaches and maps all importeddma-bufs to the drm device to get their sgt for mapping to thedirectly managed IOMMU domain.In many cases, like for newer chips (Tegra186+), the directlymanaged IOMMU domain is, however, not used. Mapping to the drmdevice can also cause issues e.g. with swiotlb since it is nota real device.To improve the situation, only attach and map imported dma-bufswhen required.Signed-off-by: Mikko Perttunen Signed-off-by: Thierry Reding Link: https://patchwork.freedesktop.org/patch/msgid/20240424051335.2872574-2-cyndis@kapsi.fi List of files: /linux-6.15/drivers/gpu/drm/tegra/gem.c

4ed09565 - drm/tegra: gem: Open code drm_prime_gem_destroy

Wed, 24 Apr 2024 05:13:34 +0000

drm/tegra: gem: Open code drm_prime_gem_destroySince we aren't using drm_gem_prime_import(_dev), for clarity don'tuse the corresponding destroy function either.Signed-off-by: Mikko Perttunen Signed-off-by: Thierry Reding Link: https://patchwork.freedesktop.org/patch/msgid/20240424051335.2872574-1-cyndis@kapsi.fi List of files: /linux-6.15/drivers/gpu/drm/tegra/gem.c

3f257bc6 - drm/tegra: gem: Do not return NULL in tegra_bo_mmap()

Tue, 10 Oct 2023 15:26:14 +0000

drm/tegra: gem: Do not return NULL in tegra_bo_mmap()It's confusing for a function to return NULL and ERR_PTR()-encoded errorcodes on failure. Make sure we only ever return the latter since that'swhat callers already expect.Reported-by: Sui Jingfeng Reviewed-by: Sui Jingfeng Signed-off-by: Thierry Reding Link: https://patchwork.freedesktop.org/patch/msgid/ZSVuVcqdGfGtQIQj@orome.fritz.box List of files: /linux-6.15/drivers/gpu/drm/tegra/gem.c

3868ff00 - drm/tegra: Zero-initialize iosys_map

Fri, 01 Sep 2023 11:59:10 +0000

drm/tegra: Zero-initialize iosys_mapUBSAN reports an invalid load for bool, as the iosys_map is readlater without being initialized. Zero-initialize it to avoid this.Reported-by: Ashish Mhetre Signed-off-by: Mikko Perttunen Signed-off-by: Thierry Reding Link: https://patchwork.freedesktop.org/patch/msgid/20230901115910.701518-2-cyndis@kapsi.fi List of files: /linux-6.15/drivers/gpu/drm/tegra/gem.c

195dd40c - drm/tegra: Remove surplus else after return

Mon, 26 Jun 2023 14:33:31 +0000

drm/tegra: Remove surplus else after returnelse is not generally useful after returnSigned-off-by: Sui Jingfeng Signed-off-by: Thierry Reding Link: https://patchwork.freedesktop.org/patch/msgid/20230626143331.640454-2-suijingfeng@loongson.cn List of files: /linux-6.15/drivers/gpu/drm/tegra/gem.c

11f38236 - drm: Don't assert held reservation lock for dma-buf mmapping

Mon, 29 May 2023 22:39:33 +0000

drm: Don't assert held reservation lock for dma-buf mmappingDon't assert held dma-buf reservation lock on memory mapping of exportedbuffer.We're going to change dma-buf mmap() locking policy such that exporterswill have to handle the lock. The previous locking policy caused deadlockproblem for DRM drivers in a case of self-imported dma-bufs once thesedrivers are moved to use reservation lock universally. The problem issolved by moving the lock down to exporters. This patch prepares DRMdrivers for the locking policy update.Reviewed-by: Emil Velikov Acked-by: Christian König Signed-off-by: Dmitry Osipenko Link: https://patchwork.freedesktop.org/patch/msgid/20230529223935.2672495-2-dmitry.osipenko@collabora.comLink: https://patchwork.freedesktop.org/patch/msgid/20230529223935.2672495-3-dmitry.osipenko@collabora.comLink: https://patchwork.freedesktop.org/patch/msgid/20230529223935.2672495-4-dmitry.osipenko@collabora.comLink: https://patchwork.freedesktop.org/patch/msgid/20230529223935.2672495-2-dmitry.osipenko@collabora.comLink: https://patchwork.freedesktop.org/patch/msgid/20230529223935.2672495-3-dmitry.osipenko@collabora.comLink: https://patchwork.freedesktop.org/patch/msgid/20230529223935.2672495-4-dmitry.osipenko@collabora.com List of files: /linux-6.15/drivers/gpu/drm/tegra/gem.c

f75d1982 - drm/tegra: Allow compile test on !ARM v2

Wed, 22 Mar 2023 10:39:15 +0000

drm/tegra: Allow compile test on !ARM v2This compile tests on x86 just perfectly fine.v2: fix missing include complained by kernel test robotSigned-off-by: Christian König CC: Thierry Reding CC: Jonathan Hunter CC: linux-tegra@vger.kernel.orgSigned-off-by: Thierry Reding List of files: /linux-6.15/drivers/gpu/drm/tegra/gem.c

1c71222e - mm: replace vma->vm_flags direct modifications with modifier calls

Thu, 26 Jan 2023 19:37:49 +0000

mm: replace vma->vm_flags direct modifications with modifier callsReplace direct modifications to vma->vm_flags with calls to modifierfunctions to be able to track flag changes and to keep vma lockingcorrectness.[akpm@linux-foundation.org: fix drivers/misc/open-dice.c, per Hyeonggon Yoo]Link: https://lkml.kernel.org/r/20230126193752.297968-5-surenb@google.comSigned-off-by: Suren Baghdasaryan Acked-by: Michal Hocko Acked-by: Mel Gorman Acked-by: Mike Rapoport (IBM) Acked-by: Sebastian Reichel Reviewed-by: Liam R. Howlett Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>Cc: Andy Lutomirski Cc: Arjun Roy Cc: Axel Rasmussen Cc: David Hildenbrand Cc: David Howells Cc: Davidlohr Bueso Cc: David Rientjes Cc: Eric Dumazet Cc: Greg Thelen Cc: Hugh Dickins Cc: Ingo Molnar Cc: Jann Horn Cc: Joel Fernandes Cc: Johannes Weiner Cc: Kent Overstreet Cc: Laurent Dufour Cc: Lorenzo Stoakes Cc: Matthew Wilcox Cc: Minchan Kim Cc: Paul E. McKenney Cc: Peter Oskolkov Cc: Peter Xu Cc: Peter Zijlstra Cc: Punit Agrawal Cc: Sebastian Andrzej Siewior Cc: Shakeel Butt Cc: Soheil Hassas Yeganeh Cc: Song Liu Cc: Vlastimil Babka Cc: Will Deacon Signed-off-by: Andrew Morton List of files: /linux-6.15/drivers/gpu/drm/tegra/gem.c

39ce2529 - drm: Assert held reservation lock for dma-buf mmapping

Thu, 10 Nov 2022 20:13:45 +0000

drm: Assert held reservation lock for dma-buf mmappingWhen userspace mmaps dma-buf's fd, the dma-buf reservation lock must beheld. Add locking sanity checks to the dma-buf mmaping callbacks of DRMdrivers to ensure that the locking assumptions won't regress in future.Suggested-by: Daniel Vetter Signed-off-by: Dmitry Osipenko Acked-by: Christian König Link: https://patchwork.freedesktop.org/patch/msgid/20221110201349.351294-3-dmitry.osipenko@collabora.com List of files: /linux-6.15/drivers/gpu/drm/tegra/gem.c

f66d48c8 - drm/tegra: Prepare to dynamic dma-buf locking specification

Mon, 17 Oct 2022 17:22:16 +0000

drm/tegra: Prepare to dynamic dma-buf locking specificationPrepare Tegra DRM driver to the common dynamic dma-buf locking conventionby starting to use the unlocked versions of dma-buf API functions.Acked-by: Christian König Signed-off-by: Dmitry Osipenko Link: https://patchwork.freedesktop.org/patch/msgid/20221017172229.42269-9-dmitry.osipenko@collabora.com List of files: /linux-6.15/drivers/gpu/drm/tegra/gem.c

c7860cbe - drm/tegra: Fix vmapping of prime buffers

Tue, 28 Jun 2022 22:42:39 +0000

drm/tegra: Fix vmapping of prime buffersThe code assumes that Tegra GEM is permanently vmapped, which is nottrue for the scattered buffers. After converting Tegra video decoderdriver to V4L API, we're now getting a BUG_ON from dma-buf core on playingvideo using libvdpau-tegra on T30+ because tegra_gem_prime_vmap() setsvaddr to NULL. Older pre-V4L video decoder driver wasn't vmapping dma-bufs.Fix it by actually vmapping the exported GEMs.Cc: stable@vger.kernel.orgSigned-off-by: Dmitry Osipenko Signed-off-by: Thierry Reding List of files: /linux-6.15/drivers/gpu/drm/tegra/gem.c

cb7e1abc - drm/tegra: gem: Do not try to dereference ERR_PTR()

Fri, 06 May 2022 13:52:49 +0000

drm/tegra: gem: Do not try to dereference ERR_PTR()When mapping the DMA-BUF attachment fails, map->sgt will be an ERR_PTR-encoded error code and the cleanup code would try to free that memory,which obviously would fail.Zero out that pointer after extracting the error code when this happensso that kfree() can do the right thing.Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Thierry Reding List of files: /linux-6.15/drivers/gpu/drm/tegra/gem.c

7938f421 - dma-buf-map: Rename to iosys-map

Fri, 04 Feb 2022 17:05:41 +0000

dma-buf-map: Rename to iosys-mapRename struct dma_buf_map to struct iosys_map and corresponding APIs.Over time dma-buf-map grew up to more functionality than the one used bydma-buf: in fact it's just a shim layer to abstract system memory, thatcan be accessed via regular load and store, from IO memory that needs tobe acessed via arch helpers.The idea is to extend this API so it can fulfill other needs, internalto a single driver. Example: in the i915 driver it's desired to sharethe implementation for integrated graphics, which uses mostly systemmemory, with discrete graphics, which may need to access IO memory.The conversion was mostly done with the following semantic patch: @r1@ @@ - struct dma_buf_map + struct iosys_map @r2@ @@ ( - DMA_BUF_MAP_INIT_VADDR + IOSYS_MAP_INIT_VADDR | - dma_buf_map_set_vaddr + iosys_map_set_vaddr | - dma_buf_map_set_vaddr_iomem + iosys_map_set_vaddr_iomem | - dma_buf_map_is_equal + iosys_map_is_equal | - dma_buf_map_is_null + iosys_map_is_null | - dma_buf_map_is_set + iosys_map_is_set | - dma_buf_map_clear + iosys_map_clear | - dma_buf_map_memcpy_to + iosys_map_memcpy_to | - dma_buf_map_incr + iosys_map_incr ) @@ @@ - #include + #include Then some files had their includes adjusted and some comments wereupdate to remove mentions to dma-buf-map.Since this is not specific to dma-buf anymore, move the documentation tothe "Bus-Independent Device Accesses" section.v2: - Squash patchesv3: - Fix wrong removal of dma-buf.h from MAINTAINERS - Move documentation from dma-buf.rst to device-io.rstv4: - Change documentation title and levelSigned-off-by: Lucas De Marchi Acked-by: Christian König Acked-by: Sumit Semwal Acked-by: Thomas Zimmermann Link: https://patchwork.freedesktop.org/patch/msgid/20220204170541.829227-1-lucas.demarchi@intel.com List of files: /linux-6.15/drivers/gpu/drm/tegra/gem.c

1f39b1df - drm/tegra: Implement buffer object cache

Fri, 07 Feb 2020 15:50:52 +0000

drm/tegra: Implement buffer object cacheThis cache is used to avoid mapping and unmapping buffer objectsunnecessarily. Mappings are cached per client and stay hot untilthe buffer object is destroyed.Signed-off-by: Thierry Reding List of files: /linux-6.15/drivers/gpu/drm/tegra/gem.c

c6aeaf56 - drm/tegra: Implement correct DMA-BUF semantics

Thu, 09 Sep 2021 13:51:24 +0000

drm/tegra: Implement correct DMA-BUF semanticsDMA-BUF requires that each device that accesses a DMA-BUF attaches to itseparately. To do so the host1x_bo_pin() and host1x_bo_unpin() functionsneed to be reimplemented so that they can return a mapping, which eitherrepresents an attachment or a map of the driver's own GEM object.Signed-off-by: Thierry Reding List of files: /linux-6.15/drivers/gpu/drm/tegra/gem.c

16b0314a - dma-buf: move dma-buf symbols into the DMA_BUF module namespace

Sun, 10 Oct 2021 12:46:28 +0000

dma-buf: move dma-buf symbols into the DMA_BUF module namespaceIn order to better track where in the kernel the dma-buf code is used,put the symbols in the namespace DMA_BUF and modify all users of thesymbols to properly import the namespace to not break the build at thesame time.Now the output of modinfo shows the use of these symbols, making iteasier to watch for users over time:$ modinfo drivers/misc/fastrpc.ko | grep importimport_ns: DMA_BUFCc: "Pan, Xinhui" Cc: David Airlie Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: Mauro Carvalho Chehab Cc: dri-devel@lists.freedesktop.orgAcked-by: Daniel Vetter Acked-by: Christian König Acked-by: Arnd Bergmann Acked-by: Sumit Semwal Acked-by: Alex Deucher Link: https://lore.kernel.org/r/20211010124628.17691-1-gregkh@linuxfoundation.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/gpu/drm/tegra/gem.c

f51632cc - drm/tegra: Extract tegra_gem_lookup()

Thu, 10 Jun 2021 11:04:47 +0000

drm/tegra: Extract tegra_gem_lookup()The static function host1x_bo_lookup() in drm.c is also usefulelsewhere. Extract it as tegra_gem_lookup() in gem.c.Signed-off-by: Mikko Perttunen Signed-off-by: Thierry Reding List of files: /linux-6.15/drivers/gpu/drm/tegra/gem.c

20e76f1a - dma-buf: Use struct dma_buf_map in dma_buf_vunmap() interfaces

Fri, 25 Sep 2020 11:56:00 +0000

dma-buf: Use struct dma_buf_map in dma_buf_vunmap() interfacesThis patch updates dma_buf_vunmap() and dma-buf's vunmap callback touse struct dma_buf_map. The interfaces used to receive a buffer address.This address is now given in an instance of the structure.Users of the functions are updated accordingly. This is only an interfacechange. It is currently expected that dma-buf memory can be accessed withsystem memory load/store operations.v2: * include dma-buf-heaps and i915 selftests (kernel test robot) * initialize cma_obj before using it in drm_gem_cma_free_object() (kernel test robot)Signed-off-by: Thomas Zimmermann Acked-by: Sumit Semwal Acked-by: Christian König Acked-by: Daniel Vetter Acked-by: Tomasz Figa Acked-by: Sam Ravnborg Link: https://patchwork.freedesktop.org/patch/msgid/20200925115601.23955-4-tzimmermann@suse.de List of files: /linux-6.15/drivers/gpu/drm/tegra/gem.c

6619ccf1 - dma-buf: Use struct dma_buf_map in dma_buf_vmap() interfaces

Fri, 25 Sep 2020 11:55:59 +0000

dma-buf: Use struct dma_buf_map in dma_buf_vmap() interfacesThis patch updates dma_buf_vmap() and dma-buf's vmap callback to usestruct dma_buf_map.The interfaces used to return a buffer address. This address now getsstored in an instance of the structure that is given as an additionalargument. The functions return an errno code on errors.Users of the functions are updated accordingly. This is only an interfacechange. It is currently expected that dma-buf memory can be accessed withsystem memory load/store operations.v3: * update fastrpc driver (kernel test robot)v2: * always clear map parameter in dma_buf_vmap() (Daniel) * include dma-buf-heaps and i915 selftests (kernel test robot)Signed-off-by: Thomas Zimmermann Acked-by: Sumit Semwal Acked-by: Christian König Acked-by: Daniel Vetter Acked-by: Tomasz Figa Acked-by: Sam Ravnborg Link: https://patchwork.freedesktop.org/patch/msgid/20200925115601.23955-3-tzimmermann@suse.de List of files: /linux-6.15/drivers/gpu/drm/tegra/gem.c