Changes in Makefile

f14d81b7 - drm/i915/cmtg: Disable the CMTG

Fri, 24 Jan 2025 17:38:14 +0000

drm/i915/cmtg: Disable the CMTGThe CMTG is a timing generator that runs in parallel with transcoderstiming generators and can be used as a reference for synchronization.We have observed that we are inheriting from GOP a display configurationwith the CMTG enabled. Because our driver doesn't currently implementany CMTG sequences, the CMTG ends up still enabled after our drivertakes over.We need to make sure that the CMTG is not enabled if we are not going touse it. For that, let's add a partial implementation in our driver thatonly cares about disabling the CMTG if it was found enabled duringinitial hardware readout. In the future, we can also implement sequencesfor using the CMTG if that becomes a needed feature.For now, we only deal with cases when it is possible to disable the CMTGwithout requiring a modeset. For earlier display versions, we simplyskip if we find the CMTG enabled and we can't disable it without aproper modeset. In the future, we need to properly handle that case.v2: - DG2 does not have the CMTG. Update HAS_CMTG() accordingly. - Update logic to force disabling of CMTG only for initial commit.v3: - Add missing changes for v2 that were staged but not committed.v4: - Avoid if/else duplication in intel_cmtg_dump_state() by using "n/a" for CMTG B enabled/disabled string for platforms without it. (Jani) - Prefer intel_cmtg_readout_hw_state() over intel_cmtg_readout_state(). (Jani) - Use display struct instead of i915 as first parameter for TRANS_DDI_FUNC_CTL2(). (Jani) - Fewer continuation lines in variable declaration/initialization for better readability. (Jani) - Coding style improvements. (Jani) - Use drm_dbg_kms() instead of drm_info() for logging the disabling of the CMTG. - Make struct intel_cmtg_state entirely private to intel_cmtg.c.v5: - Do the disable sequence as part of the sanitization step after hardware readout instead of initial modeset commit. (Jani) - Adapt to commit 15133582465f ("drm/i915/display: convert global state to struct intel_display") by using a display struct instead of i915 as argument for intel_atomic_global_obj_init().v6: - Do not track CMTG state as a global state. (Ville) - Simplify the driver logic by only disabling the CMTG only on cases when a modeset is not required. (Ville)v7: - Remove the call to drm_WARN_ON() when checking intel_cmtg_disable_requires_modeset() and use a FIXME in the comment instead. - Remove the !HAS_CMTG() guard from intel_cmtg_get_config(), which is static and its caller is already protected by that same condition. - Also take the opportunity to put some Bspec references in the commit trailers section.v8: - Use HAS_TRANSCODER() instead of intel_crtc_for_pipe(). (Ville) - Ensure transcoder power well is enabled before reading TRANS_DDI_FUNC_CTL2. (Ville)Bspec: 68915, 49262Cc: Jani Nikula Reviewed-by: Ville Syrjälä Signed-off-by: Gustavo Sousa Link: https://patchwork.freedesktop.org/patch/msgid/20250124173956.46534-1-gustavo.sousa@intel.com List of files: /linux-6.15/drivers/gpu/drm/i915/Makefile

59476420 - drm/i915/display: Add support for SNPS PHY HDMI PLL algorithm for DG2

Mon, 20 Jan 2025 04:21:17 +0000

drm/i915/display: Add support for SNPS PHY HDMI PLL algorithm for DG2Add helpers to calculate the necessary parameters for configuring theHDMI PLL for SNPS MPLLB and C10 PHY.The pll parameters are computed for desired pixel clock, curve dataand other inputs used for interpolation and finally stored in thepll_state.Currently the helper is used to compute PLLs for DG2 SNPS PHY.Support for computing Plls for C10 PHY is added in subsequent patches.v2:-Used kernel types instead of C99 types. (Jani)-Fixed styling issues and renamed few variables to more meaningful names. (Jani)-Added Xe make file changes. (Jani)-Fixed build errors reported by kernel test robotv3:-Renamed helper to align with file name. (Jani)v4:-Removed erroraneous comment, and added Bspec# as part of trailer. (Suraj)-Fixed warning flagged by kernel test robot.Bspec: 54032Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal Acked-by: Jani Nikula Tested-by: Khaled Almahallawy Link: https://patchwork.freedesktop.org/patch/msgid/20250120042122.1029481-2-ankit.k.nautiyal@intel.com List of files: /linux-6.15/drivers/gpu/drm/i915/Makefile

adceb416 - drm/i915/display: add intel_display_conversion.c to hide stuff better

Wed, 20 Nov 2024 12:03:34 +0000

drm/i915/display: add intel_display_conversion.c to hide stuff betterThe __to_intel_display() generics require the definition of structdrm_i915_private i.e. inclusion of i915_drv.h. Addintel_display_conversion.c with a __i915_to_display() function to do theconversion without the intel_display_conversion.h having an implicitdependency on i915_drv.h.The long term goal is to remove __to_intel_display() and theintel_display_conversion.[ch] files altoghether, and this is merely atransitional step to make the dependencies on i915_drv.h explicit.Reviewed-by: Luca Coelho Signed-off-by: Jani Nikula Link: https://patchwork.freedesktop.org/patch/msgid/39e99b765b8c1a05d001659c39686a661ac268e2.1732104170.git.jani.nikula@intel.com List of files: /linux-6.15/drivers/gpu/drm/i915/Makefile

17d70726 - drm/i915: extract intel_uncore_trace.[ch]

Wed, 20 Nov 2024 12:03:33 +0000

drm/i915: extract intel_uncore_trace.[ch]The i915_reg_rw tracing is a small isolated part of i915_trace.h. Itsusers are orthogonal to the other i915_trace.h users as well, and itsimplementation does not require all the includes of i915_trace.h. Spliti915_reg_rw tracing to separate intel_uncore_trace.[ch].The main underlying goal is to reduce implicit includes of i915_drv.hfrom display code.Reviewed-by: Luca Coelho Signed-off-by: Jani Nikula Link: https://patchwork.freedesktop.org/patch/msgid/1a3623fbb120adc55bc1cab1e27aca6e55487163.1732104170.git.jani.nikula@intel.com List of files: /linux-6.15/drivers/gpu/drm/i915/Makefile

d58db10e - drm/i915: Introduce intel_cpu_info.c for CPU IDs

Wed, 11 Dec 2024 11:59:51 +0000

drm/i915: Introduce intel_cpu_info.c for CPU IDsHaving similar naming convention in intel-family.h and intel_device_info.hresults in redefinition of a few platforms. Define CPU IDs in its own fileto avoid this.v3: Move file out of gt directory, add kernel doc (Riana) Rephrase file description (Jani)Signed-off-by: Raag Jadav Acked-by: Jani Nikula Reviewed-by: Riana Tauro Reviewed-by: Andi Shyti Signed-off-by: Andi Shyti Link: https://patchwork.freedesktop.org/patch/msgid/20241211115952.1659287-4-raag.jadav@intel.com List of files: /linux-6.15/drivers/gpu/drm/i915/Makefile

c3bda715 - drm/i915/display: Convert i915_suspend into i9xx_display_sr

Wed, 13 Nov 2024 22:50:11 +0000

drm/i915/display: Convert i915_suspend into i9xx_display_srThese save & restore functions inside i915_suspend are old displayfunctions to save and restore a bunch of display related registers.Move it under display and rename accordantly. Just don't move itentirely towards intel_display struct yet because it dependson drm_i915_private for the IS_MOBILE.While doing this conversion also update the MIT header usingthe new SPDX ones.v2: Fix Makefile and include (Jani) Removed vga and gmbus (Jani, Ville)Cc: Jesse Barnes Cc: Jani Nikula Reviewed-by: Jani Nikula Reviewed-by: Jonathan Cavitt Link: https://patchwork.freedesktop.org/patch/msgid/20241113225016.208673-2-rodrigo.vivi@intel.comSigned-off-by: Rodrigo Vivi List of files: /linux-6.15/drivers/gpu/drm/i915/Makefile

0f16cd2a - drm/i915/pfit: Extract intel_pfit.c

Wed, 16 Oct 2024 14:31:33 +0000

drm/i915/pfit: Extract intel_pfit.cThe panel fitter code doesn't really have much to do with therest of intel_panel.c, so extract it all into its own file.Signed-off-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20241016143134.26903-9-ville.syrjala@linux.intel.comReviewed-by: Jani Nikula List of files: /linux-6.15/drivers/gpu/drm/i915/Makefile

e6229050 - drm/i915/bios: Extract soc/intel_rom.c

Mon, 23 Sep 2024 15:24:53 +0000

drm/i915/bios: Extract soc/intel_rom.cAbstract away the nuts and bolts of the SPI vs. PCI ROMstuff, and hide it all in soc/intel_rom.c so that theVBT code doesn't have to care about this stuff.This leaves intel_bios.c with a single codepath thatcan focus on the details related to the VBT layout.This should have no functional changes.v2: Rebase due to vbt_signature changes Drop unnecessary cast (Jani)Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20240923152453.11230-7-ville.syrjala@linux.intel.com List of files: /linux-6.15/drivers/gpu/drm/i915/Makefile

a5b40d4f - drm/i915/dp: split out intel_dp_test.[ch] to a dedicated file

Fri, 20 Sep 2024 11:56:43 +0000

drm/i915/dp: split out intel_dp_test.[ch] to a dedicated fileintel_dp.c has become huge, over 7k lines. Split out the fairly wellisolated chunk of DP test code to a dedicated file intel_dp_test.[ch].Reviewed-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/262d565fe59715ba297702b67d4bcca81c736dc0.1726833193.git.jani.nikula@intel.comSigned-off-by: Jani Nikula List of files: /linux-6.15/drivers/gpu/drm/i915/Makefile

17cd58a8 - drm/i915/display: start a buffer object abstraction layer

Tue, 17 Sep 2024 16:13:40 +0000

drm/i915/display: start a buffer object abstraction layerThe display code needs to deal with gem objects, and mostly uses structdrm_i915_gem_object. That's not great, because for xe we need toredefine it struct xe_bo during build.Start a common interface using struct drm_gem_object, with separateimplementations for i915 and xe. For starters, convert i9xx_wm.c to useit.Reviewed-by: Maarten Lankhorst Acked-by: Rodrigo Vivi Signed-off-by: Jani Nikula Link: https://patchwork.freedesktop.org/patch/msgid/df6867523a0b5fdd4eb63f657f545603ae6f6e0b.1726589119.git.jani.nikula@intel.com List of files: /linux-6.15/drivers/gpu/drm/i915/Makefile

6843cd85 - drm/i915/display: add intel_display_snapshot abstraction

Thu, 12 Sep 2024 14:34:12 +0000

drm/i915/display: add intel_display_snapshot abstractionThe error state capture still handles display info at a too detailedlevel. Start abstracting the whole display snapshot capture and printingat a higher level. Move overlay to display snapshot first.Use the same nomenclature and style as in xe devcoredump, in preparationfor perhaps some day bolting the snapshots there as well.v3: Fix build harder for CONFIG_DRM_I915_CAPTURE_ERROR=nv2: Fix build for CONFIG_DRM_I915_CAPTURE_ERROR=n (kernel test robot)Reviewed-by: Rodrigo Vivi Link: https://patchwork.freedesktop.org/patch/msgid/ba6a36759600c2d35405c41a0fc9d69f676df77d.1726151571.git.jani.nikula@intel.comSigned-off-by: Jani Nikula List of files: /linux-6.15/drivers/gpu/drm/i915/Makefile

3b3be899 - drm/i915/dp: Recheck link state after modeset

Mon, 10 Jun 2024 18:14:28 +0000

drm/i915/dp: Recheck link state after modesetRecheck the link state after a passing link training, with a 2 sec delayto account for cases where the link goes bad following the link trainingand the sink doesn't report this via an HPD IRQ.The delayed work added here will be also used by a later patch after afailed link training to try to retrain the link with unchanged linkparams before reducing the link params.v2: Don't flush an uninitialized delayed work (on HDMI-only DDI ports).v3:- Move the helpers to a new intel_encoder.c file, rename them accordingly. (Ville)- Add the work to intel_encoder instead of intel_digital_port.- Call the encoder specific link check function via an encoder hook.- Flush the link check work during encoder destroy from intel_dp_encoder_flush_work().- Flush the link check work during encoder suspend as well.v4: Call intel_encoder_link_check_init() with a valid encoder pointer.Cc: Ville Syrjälä Reviewed-by: Ville Syrjälä Signed-off-by: Imre Deak Link: https://patchwork.freedesktop.org/patch/msgid/20240610181428.2955658-1-imre.deak@intel.com List of files: /linux-6.15/drivers/gpu/drm/i915/Makefile

dd3cac0a - drm/i915: drop redundant W=1 warnings from Makefile

Thu, 23 May 2024 13:37:05 +0000

drm/i915: drop redundant W=1 warnings from MakefileSince commit a61ddb4393ad ("drm: enable (most) W=1 warnings by defaultacross the subsystem"), most of the extra warnings in the driverMakefile are redundant. Remove them.Note that -Wmissing-declarations and -Wmissing-prototypes are alwaysenabled by default in scripts/Makefile.extrawarn.Acked-by: Lucas De Marchi Signed-off-by: Jani Nikula Link: https://patchwork.freedesktop.org/patch/msgid/490931748fa9a1dbac2bceda0c4b778240b10b58.1716471145.git.jani.nikula@intel.com List of files: /linux-6.15/drivers/gpu/drm/i915/Makefile

8bdbde7c - drm/i915/alpm: Move alpm related code to a new file

Wed, 29 May 2024 20:07:38 +0000

drm/i915/alpm: Move alpm related code to a new fileMove ALPM feature related code as it will be used fornon-psr panel also thorugh LOBF feature.v1: Initial version.v2: Correct ordering in makefile. [Jani]Reviewed-by: Jouni Högander Signed-off-by: Animesh Manna Link: https://patchwork.freedesktop.org/patch/msgid/20240529200742.1694401-3-animesh.manna@intel.com List of files: /linux-6.15/drivers/gpu/drm/i915/Makefile

b1992c37 - kbuild: use $(src) instead of $(srctree)/$(src) for source directory

Sat, 27 Apr 2024 14:55:02 +0000

kbuild: use $(src) instead of $(srctree)/$(src) for source directoryKbuild conventionally uses $(obj)/ for generated files, and $(src)/ forchecked-in source files. It is merely a convention without any functionaldifference. In fact, $(obj) and $(src) are exactly the same, as definedin scripts/Makefile.build: src := $(obj)When the kernel is built in a separate output directory, $(src) doesnot accurately reflect the source directory location. While Kbuildresolves this discrepancy by specifying VPATH=$(srctree) to search forsource files, it does not cover all cases. For example, when adding aheader search path for local headers, -I$(srctree)/$(src) is typicallypassed to the compiler.This introduces inconsistency between upstream and downstream Makefilesbecause $(src) is used instead of $(srctree)/$(src) for the latter.To address this inconsistency, this commit changes the semantics of$(src) so that it always points to the directory in the source tree.Going forward, the variables used in Makefiles will have the followingmeanings: $(obj) - directory in the object tree $(src) - directory in the source tree (changed by this commit) $(objtree) - the top of the kernel object tree $(srctree) - the top of the kernel source treeConsequently, $(srctree)/$(src) in upstream Makefiles need to be replacedwith $(src).Signed-off-by: Masahiro Yamada Reviewed-by: Nicolas Schier List of files: /linux-6.15/drivers/gpu/drm/i915/Makefile

765425f5 - drm/i915/display: add support for DMC wakelocks

Fri, 12 Apr 2024 09:41:45 +0000

drm/i915/display: add support for DMC wakelocksIn order to reduce the DC5->DC2 restore time, wakelocks have beenintroduced in DMC so the driver can tell it when registers and othermemory areas are going to be accessed and keep their respective blocksawake.Implement this in the driver by adding the concept of DMC wakelocks.When the driver needs to access memory which lies inside pre-definedranges, it will tell DMC to set the wakelock, access the memory, thenwait for a while and clear the wakelock.The wakelock state is protected in the driver with spinlocks toprevent concurrency issues.BSpec: 71583Signed-off-by: Luca Coelho Reviewed-by: Uma Shankar Link: https://patchwork.freedesktop.org/patch/msgid/20240412094148.808179-2-luciano.coelho@intel.comSigned-off-by: Jani Nikula List of files: /linux-6.15/drivers/gpu/drm/i915/Makefile

6db31251 - drm/i915/gt: Enable only one CCS for compute workload

Thu, 28 Mar 2024 07:34:05 +0000

drm/i915/gt: Enable only one CCS for compute workloadEnable only one CCS engine by default with all the compute sicesallocated to it.While generating the list of UABI engines to be exposed to theuser, exclude any additional CCS engines beyond the firstinstance.This change can be tested with igt i915_query.Fixes: d2eae8e98d59 ("drm/i915/dg2: Drop force_probe requirement")Signed-off-by: Andi Shyti Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Matt Roper Cc: # v6.2+Reviewed-by: Matt Roper Acked-by: Michal Mrozek Link: https://patchwork.freedesktop.org/patch/msgid/20240328073409.674098-4-andi.shyti@linux.intel.com(cherry picked from commit 2bebae0112b117de7e8a7289277a4bd2403b9e17)Signed-off-by: Rodrigo Vivi List of files: /linux-6.15/drivers/gpu/drm/i915/Makefile

2d2d92bc - drm/i915: use fine grained -Woverride-init disable

Thu, 28 Mar 2024 10:24:55 +0000

drm/i915: use fine grained -Woverride-init disableUse localized __diag_push(), __diag_ignore_all() with rationale, and__diag_pop() for specific initializations instead of blanket disablingof -Woverride-init across several files.Note that we've tried this before with commit 88e9664434c9 ("drm/i915:use localized __diag_ignore_all() instead of per file") and reverted incommit 290d16104575 ("Revert "drm/i915: use localized__diag_ignore_all() instead of per file""). The issue turned out to bein __diag_ignore_all() and it was fixed by commit 689b097a06ba("compiler-gcc: Suppress -Wmissing-prototypes warning for all supportedGCC"). So we should be able to pull this off now.Cc: Arnd Bergmann Cc: Lucas De Marchi Acked-by: Arnd Bergmann Reviewed-by: Lucas De Marchi Link: https://patchwork.freedesktop.org/patch/msgid/20240328102455.944131-1-jani.nikula@intel.comSigned-off-by: Jani Nikula List of files: /linux-6.15/drivers/gpu/drm/i915/Makefile

c40845e3 - kbuild: make -Woverride-init warnings more consistent

Tue, 26 Mar 2024 14:47:16 +0000

kbuild: make -Woverride-init warnings more consistentThe -Woverride-init warn about code that may be intentional or not,but the inintentional ones tend to be real bugs, so there is a bit ofdisagreement on whether this warning option should be enabled by defaultand we have multiple settings in scripts/Makefile.extrawarn as well asindividual subsystems.Older versions of clang only supported -Wno-initializer-overrides withthe same meaning as gcc's -Woverride-init, though all supported versionsnow work with both. Because of this difference, an earlier cleanup ofmine accidentally turned the clang warning off for W=1 builds and onlyleft it on for W=2, while it's still enabled for gcc with W=1.There is also one driver that only turns the warning off for newerversions of gcc but not other compilers, and some but not all theMakefiles still use a cc-disable-warning conditional that is nolonger needed with supported compilers here.Address all of the above by removing the special cases for clangand always turning the warning off unconditionally where it gotin the way, using the syntax that is supported by both compilers.Fixes: 2cd3271b7a31 ("kbuild: avoid duplicate warning options")Signed-off-by: Arnd Bergmann Acked-by: Hamza Mahfooz Acked-by: Jani Nikula Acked-by: Andrew Jeffery Signed-off-by: Jani Nikula Reviewed-by: Linus Walleij Signed-off-by: Masahiro Yamada List of files: /linux-6.15/drivers/gpu/drm/i915/Makefile

2bebae01 - drm/i915/gt: Enable only one CCS for compute workload

Thu, 28 Mar 2024 07:34:05 +0000

drm/i915/gt: Enable only one CCS for compute workloadEnable only one CCS engine by default with all the compute sicesallocated to it.While generating the list of UABI engines to be exposed to theuser, exclude any additional CCS engines beyond the firstinstance.This change can be tested with igt i915_query.Fixes: d2eae8e98d59 ("drm/i915/dg2: Drop force_probe requirement")Signed-off-by: Andi Shyti Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Matt Roper Cc: # v6.2+Reviewed-by: Matt Roper Acked-by: Michal Mrozek Link: https://patchwork.freedesktop.org/patch/msgid/20240328073409.674098-4-andi.shyti@linux.intel.com List of files: /linux-6.15/drivers/gpu/drm/i915/Makefile