Changes in Makefile

5f56be33 - drm/amd/display: Fix POWERPC_64 compilation

Tue, 14 May 2024 16:27:08 +0000

drm/amd/display: Fix POWERPC_64 compilation[Why]Compilation errors while compiling without CONFIG_DRM_AMD_DC_FP:"undefined reference to `dc_bandwidth_in_kbps_from_timing'"[How]Fix Makefile to move dsc files out of DC_FP guard.Fixes: 00c391102abc ("drm/amd/display: Add misc DC changes for DCN401")Reviewed-by: Aurabindo Pillai Signed-off-by: Roman Li Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dsc/Makefile

f5d75327 - drm/amd/display: Fix invalid Copyright notice

Mon, 22 Apr 2024 14:17:17 +0000

drm/amd/display: Fix invalid Copyright notice[Why && How]Copyright notice failed in the Palamida scan and make changes toalign with our guidelines.Acked-by: Tom Chung Signed-off-by: Leo Ma Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dsc/Makefile

00c39110 - drm/amd/display: Add misc DC changes for DCN401

Wed, 20 Mar 2024 17:56:16 +0000

drm/amd/display: Add misc DC changes for DCN401Add miscellaneous changes to enable DCN401 initSigned-off-by: Aurabindo Pillai Acked-by: Rodrigo Siqueira Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dsc/Makefile

6c22fb07 - drm/amd/display: Refactor DSC into component folder

Wed, 18 Oct 2023 13:46:17 +0000

drm/amd/display: Refactor DSC into component folder[why]To refactor DSC and make DSC files unit testable.[how]moved the dcnxx_dsc.c and .h filesinto corresponding dcn folders insidethe dsc and cleared the linkage errors.Reviewed-by: Wenjing Liu Acked-by: Hamza Mahfooz Signed-off-by: Bhuvana Chandra Pinninti Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dsc/Makefile

d738db68 - drm/amd/display: move FPU associated DSC code to DML folder

Tue, 31 Aug 2021 11:52:24 +0000

drm/amd/display: move FPU associated DSC code to DML folder[Why & How]As part of the FPU isolation work documented inhttps://patchwork.freedesktop.org/series/93042/, isolate code that usesFPU in DSC to DML, where all FPU code should locate.This change does not refactor any functions but move code around.Cc: Christian König Cc: Hersen Wu Cc: Anson Jacob Cc: Harry Wentland Reviewed-by: Rodrigo Siqueira Acked-by: Agustin Gutierrez Tested-by: Anson Jacob Tested-by: Daniel Wheeler Signed-off-by: Qingqing Zhuo Acked-by: Christian König Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dsc/Makefile

c241ed2f - drm/amdgpu/display: drop DCN support for aarch64

Mon, 04 Jan 2021 16:24:20 +0000

drm/amdgpu/display: drop DCN support for aarch64From Ard:"Simply disabling -mgeneral-regs-only left and right is risky, given thatthe standard AArch64 ABI permits the use of FP/SIMD registers anywhere,and GCC is known to use SIMD registers for spilling, and may inventother uses of the FP/SIMD register file that have nothing to do with thefloating point code in question. Note that putting kernel_neon_begin()and kernel_neon_end() around the code that does use FP is not sufficienthere, the problem is in all the other code that may be emitted withreferences to SIMD registers in it.So the only way to do this properly is to put all floating point code ina separate compilation unit, and only compile that unit with-mgeneral-regs-only."Disable support until the code can be properly refactored to support thisproperly on aarch64.Acked-by: Will Deacon Reported-by: Ard Biesheuvel Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dsc/Makefile

88d5cb25 - drm/amdgpu/display: drop DCN support for aarch64

Mon, 04 Jan 2021 16:24:20 +0000

c38d444e - drm/amd/display: add DCN support for aarch64

Sat, 08 Aug 2020 20:44:58 +0000

drm/amd/display: add DCN support for aarch64This adds ARM64 support into the DCN. This mainly enables supportfor Navi graphics cards. The dcn10 changes haven't been tested,since I don't have the relevant hardware available, but thereis no way to conditionally disable them, so I've done them anyway.Signed-off-by: Daniel Kolesa Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dsc/Makefile

1e5d05ec - drm/amd/display: Rework dsc to isolate FPU operations

Wed, 29 Apr 2020 14:53:02 +0000

drm/amd/display: Rework dsc to isolate FPU operationsWhen we want to use float point operation on Linuxwe need to use within special kernel protection(`kernel_fpu_{begin,end}()`.), otherwise the kernelcan clobber userspace FPU register state. For detectingthese issues we use a tool named objtool (with -Ffaflags) to highlight the FPU problems, all warnings canbe summed up as follows:./tools/objtool/objtool check -Ffadrivers/gpu/drm/amd/display/dc/dml/dml_common_defs.o[..] dc/dsc/rc_calc.o: warning: objtool: get_qp_set()+0x2f8:FPU instruction outside of kernel_fpu_{begin,end}()[..] dc/dsc/rc_calc.o: warning: objtool: dsc_roundf()+0x5:FPU instruction outside of kernel_fpu_{begin,end}()[..] dc/dsc/rc_calc.o: warning: objtool: dsc_ceil()+0x5:FPU instruction outside of kernel_fpu_{begin,end}()[..] dc/dsc/rc_calc.o: warning: objtool: get_ofs_set()+0x3eb:FPU instruction outside of kernel_fpu_{begin,end}()[..] dc/dsc/rc_calc.o: warning: objtool: calc_rc_params()+0x3c:FPU instruction outside of kernel_fpu_{begin,end}()[..] dc/dsc/dc_dsc.o: warning: objtool:get_dsc_bandwidth_range.isra.0()+0x8d:FPU instruction outside of kernel_fpu_{begin,end}()[..] dc/dsc/dc_dsc.o: warning: objtool: setup_dsc_config()+0x2ef:FPU instruction outside of kernel_fpu_{begin,end}()[..] dc/dsc/rc_calc_dpi.o: warning: objtool:copy_pps_fields()+0xbb:FPU instruction outside of kernel_fpu_{begin,end}()[..] dc/dsc/rc_calc_dpi.o: warning: objtool:dscc_compute_dsc_parameters()+0x7b:FPU instruction outside of kernel_fpu_{begin,end}()This commit fixes the above issues by rework DSC as described:1. Isolate all FPU operations in a single file;2. Use FPU flags only in the file that handles FPU operations;3. Isolate all functions that require float point operation in static functions;4. Add a mid-layer function that does not use any float point operation, and that could be safely invoked in other parts of the code.5. Keep float point operation under DC_FP_{START/END} macro.CC: Christian König CC: Alexander Deucher CC: Peter Zijlstra CC: Tony Cheng CC: Harry Wentland Signed-off-by: Rodrigo Siqueira Reviewed-by: Mikita Lipski Acked-by: Qingqing Zhuo Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dsc/Makefile

9ec051bf - drm/amd/display: Rework dsc to isolate FPU operations

Wed, 29 Apr 2020 14:53:02 +0000

16a9dea1 - amdgpu: Enable initial DCN support on POWER

Sat, 07 Dec 2019 22:47:46 +0000

amdgpu: Enable initial DCN support on POWERDCN requires floating point support to operate. Add the appropriatex86/ppc64 guards and FPU / AltiVec / VSX context switches to DCN.Note that the current DC20 code doesn't contain all required FPUwrappers on x86 or POWER, so this patch is insufficient to fullyenable DC20 on POWER.v2: s/X86_64/X86/g to retain previous behavior.Signed-off-by: Timothy Pearson Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dsc/Makefile

ad808910 - drm/amdgpu: fix license on Kconfig and Makefiles

Wed, 11 Dec 2019 15:09:03 +0000

drm/amdgpu: fix license on Kconfig and Makefilesamdgpu is MIT licensed.Fixes: ec8f24b7faaf3d ("treewide: Add SPDX license identifier - Makefile/Kconfig")Reviewed-by: Christian König Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dsc/Makefile

bd95c144 - drm/amdgpu: fix license on Kconfig and Makefiles

Wed, 11 Dec 2019 15:09:03 +0000

e8a170ff - drm/amdgpu: enable -msse2 for GCC 7.1+ users

Wed, 16 Oct 2019 23:02:09 +0000

drm/amdgpu: enable -msse2 for GCC 7.1+ usersA final attempt at enabling sse2 for GCC users.Orininally attempted in:commit 10117450735c ("drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines")Reverted due to "reported instability" in:commit 193392ed9f69 ("Revert "drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines"")Re-added just for Clang in:commit 0f0727d971f6 ("drm/amd/display: readd -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines")The original report didn't have enough information to know if the GPFwas due to misalignment, but I suspect that it was. (The missinginformation was the disassembly of the function at the bottom of thetrace, to see if the instruction pointer pointed to an instruction with16B alignment memory operand requirements. The stack trace does showthe stack was only 8B but not 16B aligned though, which makes this astrong possibility).Now that the stack misalignment issue has been fixed for users of GCC7.1+, reattempt adding -msse2. This matches Clang.It will likely never be safe to enable this for pre-GCC 7.1 AND use a16B aligned stack in these translation units.This is only a functional change for GCC 7.1+ users, and should be boottested.Link: https://bugs.freedesktop.org/show_bug.cgi?id=109487Signed-off-by: Nick Desaulniers Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dsc/Makefile

00db2971 - drm/amdgpu: fix stack alignment ABI mismatch for GCC 7.1+

Wed, 16 Oct 2019 23:02:08 +0000

drm/amdgpu: fix stack alignment ABI mismatch for GCC 7.1+GCC earlier than 7.1 errors when compiling code that makes use of`double`s and sets a stack alignment outside of the range of [2^4-2^12]:$ cat foo.cdouble foo(double x, double y) { return x + y;}$ gcc-4.9 -mpreferred-stack-boundary=3 foo.cerror: -mpreferred-stack-boundary=3 is not between 4 and 12This is likely why the AMDGPU driver was ever compiled with a differentstack alignment (and thus different ABI) than the rest of the x86kernel. The kernel uses 8B stack alignment, while the driver was using16B stack alignment in a few places.Since GCC 7.1+ doesn't error, fix the ABI mismatch for users of newerversions of GCC.There was discussion about whether to mark the driver broken or not forusers of GCC earlier than 7.1, but since the driver currently isworking, don't explicitly break the driver for them here.Relying on differing stack alignment is unspecified behavior, andbrittle, and may break in the future.This patch is no functional change for GCC users earlier than 7.1. It'sbeen compile tested on GCC 4.9 and 8.3 to check the correct flags. Itshould be boot tested when built with GCC 7.1+.-mincoming-stack-boundary= or -mstackrealign may help keep this codebuilding for pre-GCC 7.1 users.The version check for GCC is broken into two conditionals, both becausecc-ifversion is currently GCC specific, and it simplifies a subsequentpatch.Signed-off-by: Nick Desaulniers Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dsc/Makefile

c868868f - drm/amdgpu: fix stack alignment ABI mismatch for Clang

Wed, 16 Oct 2019 23:02:07 +0000

drm/amdgpu: fix stack alignment ABI mismatch for ClangThe x86 kernel is compiled with an 8B stack alignment via`-mpreferred-stack-boundary=3` for GCC since 3.6-rc1 viacommit d9b0cde91c60 ("x86-64, gcc: Use -mpreferred-stack-boundary=3 if supported")or `-mstack-alignment=8` for Clang. Parts of the AMDGPU driver arecompiled with 16B stack alignment.Generally, the stack alignment is part of the ABI. Linking together twodifferent translation units with differing stack alignment is dangerous,particularly when the translation unit with the smaller stack alignmentmakes calls into the translation unit with the larger stack alignment.While 8B aligned stacks are sometimes also 16B aligned, they are notalways.Multiple users have reported General Protection Faults (GPF) when usingthe AMDGPU driver compiled with Clang. Clang is placing objects in stackslots assuming the stack is 16B aligned, and selecting instructions thatrequire 16B aligned memory operands.At runtime, syscall handlers with 8B aligned stack call into code thatassumes 16B stack alignment. When the stack is a multiple of 8B but not16B, these instructions result in a GPF.Remove the code that added compatibility between the differing compilerflags, as it will result in runtime GPFs when built with Clang. Cleanupsfor GCC will be sent in later patches in the series.Link: https://github.com/ClangBuiltLinux/linux/issues/735Debugged-by: Yuxuan Shui Reported-by: Shirish S Reported-by: Yuxuan Shui Suggested-by: Andrew Cooper Signed-off-by: Nick Desaulniers Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dsc/Makefile

54b8ae66 - kbuild: change *FLAGS_.o to take the path relative to $(obj)

Fri, 30 Aug 2019 04:34:01 +0000

kbuild: change *FLAGS_.o to take the path relative to $(obj)Kbuild provides per-file compiler flag addition/removal: CFLAGS_.o CFLAGS_REMOVE_.o AFLAGS_.o AFLAGS_REMOVE_.o CPPFLAGS_.lds HOSTCFLAGS_.o HOSTCXXFLAGS_.oThe is the filename of the target with its directory andsuffix stripped.This syntax comes into a trouble when two files with the same basenameappear in one Makefile, for example: obj-y += foo.o obj-y += dir/foo.o CFLAGS_foo.o := Here, the applies to both foo.o and dir/foo.oThe real world problem is: scripts/kconfig/util.c scripts/kconfig/lxdialog/util.cBoth files are compiled into scripts/kconfig/mconf, but only thelatter should be given with the ncurses flags.It is more sensible to use the relative path to the Makefile, like this: obj-y += foo.o CFLAGS_foo.o := obj-y += dir/foo.o CFLAGS_dir/foo.o := At first, I attempted to replace $(basetarget) with $*. The $* variableis replaced with the stem ('%') part in a pattern rule. This works withmost of cases, but does not for explicit rules.For example, arch/ia64/lib/Makefile reuses rule_as_o_S in its ownexplicit rules, so $* will be empty, resulting in ignoring the per-fileAFLAGS.I introduced a new variable, target-stem, which can be used also fromexplicit rules.Signed-off-by: Masahiro Yamada Acked-by: Marc Zyngier List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dsc/Makefile

0f0727d9 - drm/amd/display: readd -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines

Mon, 22 Jul 2019 22:31:05 +0000

drm/amd/display: readd -msse2 to prevent Clang from emitting libcalls to undefined SW FP routinesarch/x86/Makefile disables SSE and SSE2 for the whole kernel. TheAMDGPU drivers modified in this patch re-enable SSE but not SSE2. Turnon SSE2 to support emitting double precision floating point instructionsrather than calls to non-existent (usually available from gcc_s orcompiler_rt) floating point helper routines for Clang.This was originally landed in:commit 10117450735c ("drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines")but reverted in:commit 193392ed9f69 ("Revert "drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines"")due to bugreports from GCC builds. Add guards to only do so for Clang.Link: https://bugs.freedesktop.org/show_bug.cgi?id=109487Link: https://github.com/ClangBuiltLinux/linux/issues/327Suggested-by: Sedat Dilek Suggested-by: Sami Tolvanen Signed-off-by: Nick Desaulniers Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dsc/Makefile

7e446b3c - drm/amd/display: Support clang option for stack alignment

Fri, 12 Jul 2019 09:37:00 +0000

drm/amd/display: Support clang option for stack alignmentAs previously fixed for dml in commit 4769278e5c7f ("amdgpu/dc/dml:Support clang option for stack alignment") and calcs in commitcc32ad8f559c ("amdgpu/dc/calcs: Support clang option for stackalignment"), dcn20 uses an option that is not available with clang:clang: error: unknown argument: '-mpreferred-stack-boundary=4'scripts/Makefile.build:281: recipe for target 'drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.o' failedUse the same trick that we have in the other two files.Fixes: 7ed4e6352c16 ("drm/amd/display: Add DCN2 HW Sequencer and Resource")Signed-off-by: Arnd Bergmann Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dsc/Makefile

97bda032 - drm/amd/display: Add DSC support for Navi (v2)

Mon, 25 Feb 2019 18:26:34 +0000

drm/amd/display: Add DSC support for Navi (v2)Add support for DCN2 DSC (Display Stream Compression)HW Blocks: +--------++------+ +----------+ | HUBBUB || HUBP | <-- | MMHUBBUB | +--------++------+ +----------+ | ^ v | +--------+ +--------+ | DPP | | DWB | +--------+ +--------+ | v ^ +--------+ | | MPC | | +--------+ | | | v | +-------+ +-------+ | | OPP | <--> | DSC | | +-------+ +-------+ | | | v | +--------+ / | OPTC | -------------- +--------+ | v +--------+ +--------+ | DIO | | DCCG | +--------+ +--------+v2: rebase (Alex)Signed-off-by: Harry Wentland Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dsc/Makefile