Changes in Makefile

820ccf8c - drm/amd/display: Respect user's CONFIG_FRAME_WARN more for dml files

Fri, 31 Jan 2025 22:31:19 +0000

drm/amd/display: Respect user's CONFIG_FRAME_WARN more for dml filesCurrently, there are several files in drm/amd/display that aim to have ahigher -Wframe-larger-than value to avoid instances of that warning witha lower value from the user's configuration. However, with the way thatit is currently implemented, it does not respect the user's request viaCONFIG_FRAME_WARN for a higher stack frame limit, which can cause painwhen new instances of the warning appear and break the build due toCONFIG_WERROR.Adjust the logic to switch from a hard coded -Wframe-larger-than valueto only using the value as a minimum clamp and deferring to therequested value from CONFIG_FRAME_WARN if it is higher.Suggested-by: Harry Wentland Reported-by: Greg Kroah-Hartman Closes: https://lore.kernel.org/2025013003-audience-opposing-7f95@gregkh/Signed-off-by: Nathan Chancellor Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dml2/Makefile

e4479aec - drm/amd/display: Increase sanitizer frame larger than limit when compile testing with clang

Thu, 19 Dec 2024 23:46:35 +0000

drm/amd/display: Increase sanitizer frame larger than limit when compile testing with clangCommit 24909d9ec7c3 ("drm/amd/display: Overwriting dualDPP UBF valuesbefore usage") added a new warning in dml2/display_mode_core.c whenbuilding allmodconfig with clang: drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:6268:13: error: stack frame size (3128) exceeds limit (3072) in 'dml_prefetch_check' [-Werror,-Wframe-larger-than] 6268 | static void dml_prefetch_check(struct display_mode_lib_st *mode_lib) | ^Commit be4e3509314a ("drm/amd/display: DML21 Reintegration For VariousFixes") introduced one in dml2_core/dml2_core_dcn4_calcs.c with the sameconfiguration: drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c:7236:13: error: stack frame size (3256) exceeds limit (3072) in 'dml_core_mode_support' [-Werror,-Wframe-larger-than] 7236 | static bool dml_core_mode_support(struct dml2_core_calcs_mode_support_ex *in_out_params) | ^In the case of the first warning, the stack usage was already at thelimit at the parent change, so the offending change was ratherinnocuous. In the case of the second warning, there was a ratherdramatic increase in stack usage compared to the parent: drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c:7032:13: error: stack frame size (2696) exceeds limit (2048) in 'dml_core_mode_support' [-Werror,-Wframe-larger-than] 7032 | static bool dml_core_mode_support(struct dml2_core_calcs_mode_support_ex *in_out_params) | ^This is an unfortunate interaction between an issue with stack slotreuse in LLVM that gets exacerbated by sanitization (which gets enabledwith all{mod,yes}config) and function calls using a much higher numberof parameters than is typical in the kernel, necessitating passing mostof these values on the stack.While it is possible that there should be source code changes to addressthese warnings, this code is difficult to modify for various reasons, ashas been noted in other changes that have occurred for similar reasons,such as commit 6740ec97bcdb ("drm/amd/display: Increase frame warninglimit with KASAN or KCSAN in dml2").Increase the frame larger than limit when compile testing with clang andthe sanitizers enabled to avoid this breakage in all{mod,yes}config, asthey are commonly used and valuable testing targets. While it is not thebest to hide this issue, it is not really relevant when compile testing,as the sanitizers are commonly stressful on optimizations and they areonly truly useful at runtime, which COMPILE_TEST states will not occurwith the current build.Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202412121748.chuX4sap-lkp@intel.com/Signed-off-by: Nathan Chancellor Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dml2/Makefile

be4e3509 - drm/amd/display: DML21 Reintegration For Various Fixes

Mon, 25 Nov 2024 22:16:53 +0000

drm/amd/display: DML21 Reintegration For Various FixesReintegrate latest DML21 code.Tested-by: Daniel Wheeler Reviewed-by: Dillon Varone Signed-off-by: Austin Zheng Signed-off-by: Rodrigo Siqueira Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dml2/Makefile

d07722e1 - drm/amd/display: DML2.1 Reintegration for Various Fixes

Thu, 15 Aug 2024 22:45:23 +0000

drm/amd/display: DML2.1 Reintegration for Various Fixes[Why and How]DML2.1 reintegration for several fixes and updates to the DMLcode.Reviewed-by: Dillon Varone Signed-off-by: Austin Zheng Signed-off-by: Roman Li Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dml2/Makefile

0964fbd5 - drm/amd/display: Cleanup dml2 and dc/resource Makefile

Wed, 24 Jul 2024 21:19:31 +0000

drm/amd/display: Cleanup dml2 and dc/resource MakefileRemove some useless lines from DC Makefiles.Acked-by: Tom Chung Signed-off-by: Rodrigo Siqueira Signed-off-by: Wayne Lin Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dml2/Makefile

2563391e - drm/amd/display: DML2.1 resynchronization

Tue, 02 Jul 2024 14:50:04 +0000

drm/amd/display: DML2.1 resynchronizationJuly update for DML2.1 library from hardware team targeting DCN401Reviewed-by: Aurabindo Pillai Signed-off-by: Jerry Zuo Signed-off-by: Chaitanya Dhere Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dml2/Makefile

aa463cc8 - drm/amd/display: Fix CFLAGS for dml2_core_dcn4_calcs.o

Wed, 24 Apr 2024 18:19:27 +0000

drm/amd/display: Fix CFLAGS for dml2_core_dcn4_calcs.o-Wframe-larger-than=2048 is a part of both CFLAGS and CFLAGS_REMOVE fordml2_core_dcn4_calcs.o, which means that it ultimately gets removedaltogether for 64-bit targets, as 2048 is the default FRAME_WARN valuefor 64-bit platforms, resulting in no -Wframe-larger-than coverage forthis file.Remove -Wframe-larger-than from CFLAGS_REMOVE_dml2_core_dcn4_calcs.o andmove to $(frame_warn_flag) for CFLAGS_dml2_core_dcn4_calcs.o, as thataccounts for the fact that -Wframe-larger-than may need to be largerthan 2048 in certain situations, such as when the sanitizers areenabled.Fixes: 00c391102abc ("drm/amd/display: Add misc DC changes for DCN401")Signed-off-by: Nathan Chancellor Reviewed-by: Aurabindo Pillai Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dml2/Makefile

9f4c6256 - drm/amd/display: Add frame_warn_flag to dml2_core_shared.o

Wed, 24 Apr 2024 18:19:26 +0000

drm/amd/display: Add frame_warn_flag to dml2_core_shared.oWhen building with tip of tree Clang, there are some new instances of-Wframe-larger-than from the new display code (which become fatal withCONFIG_WERROR=y): drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_core/dml2_core_shared.c:754:6: error: stack frame size (2488) exceeds limit (2048) in 'dml2_core_shared_mode_support' [-Werror,-Wframe-larger-than] 754 | bool dml2_core_shared_mode_support(struct dml2_core_calcs_mode_support_ex *in_out_params) | ^ drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_core/dml2_core_shared.c:9834:6: error: stack frame size (2152) exceeds limit (2048) in 'dml2_core_shared_mode_programming' [-Werror,-Wframe-larger-than] 9834 | bool dml2_core_shared_mode_programming(struct dml2_core_calcs_mode_programming_ex *in_out_params) | ^ 2 errors generated.These warnings do not occur when CONFIG_K{A,C,M}SAN are disabled, so add$(frame_warn_flag) to dml2_core_shared.o's CFLAGS, which was added incommit 6740ec97bcdb ("drm/amd/display: Increase frame warning limit withKASAN or KCSAN in dml2") to account for this situation.Fixes: 00c391102abc ("drm/amd/display: Add misc DC changes for DCN401")Signed-off-by: Nathan Chancellor Reviewed-by: Aurabindo Pillai Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dml2/Makefile

00c39110 - drm/amd/display: Add misc DC changes for DCN401

Wed, 20 Mar 2024 17:56:16 +0000

drm/amd/display: Add misc DC changes for DCN401Add miscellaneous changes to enable DCN401 initSigned-off-by: Aurabindo Pillai Acked-by: Rodrigo Siqueira Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dml2/Makefile

a28e4b67 - drm/amd/display: use ARCH_HAS_KERNEL_FPU_SUPPORT

Fri, 29 Mar 2024 07:18:28 +0000

drm/amd/display: use ARCH_HAS_KERNEL_FPU_SUPPORTNow that all previously-supported architectures selectARCH_HAS_KERNEL_FPU_SUPPORT, this code can depend on that symbol insteadof the existing list of architectures. It can also take advantage of thecommon kernel-mode FPU API and method of adjusting CFLAGS.Link: https://lkml.kernel.org/r/20240329072441.591471-14-samuel.holland@sifive.comSigned-off-by: Samuel Holland Acked-by: Alex Deucher Reviewed-by: Christoph Hellwig Acked-by: Christian König Cc: Borislav Petkov (AMD) Cc: Catalin Marinas Cc: Dave Hansen Cc: Huacai Chen Cc: Ingo Molnar Cc: Jonathan Corbet Cc: Masahiro Yamada Cc: Michael Ellerman Cc: Nathan Chancellor Cc: Nicolas Schier Cc: Palmer Dabbelt Cc: Russell King Cc: Thomas Gleixner Cc: WANG Xuerui Cc: Will Deacon Signed-off-by: Andrew Morton List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dml2/Makefile

06a990b6 - drm/amd/display: only use hard-float, not altivec on powerpc

Fri, 29 Mar 2024 07:18:27 +0000

drm/amd/display: only use hard-float, not altivec on powerpcThe compiler flags enable altivec, but that is not required; hard-float issufficient for the code to build and function.Drop altivec from the compiler flags and adjust the enable/disable code toonly enable FPU use.Link: https://lkml.kernel.org/r/20240329072441.591471-13-samuel.holland@sifive.comSigned-off-by: Michael Ellerman Signed-off-by: Samuel Holland Acked-by: Alex Deucher Acked-by: Christian König Cc: Borislav Petkov (AMD) Cc: Catalin Marinas Cc: Christoph Hellwig Cc: Dave Hansen Cc: Huacai Chen Cc: Ingo Molnar Cc: Jonathan Corbet Cc: Masahiro Yamada Cc: Nathan Chancellor Cc: Nicolas Schier Cc: Palmer Dabbelt Cc: Russell King Cc: Thomas Gleixner Cc: WANG Xuerui Cc: Will Deacon Signed-off-by: Andrew Morton List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dml2/Makefile

caef6c45 - drm/amd/display: Add DML2 folder to include path

Mon, 11 Dec 2023 19:51:22 +0000

drm/amd/display: Add DML2 folder to include pathAdd DML2 compilation rule in the Makefile.Reviewed-by: Chaitanya Dhere Acked-by: Alex Hung Signed-off-by: Aurabindo Pillai Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dml2/Makefile

6740ec97 - drm/amd/display: Increase frame warning limit with KASAN or KCSAN in dml2

Thu, 02 Nov 2023 17:40:52 +0000

drm/amd/display: Increase frame warning limit with KASAN or KCSAN in dml2When building ARCH=x86_64 allmodconfig with clang, which will typicallyhave sanitizers enabled, there is a warning about a large stack frame. drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:6265:13: error: stack frame size (2520) exceeds limit (2048) in 'dml_prefetch_check' [-Werror,-Wframe-larger-than] 6265 | static void dml_prefetch_check(struct display_mode_lib_st *mode_lib) | ^ 1 error generated.Notably, GCC 13.2.0 does not do too much of a better job, as it is rightat the current limit of 2048 (and others have reported being over witholder GCC versions): drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c: In function 'dml_prefetch_check': drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:6705:1: error: the frame size of 2048 bytes is larger than 1800 bytes [-Werror=frame-larger-than=] 6705 | } | ^In the past, these warnings have been avoided by reducing the number ofparameters to various functions so that not as many arguments need to bepassed on the stack. However, these patches take a good amount of effortto write despite being mechanical due to code structure and complexityand they are never carried forward to new generations of the code sothat effort has to be expended every new hardware generation, whichbecomes harder to justify as time goes on.To avoid having a noticeable or lengthy breakage in all{mod,yes}config,which are easy testing targets that have -Werror enabled, increase thelimit for configurations that have KASAN or KCSAN enabled by 50% so thatcases of extremely poor code generation can still be caught while notbreaking the majority of builds. CONFIG_KMSAN also causes high stackusage but the frame limit is already set to zero when it is enabled,which is accounted for by the check for CONFIG_FRAME_WARN=0 in the dml2Makefile.Signed-off-by: Nathan Chancellor Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dml2/Makefile

d30a584c - drm/amd/display: Fix copyright notice in DML2 code

Thu, 19 Oct 2023 14:46:51 +0000

drm/amd/display: Fix copyright notice in DML2 code[Why & How]Fix incomplete copyright notice in DML2 code.Reviewed-by: Harry Wentland Signed-off-by: Stylon Wang Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dml2/Makefile

089dbf6a - drm/amd/display: Respect CONFIG_FRAME_WARN=0 in DML2

Wed, 18 Oct 2023 18:45:52 +0000

drm/amd/display: Respect CONFIG_FRAME_WARN=0 in DML2display_mode_code.c is unconditionally built with-Wframe-larger-than=2048, which causes warnings even whenCONFIG_FRAME_WARN has been set to 0, which should show no warnings.Use the existing $(frame_warn_flag) variable, which handles thissituation. This is basically commit 25f178bbd078 ("drm/amd/display:Respect CONFIG_FRAME_WARN=0 in dml Makefile") but for DML2.Fixes: 7966f319c66d ("drm/amd/display: Introduce DML2")Signed-off-by: Nathan Chancellor Signed-off-by: Hamza Mahfooz Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dml2/Makefile

7966f319 - drm/amd/display: Introduce DML2

Fri, 28 Jul 2023 21:55:30 +0000

drm/amd/display: Introduce DML2DC is transitioning from DML to DML2, and this commit introduces all therequired changes for some of the already available ASICs and adds therequired code infra to support new ASICs under DML2. DML2 is also agenerated code that provides better mode verification and programmingmodels for software/hardware, and it enables a better way to createvalidation tools. This version is more like a middle step to thecomplete transition to the DML2 version.Changes since V1:- Alex: Fix typosChanges since V2:- Update DC includesChanges since V3:- Fix 32 bit compilation issues on x86Changes since V4:- Avoid compilation of DML2 on some not supported 32-bit architecture- Update commit messageCo-developed-by: Rodrigo Siqueira Signed-off-by: Rodrigo Siqueira Co-developed-by: Roman Li Signed-off-by: Roman Li Signed-off-by: Qingqing Zhuo Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/dc/dml2/Makefile