Changes in amdgpu_dm.h

f729e637 - drm/amd: Pass luminance data to amdgpu_dm_backlight_caps

Fri, 28 Feb 2025 18:51:42 +0000

drm/amd: Pass luminance data to amdgpu_dm_backlight_capsThe ATIF method on some systems will provide a backlight curve. Passthis curve into amdgpu_dm add it to the structures.Reviewed-by: Alex Hung Link: https://lore.kernel.org/r/20250228185145.186319-3-mario.limonciello@amd.comSigned-off-by: Mario Limonciello Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

cbf4890c - drm/amd/display: Don't treat wb connector as physical in create_validate_stream_for_sink

Fri, 31 Jan 2025 16:57:49 +0000

drm/amd/display: Don't treat wb connector as physical in create_validate_stream_for_sinkDon't try to operate on a drm_wb_connector as an amdgpu_dm_connector.While dereferencing aconnector->base will "work" it's wrong andmight lead to unknown bad things. Just... don't.Reviewed-by: Alex Hung Signed-off-by: Harry Wentland Signed-off-by: Roman Li Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

3d5470c9 - drm/amd/display/dm: add support for OEM i2c bus

Tue, 17 Dec 2024 14:55:49 +0000

drm/amd/display/dm: add support for OEM i2c busExpose the OEM i2c bus on boards that support it.This bus is used for OEM specific features like RGB, etc.Reviewed-by: Harry Wentland Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

adb4998f - drm/amd/display: Reduce accessing remote DPCD overhead

Mon, 09 Dec 2024 07:25:35 +0000

drm/amd/display: Reduce accessing remote DPCD overhead[Why]Observed frame rate get dropped by tool like glxgear. Even though theoutput to monitor is 60Hz, the rendered frame rate drops to 30Hz lower.It's due to code path in some cases will triggerdm_dp_mst_is_port_support_mode() to read out remote Link status toassess the available bandwidth for dsc maniplation. Overhead of keepreading remote DPCD is considerable.[How]Store the remote link BW in mst_local_bw and use end-to-end full_pbnas an indicator to decide whether update the remote link bw or not.Whenever we need the info to assess the BW, visit the stored one first.Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3720Fixes: fa57924c76d9 ("drm/amd/display: Refactor function dm_dp_mst_is_port_support_mode()")Cc: Mario Limonciello Cc: Alex Deucher Reviewed-by: Jerry Zuo Signed-off-by: Wayne Lin Signed-off-by: Tom Chung Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher (cherry picked from commit 4a9a918545455a5979c6232fcf61ed3d8f0db3ae)Cc: stable@vger.kernel.org List of files: /linux-6.15/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

4a9a9185 - drm/amd/display: Reduce accessing remote DPCD overhead

Mon, 09 Dec 2024 07:25:35 +0000

drm/amd/display: Reduce accessing remote DPCD overhead[Why]Observed frame rate get dropped by tool like glxgear. Even though theoutput to monitor is 60Hz, the rendered frame rate drops to 30Hz lower.It's due to code path in some cases will triggerdm_dp_mst_is_port_support_mode() to read out remote Link status toassess the available bandwidth for dsc maniplation. Overhead of keepreading remote DPCD is considerable.[How]Store the remote link BW in mst_local_bw and use end-to-end full_pbnas an indicator to decide whether update the remote link bw or not.Whenever we need the info to assess the BW, visit the stored one first.Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3720Fixes: fa57924c76d9 ("drm/amd/display: Refactor function dm_dp_mst_is_port_support_mode()")Cc: Mario Limonciello Cc: Alex Deucher Reviewed-by: Jerry Zuo Signed-off-by: Wayne Lin Signed-off-by: Tom Chung Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

75948742 - drm/amd/display: add CEC notifier to amdgpu driver

Wed, 08 Jan 2025 09:18:49 +0000

drm/amd/display: add CEC notifier to amdgpu driverThis patch adds the cec_notifier feature to amdgpu driver.The changes will allow amdgpu driver code to notify EDIDand HPD changes to an eventual CEC adapter.Signed-off-by: Kun Liu Reviewed-by: Mario Limonciello Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

26d6fd81 - drm/connector: make mode_valid take a const struct drm_display_mode

Sat, 14 Dec 2024 13:37:09 +0000

drm/connector: make mode_valid take a const struct drm_display_modeThe mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridgetake a const struct drm_display_mode argument. Change the mode_validcallback of drm_connector to also take a const argument.Acked-by: Jani Nikula Reviewed-by: Liviu Dudau Reviewed-by: Raphael Gallais-Pou Reviewed-by: Laurent Pinchart Reviewed-by: Lyude Paul Reviewed-by: Maxime Ripard Reviewed-by: Thomas Zimmermann Reviewed-by: Harry Wentland Link: https://patchwork.freedesktop.org/patch/msgid/20241214-drm-connector-mode-valid-const-v2-5-4f9498a4c822@linaro.orgSigned-off-by: Dmitry Baryshkov List of files: /linux-6.15/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

58a8467a - drm/amd/display: Adjust secure_display_context data structure

Thu, 31 Oct 2024 09:32:32 +0000

drm/amd/display: Adjust secure_display_context data structure[Why]Variables relates to secure display are spreading out within structamdgpu_display_manager.[How]Encapsulate relevant variables into struct secure_display_context andadjust relevant affected codes.Reviewed-by: HaoPing Liu Signed-off-by: Wayne Lin Signed-off-by: Aurabindo Pillai Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

34b6c4b1 - drm/amd/display: Fix phy id mapping issue for secure display

Thu, 25 Jul 2024 07:29:44 +0000

drm/amd/display: Fix phy id mapping issue for secure display[Why]Under mst scenario, mst streams are from the same link_enc_hw_inst.As the result, can't utilize that as the phy index for distinguisingdifferent stream sinks.[How]Sort the connectors by:link_enc_hw_instance->mst tree depth->mst RADAfter sorting the phy index assignment, store connector's relevant infointo dm mapping array. Once need the index, just look up the staticarray.Reviewed-by: HaoPing Liu Signed-off-by: Wayne Lin Signed-off-by: Aurabindo Pillai Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

b8d9d5fe - drm/amd/display: Change some variable name of psr

Tue, 29 Oct 2024 07:38:16 +0000

drm/amd/display: Change some variable name of psrPanel Replay feature may also use the same variable with PSR.Change the variable name and make it not specify for PSR.Reviewed-by: Leo Li Signed-off-by: Tom Chung Signed-off-by: Hamza Mahfooz Signed-off-by: Alex Deucher (cherry picked from commit c7fafb7a46b38a11a19342d153f505749bf56f3e)Cc: stable@vger.kernel.org # 6.11+ List of files: /linux-6.15/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

c7fafb7a - drm/amd/display: Change some variable name of psr

Tue, 29 Oct 2024 07:38:16 +0000

drm/amd/display: Change some variable name of psrPanel Replay feature may also use the same variable with PSR.Change the variable name and make it not specify for PSR.Reviewed-by: Leo Li Signed-off-by: Tom Chung Signed-off-by: Hamza Mahfooz Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

48edb2a4 - drm/amd/display: switch amdgpu_dm_connector to use struct drm_edid

Fri, 27 Sep 2024 23:05:56 +0000

drm/amd/display: switch amdgpu_dm_connector to use struct drm_edidReplace raw edid handling (struct edid) with the opaque EDID type(struct drm_edid) on amdgpu_dm_connector for consistency. It may alsoprevent mismatch of approaches in different parts of the driver code.Signed-off-by: Melissa Wen Co-developed-by: Mario Limonciello Signed-off-by: Mario Limonciello Reviewed-by: Alex Hung Tested-by: Daniel Wheeler Signed-off-by: Rodrigo Siqueira Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

d4f36e5f - drm/amd/display: fix a memleak issue when driver is removed

Mon, 23 Sep 2024 20:07:25 +0000

drm/amd/display: fix a memleak issue when driver is removedRunning "modprobe amdgpu" the second time (followed by a modprobe -ramdgpu) causes a call trace like:[ 845.212163] Memory manager not clean during takedown.[ 845.212170] WARNING: CPU: 4 PID: 2481 at drivers/gpu/drm/drm_mm.c:999 drm_mm_takedown+0x2b/0x40[ 845.212177] Modules linked in: amdgpu(OE-) amddrm_ttm_helper(OE) amddrm_buddy(OE) amdxcp(OE) amd_sched(OE) drm_exec drm_suballoc_helper drm_display_helper i2c_algo_bit amdttm(OE) amdkcl(OE) cec rc_core sunrpc qrtr intel_rapl_msr intel_rapl_common snd_hda_codec_hdmi edac_mce_amd snd_hda_intel snd_intel_dspcfg snd_intel_sdw_acpi snd_usb_audio snd_hda_codec snd_usbmidi_lib kvm_amd snd_hda_core snd_ump mc snd_hwdep kvm snd_pcm snd_seq_midi snd_seq_midi_event irqbypass crct10dif_pclmul snd_rawmidi polyval_clmulni polyval_generic ghash_clmulni_intel sha256_ssse3 sha1_ssse3 snd_seq aesni_intel crypto_simd snd_seq_device cryptd snd_timer mfd_aaeon asus_nb_wmi eeepc_wmi joydev asus_wmi snd ledtrig_audio sparse_keymap ccp wmi_bmof input_leds k10temp i2c_piix4 platform_profile rapl soundcore gpio_amdpt mac_hid binfmt_misc msr parport_pc ppdev lp parport efi_pstore nfnetlink dmi_sysfs ip_tables x_tables autofs4 hid_logitech_hidpp hid_logitech_dj hid_generic usbhid hid ahci xhci_pci igc crc32_pclmul libahci xhci_pci_renesas video[ 845.212284] wmi [last unloaded: amddrm_ttm_helper(OE)][ 845.212290] CPU: 4 PID: 2481 Comm: modprobe Tainted: G W OE 6.8.0-31-generic #31-Ubuntu[ 845.212296] RIP: 0010:drm_mm_takedown+0x2b/0x40[ 845.212300] Code: 1f 44 00 00 48 8b 47 38 48 83 c7 38 48 39 f8 75 09 31 c0 31 ff e9 90 2e 86 00 55 48 c7 c7 d0 f6 8e 8a 48 89 e5 e8 f5 db 45 ff <0f> 0b 5d 31 c0 31 ff e9 74 2e 86 00 66 0f 1f 84 00 00 00 00 00 90[ 845.212302] RSP: 0018:ffffb11302127ae0 EFLAGS: 00010246[ 845.212305] RAX: 0000000000000000 RBX: ffff92aa5020fc08 RCX: 0000000000000000[ 845.212307] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000[ 845.212309] RBP: ffffb11302127ae0 R08: 0000000000000000 R09: 0000000000000000[ 845.212310] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000004[ 845.212312] R13: ffff92aa50200000 R14: ffff92aa5020fb10 R15: ffff92aa5020faa0[ 845.212313] FS: 0000707dd7c7c080(0000) GS:ffff92b93de00000(0000) knlGS:0000000000000000[ 845.212316] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033[ 845.212318] CR2: 00007d48b0aee200 CR3: 0000000115a58000 CR4: 0000000000f50ef0[ 845.212320] PKRU: 55555554[ 845.212321] Call Trace:[ 845.212323] [ 845.212328] ? show_regs+0x6d/0x80[ 845.212333] ? __warn+0x89/0x160[ 845.212339] ? drm_mm_takedown+0x2b/0x40[ 845.212344] ? report_bug+0x17e/0x1b0[ 845.212350] ? handle_bug+0x51/0xa0[ 845.212355] ? exc_invalid_op+0x18/0x80[ 845.212359] ? asm_exc_invalid_op+0x1b/0x20[ 845.212366] ? drm_mm_takedown+0x2b/0x40[ 845.212371] amdgpu_gtt_mgr_fini+0xa9/0x130 [amdgpu][ 845.212645] amdgpu_ttm_fini+0x264/0x340 [amdgpu][ 845.212770] amdgpu_bo_fini+0x2e/0xc0 [amdgpu][ 845.212894] gmc_v12_0_sw_fini+0x2a/0x40 [amdgpu][ 845.213036] amdgpu_device_fini_sw+0x11a/0x590 [amdgpu][ 845.213159] amdgpu_driver_release_kms+0x16/0x40 [amdgpu][ 845.213302] devm_drm_dev_init_release+0x5e/0x90[ 845.213305] devm_action_release+0x12/0x30[ 845.213308] release_nodes+0x42/0xd0[ 845.213311] devres_release_all+0x97/0xe0[ 845.213314] device_unbind_cleanup+0x12/0x80[ 845.213317] device_release_driver_internal+0x230/0x270[ 845.213319] ? srso_alias_return_thunk+0x5/0xfbef5This is caused by lost memory during early init phase. First time driveris removed, memory is freed but when second time the driver is inserted,VBIOS dmub is not active, since the PSP policy is to retain the driverloaded version on subsequent warm boots. Hence, communication with VBIOSDMUB fails.Fix this by aborting further communication with vbios dmub and releasethe memory immediately.Fixes: f59549c7e705 ("drm/amd/display: free bo used for dmub bounding box")Reviewed-by: Rodrigo Siqueira Signed-off-by: Aurabindo Pillai Signed-off-by: Rodrigo Siqueira Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

5a3d3e11 - drm/amd/display: Add dmub hpd sense callback

Wed, 21 Aug 2024 14:53:15 +0000

drm/amd/display: Add dmub hpd sense callback[WHY]HPD sense notification has been implemented in DMUB, whichcan occur during low power states and need to benotified from firmware to driver.[HOW]Define callback and register new HPD sense notification.Reviewed-by: Nicholas Kazlauskas Signed-off-by: Roman Li Signed-off-by: Alex Hung Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

717b432b - Revert "drm/amd: Add power_saving_policy drm property to eDP connectors"

Fri, 02 Aug 2024 14:59:46 +0000

Revert "drm/amd: Add power_saving_policy drm property to eDP connectors"This reverts commit 9d8c094ddab05db88d183ba82e23be807848cad8.It was merged without meeting userspace requirements.Signed-off-by: Hamza Mahfooz Reviewed-by: Harry Wentland Link: https://patchwork.freedesktop.org/patch/msgid/20240802145946.48073-2-hamza.mahfooz@amd.com List of files: /linux-6.15/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

0e2c796b - drm/amd/display: Add function banner for idle_workqueue

Mon, 15 Jul 2024 20:45:46 +0000

drm/amd/display: Add function banner for idle_workqueue[Why]htmldocs warning:drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h: warning:Function parameter or struct member 'idle_workqueue' not described in'amdgpu_display_manager'.[How]Add comment section for idle_workqueue with param description.Reported-by: Stephen Rothwell Link: https://lore.kernel.org/dri-devel/20240715090211.736a9b4d@canb.auug.org.au/Signed-off-by: Roman Li Reviewed-by: Aurabindo Pillai Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

7bbae44c - drm/amd/display: fix doc entry for bb_from_dmub

Mon, 15 Jul 2024 19:02:20 +0000

drm/amd/display: fix doc entry for bb_from_dmubFixes the warning:Function parameter or struct member 'bb_from_dmub' not described in 'amdgpu_display_manager'Reported-by: Stephen Rothwell Signed-off-by: Aurabindo Pillai Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

9d8c094d - drm/amd: Add power_saving_policy drm property to eDP connectors

Wed, 03 Jul 2024 05:17:22 +0000

drm/amd: Add power_saving_policy drm property to eDP connectorsWhen the `power_saving_policy` property is set to bit mask"Require color accuracy" ABM should be disabled immediately andany requests by sysfs to update will return an -EBUSY error.When the `power_saving_policy` property is set to bit mask"Require low latency" PSR should be disabled.When the property is restored to an empty bit mask ABM and PSRcan be enabled again.Signed-off-by: Mario Limonciello Reviewed-by: Leo Li Signed-off-by: Hamza Mahfooz Link: https://patchwork.freedesktop.org/patch/msgid/20240703051722.328-3-mario.limonciello@amd.com List of files: /linux-6.15/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

9862ef7b - drm/amd/display: Use periodic detection for ipx/headless

Thu, 13 Jun 2024 14:41:51 +0000

drm/amd/display: Use periodic detection for ipx/headless[WHY]Hotplug is not detected in headless (no eDP) mode on dcn35x.With no display dcn35x goes to IPS2 powersaving state where HPD interruptis not handled.[HOW]Use idle worker thread for periodic detection of HPD in headless mode.Reviewed-by: Aurabindo Pillai Cc: Mario Limonciello Cc: Alex Deucher Cc: stable@vger.kernel.orgSigned-off-by: Alex Hung Signed-off-by: Roman Li Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

1b04dcca - drm/amd/display: Introduce overlay cursor mode

Thu, 18 Jan 2024 21:29:49 +0000

drm/amd/display: Introduce overlay cursor mode[Why]DCN is the display hardware for amdgpu. DRM planes are backed by DCNhardware pipes, which carry pixel data from one end (memory), to theother (output encoder).Each DCN pipe has the ability to blend in a cursor early on in thepipeline. In other words, there are no dedicated cursor planes in DCN,which makes cursor behavior somewhat unintuitive for compositors.For example, if the cursor is in RGB format, but the top-most DRM planeis in YUV format, DCN will not be able to blend them. Because of this,amdgpu_dm rejects all configurations where a cursor needs to be enabledon top of a YUV formatted plane.From a compositor's perspective, when computing an allocation forhardware plane offloading, this cursor-on-yuv configuration result in anatomic test failure. Since the failure reason is not obvious at all,compositors will likely fall back to full rendering, which is not ideal.Instead, amdgpu_dm can try to accommodate the cursor-on-yuvconfiguration by opportunistically reserving a separate DCN pipe justfor the cursor. We can refer to this as "overlay cursor mode". It iscontrasted with "native cursor mode", where the native DCN per-pipecursor is used.[How]On each crtc, compute whether the cursor plane should be enabled inoverlay mode. If it is, mark the CRTC as requesting overlay cursor mode.Overlay cursor should be enabled whenever there exists a underlyingplane that has YUV format, or is scaled differently than the cursor. Itshould also be enabled if there is no underlying plane, or if underlyingplanes do not cover the entire CRTC.During DC validation, attempt to enable a separate DCN pipe for thecursor if it's in overlay mode. If that fails, or if no overlay mode isrequested, then fallback to native mode.v2:* Update commit message for when overlay cursor should be enabled* Also consider scale and no-underlying-plane case (cursor on crtc bg)* Consider all underlying planes when determinig overlay/native, not just the plane immediately beneath the cursor, as it may not cover the entire CRTC.* Fix typo s/decending/descending/* Force native cursor on pre-DCN hardwareReviewed-by: Harry Wentland Acked-by: Zaeem Mohamed Signed-off-by: Leo Li Acked-by: Harry Wentland Acked-by: Pekka Paalanen Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h