Changes in amdgpu_doorbell_mgr.c

3806a8c6 - drm/amdgpu: fix SI failure due to doorbells allocation

Sun, 08 Oct 2023 06:46:49 +0000

drm/amdgpu: fix SI failure due to doorbells allocationSI hardware does not have doorbells at all, however currently the codewill try to do the allocation and thus fail, makes SI AMDGPU not usable.Fix this failure by skipping doorbells allocation when doorbells countis zero.Fixes: 54c30d2a8def ("drm/amdgpu: create kernel doorbell pages")Reviewed-by: Shashank Sharma Signed-off-by: Icenowy Zheng Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c

219223ec - drm/amdgpu: fix SI failure due to doorbells allocation

Sun, 08 Oct 2023 06:46:49 +0000

367a0af4 - drm/amdkfd: get doorbell's absolute offset based on the db_size

Mon, 09 Oct 2023 17:13:16 +0000

drm/amdkfd: get doorbell's absolute offset based on the db_sizeHere, Adding db_size in byte to find the doorbell'sabsolute offset for both 32-bit and 64-bit doorbell sizes.So that doorbell offset will be aligned based on the doorbellsize.v2:- Addressed the review comment from Felix.v3:- Adding doorbell_size as parameter to get db absolute offset.v4: Squash the two patches into one.Cc: Christian Koenig Cc: Alex Deucher Reviewed-by: Felix Kuehling Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c

04cef5f5 - drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param 'doorbell_index'

Thu, 24 Aug 2023 07:36:56 +0000

drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param 'doorbell_index'Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Function parameter or member 'doorbell_index' not described in 'amdgpu_doorbell_index_on_bar' drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Excess function parameter 'db_index' description in 'amdgpu_doorbell_index_on_bar'Reviewed-by: Shashank Sharma Signed-off-by: Lee Jones Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c

e3cbb1f4 - drm/amdgpu: use doorbell mgr for MES kernel doorbells

Fri, 14 Jul 2023 14:22:38 +0000

drm/amdgpu: use doorbell mgr for MES kernel doorbellsThis patch:- Removes the existing doorbell management code, and its variables from the doorbell_init function, it will be done in doorbell manager now.- uses the doorbell page created for MES kernel level needs (doorbells for MES self tests)- current MES code was allocating MES doorbells in MES process context, but those were getting written using kernel doorbell calls. This patch instead allocates a MES kernel doorbell for this (in add_hw_queue).V2: Create an extra page of doorbells for MES during kernel doorbell creation (Alex)V4: Move MES doorbell size and page offset objects in this patch from patch 6.Cc: Alex Deucher Cc: Christian Koenig Reviewed-by: Christian Koenig Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c

d124aa0a - drm/amdgpu: get absolute offset from doorbell index

Wed, 12 Apr 2023 12:39:00 +0000

drm/amdgpu: get absolute offset from doorbell indexThis patch adds a helper function which converts a doorbell'srelative index in a BO to an absolute doorbell offset in thedoorbell BAR.V2: No space between the variable name doc (Luben)Cc: Alex Deucher Cc: Christian Koenig Acked-by: Christian König Signed-off-by: Shashank Sharma Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c

54c30d2a - drm/amdgpu: create kernel doorbell pages

Fri, 14 Jul 2023 13:19:54 +0000

drm/amdgpu: create kernel doorbell pagesThis patch:- creates a doorbell page for graphics driver usages.- adds a few new varlables in adev->doorbell structure to keep track of kernel's doorbell-bo.- removes the adev->doorbell.ptr variable, replaces it with kernel-doorbell-bo's cpu address.V2: - Create doorbell BO directly, no wrappe functions (Alex) - no additional doorbell structure (Alex, Christian) - Use doorbell_cpu_ptr, remove ioremap (Christian, Alex) - Allocate one extra page of doorbells for MES (Alex)V4: Move MES doorbell base init into MES related patch (Christian)Cc: Alex Deucher Cc: Christian Koenig Reviewed-by: Christian König Signed-off-by: Shashank Sharma Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c

794c33c6 - drm/amdgpu: don't modify num_doorbells for mes

Fri, 31 Mar 2023 17:57:05 +0000

drm/amdgpu: don't modify num_doorbells for mesThis patch removes the check and change in num_kernel_doorbellsfor MES, which is not being used anywhere by MES code.V2: Fixed checkpatch warnings.Cc: Alex Deucher Cc: Christian Koenig Reviewed-by: Christian Koenig Acked-by: Alex Deucher Signed-off-by: Shashank Sharma Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c

43c064db - drm/amdgpu: create a new file for doorbell manager

Fri, 14 Jul 2023 13:05:44 +0000

drm/amdgpu: create a new file for doorbell managerThis patch:- creates a new file for doorbell management.- moves doorbell code from amdgpu_device.c to this file.V2: - remove doc from function declaration (Christian) - remove 'device' from function names to make it consistent (Alex) - add SPDX license identifier (Luben)V3: - change license to MIT license(Christian)Cc: Alex Deucher Cc: Christian Koenig Reviewed-by: Christian König Signed-off-by: Shashank Sharma Signed-off-by: Alex Deucher List of files: /linux-6.15/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c