Changes in dmi-sysfs.c

1c83b02c - firmware: dmi: Constify 'struct bin_attribute'

Sat, 25 Jan 2025 10:12:16 +0000

firmware: dmi: Constify 'struct bin_attribute'The sysfs core now allows instances of 'struct bin_attribute' to bemoved into read-only memory. Make use of that to protect them againstaccidental or malicious modifications.Signed-off-by: Thomas Weißschuh Link: https://lore.kernel.org/r/20250125-sysfs-const-bin_attr-dmi-v2-3-ece1895936f4@weissschuh.netSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/firmware/dmi-sysfs.c

80d3989b - firmware: dmi: Define bin_attributes through macro

Sat, 25 Jan 2025 10:12:15 +0000

firmware: dmi: Define bin_attributes through macroThe macro makes the code shorter and simplifies constification of thecallback arguments.Signed-off-by: Thomas Weißschuh Link: https://lore.kernel.org/r/20250125-sysfs-const-bin_attr-dmi-v2-2-ece1895936f4@weissschuh.netSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/firmware/dmi-sysfs.c

e7f3dd80 - firmware: dmi-sysfs: handle HAS_IOPORT=n

Mon, 22 May 2023 10:50:15 +0000

firmware: dmi-sysfs: handle HAS_IOPORT=nIn a future patch HAS_IOPORT=n will result in inb()/outb() and friendsnot being declared. We thus need to guard sections of code calling themas alternative access methods.Co-developed-by: Arnd Bergmann Signed-off-by: Arnd Bergmann Signed-off-by: Niklas Schnelle Link: https://lore.kernel.org/r/20230522105049.1467313-11-schnelle@linux.ibm.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/firmware/dmi-sysfs.c

81773c98 - firmware: dmi-sysfs: make kobj_type structures constant

Mon, 27 Feb 2023 03:17:37 +0000

firmware: dmi-sysfs: make kobj_type structures constantSince commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")the driver core allows the usage of const struct kobj_type.Take advantage of this to constify the structure definitions to preventmodification at runtime.Signed-off-by: Thomas Weißschuh Link: https://lore.kernel.org/r/20230227-kobj_type-firmware-dmi-v1-1-d1131d4e7a2b@weissschuh.netSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/firmware/dmi-sysfs.c

18e126e9 - firmware: dmi-sysfs: Fix null-ptr-deref in dmi_sysfs_register_handle

Fri, 11 Nov 2022 01:53:26 +0000

firmware: dmi-sysfs: Fix null-ptr-deref in dmi_sysfs_register_handleKASAN reported a null-ptr-deref error:KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f]CPU: 0 PID: 1373 Comm: modprobeHardware name: QEMU Standard PC (i440FX + PIIX, 1996)RIP: 0010:dmi_sysfs_entry_release...Call Trace: kobject_put dmi_sysfs_register_handle (drivers/firmware/dmi-sysfs.c:540) dmi_sysfs dmi_decode_table (drivers/firmware/dmi_scan.c:133) dmi_walk (drivers/firmware/dmi_scan.c:1115) dmi_sysfs_init (drivers/firmware/dmi-sysfs.c:149) dmi_sysfs do_one_initcall (init/main.c:1296) ...Kernel panic - not syncing: Fatal exceptionKernel Offset: 0x4000000 from 0xffffffff81000000---[ end Kernel panic - not syncing: Fatal exception ]---It is because previous patch added kobject_put() to release the memorywhich will call dmi_sysfs_entry_release() and list_del().However, list_add_tail(entry->list) is called after the error block,so the list_head is uninitialized and cannot be deleted.Move error handling to after list_add_tail to fix this.Fixes: 660ba678f999 ("firmware: dmi-sysfs: Fix memory leak in dmi_sysfs_register_handle")Signed-off-by: Chen Zhongjin Link: https://lore.kernel.org/r/20221111015326.251650-2-chenzhongjin@huawei.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/firmware/dmi-sysfs.c

7d12970f - firmware: dmi-sysfs: make pr_info messages rate limited

Tue, 29 Nov 2022 22:38:55 +0000

firmware: dmi-sysfs: make pr_info messages rate limitedCurrently if a process repeat repeatedly reads the dmi sysfs raw event log/sys/firmware/dmi/entries/15-0/system_event_log/raw_event_log when GPNVsupport is missing or using an unknown access method the kernel log getsspammed with info messages. Make the messages rate limited to reduce themessage spamming. Triggered when running sudo stress-ng --sysfs -t 5m.Signed-off-by: Colin Ian King Link: https://lore.kernel.org/r/20221129223855.1005674-1-colin.i.king@gmail.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/firmware/dmi-sysfs.c

660ba678 - firmware: dmi-sysfs: Fix memory leak in dmi_sysfs_register_handle

Wed, 11 May 2022 07:14:19 +0000

firmware: dmi-sysfs: Fix memory leak in dmi_sysfs_register_handlekobject_init_and_add() takes reference even when it fails.According to the doc of kobject_init_and_add() If this function returns an error, kobject_put() must be called to properly clean up the memory associated with the object.Fix this issue by calling kobject_put().Fixes: 948af1f0bbc8 ("firmware: Basic dmi-sysfs support")Signed-off-by: Miaoqian Lin Link: https://lore.kernel.org/r/20220511071421.9769-1-linmq006@gmail.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/firmware/dmi-sysfs.c

ab6d0f57 - firmware: dmi-sysfs: use default_groups in kobj_type

Wed, 05 Jan 2022 18:17:19 +0000

firmware: dmi-sysfs: use default_groups in kobj_typeThere are currently 2 ways to create a set of sysfs files for akobj_type, through the default_attrs field, and the default_groupsfield. Move the firmware dmi-sysfs sysfs code to use default_groupsfield which has been the preferred way since aa30f47cf666 ("kobject: Addsupport for default attribute groups to kobj_type") so that we can soonget rid of the obsolete default_attrs field.Link: https://lore.kernel.org/r/20220105181719.2737782-1-gregkh@linuxfoundation.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/firmware/dmi-sysfs.c

8e849a41 - firmware: dmi-sysfs: Replace zero-length array with flexible-array member

Fri, 21 Feb 2020 15:15:44 +0000

firmware: dmi-sysfs: Replace zero-length array with flexible-array memberThere is a regular need in the kernel to provide a way to declare having adynamically sized set of trailing elements in a structure. Kernel code shouldalways use “flexible array members”[1] for these cases. The older style ofone-element or zero-length arrays should no longer be used[2].[1] https://en.wikipedia.org/wiki/Flexible_array_member[2] https://github.com/KSPP/linux/issues/21Signed-off-by: Gustavo A. R. Silva List of files: /linux-6.15/drivers/firmware/dmi-sysfs.c

09c434b8 - treewide: Add SPDX license identifier for more missed files

Sun, 19 May 2019 12:08:20 +0000

treewide: Add SPDX license identifier for more missed filesAdd SPDX license identifiers to all files which: - Have no license information of any form - Have MODULE_LICENCE("GPL*") inside which was used in the initial scan/conversion to ignore the fileThese files fall under the project license, GPL v2 only. The resulting SPDXlicense identifier is: GPL-2.0-onlySigned-off-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/firmware/dmi-sysfs.c

a81114d0 - firmware: dmi: handle missing DMI data gracefully

Sat, 03 Feb 2018 10:25:20 +0000

firmware: dmi: handle missing DMI data gracefullyCurrently, when booting a kernel with DMI support on a platform that hasno DMI tables, the following output is emitted into the kernel log: [ 0.128818] DMI not present or invalid. ... [ 1.306659] dmi: Firmware registration failed. ... [ 2.908681] dmi-sysfs: dmi entry is absent.The first one is a pr_info(), but the subsequent ones are pr_err()s thatcomplain about a condition that is not really an error to begin with.So let's clean this up, and give up silently if dma_available is not set.Signed-off-by: Ard Biesheuvel Acked-by: Martin Hundebøll Signed-off-by: Jean Delvare List of files: /linux-6.15/drivers/firmware/dmi-sysfs.c

f7750a79 - x86, mpparse, x86/acpi, x86/PCI, x86/dmi, SFI: Use memremap() for RAM mappings

Mon, 17 Jul 2017 21:10:00 +0000

x86, mpparse, x86/acpi, x86/PCI, x86/dmi, SFI: Use memremap() for RAM mappingsThe ioremap() function is intended for mapping MMIO. For RAM, thememremap() function should be used. Convert calls from ioremap() tomemremap() when re-mapping RAM.This will be used later by SME to control how the encryption mask isapplied to memory mappings, with certain memory locations being mappeddecrypted vs encrypted.Signed-off-by: Tom Lendacky Reviewed-by: Thomas Gleixner Reviewed-by: Borislav Petkov Cc: Alexander Potapenko Cc: Andrey Ryabinin Cc: Andy Lutomirski Cc: Arnd Bergmann Cc: Borislav Petkov Cc: Brijesh Singh Cc: Dave Young Cc: Dmitry Vyukov Cc: Jonathan Corbet Cc: Konrad Rzeszutek Wilk Cc: Larry Woodman Cc: Linus Torvalds Cc: Matt Fleming Cc: Michael S. Tsirkin Cc: Paolo Bonzini Cc: Peter Zijlstra Cc: Radim Krčmář Cc: Rik van Riel Cc: Toshimitsu Kani Cc: kasan-dev@googlegroups.comCc: kvm@vger.kernel.orgCc: linux-arch@vger.kernel.orgCc: linux-doc@vger.kernel.orgCc: linux-efi@vger.kernel.orgCc: linux-mm@kvack.orgLink: http://lkml.kernel.org/r/b13fccb9abbd547a7eef7b1fdfc223431b211c88.1500319216.git.thomas.lendacky@amd.comSigned-off-by: Ingo Molnar List of files: /linux-6.15/drivers/firmware/dmi-sysfs.c

d7f96f97 - firmware: dmi_scan: add SBMIOS entry and DMI tables

Thu, 25 Jun 2015 07:06:56 +0000

firmware: dmi_scan: add SBMIOS entry and DMI tablesSome utils, like dmidecode and smbios, need to access SMBIOS entrytable area in order to get information like SMBIOS version, size, etc.Currently it's done via /dev/mem. But for situation when /dev/memusage is disabled, the utils have to use dmi sysfs instead, whichdoesn't represent SMBIOS entry and adds code/delay redundancy when directaccess for table is needed.So this patch creates dmi/tables and adds SMBIOS entry point to allowutils in question to work correctly without /dev/mem. Also patch addsraw dmi table to simplify dmi table processing in user space, asproposed by Jean Delvare.Tested-by: Roy Franz Signed-off-by: Ivan Khoronzhuk Signed-off-by: Jean Delvare List of files: /linux-6.15/drivers/firmware/dmi-sysfs.c

d0f80f9a - firmware: dmi-sysfs: Remove "dmi" directory on module exit

Thu, 05 Dec 2013 23:46:35 +0000

firmware: dmi-sysfs: Remove "dmi" directory on module exitWith CONFIG_DEBUG_KOBJECT_RELEASE=y, removing and immediately reloading thedmi-sysfs module causes the following warning: sysfs: cannot create duplicate filename '/firmware/dmi' kobject_add_internal failed for dmi with -EEXIST, don't try to register things with the same name in the same directory.The "dmi" directory stays in sysfs until the dmi_kobj is released, andDEBUG_KOBJECT_RELEASE delays that.I don't think we can hit this problem in normal usage because dmi_kobj isstatic and nothing outside dmi-sysfs can get a reference to it, so theonly way to delay the "dmi" release is with DEBUG_KOBJECT_RELEASE.Signed-off-by: Bjorn Helgaas Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/firmware/dmi-sysfs.c

a61aca28 - firmware: dmi-sysfs: Don't remove dmi-sysfs "raw" file explicitly

Thu, 05 Dec 2013 23:46:28 +0000

firmware: dmi-sysfs: Don't remove dmi-sysfs "raw" file explicitlyRemoving the dmi-sysfs module causes the following warning: # modprobe -r dmi_sysfs WARNING: CPU: 11 PID: 6785 at fs/sysfs/inode.c:325 sysfs_hash_and_remove+0xa9/0xb0() sysfs: can not remove 'raw', no directoryThis is because putting the entry kobject, e.g., for"/sys/firmware/dmi/entries/19-0", removes the directory and all itscontents. By the time dmi_sysfs_entry_release() runs, the "raw" fileinside ".../19-0/" has already been removed.Therefore, we don't need to remove the "raw" bin file at all indmi_sysfs_entry_release().Signed-off-by: Bjorn Helgaas Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/firmware/dmi-sysfs.c

66245ad0 - firmware: Fix unaligned memory accesses in dmi-sysfs

Fri, 25 Feb 2011 23:41:49 +0000

firmware: Fix unaligned memory accesses in dmi-sysfsDMI entries are arranged in memory back to back with no alignmentguarantees. This means that the struct dmi_header passed to callbacksfrom dmi_walk() itself isn't byte aligned. This causes problems onarchitectures that expect aligned data, such as IA64.The dmi-sysfs patchset introduced structure member accesses through thispassed in dmi_header. Fix this by memcpy()ing the structures totemporary locations on stack when inspecting/copying them.Signed-off-by: Mike Waychison Tested-by: Tony Luck Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/firmware/dmi-sysfs.c

a3857a5c - firmware: Expose DMI type 15 System Event Log

Wed, 23 Feb 2011 01:53:31 +0000

firmware: Expose DMI type 15 System Event LogThe System Event Log described by DMI entry type 15 may be backed byeither memory or may be indirectly accessed via an IO index/dataregister pair.In order to get read access to this log, expose it in the"system_event_log" sub-directory of type 15 DMI entries, ie:/sys/firmware/dmi/entries/15-0/system_event_log/raw_event_log.This commit handles both IO accessed and memory access system eventlogs. OEM specific access and GPNV support is explicitly not handledand we error out in the logs when we do not recognize the access method.Signed-off-by: Mike Waychison Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/firmware/dmi-sysfs.c

925a1da7 - firmware: Break out system_event_log in dmi-sysfs

Wed, 23 Feb 2011 01:53:26 +0000

firmware: Break out system_event_log in dmi-sysfsThe optional type 15 entry of the DMI table describes a non-volatilestorage-backed system event log.In preparation for the next commit which exposes the raw bits of theevent log to userland, create a new sub-directory within the dmi entrycalled "system_event_log" and expose attribute files that describe theevent log itself.Currently, only a single child object is permitted within admi_sysfs_entry. We simply point at this child from the dmi_sysfs_entryif it exists.Signed-off-by: Mike Waychison Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/firmware/dmi-sysfs.c

948af1f0 - firmware: Basic dmi-sysfs support

Wed, 23 Feb 2011 01:53:21 +0000

firmware: Basic dmi-sysfs supportIntroduce a new module "dmi-sysfs" that exports the broken out entriesof the DMI table through sysfs.Entries are enumerated via dmi_walk() on module load, and are populatedas kobjects rooted at /sys/firmware/dmi/entries.Entries are named "-", where: : is the type of the entry, and : is the ordinal count within the DMI table of that entry type. This instance is used in lieu the DMI entry's handle as no assurances are made by the kernel that handles are unique.All entries export the following attributes: length : The length of the formatted portion of the entry handle : The handle given to this entry by the firmware raw : The raw bytes of the entire entry, including the formatted portion, the unformatted (strings) portion, and the two terminating nul characters. type : The DMI entry type instance : The ordinal instance of this entry given its type. position : The position ordinal of the entry within the table in its entirety.Entries in dmi-sysfs are kobject backed members called "structdmi_sysfs_entry" and belong to dmi_kset. They are threaded throughentry_list (protected by entry_list_lock) so that we can find them atcleanup time.Signed-off-by: Mike Waychison Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/firmware/dmi-sysfs.c