Changes in Kconfig

a0b887f6 - firmware: cs_dsp: tests: Depend on FW_CS_DSP rather then enabling it

Fri, 11 Apr 2025 12:36:08 +0000

firmware: cs_dsp: tests: Depend on FW_CS_DSP rather then enabling itFW_CS_DSP gets enabled if KUNIT is enabled. The test should ratherdepend on if the feature is enabled. Fix this by moving FW_CS_DSP to thedepends on clause.Fixes: dd0b6b1f29b9 ("firmware: cs_dsp: Add KUnit testing of bin file download")Signed-off-by: Nico Pache Signed-off-by: Richard Fitzgerald Link: https://patch.msgid.link/20250411123608.1676462-4-rf@opensource.cirrus.comReviewed-by: David Gow Signed-off-by: Mark Brown List of files: /linux-6.15/drivers/firmware/cirrus/Kconfig

eb5c7982 - firmware: cs_dsp: FW_CS_DSP_KUNIT_TEST should not select REGMAP

Sat, 25 Jan 2025 19:32:15 +0000

firmware: cs_dsp: FW_CS_DSP_KUNIT_TEST should not select REGMAPEnabling a (modular) test should not silently enable additional kernelfunctionality, as that may increase the attack vector of a product.Fix this by making FW_CS_DSP_KUNIT_TEST (and FW_CS_DSP_KUNIT_TEST_UTILS)depend on REGMAP instead of selecting it.After this, one can safely enable CONFIG_KUNIT_ALL_TESTS=m to buildmodules for all appropriate tests for ones system, without pulling inextra unwanted functionality, while still allowing a tester to manuallyenable REGMAP_BUILD and this test suite on a system where REGMAP is notenabled by default.Fixes: dd0b6b1f29b92202 ("firmware: cs_dsp: Add KUnit testing of bin file download")Signed-off-by: Geert Uytterhoeven Link: https://patch.msgid.link/73c81ac85e21f1c5a75b7628d90cbb0e1b4ed0fa.1737833376.git.geert@linux-m68k.orgSigned-off-by: Mark Brown List of files: /linux-6.15/drivers/firmware/cirrus/Kconfig

dd0b6b1f - firmware: cs_dsp: Add KUnit testing of bin file download

Thu, 12 Dec 2024 14:37:18 +0000

firmware: cs_dsp: Add KUnit testing of bin file downloadThis adds a KUnit test suite to test downloading bin files.The general technique is1. Create mock bin file content2. Tell cs_dsp to download the bin file3. Check in the emulated regmap registers that the correct values have been written to DSP memory4. Drop the regmap cache for the expected written registers and then do a regcache_sync() to check for unexpected writes to other registers.The test covers ADSP2 v1 and v2, and HALO Core DSPs. (ADSP1 is veryobsolete so isn't tested).There is a large number of test cases and parameterized variants of testsbecause of the many different addressing schemes supported by the Cirrusdevices. The DSP has 2 or 3 memory spaces: XM, YM and ZM. The DSP seesthese using its native addressing, which is word-addressed (notbyte-addressed). The host sees these through one of several registermappings (depending on the DSP type and parent codec family). Theregisters have three different addressing schemes: 16-bit registersaddressed by register number, 32-bit registers addressed by registernumber, or 32-bit registers addressed by byte (with a stride of 4). Inaddition to these multiple addressing schemes, the Halo Core DSPs have a"packed" register mapping that maps 4 DSP words into 3 registers. The binfile addresses the data blob relative to the base address of an algorithm,which has to be calculated in both DSP words (for the DSP to access) andregister addresses (for the host).This results in many different addressing schemes used in parallel, hencethe complexity of the address and size manipulation in the test cases:word addresses in DSP memory, byte offsets, word offsets, registeraddresses (either byte-addressed 32-bit or index-addressed 16-bit), andpacked register addresses.The test cases intentionally have relatively little factoring-out ofsimilar code. This makes it much easier to visually verify that a testcase is testing correctly, and what exactly it is testing. Factoring outlarge amounts of code into helper functions tends to obscure what theactual test procedure is, so increasing the chance of hidden errors wheretest cases don't actually test as intended.Signed-off-by: Richard Fitzgerald Link: https://patch.msgid.link/20241212143725.1381013-6-rf@opensource.cirrus.comSigned-off-by: Mark Brown List of files: /linux-6.15/drivers/firmware/cirrus/Kconfig

d54a3fc6 - firmware: cs_dsp: Add mock regmap for KUnit testing

Thu, 12 Dec 2024 14:37:14 +0000

firmware: cs_dsp: Add mock regmap for KUnit testingAdd a mock regmap implementation to act as a simulated DSP for KUnittesting. This is built as a utility module so that it could be used byclients of cs_dsp to create a mock "DSP" for their own testing.cs_dsp interacts with the DSP only through registers. Most of theregister space of the DSP is RAM. ADSP cores have a small set of controlregisters. HALO Core DSPs have a much larger set of control registers butonly a small subset are used.Most writes are "blind" in the sense that cs_dsp does not expect toreceive any sort of response from the DSP. So there isn't any need toemulate a "DSP", only a set of registers that can be written and readback.The idea of the mock regmap is to use the cache to accumulate writeswhich can then be tested against the values that are expected to be inthe registers.Stray writes can be detected by dropping the cache entries for alladdresses that should have been written and then issuing a regcache_sync().If this causes bus writes it means there were writes to unexpectedregisters.Signed-off-by: Richard Fitzgerald Link: https://patch.msgid.link/20241212143725.1381013-2-rf@opensource.cirrus.comSigned-off-by: Mark Brown List of files: /linux-6.15/drivers/firmware/cirrus/Kconfig

d7cfdf17 - firmware: cs_dsp: Rename KConfig symbol CS_DSP -> FW_CS_DSP

Thu, 24 Nov 2022 13:45:55 +0000

firmware: cs_dsp: Rename KConfig symbol CS_DSP -> FW_CS_DSPQualify the KConfig symbol for cs_dsp by adding a FW_ prefix so thatit is more explicit what is being referred to. This is preparation forusing the symbol to namespace the exports.Signed-off-by: Richard Fitzgerald Link: https://lore.kernel.org/r/20221124134556.3343784-2-rf@opensource.cirrus.comSigned-off-by: Mark Brown List of files: /linux-6.15/drivers/firmware/cirrus/Kconfig

f6bc909e - firmware: cs_dsp: add driver to support firmware loading on Cirrus Logic DSPs

Mon, 13 Sep 2021 16:00:57 +0000

firmware: cs_dsp: add driver to support firmware loading on Cirrus Logic DSPswm_adsp originally provided firmware loading on some audio DSP and wasimplemented as an ASoC codec driver. However, the firmware loading nowcovers a wider range of DSP cores and peripherals containing them,beyond just audio. So it needs to be available to non-audio drivers. Allthe core firmware loading support has been moved into a new drivercs_dsp, leaving only the ASoC-specific parts in wm_adsp.Signed-off-by: Simon Trimmer Signed-off-by: Charles Keepax Link: https://lore.kernel.org/r/20210913160057.103842-17-simont@opensource.cirrus.comSigned-off-by: Mark Brown List of files: /linux-6.15/drivers/firmware/cirrus/Kconfig