892bb074 - firewire: ohci: use generic power management

Mon, 20 Jul 2020 15:07:16 +0000

firewire: ohci: use generic power managementDrivers using legacy PM have to manage PCI states and device's PM statesthemselves. They also need to take care of configuration registers.With improved and powerful support of generic PM, PCI Core takes care ofabove mentioned, device-independent, jobs.This driver makes use of PCI helper functions likepci_save/restore_state(), pci_disable_device() and pci_set_power_state() todo required operations. In generic mode, they are no longer needed.Change function parameter in both .suspend() and .resume() to"struct device*" type. Use to_pci_dev() to get "struct pci_dev*" variable.Compile-tested only.Maintainer has tested the changes on non-PowerPC platform and got nofailure of the suspend/resume operations.Signed-off-by: Vaibhav Gupta Link: https://lore.kernel.org/r/20200720150715.624520-1-vaibhavgupta40@gmail.comTested-by: Takashi Sakamoto Signed-off-by; Takashi Sakamoto

b7688fcd - firewire: ohci: Replace deprecated PCI functions

Mon, 28 Oct 2024 09:44:42 +0000

firewire: ohci: Replace deprecated PCI functionspcim_iomap_regions() and pcim_iomap_table() have been deprecated incommit e354bb84a4c1 ("PCI: Deprecate pcim_iomap_table(),pcim_iomap_regions_request_all()").Replace these functions with pcim_iomap_region().Signed-off-by: Philipp Stanner Link: https://lore.kernel.org/r/20241028094440.19115-3-pstanner@redhat.comSigned-off-by: Takashi Sakamoto List of files: /linux-6.15/drivers/firewire/ohci.c

8f04019d - firewire: Correct some typos

Mon, 30 Sep 2024 02:33:44 +0000

firewire: Correct some typosFixed some confusing typos that were currently identified with codespell,the details are as follows:drivers/firewire/core-topology.c:59: containted ==> containeddrivers/firewire/core.h:83: reenable ==> re-enabledrivers/firewire/ohci.c:1387: apppends ==> appendsdrivers/firewire/ohci.c:2216: superceded ==> supersededdrivers/firewire/ohci.c:2617: litte ==> littleSigned-off-by: Shen Lichuan Link: https://lore.kernel.org/r/20240930023344.7535-1-shenlichuan@vivo.comSigned-off-by: Takashi Sakamoto List of files: /linux-6.15/drivers/firewire/ohci.c

f1cba521 - firewire: core: rename cause flag of tracepoints event

Thu, 12 Sep 2024 13:30:38 +0000

firewire: core: rename cause flag of tracepoints eventThe flag of FW_ISO_CONTEXT_COMPLETIONS_CAUSE_IRQ directly causes hardIRQrequest by 1394 OHCI hardware when the corresponding isochronous packet istransferred, however it is not so directly associated to hardIRQprocessing itself.This commit renames the flag so that it relates to interrupt parameter ofinternal packet data.Link: https://lore.kernel.org/r/20240912133038.238786-6-o-takashi@sakamocchi.jpSigned-off-by: Takashi Sakamoto List of files: /linux-6.15/drivers/firewire/ohci.c

5d567654 - firewire: core: add helper function to retire descriptors

Thu, 12 Sep 2024 13:30:36 +0000

firewire: core: add helper function to retire descriptorsBoth IR/IT contexts use the same code to retire completed descriptorsas AT context uses.This commit adds a helper function to reduce the duplicated codes.Link: https://lore.kernel.org/r/20240912133038.238786-4-o-takashi@sakamocchi.jpSigned-off-by: Takashi Sakamoto List of files: /linux-6.15/drivers/firewire/ohci.c

6ffa9bd6 - Revert "firewire: core: move workqueue handler from 1394 OHCI driver to core function"

Thu, 12 Sep 2024 13:30:35 +0000

Revert "firewire: core: move workqueue handler from 1394 OHCI driver to core function"This reverts commit 767bfb9ef27ebf760290d9f8bc303828b018c312. It appearsthat the call of ohci_flush_iso_completions() in the work item scheduledby hardIRQ of 1394 OHCI for any isochronous context changes the timing toqueue events in the view of user space application.Link: https://lore.kernel.org/r/20240912133038.238786-3-o-takashi@sakamocchi.jpSigned-off-by: Takashi Sakamoto List of files: /linux-6.15/drivers/firewire/ohci.c

c45b9a07 - Revert "firewire: core: use mutex to coordinate concurrent calls to flush completions"

Thu, 12 Sep 2024 13:30:34 +0000

Revert "firewire: core: use mutex to coordinate concurrent calls to flush completions"This reverts commit d9605d67562505e27dcc0f71af418118d3db91e5, since thiscommit is on the following reverted changes.Link: https://lore.kernel.org/r/20240912133038.238786-2-o-takashi@sakamocchi.jpSigned-off-by: Takashi Sakamoto List of files: /linux-6.15/drivers/firewire/ohci.c

f877f1d8 - firewire: core: use mutex to coordinate concurrent calls to flush completions

Mon, 09 Sep 2024 14:00:18 +0000

firewire: core: use mutex to coordinate concurrent calls to flush completionsIn current implementation, test_and_set_bit_lock() is used to mediateconcurrent calls of ohci_flush_iso_completions(). However, the ad-hocusage of atomic operations is not preferable.This commit uses mutex_trylock() as the similar operations. The corefunction is responsible for the mediation, instead of 1394 OHCI driver.Link: https://lore.kernel.org/r/20240909140018.65289-3-o-takashi@sakamocchi.jpSigned-off-by: Takashi Sakamoto List of files: /linux-6.15/drivers/firewire/ohci.c

e97fb38f - firewire: core: move workqueue handler from 1394 OHCI driver to core function

Mon, 09 Sep 2024 14:00:17 +0000

firewire: core: move workqueue handler from 1394 OHCI driver to core functionIn current implementation, the work item for isochronous context executesthe same procedure of fw_iso_context_flush_completions() internally. Thereis a space to refactor the implementation.This commit calls fw_iso_context_flush_completions() in the work item. Itobsoletes fw_iso_context_init_work(). It also obsoletes a pair ofdisable_work_sync() and enable_work() since the usage oftest_and_set_bit_lock() mediates concurrent call already.Link: https://lore.kernel.org/r/20240909140018.65289-2-o-takashi@sakamocchi.jpSigned-off-by: Takashi Sakamoto List of files: /linux-6.15/drivers/firewire/ohci.c

446216bd - firewire: core: expose kernel API to schedule work item to process isochronous context

Sun, 08 Sep 2024 04:05:48 +0000

firewire: core: expose kernel API to schedule work item to process isochronous contextIn packet-per-buffer mode for isochronous context of 1394 OHCI, softwarecan schedule hardIRQ to the buffer in which the content of isochronouspacket is processed. The actual behaviour is different between isochronousreceive (IR) and transmit (IT) contexts in respect to isochronous cycle inwhich the hardIRQ occurs.In IR context, the hardIRQ occurs when the buffer is filled actually bythe content of received packet. If there are any isochronous cycles inwhich the packet transmission is skipped, it is postponed to generatethe hardIRQ in respect to the isochronous cycle. In IT context, softwarecan schedule the content of packet every isochronous cycle includingskipping, therefore the hardIRQ occurs in the isochronous cycle to whichthe software scheduled.ALSA firewire stack uses the packet-per-buffer mode for both IR/ITcontexts. To process time stamp per packet (or per sample in some cases)steadily for media clock recovery against unexpected transmission skips,it uses an IT context to operate all of isochronous contexts by calls offw_iso_context_flush_completions() in the bottom-half of hardIRQ for theIT context.Although it looks well to handle all of isochronous contexts in a singlebottom-half context, it relatively takes longer time. In the future codeintegration (not yet), it is possible to apply parallelism method toprocess these context. In the case, it is useful to allow unit drivers toschedule work items to process these isochronous contexts.As a preparation, this commit exposesfw_iso_context_schedule_flush_completions() as a kernel API available byunit drivers. It is renamed from fw_iso_context_queue_work() since it isa counter part of fw_iso_context_flush_completions().Link: https://lore.kernel.org/r/20240908040549.75304-2-o-takashi@sakamocchi.jpSigned-off-by: Takashi Sakamoto List of files: /linux-6.15/drivers/firewire/ohci.c

5390813c - firewire: ohci: operate IT/IR events in sleepable work process instead of tasklet softIRQ

Wed, 04 Sep 2024 12:51:52 +0000

firewire: ohci: operate IT/IR events in sleepable work process instead of tasklet softIRQThis commit queues work item for IT/IR events at hardIRQ handler to operatethe corresponding isochronous context. The work item is queued to any ofworker-pools.The callback for either the implementation of unit protocol and user spaceclients is executed in sleepable work process context. The change couldresults in any errors of concurrent processing as well as sleep at atomiccontext. These errors are fixed by the following commits.Tested-by: Edmund Raile Link: https://lore.kernel.org/r/20240904125155.461886-4-o-takashi@sakamocchi.jpSigned-off-by: Takashi Sakamoto List of files: /linux-6.15/drivers/firewire/ohci.c

c6fb88a5 - firewire: core: allocate workqueue to handle isochronous contexts in card

Wed, 04 Sep 2024 12:51:50 +0000

firewire: core: allocate workqueue to handle isochronous contexts in cardThis commit adds a workqueue dedicated for isochronous context processing.The workqueue is allocated per instance of fw_card structure to satisfy thefollowing characteristics descending from 1394 OHCI specification:In 1394 OHCI specification, memory pages are reserved to each isochronouscontext dedicated to DMA transmission. It allows to operate theseper-context pages concurrently. Software can schedule hardware interruptfor several isochronous context to the same cycle, thus WQ_UNBOUND isspecified. Additionally, it is sleepable to operate the content of pages,thus WQ_BH is not used.The isochronous context delivers the packets with time stamp, thusWQ_HIGHPRI is specified for semi real-time data such as IEC 61883-1/6protocol implemented by ALSA firewire stack. The isochronous context is notused by the implementation of SCSI over IEEE1394 protocol (sbp2), thusWQ_MEM_RECLAIM is not specified.It is useful for users to adjust cpu affinity of the workqueue dependingon their work loads, thus WQ_SYS is specified to expose the attributes touser space.Tested-by: Edmund Raile Link: https://lore.kernel.org/r/20240904125155.461886-2-o-takashi@sakamocchi.jpSigned-off-by: Takashi Sakamoto List of files: /linux-6.15/drivers/firewire/ohci.c

7d35a006 - firewire: ohci: obsolete direct usage of printk_ratelimit()

Tue, 03 Sep 2024 10:15:23 +0000

firewire: ohci: obsolete direct usage of printk_ratelimit()A commit 77006a0a8282 ("ratelimit: add comment warning people offprintk_ratelimit()") has already deprecated printk_ratelimit().This commit uses alternative functions to obsolete its usage.Link: https://lore.kernel.org/r/20240903101523.317110-1-o-takashi@sakamocchi.jpSigned-off-by: Takashi Sakamoto List of files: /linux-6.15/drivers/firewire/ohci.c

cd702372 - firewire: ohci: deprecate debug parameter

Tue, 03 Sep 2024 10:14:55 +0000

firewire: ohci: deprecate debug parameterMany tracepoints events have been added to 6.10 and 6.11 kernels. They areavailable as an alternative of debug parameter in firewire-ohci module.The logging messages enabled by the parameter require some cumbersomes ina point of maintenance; e.g. the code to decode transaction frame.This commit adds deprecation text to conduct users to them..Link: https://lore.kernel.org/r/20240903101455.317067-1-o-takashi@sakamocchi.jpSigned-off-by: Takashi Sakamoto List of files: /linux-6.15/drivers/firewire/ohci.c

52f9fcbc - firewire: ohci: fix error path to detect initiated reset in TI TSB41BA3D phy

Sat, 17 Aug 2024 09:11:28 +0000

firewire: ohci: fix error path to detect initiated reset in TI TSB41BA3D phyA commit 404957c1e207 ("firewire: ohci: use guard macro to serializeaccesses to phy registers") refactored initiated_reset() helper function,while the error path was changed wrongly.This commit fixes the bug.Reported-by: Dan Carpenter Fixes: 80f3401dfeb2 ("firewire: ohci: use guard macro to serialize accesses to phy registers")Link: https://lore.kernel.org/r/20240817091128.180303-1-o-takashi@sakamocchi.jpSigned-off-by: Takashi Sakamoto List of files: /linux-6.15/drivers/firewire/ohci.c

e8b89bc1 - firewire: core/ohci: minor refactoring for computation of configuration ROM size

Wed, 14 Aug 2024 13:12:22 +0000

firewire: core/ohci: minor refactoring for computation of configuration ROM sizeThe size of space for configuration ROM is defined by IEEE 1212. The startand end offsets are available as some macros in UAPI header.This commit uses these macros to compute the size.Link: https://lore.kernel.org/r/20240814131222.69949-4-o-takashi@sakamocchi.jpSigned-off-by: Takashi Sakamoto List of files: /linux-6.15/drivers/firewire/ohci.c

d4dcb339 - firewire: ohci: remove unused wrapper macro for dev_info()

Wed, 14 Aug 2024 13:12:21 +0000

firewire: ohci: remove unused wrapper macro for dev_info()The ohci_info() macro is a thin wrapper of dev_info(), while it is neverused.Link: https://lore.kernel.org/r/20240814131222.69949-3-o-takashi@sakamocchi.jpSigned-off-by: Takashi Sakamoto List of files: /linux-6.15/drivers/firewire/ohci.c

56a4832c - firewire: ohci: use helper macro for compiler aligned attribute

Wed, 14 Aug 2024 13:12:20 +0000

firewire: ohci: use helper macro for compiler aligned attributeThe __aligned() macro has been available since v4.19 kernel by a commit815f0ddb346c ("include/linux/compiler*.h: make compiler-*.h mutuallyexclusive").This commit replaces with the macro.Link: https://lore.kernel.org/r/20240814131222.69949-2-o-takashi@sakamocchi.jpSigned-off-by: Takashi Sakamoto List of files: /linux-6.15/drivers/firewire/ohci.c

e4c8b801 - firewire: ohci: use guard macro to serialize operations for isochronous contexts

Mon, 05 Aug 2024 08:54:08 +0000

firewire: ohci: use guard macro to serialize operations for isochronous contextsThe 1394 OHCI driver uses spinlock to serialize operations forisochronous contexts.This commit uses guard macro to maintain the spinlock.Link: https://lore.kernel.org/r/20240805085408.251763-18-o-takashi@sakamocchi.jpSigned-off-by: Takashi Sakamoto List of files: /linux-6.15/drivers/firewire/ohci.c

86baade9 - firewire: ohci: use guard macro to maintain image of configuration ROM

Mon, 05 Aug 2024 08:54:07 +0000

firewire: ohci: use guard macro to maintain image of configuration ROMThe 1394 OHCI driver uses spinlock for the process to update localconfiguration ROM.This commit uses guard macro to maintain the spinlock.Link: https://lore.kernel.org/r/20240805085408.251763-17-o-takashi@sakamocchi.jpSigned-off-by: Takashi Sakamoto List of files: /linux-6.15/drivers/firewire/ohci.c

Changes in ohci.c