Changes in extcon-max3355.c

e70140ba - Get rid of 'remove_new' relic from platform driver struct

Sun, 01 Dec 2024 23:12:43 +0000

Get rid of 'remove_new' relic from platform driver structThe continual trickle of small conversion patches is grating on me, andis really not helping. Just get rid of the 'remove_new' memberfunction, which is just an alias for the plain 'remove', and had acomment to that effect: /* * .remove_new() is a relic from a prototype conversion of .remove(). * New drivers are supposed to implement .remove(). Once all drivers are * converted to not use .remove_new any more, it will be dropped. */This was just a tree-wide 'sed' script that replaced '.remove_new' with'.remove', with some care taken to turn a subsequent tab into two tabsto make things line up.I did do some minimal manual whitespace adjustment for places that usedspaces to line things up.Then I just removed the old (sic) .remove_new member function, and thisis the end result. No more unnecessary conversion noise.Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/extcon/extcon-max3355.c

ba6985ea - extcon: max3355: Convert to platform remove callback returning void

Sun, 25 Feb 2024 15:54:53 +0000

extcon: max3355: Convert to platform remove callback returning voidThe .remove() callback for a platform driver returns an int which makesmany driver authors wrongly assume it's possible to do error handling byreturning an error code. However the value returned is ignored (apartfrom emitting a warning) and this typically results in resource leaks.To improve here there is a quest to make the remove callback returnvoid. In the first step of this quest all drivers are converted to.remove_new(), which already returns void. Eventually after all driversare converted, .remove_new() will be renamed to .remove().Trivially convert this driver from always returning zero in the removecallback to the void returning variant.Link: https://lore.kernel.org/lkml/2c017ea490f721646bd472e7d427eb377e4e8423.1708876186.git.u.kleine-koenig@pengutronix.de/Signed-off-by: Uwe Kleine-König Signed-off-by: Chanwoo Choi List of files: /linux-6.15/drivers/extcon/extcon-max3355.c

3177308a - extcon: max3355: Drop unused include

Thu, 15 Jul 2021 15:26:57 +0000

extcon: max3355: Drop unused includeThis driver includes the legacy header butdoes not use it. Drop this include.Cc: Sergei Shtylyov Signed-off-by: Linus Walleij Signed-off-by: Chanwoo Choi List of files: /linux-6.15/drivers/extcon/extcon-max3355.c

ac1dc6b2 - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 233

Mon, 03 Jun 2019 05:44:49 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 233Based on 1 normalized pattern(s): this software is licensed under the terms of the gnu general public license version 2 as published by the free software foundation and may be copied distributed and modified under those termsextracted by the scancode license scanner the SPDX license identifier GPL-2.0-onlyhas been chosen to replace the boilerplate/reference in 6 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Alexios Zavras Reviewed-by: Allison Randal Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190602204653.720704315@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/extcon/extcon-max3355.c

c9c159b2 - extcon: max3355: include mod_devicetable.h

Wed, 11 Jul 2018 15:50:29 +0000

extcon: max3355: include mod_devicetable.hAnother driver turned up that is missing linux/mod_devicetable.h afterthe device IDs are split out from linux/platform_device.h:drivers/extcon/extcon-max3355.c:127:34: error: array type has incomplete element type 'struct of_device_id' static const struct of_device_id max3355_match_table[] = {Fixes: ac3167257b9f ("headers: separate linux/mod_devicetable.h from linux/platform_device.h")Signed-off-by: Arnd Bergmann Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/extcon/extcon-max3355.c

176aa360 - extcon: Split out extcon header file for consumer and provider device

Thu, 21 Sep 2017 03:11:24 +0000

extcon: Split out extcon header file for consumer and provider deviceThe extcon has two type of extcon devices as following.- 'extcon provider deivce' adds new extcon device and detect the state/properties of external connector. Also, it notifies the state/properties to the extcon consumer device.- 'extcon consumer device' gets the change state/properties from extcon provider device.Prior to that, include/linux/extcon.h contains all exported API forboth provider and consumer device driver. To clarify the meaning ofheader file and to remove the wrong use-case on consumer device,this patch separates into extcon.h and extcon-provider.h.[Description for include/linux/{extcon.h|extcon-provider.h}]- extcon.h includes the extcon API and data structure for extcon consumer device driver. This header file contains the following APIs: : Register/unregister the notifier to catch the change of extcon device : Get the extcon device instance : Get the extcon device name : Get the state of each external connector : Get the property value of each external connector : Get the property capability of each external connector- extcon-provider.h includes the extcon API and data structure for extcon provider device driver. This header file contains the following APIs: : Include 'include/linux/extcon.h' : Allocate the memory for extcon device instance : Register/unregister extcon device : Set the state of each external connector : Set the property value of each external connector : Set the property capability of each external connectorSigned-off-by: Chanwoo Choi Acked-by: Sebastian Reichel Acked-by: Chen-Yu Tsai Acked-by: Charles Keepax Acked-by: Lee Jones Acked-by: Felipe Balbi Acked-by: Yoshihiro Shimoda Acked-by: Kishon Vijay Abraham I List of files: /linux-6.15/drivers/extcon/extcon-max3355.c

8670b459 - extcon: Use the extcon_set_state_sync() instead of deprecated functions

Tue, 16 Aug 2016 06:55:34 +0000

extcon: Use the extcon_set_state_sync() instead of deprecated functionsThis patch alters the renamed extcon API to set the state of the externalconnectors instead of deprecated extcon_set_cable_state_().Because the patch[1] modifies the function name to maintain the functionnaming pattern.- extcon_set_cable_state_() -> extcon_set_state_sync()- extcon_get_cable_state_() -> extcon_get_state()[1] https://lkml.org/lkml/2016/8/4/729- extcon: Rename the extcon_set/get_state() to maintain the function naming patternSigned-off-by: Chanwoo Choi Acked-by: Charles Keepax Acked-by: Roger Quadros List of files: /linux-6.15/drivers/extcon/extcon-max3355.c

08a0a4f9 - extcon: add Maxim MAX3355 driver

Fri, 18 Dec 2015 23:17:41 +0000

extcon: add Maxim MAX3355 driverMaxim Integrated MAX3355E chip integrates a charge pump and comparators toenable a system with an integrated USB OTG dual-role transceiver tofunction as an USB OTG dual-role device. In addition to sensing/controllingVbus, the chip also passes thru the ID signal from the USB OTG connector.On some Renesas boards, this signal is just fed into the SoC thru a GPIOpin -- there's no real OTG controller, only host and gadget USB controllerssharing the same USB bus; however, we'd like to allow host or gadgetdrivers to be loaded depending on the cable type, hence the need for theMAX3355 extcon driver. The Vbus status signals are also wired to GPIOs(however, we aren't currently interested in them), the OFFVBUS# signal iscontrolled by the host controllers, there's also the SHDN# signal wired toa GPIO, it should be driven high for the normal operation.Signed-off-by: Sergei Shtylyov Acked-by: Chanwoo Choi Acked-by: Rob Herring [cw00.choi: Add the GPIOLIB dependency]Signed-off-by: Chanwoo Choi List of files: /linux-6.15/drivers/extcon/extcon-max3355.c