Changes in extcon-max14577.c

14ad7682 - extcon: extcon-max14577: Fix potential work-queue cancellation race

Tue, 08 Jun 2021 10:09:55 +0000

extcon: extcon-max14577: Fix potential work-queue cancellation raceThe extcon IRQ schedules a work item. IRQ is requested using devm whileWQ is cancelld at remove(). This mixing of devm and manual unwinding haspotential case where the WQ has been emptied (.remove() was ran) butdevm unwinding of IRQ was not yet done. It is possible the IRQ is triggeredat this point scheduling new work item to the already flushed queue.Use new devm_work_autocancel() to remove the remove() and to kill the bug.Signed-off-by: Matti Vaittinen Reviewed-by: Krzysztof Kozlowski Reviewed-by: Hans de Goede Acked-by: Chanwoo Choi Link: https://lore.kernel.org/r/ee8545f59ae3a93f0a70f640ecbd7e31cfadbcb9.1623146580.git.matti.vaittinen@fi.rohmeurope.comSigned-off-by: Hans de Goede List of files: /linux-6.15/drivers/extcon/extcon-max14577.c

4e984d83 - extcon: max14577: Return error code of extcon_dev_allocate()

Sat, 29 Aug 2020 12:43:53 +0000

extcon: max14577: Return error code of extcon_dev_allocate()devm_extcon_dev_allocate() can fail of multiple reasons. The callreturns proper error code on failure so pass it instead of fixed ENOMEM.Signed-off-by: Krzysztof Kozlowski Signed-off-by: Chanwoo Choi List of files: /linux-6.15/drivers/extcon/extcon-max14577.c

3d6954dd - extcon: max14577: Add proper dt-compatible strings

Fri, 22 May 2020 10:24:47 +0000

extcon: max14577: Add proper dt-compatible stringsAdd device tree compatible strings and create proper modalias structuresto let this driver load automatically if compiled as module, becausemax14577 MFD driver creates MFD cells with such compatible strings.Signed-off-by: Marek Szyprowski Signed-off-by: Chanwoo Choi List of files: /linux-6.15/drivers/extcon/extcon-max14577.c

5a196c29 - extcon: max14577: Avoid forcing UART path on drive probe

Thu, 08 Nov 2018 13:45:47 +0000

extcon: max14577: Avoid forcing UART path on drive probeDriver unconditionally forces UART path during probe, probably to ensurethat one can get kernel serial log as soon as possible.This approach causes some issues, especially when board is booted withnon-UART cable connected to micro-USB port. For example, when USB cable isconnected, UART TX/RX lines are unconditionally short-circuited to USBD+/D- lines. This is in turn recognized by a series of serial BREAKsignals and some random characters when USB host tries to performenumeration procedure.To solve the above issue and keep UART console operational as early aspossible, set UART path only when USB ID reports UART capable cable.Signed-off-by: Marek Szyprowski Signed-off-by: Chanwoo Choi List of files: /linux-6.15/drivers/extcon/extcon-max14577.c

1213a366 - extcon: maxim: Add SPDX license identifiers

Tue, 07 Aug 2018 16:21:22 +0000

extcon: maxim: Add SPDX license identifiersReplace GPL v2.0+ license statements with SPDX license identifiers.Signed-off-by: Krzysztof Kozlowski Signed-off-by: Chanwoo Choi List of files: /linux-6.15/drivers/extcon/extcon-max14577.c

b743483b - extcon: max14577: Delete an unnecessary variable initialisation in max14577_muic_set_path()

Sun, 22 Oct 2017 17:39:12 +0000

extcon: max14577: Delete an unnecessary variable initialisation in max14577_muic_set_path()The variable "ret" is immediately reassigned by a following statement.Thus omit the explicit initialisation at the beginning.Signed-off-by: Markus Elfring Reviewed-by: Krzysztof Kozlowski Signed-off-by: Chanwoo Choi List of files: /linux-6.15/drivers/extcon/extcon-max14577.c

176aa360 - extcon: Split out extcon header file for consumer and provider device

Thu, 21 Sep 2017 03:11:24 +0000

extcon: Split out extcon header file for consumer and provider deviceThe extcon has two type of extcon devices as following.- 'extcon provider deivce' adds new extcon device and detect the state/properties of external connector. Also, it notifies the state/properties to the extcon consumer device.- 'extcon consumer device' gets the change state/properties from extcon provider device.Prior to that, include/linux/extcon.h contains all exported API forboth provider and consumer device driver. To clarify the meaning ofheader file and to remove the wrong use-case on consumer device,this patch separates into extcon.h and extcon-provider.h.[Description for include/linux/{extcon.h|extcon-provider.h}]- extcon.h includes the extcon API and data structure for extcon consumer device driver. This header file contains the following APIs: : Register/unregister the notifier to catch the change of extcon device : Get the extcon device instance : Get the extcon device name : Get the state of each external connector : Get the property value of each external connector : Get the property capability of each external connector- extcon-provider.h includes the extcon API and data structure for extcon provider device driver. This header file contains the following APIs: : Include 'include/linux/extcon.h' : Allocate the memory for extcon device instance : Register/unregister extcon device : Set the state of each external connector : Set the property value of each external connector : Set the property capability of each external connectorSigned-off-by: Chanwoo Choi Acked-by: Sebastian Reichel Acked-by: Chen-Yu Tsai Acked-by: Charles Keepax Acked-by: Lee Jones Acked-by: Felipe Balbi Acked-by: Yoshihiro Shimoda Acked-by: Kishon Vijay Abraham I List of files: /linux-6.15/drivers/extcon/extcon-max14577.c

af57fa4d - extcon: Restructure multi-line comments to follow codingstyle

Wed, 07 Dec 2016 11:59:39 +0000

extcon: Restructure multi-line comments to follow codingstyleAligning all block comments in extcon subsystem as per linux coding style.Found using checkpatch.pl script.Signed-off-by: Srikant Ritolia Signed-off-by: Chanwoo Choi List of files: /linux-6.15/drivers/extcon/extcon-max14577.c

8670b459 - extcon: Use the extcon_set_state_sync() instead of deprecated functions

Tue, 16 Aug 2016 06:55:34 +0000

extcon: Use the extcon_set_state_sync() instead of deprecated functionsThis patch alters the renamed extcon API to set the state of the externalconnectors instead of deprecated extcon_set_cable_state_().Because the patch[1] modifies the function name to maintain the functionnaming pattern.- extcon_set_cable_state_() -> extcon_set_state_sync()- extcon_get_cable_state_() -> extcon_get_state()[1] https://lkml.org/lkml/2016/8/4/729- extcon: Rename the extcon_set/get_state() to maintain the function naming patternSigned-off-by: Chanwoo Choi Acked-by: Charles Keepax Acked-by: Roger Quadros List of files: /linux-6.15/drivers/extcon/extcon-max14577.c

e5b07e55 - extcon: max14577: Change Krzysztof Kozlowski's email to kernel.org

Wed, 17 Aug 2016 12:07:44 +0000

extcon: max14577: Change Krzysztof Kozlowski's email to kernel.orgChange my email address to kernel.org instead of Samsung one for thepurpose of any future contact. The copyrights remain untouched and areattributed to Samsung.Signed-off-by: Krzysztof Kozlowski Signed-off-by: Chanwoo Choi List of files: /linux-6.15/drivers/extcon/extcon-max14577.c

8b45b6a0 - extcon: Add the EXTCON_CHG_USB_SDP to support SDP charing port

Mon, 09 Nov 2015 01:10:15 +0000

extcon: Add the EXTCON_CHG_USB_SDP to support SDP charing portThis patch adds the new EXTCON_CHG_USB_SDP connector to support SDP (StandardDownstream Port) USB charging port. The commit 11eecf910bd8 ("extcon: Modifythe id and name of external connector") add the new EXTCON_CHG_USB_SDPconnector which support the both data transfer and usb charging at the sametime.Signed-off-by: Chanwoo Choi Reviewed-by: Krzysztof Kozlowski List of files: /linux-6.15/drivers/extcon/extcon-max14577.c

c2957563 - extcon: max14577: fix handling return value of regmap_irq_get_virq

Mon, 14 Dec 2015 10:06:02 +0000

extcon: max14577: fix handling return value of regmap_irq_get_virqThe function can return negative values, so its result shouldbe assigned to signed variable.The problem has been detected using proposed semantic patchscripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107Signed-off-by: Andrzej Hajda Reviewed-by: Krzysztof Kozlowski Signed-off-by: Chanwoo Choi List of files: /linux-6.15/drivers/extcon/extcon-max14577.c

11eecf91 - extcon: Modify the id and name of external connector

Sat, 03 Oct 2015 05:15:13 +0000

extcon: Modify the id and name of external connectorThis patch modifies the id and name of external connector with theadditional prefix to clarify both attribute and meaning of externalconnector as following:- EXTCON_CHG_* mean the charger connector.- EXTCON_JACK_* mean the jack connector.- EXTCON_DISP_* mean the display port connector.Following table show the new name of external connector with old name:--------------------------------------------------Old extcon name | New extcon name |--------------------------------------------------EXTCON_TA | EXTCON_CHG_USB_DCP |EXTCON_CHARGE_DOWNSTREAM| EXTCON_CHG_USB_CDP |EXTCON_FAST_CHARGER | EXTCON_CHG_USB_FAST |EXTCON_SLOW_CHARGER | EXTCON_CHG_USB_SLOW |--------------------------------------------------EXTCON_MICROPHONE | EXTCON_JACK_MICROPHONE |EXTCON_HEADPHONE | EXTCON_JACK_HEADPHONE |EXTCON_LINE_IN | EXTCON_JACK_LINE_IN |EXTCON_LINE_OUT | EXTCON_JACK_LINE_OUT |EXTCON_VIDEO_IN | EXTCON_JACK_VIDEO_IN |EXTCON_VIDEO_OUT | EXTCON_JACK_VIDEO_OUT |EXTCON_SPDIF_IN | EXTCON_JACK_SPDIF_IN |EXTCON_SPDIF_OUT | EXTCON_JACK_SPDIF_OUT |--------------------------------------------------EXTCON_HMDI | EXTCON_DISP_HDMI |EXTCON_MHL | EXTCON_DISP_MHL |EXTCON_DVI | EXTCON_DISP_DVI |EXTCON_VGA | EXTCON_DISP_VGA |--------------------------------------------------And, when altering the name of USB charger connector, EXTCON refers to the"Battery Charging v1.2 Spec and Adopters Agreement"[1] to use the standardname of USB charging port as following. Following name of USB charging portare already used in power_supply subsystem. We chan check it on patch[2].- EXTCON_CHG_USB_SDP /* Standard Downstream Port */- EXTCON_CHG_USB_DCP /* Dedicated Charging Port */- EXTCON_CHG_USB_CDP /* Charging Downstream Port */- EXTCON_CHG_USB_ACA /* Accessory Charger Adapter */[1] www.usb.org/developers/docs/devclass_docs/BCv1.2_070312.zip[2] commit 85efc8a18ced ("power_supply: Add types for USB chargers")Signed-off-by: Chanwoo Choi [ckeepax: For the Arizona changes]Acked-by: Charles Keepax Reviewed-by: Roger Quadros List of files: /linux-6.15/drivers/extcon/extcon-max14577.c

73b6ecdb - extcon: Redefine the unique id of supported external connectors without 'enum extcon' type

Fri, 12 Jun 2015 02:10:06 +0000

extcon: Redefine the unique id of supported external connectors without 'enum extcon' typeThis patch just redefine the unique id of supported external connectors without'enum extcon' type. Because unique id would be used on devictree file(*.dts) toindicate the specific external connectors like key number of input framework.So, I have the plan to move this definitions to following header file whichincludes the unique id of supported external connectors.- include/dt-bindings/extcon/extcon.hFixes: 2a9de9c0f08d ("extcon: Use the unique id for external connector instead of string")Signed-off-by: Chanwoo Choi Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/extcon/extcon-max14577.c

2a9de9c0 - extcon: Use the unique id for external connector instead of string

Fri, 24 Apr 2015 10:16:05 +0000

extcon: Use the unique id for external connector instead of stringThis patch uses the unique id to identify the type of external connector insteadof string name. The string name have the many potential issues. So, this patchdefines the 'extcon' enumeration which includes all supported external connectoron EXTCON subsystem. If new external connector is necessary, the unique id ofnew connector have to be added in 'extcon' enumeration. There are currentsupported external connector in 'enum extcon' as following:enum extcon { EXTCON_NONE = 0x0, /* USB external connector */ EXTCON_USB = 0x1, EXTCON_USB_HOST = 0x2, /* Charger external connector */ EXTCON_TA = 0x10, EXTCON_FAST_CHARGER = 0x11, EXTCON_SLOW_CHARGER = 0x12, EXTCON_CHARGE_DOWNSTREAM = 0x13, /* Audio and video external connector */ EXTCON_LINE_IN = 0x20, EXTCON_LINE_OUT = 0x21, EXTCON_MICROPHONE = 0x22, EXTCON_HEADPHONE = 0x23, EXTCON_HDMI = 0x30, EXTCON_MHL = 0x31, EXTCON_DVI = 0x32, EXTCON_VGA = 0x33, EXTCON_SPDIF_IN = 0x34, EXTCON_SPDIF_OUT = 0x35, EXTCON_VIDEO_IN = 0x36, EXTCON_VIDEO_OUT = 0x37, /* Miscellaneous external connector */ EXTCON_DOCK = 0x50, EXTCON_JIG = 0x51, EXTCON_MECHANICAL = 0x52, EXTCON_END,};For example in extcon-arizona.c:To use unique id removes the potential issue about handlingthe inconsistent name of external connector with string.- Previously, use the string to register the type of arizona jack connectorstatic const char *arizona_cable[] = { "Mechanical", "Microphone", "Headphone", "Line-out",};- Newly, use the unique id to register the type of arizona jack connectorstatic const enum extcon arizona_cable[] = { EXTCON_MECHANICAL, EXTCON_MICROPHONE, EXTCON_HEADPHONE, EXTCON_LINE_OUT, EXTCON_NONE,};And this patch modify the prototype of extcon_{get|set}_cable_state_() whichuses the 'enum extcon id' instead of 'cable_index'. Because although one moreextcon drivers support USB cable, each extcon driver might has the differnt'cable_index' for USB cable. All extcon drivers can use the unique id numberfor same external connector with modified extcon_{get|set}_cable_state_().- Previously, use 'cable_index' on these functions:extcon_get_cable_state_(struct extcon_dev*, int cable_index)extcon_set_cable_state_(struct extcon_dev*, int cable_index, bool state)-Newly, use 'enum extcon id' on these functions:extcon_get_cable_state_(struct extcon_dev*, enum extcon id)extcon_set_cable_state_(struct extcon_dev*, enum extcon id, bool state)Cc: Arnd Bergmann Cc: Felipe Balbi Signed-off-by: Chanwoo Choi Acked-by: Roger Quadros Acked-by: Charles Keepax Acked-by: Ramakrishna Pallala Reviewed-by: Krzysztof Kozlowski [arnd: Report the build break about drivers/usb/phy/phy-tahvo.c after using theunique id for external connector insteadf of string]Reported-by: Arnd Bergmann [dan.carpenter: Report the build warning of extcon_{set|get}_cable_state_()]Reported-by: Dan Carpenter List of files: /linux-6.15/drivers/extcon/extcon-max14577.c

d71aadda - extcon: Remove the optional name of extcon device

Mon, 04 May 2015 11:20:27 +0000

extcon: Remove the optional name of extcon deviceThis patch removes the optional name of extcon device. Instead,extcon_dev_register() set the device name as 'extcon[number]' naming pattern.- /sys/class/extcon/[hardcoded device name] -> /sys/class/extcon/extcon[number]Signed-off-by: Chanwoo Choi Acked-by: Krzysztof Kozlowski Cc: MyungJoo Ham Cc: Charles Keepax Cc: Graeme Gregory Cc: Kishon Vijay Abraham I Cc: Krzysztof Kozlowski Cc: Jaewon Kim List of files: /linux-6.15/drivers/extcon/extcon-max14577.c

41b3c015 - extcon: Unify the jig cable names on rt8973 and max14577/77693/77843

Fri, 24 Apr 2015 10:50:48 +0000

extcon: Unify the jig cable names on rt8973 and max14577/77693/77843This patch change the name of various jig cables as 'JIG' because the name ofvarious jig cables are strange and ambiguous on user-space aspect. They includethe different information of either USB and UART state. It is never importantfor user-space process. This patch unifies the name of jig cables as following:- JIG-USB-ON -->|--> JIG- JIG-USB-OFF -->|- JIG-UART-ON -->|- JIG-UART-OFF -->|Signed-off-by: Chanwoo Choi List of files: /linux-6.15/drivers/extcon/extcon-max14577.c

34825e51 - extcon: Fix the checkpatch warning

Fri, 06 Mar 2015 16:41:36 +0000

extcon: Fix the checkpatch warningThis patch fixes the checkpatch warning about coding style.Signed-off-by: Chanwoo Choi List of files: /linux-6.15/drivers/extcon/extcon-max14577.c

6ab0b117 - extcon: max14577: Fix obvious typo in company name in copyright

Wed, 12 Nov 2014 15:28:09 +0000

extcon: max14577: Fix obvious typo in company name in copyrightFix a typo in name of company in copyright comment.Signed-off-by: Krzysztof Kozlowski Signed-off-by: Chanwoo Choi List of files: /linux-6.15/drivers/extcon/extcon-max14577.c

08147bb1 - extcon: drop owner assignment from platform_drivers

Mon, 20 Oct 2014 14:20:30 +0000

extcon: drop owner assignment from platform_driversA platform_driver does not need to set an owner, it will be populated by thedriver core.Signed-off-by: Wolfram Sang List of files: /linux-6.15/drivers/extcon/extcon-max14577.c