Changes in dmatest.c

df180e65 - dmaengine: Revert "dmaengine: dmatest: Fix dmatest waiting less when interrupted"

Thu, 03 Apr 2025 16:24:19 +0000

dmaengine: Revert "dmaengine: dmatest: Fix dmatest waiting less when interrupted"Several issues with this change:* The analysis is flawed and it's unclear what problem is being fixed. There is no difference between wait_event_freezable_timeout() and wait_event_timeout() with respect to device interrupts. And of course "the interrupt notifying the finish of an operation happens during wait_event_freezable_timeout()" -- that's how it's supposed to work.* The link at the "Closes:" tag appears to be an unrelated use-after-free in idxd.* It introduces a regression: dmatest threads are meant to be freezable and this change breaks that.See discussion here:https://lore.kernel.org/dmaengine/878qpa13fe.fsf@AUSNATLYNCH.amd.com/Fixes: e87ca16e9911 ("dmaengine: dmatest: Fix dmatest waiting less when interrupted")Signed-off-by: Nathan Lynch Link: https://lore.kernel.org/r/20250403-dmaengine-dmatest-revert-waiting-less-v1-1-8227c5a3d7c8@amd.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/dma/dmatest.c

e87ca16e - dmaengine: dmatest: Fix dmatest waiting less when interrupted

Wed, 05 Mar 2025 23:00:06 +0000

dmaengine: dmatest: Fix dmatest waiting less when interruptedChange the "wait for operation finish" logic to take interrupts intoaccount.When using dmatest with idxd DMA engine, it's possible that duringlonger tests, the interrupt notifying the finish of an operationhappens during wait_event_freezable_timeout(), which causes dmatest tocleanup all the resources, some of which might still be in use.This fix ensures that the wait logic correctly handles interrupts,preventing premature cleanup of resources.Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-lkp/202502171134.8c403348-lkp@intel.comSigned-off-by: Vinicius Costa Gomes Reviewed-by: Dave Jiang Link: https://lore.kernel.org/r/20250305230007.590178-1-vinicius.gomes@intel.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/dma/dmatest.c

da080d98 - dmaengine: dmatest: Explicitly cast divisor to u32

Thu, 11 Jul 2024 13:20:01 +0000

dmaengine: dmatest: Explicitly cast divisor to u32As the comment explains, the while loop ensures that runtime fits into32 bits. Since do_div() casts the divisor to u32 anyway, explicitly castruntime to u32 to remove the following Coccinelle/coccicheck warningreported by do_div.cocci: WARNING: do_div() does a 64-by-32 division, please consider using div64_s64 insteadSigned-off-by: Thorsten Blum Link: https://lore.kernel.org/r/20240711132001.92157-1-thorsten.blum@toblux.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/dma/dmatest.c

6e2fb806 - dmaengine: add missing MODULE_DESCRIPTION() macros

Thu, 06 Jun 2024 20:00:01 +0000

dmaengine: add missing MODULE_DESCRIPTION() macrosmake allmodconfig && make W=1 C=1 reports:WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/idxd/idxd.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/ti/omap-dma.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/dmatest.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/ioat/ioatdma.oAdd the missing invocations of the MODULE_DESCRIPTION() macro.Acked-by: Dave Jiang Signed-off-by: Jeff Johnson Link: https://lore.kernel.org/r/20240606-md-drivers-dma-v2-1-0770dfdf74dd@quicinc.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/dma/dmatest.c

70f008fb - dmaengine: dmatest: prevent using swiotlb buffer with nobounce parameter

Fri, 24 Nov 2023 16:02:35 +0000

dmaengine: dmatest: prevent using swiotlb buffer with nobounce parameterSource and destination data buffers are allocated with GPF_KERNEL flag.It means that, if the DDR is more than 2GB, buffers can be allocated abovethe 32-bit addressable space. In this case, and if the dma controller isonly 32-bit compatible, swiotlb bounce buffer, located in the 32-bitaddressable space, is used and introduces a memcpy.To prevent this extra memcpy, due to swiotlb bounce buffer use becausesource or destination data buffer is allocated above the 32-bit addressablespace, force source and destination data buffers allocation with GPF_DMAinstead, when nobounce parameter is true.Signed-off-by: Amelie Delaunay Link: https://lore.kernel.org/r/20231124160235.2459326-1-amelie.delaunay@foss.st.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/dma/dmatest.c

197173db - treewide: use get_random_bytes() when possible

Wed, 05 Oct 2022 15:49:46 +0000

treewide: use get_random_bytes() when possibleThe prandom_bytes() function has been a deprecated inline wrapper aroundget_random_bytes() for several releases now, and compiles down to theexact same code. Replace the deprecated wrapper with a direct call tothe real function. This was done as a basic find and replace.Reviewed-by: Greg Kroah-Hartman Reviewed-by: Kees Cook Reviewed-by: Yury Norov Reviewed-by: Christophe Leroy # powerpcAcked-by: Jakub Kicinski Signed-off-by: Jason A. Donenfeld List of files: /linux-6.15/drivers/dma/dmatest.c

6bc7ea3c - dmaengine: dmatest: use strscpy to replace strlcpy

Wed, 25 May 2022 09:03:03 +0000

dmaengine: dmatest: use strscpy to replace strlcpyThe strlcpy should not be used because it doesn't limit the sourcelength. Preferred is strscpy.Signed-off-by: XueBing Chen Link: https://lore.kernel.org/r/12e4cf06.a35.180fa748c29.Coremail.chenxuebing@jari.cnSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/dma/dmatest.c

e8ecf73a - dmaengine: dmatest: Replace symbolic permissions by octal permissions

Wed, 08 Jun 2022 15:42:58 +0000

dmaengine: dmatest: Replace symbolic permissions by octal permissionsOctal permissions are easier to read.Signed-off-by: Geert Uytterhoeven Link: https://lore.kernel.org/r/a745b883288f95e999b71fac677bbc2daa13c22d.1654702928.git.geert+renesas@glider.beSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/dma/dmatest.c

5f89b97e - dmaengine: dmatest: Remove spaces before tabs

Wed, 08 Jun 2022 15:42:01 +0000

dmaengine: dmatest: Remove spaces before tabsScripts/checkpath.pl says "please, no space before tabs".Signed-off-by: Geert Uytterhoeven Link: https://lore.kernel.org/r/d863916120d043e3f9dd2f2670238c34f68f7d5f.1654702886.git.geert+renesas@glider.beSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/dma/dmatest.c

646728df - dmaengine: Revert "dmaengine: add verification of DMA_INTERRUPT capability for dmatest"

Mon, 06 Jun 2022 17:49:06 +0000

dmaengine: Revert "dmaengine: add verification of DMA_INTERRUPT capability for dmatest"This reverts commit a8facc7b9885 ("dmaengine: add verification ofDMA_INTERRUPT capability for dmatest") as it causes regression due tothe fact that DMA_INTERRUPT in linked to dma_prep_interrupt() sochecking that is incorrect hereSigned-off-by: Vinod Koul Link: https://lore.kernel.org/r/20220606174906.3979283-1-vkoul@kernel.orgSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/dma/dmatest.c

a8facc7b - dmaengine: add verification of DMA_INTERRUPT capability for dmatest

Tue, 12 Apr 2022 18:06:32 +0000

dmaengine: add verification of DMA_INTERRUPT capability for dmatestLooks like I forgot to add DMA_INTERRUPT cap setting to the idxd driver anddmatest is still working regardless of this mistake. Add an explicit checkof DMA_INTERRUPT capability for dmatest to make sure the DMA device being usedactually supports interrupt before the test is launched and also that thedriver is programmed correctly.Signed-off-by: Dave Jiang Link: https://lore.kernel.org/r/164978679251.2361020.5856734256126725993.stgit@djiang5-desk3.ch.intel.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/dma/dmatest.c

adc0f941 - dmaengine: dmatest: Use dmaengine_get_dma_device

Tue, 08 Dec 2020 09:04:30 +0000

dmaengine: dmatest: Use dmaengine_get_dma_deviceBy using the dmaengine_get_dma_device() to get the device fordma_api use, the dmatest can support per channel coherency if it issupported by the DMA controller.Signed-off-by: Peter Ujfalusi Link: https://lore.kernel.org/r/20201208090440.31792-11-peter.ujfalusi@ti.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/dma/dmatest.c

da75ba24 - dmaengine: dmatest: Return boolean result directly in filter()

Tue, 22 Sep 2020 11:58:47 +0000

dmaengine: dmatest: Return boolean result directly in filter()There is no need to have a conditional for boolean expression whenfunction returns bool. Drop unnecessary code and return booleanresult directly.While at it, drop unneeded casting from void *.Cc: Vladimir Murzin Signed-off-by: Andy Shevchenko Tested-by: Peter Ujfalusi Link: https://lore.kernel.org/r/20200922115847.30100-3-andriy.shevchenko@linux.intel.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/dma/dmatest.c

b28de385 - dmaengine: dmatest: Check list for emptiness before access its last entry

Tue, 22 Sep 2020 11:58:46 +0000

dmaengine: dmatest: Check list for emptiness before access its last entryAfter writing a garbage to the channel we get an Oops in dmatest_chan_set()due to access to last entry in the empty list.[ 212.670672] BUG: unable to handle page fault for address: fffffff000000020[ 212.677562] #PF: supervisor read access in kernel mode[ 212.682702] #PF: error_code(0x0000) - not-present page...[ 212.710074] RIP: 0010:dmatest_chan_set+0x149/0x2d0 [dmatest][ 212.715739] Code: e8 cc f9 ff ff 48 8b 1d 0d 55 00 00 48 83 7b 10 00 0f 84 63 01 00 00 48 c7 c7 d0 65 4d c0 e8 ee 4a f5 e1 48 89 c6 48 8b 43 10 <48> 8b 40 20 48 8b 78 58 48 85 ff 0f 84 f5 00 00 00 e8 b1 41 f5 e1Fix this by checking list for emptiness before accessing its last entry.Fixes: d53513d5dc28 ("dmaengine: dmatest: Add support for multi channel testing")Cc: Vladimir Murzin Signed-off-by: Andy Shevchenko Tested-by: Peter Ujfalusi Link: https://lore.kernel.org/r/20200922115847.30100-2-andriy.shevchenko@linux.intel.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/dma/dmatest.c

ce65d55f - dmaengine: dmatest: Prevent to run on misconfigured channel

Tue, 22 Sep 2020 11:58:45 +0000

dmaengine: dmatest: Prevent to run on misconfigured channelAndy reported that commit 6b41030fdc79 ("dmaengine: dmatest:Restore default for channel") broke his scripts for the casewhere "busy" channel is used for configuration with expectationthat run command would do nothing. Instead, behavior was(unintentionally) changed to treat such case as under-configurationand progress with defaults, i.e. run command would start a testwith default setting for channel (which would use all channels).Restore original behavior with tracking status of channel setterso we can distinguish between misconfigured and under-configuredcases in run command and act accordingly.Fixes: 6b41030fdc79 ("dmaengine: dmatest: Restore default for channel")Reported-by: Andy Shevchenko Tested-by: Andy Shevchenko Signed-off-by: Vladimir Murzin Tested-by: Peter Ujfalusi Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/r/20200922115847.30100-1-andriy.shevchenko@linux.intel.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/dma/dmatest.c

ef759e4a - dmaengine: dmatest: Print error codes as signed value

Mon, 07 Sep 2020 10:13:06 +0000

dmaengine: dmatest: Print error codes as signed valueWhen we got an error from DMA mapping API we convert a negative valueto unsigned long type and hence make user confused: result #1: 'src mapping error' with src_off=0x19a72 dst_off=0xea len=0xccf4 (18446744073709551604)Change this to print error codes as signed values.Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/r/20200907101306.61824-1-andriy.shevchenko@linux.intel.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/dma/dmatest.c

fd17d1ab - dmaengine: dmatest: stop completed threads when running without set channel

Wed, 01 Jul 2020 10:12:25 +0000

dmaengine: dmatest: stop completed threads when running without set channelThe completed threads were not cleared and consequent run would resultthreads accumulating:echo 800000 > /sys/module/dmatest/parameters/test_buf_sizeecho 2000 > /sys/module/dmatest/parameters/timeoutecho 50 > /sys/module/dmatest/parameters/iterationsecho 1 > /sys/module/dmatest/parameters/max_channelsecho "" > /sys/module/dmatest/parameters/channel[ 237.507265] dmatest: Added 1 threads using dma1chan2echo 1 > /sys/module/dmatest/parameters/run[ 244.713360] dmatest: Started 1 threads using dma1chan2[ 246.117680] dmatest: dma1chan2-copy0: summary 50 tests, 0 failures 2437.47 iops 977623 KB/s (0)echo 1 > /sys/module/dmatest/parameters/run[ 292.381471] dmatest: No channels configured, continue with any[ 292.389307] dmatest: Added 1 threads using dma1chan3[ 292.394302] dmatest: Started 1 threads using dma1chan2[ 292.399454] dmatest: Started 1 threads using dma1chan3[ 293.800835] dmatest: dma1chan3-copy0: summary 50 tests, 0 failures 2624.53 iops 975014 KB/s (0)echo 1 > /sys/module/dmatest/parameters/run[ 307.301429] dmatest: No channels configured, continue with any[ 307.309212] dmatest: Added 1 threads using dma1chan4[ 307.314197] dmatest: Started 1 threads using dma1chan2[ 307.319343] dmatest: Started 1 threads using dma1chan3[ 307.324492] dmatest: Started 1 threads using dma1chan4[ 308.730773] dmatest: dma1chan4-copy0: summary 50 tests, 0 failures 2390.28 iops 965436 KB/s (0)Fixes: 6b41030fdc79 ("dmaengine: dmatest: Restore default for channel")Reported-by: Grygorii Strashko Signed-off-by: Peter Ujfalusi Link: https://lore.kernel.org/r/20200701101225.8607-1-peter.ujfalusi@ti.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/dma/dmatest.c

47ec7f09 - dmaengine: cookie bypass for out of order completion

Wed, 13 May 2020 18:47:49 +0000

dmaengine: cookie bypass for out of order completionThe cookie tracking in dmaengine expects all submissions completed inorder. Some DMA devices like Intel DSA can complete submissions out oforder, especially if configured with a work queue sharing multiple DMAengines. Add a status DMA_OUT_OF_ORDER that tx_status can be returned forthose DMA devices. The user should use callbacks to track the completionrather than the DMA cookie. This would address the issue of dmatestcomplaining that descriptors are "busy" when the cookie count goesbackwards due to out of order completion. Add DMA_COMPLETION_NO_ORDERDMA capability to allow the driver to flag the device's ability to completeoperations out of order.Reported-by: Swathi Kovvuri Signed-off-by: Dave Jiang Tested-by: Swathi Kovvuri Link: https://lore.kernel.org/r/158939557151.20335.12404113976045569870.stgit@djiang5-desk3.ch.intel.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/dma/dmatest.c

6b41030f - dmaengine: dmatest: Restore default for channel

Wed, 29 Apr 2020 07:15:22 +0000

dmaengine: dmatest: Restore default for channelIn case of dmatest is built-in and no channel was configured testdoesn't run with:dmatest: Could not start test, no channels configuredEven though description to "channel" parameter claims that default isany.Add default channel back as it used to be rather than reject test withno channel configuration.Fixes: d53513d5dc285d9a95a534fc41c5c08af6b60eac ("dmaengine: dmatest: Add support for multi channel testing)Reported-by: Dijil Mohan Signed-off-by: Vladimir Murzin Link: https://lore.kernel.org/r/20200429071522.58148-1-vladimir.murzin@arm.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/dma/dmatest.c

aa72f1d2 - dmaengine: dmatest: Fix process hang when reading 'wait' parameter

Tue, 28 Apr 2020 11:35:18 +0000

dmaengine: dmatest: Fix process hang when reading 'wait' parameterIf we do % echo 1 > /sys/module/dmatest/parameters/run [ 115.851124] dmatest: Could not start test, no channels configured % echo dma8chan7 > /sys/module/dmatest/parameters/channel [ 127.563872] dmatest: Added 1 threads using dma8chan7 % cat /sys/module/dmatest/parameters/wait ... !!! HANG !!! ...The culprit is the commit 6138f967bccc ("dmaengine: dmatest: Use fixed point div to calculate iops")which makes threads not to run, but pending and being kicked off by writingto the 'run' node. However, it forgot to consider 'wait' routine to avoidabove mentioned case.In order to fix this, check for really running threads, i.e. with pendingand done flags unset.It's pity the culprit commit hadn't updated documentation and tested allpossible scenarios.Fixes: 6138f967bccc ("dmaengine: dmatest: Use fixed point div to calculate iops")Cc: Seraj Alijan Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/r/20200428113518.70620-1-andriy.shevchenko@linux.intel.comSigned-off-by: Vinod Koul List of files: /linux-6.15/drivers/dma/dmatest.c