Changes in Makefile

3af4e7fa - crypto: qat - reorder objects in qat_common Makefile

Tue, 11 Feb 2025 09:58:53 +0000

crypto: qat - reorder objects in qat_common MakefileThe objects in the qat_common Makefile are currently listed in a randomorder.Reorder the objects alphabetically to make it easier to find where toadd a new object.Signed-off-by: Giovanni Cabiddu Reviewed-by: Ahsan Atta Reviewed-by: Andy Shevchenko Signed-off-by: Herbert Xu List of files: /linux-6.15/drivers/crypto/intel/qat/qat_common/Makefile

a4f95a2d - crypto: qat - fix object goals in Makefiles

Tue, 11 Feb 2025 09:58:52 +0000

crypto: qat - fix object goals in MakefilesAlign with kbuild documentation by using -y instead of-objs, following the kernel convention for building modulesfrom multiple object files.Link: https://docs.kernel.org/kbuild/makefiles.html#loadable-module-goals-obj-mSigned-off-by: Giovanni Cabiddu Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Signed-off-by: Herbert Xu List of files: /linux-6.15/drivers/crypto/intel/qat/qat_common/Makefile

ceb8bf2c - module: Convert default symbol namespace to string literal

Tue, 03 Dec 2024 10:21:07 +0000

module: Convert default symbol namespace to string literalCommit cdd30ebb1b9f ("module: Convert symbol namespace to stringliteral") only converted MODULE_IMPORT_NS() and EXPORT_SYMBOL_NS(),leaving DEFAULT_SYMBOL_NAMESPACE as a macro expansion.This commit converts DEFAULT_SYMBOL_NAMESPACE in the same way to avoidannoyance for the default namespace as well.Signed-off-by: Masahiro Yamada Reviewed-by: Uwe Kleine-König Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/crypto/intel/qat/qat_common/Makefile

a5d8922a - crypto: qat - fix linking errors when PCI_IOV is disabled

Mon, 10 Jun 2024 14:37:56 +0000

crypto: qat - fix linking errors when PCI_IOV is disabledWhen CONFIG_PCI_IOV=n, the build of the QAT vfio pci variant driverfails reporting the following linking errors: ERROR: modpost: "qat_vfmig_open" [drivers/vfio/pci/qat/qat_vfio_pci.ko] undefined! ERROR: modpost: "qat_vfmig_resume" [drivers/vfio/pci/qat/qat_vfio_pci.ko] undefined! ERROR: modpost: "qat_vfmig_save_state" [drivers/vfio/pci/qat/qat_vfio_pci.ko] undefined! ERROR: modpost: "qat_vfmig_suspend" [drivers/vfio/pci/qat/qat_vfio_pci.ko] undefined! ERROR: modpost: "qat_vfmig_load_state" [drivers/vfio/pci/qat/qat_vfio_pci.ko] undefined! ERROR: modpost: "qat_vfmig_reset" [drivers/vfio/pci/qat/qat_vfio_pci.ko] undefined! ERROR: modpost: "qat_vfmig_save_setup" [drivers/vfio/pci/qat/qat_vfio_pci.ko] undefined! ERROR: modpost: "qat_vfmig_destroy" [drivers/vfio/pci/qat/qat_vfio_pci.ko] undefined! ERROR: modpost: "qat_vfmig_close" [drivers/vfio/pci/qat/qat_vfio_pci.ko] undefined! ERROR: modpost: "qat_vfmig_cleanup" [drivers/vfio/pci/qat/qat_vfio_pci.ko] undefined! WARNING: modpost: suppressed 1 unresolved symbol warnings because there were too many)Make live migration helpers provided by QAT PF driver always availableeven if CONFIG_PCI_IOV is not selected. This does not cause any sideeffect.Reported-by: Arnd Bergmann Closes: https://lore.kernel.org/lkml/20240607153406.60355e6c.alex.williamson@redhat.com/T/Fixes: bb208810b1ab ("vfio/qat: Add vfio_pci driver for Intel QAT SR-IOV VF devices")Signed-off-by: Xin Zeng Reviewed-by: Giovanni Cabiddu Reviewed-by: Kevin Tian Signed-off-by: Herbert Xu List of files: /linux-6.15/drivers/crypto/intel/qat/qat_common/Makefile

f0bbfc39 - crypto: qat - implement interface for live migration

Wed, 06 Mar 2024 13:58:54 +0000

crypto: qat - implement interface for live migrationAdd logic to implement the interface for live migration defined inqat/qat_mig_dev.h. This is specific for QAT GEN4 Virtual Functions(VFs).This introduces a migration data manager which is used to handle thedevice state during migration. The manager ensures that the device stateis stored in a format that can be restored in the destination node.The VF state is organized into a hierarchical structure that includes apreamble, a general state section, a MISC bar section and an ETR barsection. The latter contains the state of the 4 ring pairs contained ona VF. Here is a graphical representation of the state: preamble | general state section | leaf state | MISC bar state section| leaf state | ETR bar state section | bank0 state section | leaf state | bank1 state section | leaf state | bank2 state section | leaf state | bank3 state section | leaf stateIn addition to the implementation of the qat_migdev_ops interface andthe state manager framework, add a mutex in pfvf to avoid pf2vf messagesduring migration.Signed-off-by: Xin Zeng Reviewed-by: Giovanni Cabiddu Signed-off-by: Herbert Xu List of files: /linux-6.15/drivers/crypto/intel/qat/qat_common/Makefile

0fce55e5 - crypto: qat - add interface for live migration

Wed, 06 Mar 2024 13:58:53 +0000

crypto: qat - add interface for live migrationExtend the driver with a new interface to be used for VF live migration.This allows to create and destroy a qat_mig_dev object that containsa set of methods to allow to save and restore the state of QAT VF.This interface will be used by the qat-vfio-pci module.Signed-off-by: Xin Zeng Reviewed-by: Giovanni Cabiddu Signed-off-by: Herbert Xu List of files: /linux-6.15/drivers/crypto/intel/qat/qat_common/Makefile

680302d1 - crypto: qat - relocate CSR access code

Wed, 06 Mar 2024 13:58:49 +0000

crypto: qat - relocate CSR access codeAs the common hw_data files are growing and the adf_hw_csr_ops is goingto be extended with new operations, move all logic related to ring CSRsto the newly created adf_gen[2|4]_hw_csr_data.[c|h] files.This does not introduce any functional change.Signed-off-by: Giovanni Cabiddu Signed-off-by: Xin Zeng Signed-off-by: Herbert Xu List of files: /linux-6.15/drivers/crypto/intel/qat/qat_common/Makefile

e2b67859 - crypto: qat - add heartbeat error simulator

Fri, 02 Feb 2024 10:53:16 +0000

crypto: qat - add heartbeat error simulatorAdd a mechanism that allows to inject a heartbeat error for testingpurposes.A new attribute `inject_error` is added to debugfs for each QAT device.Upon a write on this attribute, the driver will inject an error on thedevice which can then be detected by the heartbeat feature.Errors are breaking the device functionality thus they require adevice reset in order to be recovered.This functionality is not compiled by default, to enable itCRYPTO_DEV_QAT_ERROR_INJECTION must be set.Signed-off-by: Damian Muszynski Reviewed-by: Giovanni Cabiddu Reviewed-by: Lucas Segarra Fernandez Reviewed-by: Ahsan Atta Reviewed-by: Markas Rapoportas Signed-off-by: Mun Chun Yep Signed-off-by: Herbert Xu List of files: /linux-6.15/drivers/crypto/intel/qat/qat_common/Makefile

69e7649f - crypto: qat - add support for device telemetry

Fri, 22 Dec 2023 10:35:07 +0000

crypto: qat - add support for device telemetryExpose through debugfs device telemetry data for QAT GEN4 devices.This allows to gather metrics about the performance and the utilizationof a device. In particular, statistics on (1) the utilization of thePCIe channel, (2) address translation, when SVA is enabled and (3) theinternal engines for crypto and data compression.If telemetry is supported by the firmware, the driver allocates a DMAregion and a circular buffer. When telemetry is enabled, through the`control` attribute in debugfs, the driver sends to the firmware, viathe admin interface, the `TL_START` command. This triggers the device toperiodically gather telemetry data from hardware registers and write itinto the DMA memory region. The device writes into the shared regionevery second.The driver, every 500ms, snapshots the DMA shared region into thecircular buffer. This is then used to compute basic metric(min/max/average) on each counter, every time the `device_data` attributeis queried.Telemetry counters are exposed through debugfs in the folder/sys/kernel/debug/qat__/telemetry.For details, refer to debugfs-driver-qat_telemetry in Documentation/ABI.This patch is based on earlier work done by Wojciech Ziemba.Signed-off-by: Lucas Segarra Fernandez Reviewed-by: Giovanni Cabiddu Reviewed-by: Damian Muszynski Signed-off-by: Herbert Xu List of files: /linux-6.15/drivers/crypto/intel/qat/qat_common/Makefile

de51d223 - crypto: qat - relocate portions of qat_4xxx code

Fri, 15 Dec 2023 10:01:46 +0000

crypto: qat - relocate portions of qat_4xxx codeMove logic that is common between QAT GEN4 accelerators to theqat_common folder. This includes addresses of CSRs, setters andconfiguration logic.When moved, functions and defines have been renamed from 4XXX to GEN4.Code specific to the device is moved to the file adf_gen4_hw_data.c.Code related to configuration is moved to the newly createdadf_gen4_config.c.This does not introduce any functional change.Signed-off-by: Jie Wang Reviewed-by: Giovanni Cabiddu Signed-off-by: Herbert Xu List of files: /linux-6.15/drivers/crypto/intel/qat/qat_common/Makefile

03c76e8e - crypto: qat - move adf_cfg_services

Fri, 20 Oct 2023 14:52:51 +0000

crypto: qat - move adf_cfg_servicesThe file adf_cfg_services.h cannot be included in header files since itinstantiates the structure adf_cfg_services. Move that structure to itsown file and export the symbol.This does not introduce any functional change.Signed-off-by: Giovanni Cabiddu Reviewed-by: Damian Muszynski Signed-off-by: Herbert Xu List of files: /linux-6.15/drivers/crypto/intel/qat/qat_common/Makefile

db74e162 - crypto: qat - add rate limiting sysfs interface

Fri, 20 Oct 2023 13:49:29 +0000

crypto: qat - add rate limiting sysfs interfaceAdd an interface for the rate limiting feature which allows to add,remove and modify a QAT SLA (Service Level Agreement).This adds a new sysfs attribute group, `qat_rl`, which can be accessedfrom /sys/bus/pci/devices/ with the followinghierarchy: |-+ qat_rl |---- id (RW) # SLA identifier |---- cir (RW) # Committed Information Rate |---- pir (RW) # Peak Information Rate |---- srv (RW) # Service to be rate limited |---- rp (RW) (HEX) # Ring pairs to be rate limited |---- cap_rem (RW) # Remaining capability for a service |---- sla_op (WO) # Allows to perform an operation on an SLAThe API works by setting the appropriate RW attributes and thenissuing a command through the `sla_op`. For example, to create an SLA, auser needs to input the necessary data into the attributes cir, pir, srvand rp and then write into `sla_op` the command `add` to execute theoperation.The API also provides `cap_rem` attribute to get information aboutthe remaining device capability within a certain service which isrequired when setting an SLA.Signed-off-by: Ciunas Bennett Reviewed-by: Giovanni Cabiddu Reviewed-by: Damian Muszynski Reviewed-by: Tero Kristo Signed-off-by: Herbert Xu List of files: /linux-6.15/drivers/crypto/intel/qat/qat_common/Makefile

d9fb8408 - crypto: qat - add rate limiting feature to qat_4xxx

Fri, 20 Oct 2023 13:49:28 +0000

crypto: qat - add rate limiting feature to qat_4xxxThe Rate Limiting (RL) feature allows to control the rate of requeststhat can be submitted on a ring pair (RP). This allows sharing a QATdevice among multiple users while ensuring a guaranteed throughput.The driver provides a mechanism that allows users to set policies, thatare programmed to the device. The device is then enforcing those policies.Configuration of RL is accomplished through entities called SLAs(Service Level Agreement). Each SLA object gets a unique identifierand defines the limitations for a single service across up to fourring pairs (RPs count allocated to a single VF).The rate is determined using two fields: * CIR (Committed Information Rate), i.e., the guaranteed rate. * PIR (Peak Information Rate), i.e., the maximum rate achievable when the device has available resources.The rate values are expressed in permille scale i.e. 0-1000.Ring pair selection is achieved by providing a 64-bit mask, whereeach bit corresponds to one of the ring pairs.This adds an interface and logic that allow to add, update, retrieveand remove an SLA.Signed-off-by: Damian Muszynski Reviewed-by: Giovanni Cabiddu Reviewed-by: Tero Kristo Signed-off-by: Herbert Xu List of files: /linux-6.15/drivers/crypto/intel/qat/qat_common/Makefile

532d7f6b - crypto: qat - add error counters

Fri, 20 Oct 2023 10:32:52 +0000

crypto: qat - add error countersIntroduce ras counters interface for counting QAT specific deviceerrors and expose them through the newly created qat_ras sysfsgroup attribute.This adds the following attributes:- errors_correctable: number of correctable errors- errors_nonfatal: number of uncorrectable non fatal errors- errors_fatal: number of uncorrectable fatal errors- reset_error_counters: resets all countersThese counters are initialized during device bring up and clearedduring device shutdown and are applicable only to QAT GEN4 devices.Signed-off-by: Shashank Gupta Reviewed-by: Giovanni Cabiddu Reviewed-by: Tero Kristo Signed-off-by: Herbert Xu List of files: /linux-6.15/drivers/crypto/intel/qat/qat_common/Makefile

93b2f7de - crypto: qat - add infrastructure for error reporting

Fri, 20 Oct 2023 10:32:45 +0000

crypto: qat - add infrastructure for error reportingAdd infrastructure for enabling, disabling and reporting errors in the QATdriver. This adds a new structure, adf_ras_ops, to adf_hw_device_data thatcontains the following methods: - enable_ras_errors(): allows to enable RAS errors at device initialization. - disable_ras_errors(): allows to disable RAS errors at device shutdown. - handle_interrupt(): allows to detect if there is an error and report if a reset is required. This is executed immediately after the error is reported, in the context of an ISR.An initial, empty, implementation of the methods above is providedfor QAT GEN4.Signed-off-by: Shashank Gupta Reviewed-by: Giovanni Cabiddu Reviewed-by: Tero Kristo Signed-off-by: Herbert Xu List of files: /linux-6.15/drivers/crypto/intel/qat/qat_common/Makefile

d807f024 - crypto: qat - add cnv_errors debugfs file

Wed, 04 Oct 2023 10:36:42 +0000

crypto: qat - add cnv_errors debugfs fileThe Compress and Verify (CnV) feature check and ensures data integrityin the compression operation. The implementation of CnV keeps a recordof the CnV errors that have occurred since the driver was loaded.Expose CnV error stats by providing the "cnv_errors" file underdebugfs. This includes the number of errors detected up to now andthe type of the last error. The error count is provided on a perAcceleration Engine basis and it is reset every time the driver is loaded.Signed-off-by: Lucas Segarra Fernandez Reviewed-by: Giovanni Cabiddu Signed-off-by: Herbert Xu List of files: /linux-6.15/drivers/crypto/intel/qat/qat_common/Makefile

e0792316 - crypto: qat - add pm_status debugfs file

Wed, 04 Oct 2023 10:09:20 +0000

crypto: qat - add pm_status debugfs fileQAT devices implement a mechanism that allows them to go autonomouslyto a low power state depending on the load.Expose power management info by providing the "pm_status" file underdebugfs. This includes PM state, PM event log, PM event counters, PM HWCSRs, per-resource type constrain counters and per-domain power gatingstatus specific to the QAT device.This information is retrieved from (1) the FW by means ofICP_QAT_FW_PM_INFO command, (2) CSRs and (3) counters collected by thedevice driver.In addition, add logic to keep track and report power management eventinterrupts and acks/nacks sent to FW to allow/prevent state transitions.Signed-off-by: Lucas Segarra Fernandez Reviewed-by: Giovanni Cabiddu Signed-off-by: Herbert Xu List of files: /linux-6.15/drivers/crypto/intel/qat/qat_common/Makefile

4999999e - crypto: qat - add namespace to driver

Mon, 02 Oct 2023 08:51:09 +0000

crypto: qat - add namespace to driverCreate CRYPTO_QAT namespace for symbols exported by the qat_commonmodule and import those in the QAT drivers. It will reduce the globalnamespace crowdedness and potential misuse or the API.This does not introduce any functional change.Suggested-by: Andy Shevchenko Signed-off-by: Giovanni Cabiddu Reviewed-by: Lucas Segarra Fernandez Reviewed-by: Andy Shevchenko Signed-off-by: Herbert Xu List of files: /linux-6.15/drivers/crypto/intel/qat/qat_common/Makefile

359b84f8 - crypto: qat - add heartbeat feature

Fri, 30 Jun 2023 17:03:57 +0000

crypto: qat - add heartbeat featureUnder some circumstances, firmware in the QAT devices could becomeunresponsive. The Heartbeat feature provides a mechanism to detectunresponsive devices.The QAT FW periodically writes to memory a set of counters that allowto detect the liveness of a device. This patch adds logic to enablethe reporting of those counters, analyze them and report if a deviceis alive or not.In particular this adds (1) heartbeat enabling, reading and detection logic (2) reporting of heartbeat status and configuration via debugfs (3) documentation for the newly created sysfs entries (4) configuration of FW settings related to heartbeat, e.g. tick period (5) logic to convert time in ms (provided by the user) to clock ticksThis patch introduces a new folder in debugfs called heartbeat with thefollowing attributes: - status - queries_sent - queries_failed - configAll attributes except config are reading only. In particular: - `status` file returns 0 when device is operational and -1 otherwise. - `queries_sent` returns the total number of heartbeat queries sent. - `queries_failed` returns the total number of heartbeat queries failed. - `config` allows to adjust the frequency at which the firmware writes counters to memory. This period is given in milliseconds and it is fixed for GEN4 devices.Signed-off-by: Damian Muszynski Reviewed-by: Giovanni Cabiddu Reviewed-by: Andy Shevchenko Signed-off-by: Herbert Xu List of files: /linux-6.15/drivers/crypto/intel/qat/qat_common/Makefile

e2980ba5 - crypto: qat - add measure clock frequency

Fri, 30 Jun 2023 17:03:56 +0000

crypto: qat - add measure clock frequencyThe QAT hardware does not expose a mechanism to report its clockfrequency. This is required to implement the Heartbeat feature.Add a clock measuring algorithm that estimates the frequency bycomparing the internal timestamp counter incremented by the firmwarewith the time measured by the kernel.The frequency value is only used internally and not exposed tothe user.Signed-off-by: Damian Muszynski Reviewed-by: Giovanni Cabiddu Reviewed-by: Andy Shevchenko Signed-off-by: Herbert Xu List of files: /linux-6.15/drivers/crypto/intel/qat/qat_common/Makefile