Changes in clk-devres.c

51e32e89 - clk: Provide devm_clk_bulk_get_all_enabled() helper

Sat, 19 Oct 2024 11:16:00 +0000

clk: Provide devm_clk_bulk_get_all_enabled() helperCommit 265b07df758a ("clk: Provide managed helper to get and enable bulkclocks") added devm_clk_bulk_get_all_enable() function, but missed toreturn the number of clocks stored in the clk_bulk_data table referencedby the clks argument. Without knowing the number, it's not possible toiterate these clocks when needed, hence the argument is useless andcould have been simply removed.Introduce devm_clk_bulk_get_all_enabled() variant, which is consistentwith devm_clk_bulk_get_all() in terms of the returned value: > 0 if one or more clocks have been stored = 0 if there are no clocks < 0 if an error occurredMoreover, the naming is consistent with devm_clk_get_enabled(), i.e. usethe past form of 'enable'.To reduce code duplication and improve patch readability, makedevm_clk_bulk_get_all_enable() use the new helper, as suggested byStephen Boyd.Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Manivannan Sadhasivam Signed-off-by: Cristian Ciocaltea Link: https://lore.kernel.org/r/20241019-clk_bulk_ena_fix-v4-1-57f108f64e70@collabora.comSigned-off-by: Stephen Boyd List of files: /linux-6.15/drivers/clk/clk-devres.c

9934a1bd - clk: provide devm_clk_get_optional_enabled_with_rate()

Mon, 05 Aug 2024 08:57:31 +0000

clk: provide devm_clk_get_optional_enabled_with_rate()There are clock users in the kernel that can't usedevm_clk_get_optional_enabled() as they need to set rate after gettingthe clock and before enabling it. Provide a managed helper that wrapsthese operations in the correct order.Signed-off-by: Bartosz Golaszewski Link: https://lore.kernel.org/r/20240805-clk-new-helper-v2-1-e5fdd1e1d729@linaro.orgSigned-off-by: Stephen Boyd List of files: /linux-6.15/drivers/clk/clk-devres.c

265b07df - clk: Provide managed helper to get and enable bulk clocks

Tue, 20 Feb 2024 08:40:45 +0000

clk: Provide managed helper to get and enable bulk clocksProvide a managed devm_clk_bulk* wrapper to get and enable allbulk clocks in order to simplify drivers that keeps all clocksenabled for the time of driver operation.Suggested-by: Marek Szyprowski Reviewed-by: Alim Akhtar Reviewed-by: Manivannan Sadhasivam Signed-off-by: Shradha Todi Link: https://lore.kernel.org/r/20240220084046.23786-2-shradha.t@samsung.comSigned-off-by: Stephen Boyd List of files: /linux-6.15/drivers/clk/clk-devres.c

66fbfb35 - clk: Fix slab-out-of-bounds error in devm_clk_release()

Sat, 05 Aug 2023 08:48:47 +0000

clk: Fix slab-out-of-bounds error in devm_clk_release()Problem can be reproduced by unloading snd_soc_simple_card, because indevm_get_clk_from_child() devres data is allocated as `struct clk`, butdevm_clk_release() expects devres data to be `struct devm_clk_state`.KASAN report: ================================================================== BUG: KASAN: slab-out-of-bounds in devm_clk_release+0x20/0x54 Read of size 8 at addr ffffff800ee09688 by task (udev-worker)/287 Call trace: dump_backtrace+0xe8/0x11c show_stack+0x1c/0x30 dump_stack_lvl+0x60/0x78 print_report+0x150/0x450 kasan_report+0xa8/0xf0 __asan_load8+0x78/0xa0 devm_clk_release+0x20/0x54 release_nodes+0x84/0x120 devres_release_all+0x144/0x210 device_unbind_cleanup+0x1c/0xac really_probe+0x2f0/0x5b0 __driver_probe_device+0xc0/0x1f0 driver_probe_device+0x68/0x120 __driver_attach+0x140/0x294 bus_for_each_dev+0xec/0x160 driver_attach+0x38/0x44 bus_add_driver+0x24c/0x300 driver_register+0xf0/0x210 __platform_driver_register+0x48/0x54 asoc_simple_card_init+0x24/0x1000 [snd_soc_simple_card] do_one_initcall+0xac/0x340 do_init_module+0xd0/0x300 load_module+0x2ba4/0x3100 __do_sys_init_module+0x2c8/0x300 __arm64_sys_init_module+0x48/0x5c invoke_syscall+0x64/0x190 el0_svc_common.constprop.0+0x124/0x154 do_el0_svc+0x44/0xdc el0_svc+0x14/0x50 el0t_64_sync_handler+0xec/0x11c el0t_64_sync+0x14c/0x150 Allocated by task 287: kasan_save_stack+0x38/0x60 kasan_set_track+0x28/0x40 kasan_save_alloc_info+0x20/0x30 __kasan_kmalloc+0xac/0xb0 __kmalloc_node_track_caller+0x6c/0x1c4 __devres_alloc_node+0x44/0xb4 devm_get_clk_from_child+0x44/0xa0 asoc_simple_parse_clk+0x1b8/0x1dc [snd_soc_simple_card_utils] simple_parse_node.isra.0+0x1ec/0x230 [snd_soc_simple_card] simple_dai_link_of+0x1bc/0x334 [snd_soc_simple_card] __simple_for_each_link+0x2ec/0x320 [snd_soc_simple_card] asoc_simple_probe+0x468/0x4dc [snd_soc_simple_card] platform_probe+0x90/0xf0 really_probe+0x118/0x5b0 __driver_probe_device+0xc0/0x1f0 driver_probe_device+0x68/0x120 __driver_attach+0x140/0x294 bus_for_each_dev+0xec/0x160 driver_attach+0x38/0x44 bus_add_driver+0x24c/0x300 driver_register+0xf0/0x210 __platform_driver_register+0x48/0x54 asoc_simple_card_init+0x24/0x1000 [snd_soc_simple_card] do_one_initcall+0xac/0x340 do_init_module+0xd0/0x300 load_module+0x2ba4/0x3100 __do_sys_init_module+0x2c8/0x300 __arm64_sys_init_module+0x48/0x5c invoke_syscall+0x64/0x190 el0_svc_common.constprop.0+0x124/0x154 do_el0_svc+0x44/0xdc el0_svc+0x14/0x50 el0t_64_sync_handler+0xec/0x11c el0t_64_sync+0x14c/0x150 The buggy address belongs to the object at ffffff800ee09600 which belongs to the cache kmalloc-256 of size 256 The buggy address is located 136 bytes inside of 256-byte region [ffffff800ee09600, ffffff800ee09700) The buggy address belongs to the physical page: page:000000002d97303b refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x4ee08 head:000000002d97303b order:1 compound_mapcount:0 compound_pincount:0 flags: 0x10200(slab|head|zone=0) raw: 0000000000010200 0000000000000000 dead000000000122 ffffff8002c02480 raw: 0000000000000000 0000000080100010 00000001ffffffff 0000000000000000 page dumped because: kasan: bad access detected Memory state around the buggy address: ffffff800ee09580: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc ffffff800ee09600: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 >ffffff800ee09680: 00 fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc ^ ffffff800ee09700: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc ffffff800ee09780: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc ==================================================================Fixes: abae8e57e49a ("clk: generalize devm_clk_get() a bit")Signed-off-by: Andrey Skvortsov Link: https://lore.kernel.org/r/20230805084847.3110586-1-andrej.skvortzov@gmail.comSigned-off-by: Stephen Boyd List of files: /linux-6.15/drivers/clk/clk-devres.c

8b3d743f - clk: Fix pointer casting to prevent oops in devm_clk_release()

Mon, 20 Jun 2022 17:18:15 +0000

clk: Fix pointer casting to prevent oops in devm_clk_release()The release function is called with a pointer to the memory returned bydevres_alloc(). I was confused about that by the code before thegeneralization that used a struct clk **ptr.Reported-by: Marek Szyprowski Fixes: abae8e57e49a ("clk: generalize devm_clk_get() a bit")Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20220620171815.114212-1-u.kleine-koenig@pengutronix.deTested-by: Marek Szyprowski Tested-by: Linux Kernel Functional Testing Signed-off-by: Stephen Boyd List of files: /linux-6.15/drivers/clk/clk-devres.c

7ef9651e - clk: Provide new devm_clk helpers for prepared and enabled clocks

Fri, 20 May 2022 07:57:36 +0000

clk: Provide new devm_clk helpers for prepared and enabled clocksWhen a driver keeps a clock prepared (or enabled) during the wholelifetime of the driver, these helpers allow to simplify the drivers.Reviewed-by: Jonathan Cameron Reviewed-by: Alexandru Ardelean Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20220520075737.758761-4-u.kleine-koenig@pengutronix.deSigned-off-by: Stephen Boyd List of files: /linux-6.15/drivers/clk/clk-devres.c

abae8e57 - clk: generalize devm_clk_get() a bit

Fri, 20 May 2022 07:57:35 +0000

clk: generalize devm_clk_get() a bitAllow to add an exit hook to devm managed clocks. Also useclk_get_optional() in devm_clk_get_optional instead of open coding it.The generalisation will be used in the next commit to add some moredevm_clk helpers.Reviewed-by: Jonathan Cameron Reviewed-by: Alexandru Ardelean Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20220520075737.758761-3-u.kleine-koenig@pengutronix.deSigned-off-by: Stephen Boyd List of files: /linux-6.15/drivers/clk/clk-devres.c

f828b0bc - clk: fix leak on devm_clk_bulk_get_all() unwind

Sat, 31 Jul 2021 02:59:50 +0000

clk: fix leak on devm_clk_bulk_get_all() unwindclk_bulk_get_all() allocates an array of struct clk_bulk data for us(unlike clk_bulk_get()), so we need to free it. Let's use theclk_bulk_put_all() helper.kmemleak complains, on an RK3399 Gru/Kevin system:unreferenced object 0xffffff80045def00 (size 128): comm "swapper/0", pid 1, jiffies 4294667682 (age 86.394s) hex dump (first 32 bytes): 44 32 60 fe fe ff ff ff 00 00 00 00 00 00 00 00 D2`............. 48 32 60 fe fe ff ff ff 00 00 00 00 00 00 00 00 H2`............. backtrace: [<00000000742860d6>] __kmalloc+0x22c/0x39c [<00000000b0493f2c>] clk_bulk_get_all+0x64/0x188 [<00000000325f5900>] devm_clk_bulk_get_all+0x58/0xa8 [<00000000175b9bc5>] dwc3_probe+0x8ac/0xb5c [<000000009169e2f9>] platform_drv_probe+0x9c/0xbc [<000000005c51e2ee>] really_probe+0x13c/0x378 [<00000000c47b1f24>] driver_probe_device+0x84/0xc0 [<00000000f870fcfb>] __device_attach_driver+0x94/0xb0 [<000000004d1b92ae>] bus_for_each_drv+0x8c/0xd8 [<00000000481d60c3>] __device_attach+0xc4/0x150 [<00000000a163bd36>] device_initial_probe+0x1c/0x28 [<00000000accb6bad>] bus_probe_device+0x3c/0x9c [<000000001a199f89>] device_add+0x218/0x3cc [<000000001bd84952>] of_device_add+0x40/0x50 [<000000009c658c29>] of_platform_device_create_pdata+0xac/0x100 [<0000000021c69ba4>] of_platform_bus_create+0x190/0x224Fixes: f08c2e2865f6 ("clk: add managed version of clk_bulk_get_all")Cc: Dong Aisheng Cc: stable@vger.kernel.orgSigned-off-by: Brian Norris Link: https://lore.kernel.org/r/20210731025950.2238582-1-briannorris@chromium.orgSigned-off-by: Stephen Boyd List of files: /linux-6.15/drivers/clk/clk-devres.c

9bd5ef0b - clk: Add devm_clk_bulk_get_optional() function

Wed, 19 Jun 2019 09:39:26 +0000

clk: Add devm_clk_bulk_get_optional() functionAdd managed version of the clk_bulk_get_optional() helper function.Signed-off-by: Sylwester Nawrocki [sboyd@kernel.org: Mark __devm_clk_bulk_get() static]Signed-off-by: Stephen Boyd List of files: /linux-6.15/drivers/clk/clk-devres.c

60b8f0dd - clk: Add (devm_)clk_get_optional() functions

Mon, 03 Dec 2018 11:13:09 +0000

clk: Add (devm_)clk_get_optional() functionsThis adds clk_get_optional() and devm_clk_get_optional() functions to getoptional clocks.They behave the same as (devm_)clk_get() except where there is no clockproducer. In this case, instead of returning -ENOENT, the functionreturns NULL. This makes error checking simpler and allowsclk_prepare_enable, etc to be called on the returned referencewithout additional checks.Signed-off-by: Phil Edworthy Reviewed-by: Andy Shevchenko Cc: Russell King [sboyd@kernel.org: Document in devres.txt]Signed-off-by: Stephen Boyd List of files: /linux-6.15/drivers/clk/clk-devres.c

ebafb63d - clk: Tag clk core files with SPDX

Tue, 11 Dec 2018 17:43:03 +0000

clk: Tag clk core files with SPDXThese are all GPL-2.0 files per the existing license text. Replace theboiler plate with the tag.Signed-off-by: Stephen Boyd List of files: /linux-6.15/drivers/clk/clk-devres.c

f08c2e28 - clk: add managed version of clk_bulk_get_all

Fri, 31 Aug 2018 04:45:55 +0000

clk: add managed version of clk_bulk_get_allThis patch introduces the managed version of clk_bulk_get_all.Cc: Michael Turquette Cc: Stephen Boyd Tested-by: Thor Thayer Signed-off-by: Dong Aisheng Signed-off-by: Stephen Boyd List of files: /linux-6.15/drivers/clk/clk-devres.c

618aee02 - clk: add managed version of clk_bulk_get

Fri, 19 May 2017 13:49:05 +0000

clk: add managed version of clk_bulk_getThis patch introduces the managed version of clk_bulk_get.Cc: Michael Turquette Cc: Stephen Boyd Cc: Russell King Cc: Geert Uytterhoeven Cc: "Rafael J. Wysocki" Cc: Viresh Kumar Cc: Mark Brown Cc: Shawn Guo Cc: Fabio Estevam Cc: Sascha Hauer Cc: Anson Huang Cc: Robin Gong Cc: Bai Ping Cc: Leonard Crestez Cc: Octavian Purdila Signed-off-by: Dong Aisheng Signed-off-by: Stephen Boyd List of files: /linux-6.15/drivers/clk/clk-devres.c

71a2f115 - clk: add devm_get_clk_from_child() API

Mon, 05 Dec 2016 05:23:20 +0000

clk: add devm_get_clk_from_child() APISome driver is using this type of DT bindings for clock (more detail,see ${LINUX}/Documentation/devicetree/bindings/sound/simple-card.txt). sound_soc { ... cpu { clocks = <&xxx>; ... }; codec { clocks = <&xxx>; ... }; };Current driver in this case uses of_clk_get() for each node, but thereis no devm_of_clk_get() today.OTOH, the problem of having devm_of_clk_get() is that it encourages theuse of of_clk_get() when clk_get() is more desirable.Thus, this patch adds new devm_get_clk_from_chile() which explicitlyreads as get a clock from a child node of this device.By this function, we can also use this type of DT bindings sound_soc { clocks = <&xxx>, <&xxx>; clock-names = "cpu", "codec"; clock-ranges; ... cpu { ... }; codec { ... }; };Signed-off-by: Kuninori Morimoto [sboyd@codeurora.org: Rename subject to clk + add API]Signed-off-by: Stephen Boyd List of files: /linux-6.15/drivers/clk/clk-devres.c

20332ff3 - ARM: 7537/1: clk: Fix release in devm_clk_put()

Wed, 19 Sep 2012 11:43:21 +0000

ARM: 7537/1: clk: Fix release in devm_clk_put()Surprisingly devres_destroy() doesn't call the destructor for theresource it is destroying, use the newly added devres_release() insteadto fix this.Signed-off-by: Mark Brown Signed-off-by: Russell King List of files: /linux-6.15/drivers/clk/clk-devres.c

8ef997b6 - ARM: 7534/1: clk: Make the managed clk functions generically available

Tue, 11 Sep 2012 18:56:23 +0000

ARM: 7534/1: clk: Make the managed clk functions generically availableThe managed clk functions are currently only available when the generic clklookup framework is build. But the managed clk functions are merely wrappersaround clk_get and clk_put and do not depend on any specifics of the genericlookup functions and there are still quite a few custom implementations of theclk API. So make the managed functions available whenever the clk API isimplemented.The patch also removes the custom implementation of devm_clk_get for thecoldfire platform.Signed-off-by: Lars-Peter Clausen Acked-by: Greg Ungerer Signed-off-by: Russell King List of files: /linux-6.15/drivers/clk/clk-devres.c