Changes in ti-sysc.c

1fac9f8b - bus: Switch back to struct platform_driver::remove()

Tue, 12 Nov 2024 08:35:19 +0000

bus: Switch back to struct platform_driver::remove()After commit 0edb555a65d1 ("platform: Make platform_driver::remove()return void") .remove() is (again) the right callback to implement forplatform drivers.Convert all platform drivers below drivers/bus to use .remove(), withthe eventual goal to drop struct platform_driver::remove_new(). As.remove() and .remove_new() have the same prototypes, conversion is doneby just changing the structure member name in the driver initializer.Signed-off-by: Uwe Kleine-König Signed-off-by: Arnd Bergmann List of files: /linux-6.15/drivers/bus/ti-sysc.c

a80a3d92 - bus: ti-sysc: Remove excess struct member 'disable_on_idle' description

Mon, 05 Aug 2024 10:11:18 +0000

bus: ti-sysc: Remove excess struct member 'disable_on_idle' descriptionWhen built with W=1, the driver throws the following warning:../drivers/bus/ti-sysc.c:169: warning: Excess struct member'disable_on_idle' description in 'sysc'Fix it by removing the excess description.Signed-off-by: Dhruva Gole Reviewed-by: Roger Quadros Link: https://lore.kernel.org/r/20240805101118.427133-1-d-gole@ti.comSigned-off-by: Kevin Hilman List of files: /linux-6.15/drivers/bus/ti-sysc.c

0070dc29 - bus: ti-sysc: Use of_property_present()

Wed, 31 Jul 2024 19:12:39 +0000

bus: ti-sysc: Use of_property_present()Use of_property_present() to test for property presence rather thanof_get_property(). This is part of a larger effort to remove callersof of_get_property() and similar functions. of_get_property() leaksthe DT property data pointer which is a problem for dynamicallyallocated nodes which may be freed.The code was also incorrectly assigning the return value to a 'structproperty' pointer. It didn't matter as "prop" was never dereferenced.Signed-off-by: Rob Herring (Arm) Reviewed-by: Roger Quadros Link: https://lore.kernel.org/r/20240731191312.1710417-1-robh@kernel.orgSigned-off-by: Kevin Hilman List of files: /linux-6.15/drivers/bus/ti-sysc.c

9722c3b6 - of: remove internal arguments from of_property_for_each_u32()

Wed, 24 Jul 2024 16:33:06 +0000

of: remove internal arguments from of_property_for_each_u32()The of_property_for_each_u32() macro needs five parameters, two of whichare primarily meant as internal variables for the macro itself (in thefor() clause). Yet these two parameters are used by a few drivers, and thiscan be considered misuse or at least bad practice.Now that the kernel uses C11 to build, these two parameters can be avoidedby declaring them internally, thus changing this pattern: struct property *prop; const __be32 *p; u32 val; of_property_for_each_u32(np, "xyz", prop, p, val) { ... }to this: u32 val; of_property_for_each_u32(np, "xyz", val) { ... }However two variables cannot be declared in the for clause even with C11,so declare one struct that contain the two variables we actually need. Asthe variables inside this struct are not meant to be used by users of thismacro, give the struct instance the noticeable name "_it" so it is visibleduring code reviews, helping to avoid new code to use it directly.Most usages are trivially converted as they do not use those twoparameters, as expected. The non-trivial cases are: - drivers/clk/clk.c, of_clk_get_parent_name(): easily doable anyway - drivers/clk/clk-si5351.c, si5351_dt_parse(): this is more complex as the checks had to be replicated in a different way, making code more verbose and somewhat uglier, but I refrained from a full rework to keep as much of the original code untouched having no hardware to test my changesAll the changes have been build tested. The few for which I have thehardware have been runtime-tested too.Reviewed-by: Andre Przywara # drivers/clk/sunxi/clk-simple-gates.c, drivers/clk/sunxi/clk-sun8i-bus-gates.cAcked-by: Bartosz Golaszewski # drivers/gpio/gpio-brcmstb.cAcked-by: Nicolas Ferre # drivers/irqchip/irq-atmel-aic-common.cAcked-by: Jonathan Cameron # drivers/iio/adc/ti_am335x_adc.cAcked-by: Uwe Kleine-König # drivers/pwm/pwm-samsung.cAcked-by: Richard Leitner # drivers/usb/misc/usb251xb.cAcked-by: Mark Brown # sound/soc/codecs/arizona.cReviewed-by: Richard Fitzgerald # sound/soc/codecs/arizona.cAcked-by: Michael Ellerman # arch/powerpc/sysdev/xive/spapr.cAcked-by: Stephen Boyd # clkSigned-off-by: Luca Ceresoli Acked-by: Lee Jones Link: https://lore.kernel.org/r/20240724-of_property_for_each_u32-v3-1-bea82ce429e2@bootlin.comSigned-off-by: Rob Herring (Arm) List of files: /linux-6.15/drivers/bus/ti-sysc.c

4bcc2e91 - bus: ti-sysc: Drop legacy idle quirk handling