Changes in btbcm.c

b88655bc - Bluetooth: btbcm: Fix NULL deref in btbcm_get_board_name()

Fri, 27 Dec 2024 09:20:46 +0000

Bluetooth: btbcm: Fix NULL deref in btbcm_get_board_name()devm_kstrdup() can return a NULL pointer on failure,but thisreturned value in btbcm_get_board_name() is not checked.Add NULL check in btbcm_get_board_name(), to handle kernel NULLpointer dereference error.Fixes: f9183eaad915 ("Bluetooth: btbcm: Use devm_kstrdup()")Signed-off-by: Charles Han Signed-off-by: Luiz Augusto von Dentz List of files: /linux-6.15/drivers/bluetooth/btbcm.c

e42eec0f - Bluetooth: btbcm: fix missing of_node_put() in btbcm_get_board_name()

Thu, 31 Oct 2024 12:11:23 +0000

Bluetooth: btbcm: fix missing of_node_put() in btbcm_get_board_name()of_find_node_by_path() returns a pointer to a device_node with itsrefcount incremented, and a call to of_node_put() is required todecrement the refcount again and avoid leaking the resource.If 'of_property_read_string_index(root, "compatible", 0, &tmp)' fails,the function returns without calling of_node_put(root) before doing so.The automatic cleanup attribute can be used by means of the __free()macro to automatically call of_node_put() when the variable goes out ofscope, fixing the issue and also accounting for new error paths.Fixes: 63fac3343b99 ("Bluetooth: btbcm: Support per-board firmware variants")Signed-off-by: Javier Carrasco Signed-off-by: Luiz Augusto von Dentz List of files: /linux-6.15/drivers/bluetooth/btbcm.c

5f60d5f6 - move asm/unaligned.h to linux/unaligned.h

Tue, 01 Oct 2024 19:35:57 +0000

move asm/unaligned.h to linux/unaligned.hasm/unaligned.h is always an include of asm-generic/unaligned.h;might as well move that thing to linux/unaligned.h and includethat - there's nothing arch-specific in that header.auto-generated by the following:for i in `git grep -l -w asm/unaligned.h`; do sed -i -e "s/asm\/unaligned.h/linux\/unaligned.h/" $idonefor i in `git grep -l -w asm-generic/unaligned.h`; do sed -i -e "s/asm-generic\/unaligned.h/linux\/unaligned.h/" $idonegit mv include/asm-generic/unaligned.h include/linux/unaligned.hgit mv tools/include/asm-generic/unaligned.h tools/include/linux/unaligned.hsed -i -e "/unaligned.h/d" include/asm-generic/Kbuildsed -i -e "s/__ASM_GENERIC/__LINUX/" include/linux/unaligned.h tools/include/linux/unaligned.h List of files: /linux-6.15/drivers/bluetooth/btbcm.c

f9183eaa - Bluetooth: btbcm: Use devm_kstrdup()

Sat, 17 Feb 2024 07:30:42 +0000

Bluetooth: btbcm: Use devm_kstrdup()Use devm_kstrdup() instead of hand-writing it.It is less verbose.Signed-off-by: Christophe JAILLET Signed-off-by: Luiz Augusto von Dentz List of files: /linux-6.15/drivers/bluetooth/btbcm.c

e49f18b9 - Bluetooth: btbcm: Use strreplace()

Sat, 17 Feb 2024 07:30:41 +0000

Bluetooth: btbcm: Use strreplace()Use strreplace() instead of hand-writing it.It is less verbose.Signed-off-by: Christophe JAILLET Signed-off-by: Luiz Augusto von Dentz List of files: /linux-6.15/drivers/bluetooth/btbcm.c

47e90f6b - Bluetooth: btbcm: add default address for BCM43430A1

Sat, 15 Jul 2023 16:41:59 +0000

Bluetooth: btbcm: add default address for BCM43430A1The BCM43430A1 has a default MAC address of AA:AA:AA:AA:AA:AA.Although, unlike some other entries, this does not include thechip name, it is clearly not a real address. This was found inAzureWave AW-NB197SM and AW-NM372SM modules.Signed-off-by: Mans Rullgard Signed-off-by: Luiz Augusto von Dentz List of files: /linux-6.15/drivers/bluetooth/btbcm.c

0d218c36 - Bluetooth: hci_bcm: Fall back to getting bdaddr from EFI if not set

Fri, 31 Mar 2023 21:11:21 +0000

Bluetooth: hci_bcm: Fall back to getting bdaddr from EFI if not setOn some devices the BCM Bluetooth adapter does not have a valid bdaddr set.btbcm.c currently sets HCI_QUIRK_INVALID_BDADDR to indicate when this isthe case. But this requires users to manual setup a btaddr, by doing e.g.:btmgmt -i hci0 public-addr 'B0:F1:EC:82:1D:B3'Which means that Bluetooth will not work out of the box on such devices.To avoid this (where possible) hci_bcm sets: HCI_QUIRK_USE_BDADDR_PROPERTYwhich tries to get the bdaddr from devicetree.But this only works on devicetree platforms. On UEFI based platformsthere is a special Broadcom UEFI variable which when present containsthe devices bdaddr, just like how there is another UEFI variable whichcontains wifi nvram contents including the wifi MAC address.Add support for getting the bdaddr from this Broadcom UEFI variable,so that Bluetooth will work OOTB for users on devices where thisUEFI variable is present.This fixes Bluetooth not working on for example Asus T100HA 2-in-1s.Signed-off-by: Hans de Goede Signed-off-by: Luiz Augusto von Dentz List of files: /linux-6.15/drivers/bluetooth/btbcm.c

b76abe46 - bluetooth: btbcm: Fix logic error in forming the board name.

Fri, 10 Mar 2023 10:28:42 +0000

bluetooth: btbcm: Fix logic error in forming the board name.This patch fixes an incorrect loop exit condition in code that replaces'/' symbols in the board name. There might also be a memory corruptionissue here, but it is unlikely to be a real problem.Cc: Signed-off-by: Sasha Finkelstein Signed-off-by: Luiz Augusto von Dentz List of files: /linux-6.15/drivers/bluetooth/btbcm.c

4f17c2b6 - Bluetooth: hci_bcm: Add BCM4349B1 variant

Tue, 24 May 2022 05:56:41 +0000

Bluetooth: hci_bcm: Add BCM4349B1 variantThe BCM4349B1, aka CYW/BCM89359, is a WiFi+BT chip and its Bluetoothportion can be controlled over serial.Two subversions are added for the chip, because ROM firmware reports002.002.013 (at least for the chips I have here), while depending onpatchram firmware revision, either 002.002.013 or 002.002.014 isreported.Signed-off-by: Ahmad Fatoum Reviewed-by: Linus Walleij Signed-off-by: Marcel Holtmann List of files: /linux-6.15/drivers/bluetooth/btbcm.c

af35e28f - Bluetooth: hci_bcm: Add support for FW loading in autobaud mode

Mon, 30 May 2022 15:02:18 +0000

Bluetooth: hci_bcm: Add support for FW loading in autobaud modeUse the presence of a DT property, "brcm,requires-autobaud-mode", to enablestartup in autobaud mode. If the property is present, the device is startedin autobaud mode by asserting RTS (BT_UART_CTS_N) prior to powering on thedevice.Also prevent the use of unsupported commands for devices started inautobaud mode. Only a limited subset of HCI commands are supported inautobaud mode.Some devices (e.g. CYW5557x) require autobaud mode to enable FW loading.Autobaud mode can also be required on some boards where the controllerdevice is using a non-standard baud rate in normal mode when first poweredon.Signed-off-by: Hakan Jansson Signed-off-by: Marcel Holtmann List of files: /linux-6.15/drivers/bluetooth/btbcm.c

0d37ddfc - Bluetooth: btbcm: Add entry for BCM4373A0 UART Bluetooth

Thu, 05 May 2022 19:50:10 +0000

Bluetooth: btbcm: Add entry for BCM4373A0 UART BluetoothThis patch adds the device ID for the BCM4373A0 module, found e.g. inthe Infineon (Cypress) CYW4373E chip. The required firmware file isnamed 'BCM4373A0.hcd'.Signed-off-by: Tim Harvey Signed-off-by: Marcel Holtmann List of files: /linux-6.15/drivers/bluetooth/btbcm.c

63fac334 - Bluetooth: btbcm: Support per-board firmware variants

Sun, 20 Mar 2022 22:27:49 +0000

Bluetooth: btbcm: Support per-board firmware variantsThere are provedly different firmware variants for the differentphones using some of these chips. These were extracted from a fewSamsung phones:37446 BCM4334B0.samsung,codina-tmo.hcd37366 BCM4334B0.samsung,golden.hcd37403 BCM4334B0.samsung,kyle.hcd37366 BCM4334B0.samsung,skomer.hcdThis patch supports the above naming schedule with inserting[.board_name] between the firmware name and ".hcd". This schemeis the same as used by the companion BRCM wireless chipsas can be seen indrivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.cor just by looking at the firmwares in linux-firmware/brcm.Currently we only support board variants using the devicetree compatible string as board type, but other schemes arepossible.This makes it possible to successfully load a few uniquefirmware variants for some Samsung phones.Cc: phone-devel@vger.kernel.orgCc: Markuss Broks Cc: Stephan Gerhold Signed-off-by: Linus Walleij Signed-off-by: Marcel Holtmann List of files: /linux-6.15/drivers/bluetooth/btbcm.c

3318ae23 - Bluetooth: btbcm: disable read tx power for MacBook Air 8,1 and 8,2

Mon, 03 Jan 2022 13:28:42 +0000

Bluetooth: btbcm: disable read tx power for MacBook Air 8,1 and 8,2The MacBook Air 8,1 and 8,2 also need querying of LE Tx powerto be disabled for Bluetooth to work.Signed-off-by: Aditya Garg Signed-off-by: Marcel Holtmann Cc: stable@vger.kernel.org List of files: /linux-6.15/drivers/bluetooth/btbcm.c

801b4c02 - Bluetooth: btbcm: disable read tx power for some Macs with the T2 Security chip

Thu, 02 Dec 2021 12:42:59 +0000

Bluetooth: btbcm: disable read tx power for some Macs with the T2 Security chipSome Macs with the T2 security chip had Bluetooth not working.To fix it we add DMI based quirks to disable querying of LE Tx power.Signed-off-by: Aditya Garg Reported-by: Orlando Chamberlain Tested-by: Orlando Chamberlain Link:https://lore.kernel.org/r/4970a940-211b-25d6-edab-21a815313954@protonmail.comFixes: 7c395ea521e6 ("Bluetooth: Query LE tx power on startup")Cc: stable@vger.kernel.orgSigned-off-by: Marcel Holtmann List of files: /linux-6.15/drivers/bluetooth/btbcm.c

192aa65a - Bluetooth: btbcm: add patch ram for bluetooth

Thu, 12 Aug 2021 16:52:18 +0000

Bluetooth: btbcm: add patch ram for bluetoothBluetooth on the BCM43752 needs a patchram file to function correctly.Signed-off-by: Angus Ainslie Signed-off-by: Marcel Holtmann List of files: /linux-6.15/drivers/bluetooth/btbcm.c

27f4d1f2 - Bluetooth: btbcm: Add entry for BCM43430B0 UART Bluetooth

Sun, 09 May 2021 23:28:37 +0000

Bluetooth: btbcm: Add entry for BCM43430B0 UART BluetoothThis patch adds the device ID for the BCM43430B0 module, found e.g. incertain revisions of AMPAK AP6212 chip. The required firmware file isnamed 'BCM43430B0.hcd'.Signed-off-by: Mikhail Rudenko Signed-off-by: Marcel Holtmann List of files: /linux-6.15/drivers/bluetooth/btbcm.c

bf0ddd10 - Bluetooth: btbcm: Added 003.006.007, changed 001.003.015

Sun, 24 May 2020 17:41:29 +0000

Bluetooth: btbcm: Added 003.006.007, changed 001.003.015Added new Broadcom device BCM4350C5, changed BCM4354A2 to BCM4356A2.Based on Broadcom Windows drivers 001.003.015 should be BCM4356A2. Ihave user report that firmware name is misplaced(https://github.com/winterheart/broadcom-bt-firmware/issues/3).Signed-off-by: Azamat H. Hackimov Signed-off-by: Marcel Holtmann List of files: /linux-6.15/drivers/bluetooth/btbcm.c

c03ee9af - Bluetooth: btbcm: Add 2 missing models to subver tables

Fri, 17 Apr 2020 17:15:32 +0000

Bluetooth: btbcm: Add 2 missing models to subver tablesCurrently the bcm_uart_subver_ and bcm_usb_subver_table-s lack entriesfor the BCM4324B5 and BCM20703A1 chipsets. This makes the code use just"BCM" as prefix for the filename to pass to request-firmware, making itharder for users to figure out which firmware they need. This especiallyis problematic with the UART attached BCM4324B5 where this leads to thefilename being just "BCM.hcd".Add the 2 missing devices to subver tables. This has been tested on:1. A Dell XPS15 9550 where this makes btbcm.c try to load"BCM20703A1-0a5c-6410.hcd" before it tries to load "BCM-0a5c-6410.hcd".2. A Thinkpad 8 where this makes btbcm.c try to load"BCM4324B5.hcd" before it tries to load "BCM.hcd"Signed-off-by: Hans de Goede Signed-off-by: Marcel Holtmann List of files: /linux-6.15/drivers/bluetooth/btbcm.c

74530a63 - Bluetooth: btbcm: Try multiple Patch filenames when loading the Patch firmware

Fri, 17 Apr 2020 17:15:31 +0000

Bluetooth: btbcm: Try multiple Patch filenames when loading the Patch firmwareCurrently the bcm_uart_subver_ and bcm_usb_subver_table-s lack entriesfor various newer chipsets. This makes the code use just "BCM" as prefixfor the filename to pass to request-firmware, making it harder for usersto figure out which firmware they need. This especially a problem withUART attached devices where this leads to the filename being "BCM.hcd".If we add new entries to the subver-tables now, then this will changewhat firmware file the kernel looks for, e.g. currently linux-firmwarecontains a brcm/BCM-0bb4-0306.hcd file. If we add the info for theBCM20703A1 to the subver table, then this will change tobrcm/BCM20703A1-0bb4-0306.hcd. This will cause the file to no longerget loaded breaking Bluetooth for existing users, going against theno regressions policy.To avoid this regression make the btbcm code try multiple filenames,first try the fullname, e.g. BCM20703A1-0bb4-0306.hcd and if that isnot found, then fallback to the name with just BCM as prefix.This commit also adds an info message which filename was used,this makes the output look like this for example:[ 57.387867] Bluetooth: hci0: BCM20703A1[ 57.387870] Bluetooth: hci0: BCM20703A1 (001.001.005) build 0000[ 57.389438] Bluetooth: hci0: BCM20703A1 'brcm/BCM20703A1-0a5c-6410.hcd' Patch[ 58.681769] Bluetooth: hci0: BCM20703A1 Generic USB 20Mhz fcbga_BU[ 58.681772] Bluetooth: hci0: BCM20703A1 (001.001.005) build 0481Signed-off-by: Hans de Goede Signed-off-by: Marcel Holtmann List of files: /linux-6.15/drivers/bluetooth/btbcm.c

f53b975c - Bluetooth: btbcm: Bail sooner from btbcm_initialize() when not loading fw

Fri, 17 Apr 2020 17:15:30 +0000

Bluetooth: btbcm: Bail sooner from btbcm_initialize() when not loading fwIf we have already loaded the firmware/patchram and btbcm_initialize()is called to re-init the HCI after this then there is no need to getthe USB device-ids and build a firmware-filename out of these.Signed-off-by: Hans de Goede Signed-off-by: Marcel Holtmann List of files: /linux-6.15/drivers/bluetooth/btbcm.c