Changes in rbd_types.h

53ab8e7c - libceph, rbd: replace zero-length array with flexible-array

Thu, 07 May 2020 18:51:38 +0000

libceph, rbd: replace zero-length array with flexible-arrayThe current codebase makes use of the zero-length array languageextension to the C90 standard, but the preferred mechanism to declarevariable-length types such as these ones is a flexible array member[1][2],introduced in C99:struct foo { int stuff; struct boo array[];};By making use of the mechanism above, we will get a compiler warningin case the flexible array does not occur last in the structure, whichwill help us prevent some kind of undefined behavior bugs from beinginadvertently introduced[3] to the codebase from now on.Also, notice that, dynamic memory allocations won't be affected bythis change:"Flexible array members have incomplete type, and so the sizeof operatormay not be applied. As a quirk of the original implementation ofzero-length arrays, sizeof evaluates to zero."[1]sizeof(flexible-array-member) triggers a warning because flexible arraymembers have incomplete type[1]. There are some instances of code inwhich the sizeof operator is being incorrectly/erroneously applied tozero-length arrays and the result is zero. Such instances may be hidingsome bugs. So, this work (flexible-array member conversions) will alsohelp to get completely rid of those sorts of issues.This issue was found with the help of Coccinelle.[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html[2] https://github.com/KSPP/linux/issues/21[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")Signed-off-by: Gustavo A. R. Silva Reviewed-by: Ilya Dryomov Signed-off-by: Ilya Dryomov List of files: /linux-6.15/drivers/block/rbd_types.h

22e8bd51 - rbd: support for object-map and fast-diff

Wed, 05 Jun 2019 17:25:11 +0000

rbd: support for object-map and fast-diffSpeed up reads, discards and zeroouts through RBD_OBJ_FLAG_MAY_EXISTand RBD_OBJ_FLAG_NOOP_FOR_NONEXISTENT based on object map.Invalid object maps are not trusted, but still updated. Note that wenever iterate, resize or invalidate object maps. If object-map featureis enabled but object map fails to load, we just fail the requester(either "rbd map" or I/O, by way of post-acquire action).Signed-off-by: Ilya Dryomov List of files: /linux-6.15/drivers/block/rbd_types.h

223768d0 - rbd: RBD_V{1,2}_DATA_FORMAT macros

Wed, 25 Jan 2017 17:16:23 +0000

rbd: RBD_V{1,2}_DATA_FORMAT macros... and also fix up the comment -- format 1 data objects have alwaysbeen 12 hex digits long.Signed-off-by: Ilya Dryomov Reviewed-by: Jason Dillaman List of files: /linux-6.15/drivers/block/rbd_types.h

24dca799 - rbd: kill rbd_image_header::{crypt_type,comp_type}

Wed, 25 Jan 2017 17:16:21 +0000

rbd: kill rbd_image_header::{crypt_type,comp_type}Image format 1 is deprecated and format 2 doesn't have these. Also,__rbd_dev_create() takes care of zeroing (or otherwise initializing)format 2 specific fields.Signed-off-by: Ilya Dryomov Reviewed-by: Jason Dillaman List of files: /linux-6.15/drivers/block/rbd_types.h

ed95b21a - rbd: support for exclusive-lock feature

Fri, 12 Aug 2016 14:40:02 +0000

rbd: support for exclusive-lock featureAdd basic support for RBD_FEATURE_EXCLUSIVE_LOCK feature. Maintenanceoperations (resize, snapshot create, etc) are offloaded to librbd viareturning -EOPNOTSUPP - librbd should request the lock and execute theoperation.Signed-off-by: Ilya Dryomov Reviewed-by: Mike Christie Tested-by: Mike Christie List of files: /linux-6.15/drivers/block/rbd_types.h

2fd82b9e - rbd: get rid of RBD_MAX_SEG_NAME_LEN

Fri, 09 Nov 2012 21:05:54 +0000

rbd: get rid of RBD_MAX_SEG_NAME_LENRBD_MAX_SEG_NAME_LEN represents the maximum length of an rbd objectname (i.e., one of the objects providing storage backing an rbdimage).Another symbol, MAX_OBJ_NAME_SIZE, is used in the osd client code todefine the maximum length of any object name in an osd request.Right now they disagree, with RBD_MAX_SEG_NAME_LEN being too big.There's no real benefit at this point to defining the rbd objectname length limit separate from any other object name, so justget rid of RBD_MAX_SEG_NAME_LEN and use MAX_OBJ_NAME_SIZE in itsplace.Signed-off-by: Alex Elder Reviewed-by: Sage Weil List of files: /linux-6.15/drivers/block/rbd_types.h

3bb59ad5 - rbd: define some new format constants

Wed, 11 Jul 2012 01:30:10 +0000

rbd: define some new format constantsDefine constant symbols related to the rbd format 2 object names.This begins to bring this version of the "rbd_types.h" headermore in line with the current user-space version of that file.Complete reconciliation of differences will be done at somepoint later, as a separate task.Signed-off-by: Alex Elder Reviewed-by: Josh Durgin List of files: /linux-6.15/drivers/block/rbd_types.h

843a0d08 - rbd: rename block_name -> object_prefix

Fri, 31 Aug 2012 22:29:51 +0000

rbd: rename block_name -> object_prefixIn the on-disk image header structure there is a field "block_name"which represents what we now call the "object prefix" for an rbdimage. Rename this field "object_prefix" to be consistent withmodern usage.This appears to be the only remaining vestige of the use of "block"in symbols that represent objects in the rbd code.This addresses http://tracker.newdream.net/issues/1761Signed-off-by: Alex Elder Reviewed-by: Josh Durgin Reviewed-by: Dan Mick List of files: /linux-6.15/drivers/block/rbd_types.h

bf3e5ae1 - rbd: dynamically allocate image name

Tue, 10 Jul 2012 02:04:23 +0000

rbd: dynamically allocate image nameThere is no need to impose a small limit the length of the rbd imagename recorded in a struct rbd_dev. Remove the limitation byallocating space for the image name dynamically.Signed-off-by: Alex Elder Reviewed-by: Josh Durgin List of files: /linux-6.15/drivers/block/rbd_types.h

593a9e7b - rbd: small changes

Tue, 07 Feb 2012 18:03:37 +0000

rbd: small changesHere is another set of small code tidy-ups: - Define SECTOR_SHIFT and SECTOR_SIZE, and use these symbolic names throughout. Tell the blk_queue system our physical block size, in the (unlikely) event we want to use something other than the default. - Delete the definition of struct rbd_info, which is never used. - Move the definition of dev_to_rbd() down in its source file, just above where it gets first used, and change its name to dev_to_rbd_dev(). - Replace an open-coded operation in rbd_dev_release() to use dev_to_rbd_dev() instead. - Calculate the segment size for a given rbd_device just once in rbd_init_disk(). - Use the '%zd' conversion specifier in rbd_snap_size_show(), since the value formatted is a size_t. - Switch to the '%llu' conversion specifier in rbd_snap_id_show(). since the value formatted is unsigned.Signed-off-by: Alex Elder List of files: /linux-6.15/drivers/block/rbd_types.h

602adf40 - rbd: introduce rados block device (rbd), based on libceph

Thu, 12 Aug 2010 23:11:25 +0000

rbd: introduce rados block device (rbd), based on libcephThe rados block device (rbd), based on osdblk, creates a block devicethat is backed by objects stored in the Ceph distributed object storagecluster. Each device consists of a single metadata object and datastriped over many data objects.The rbd driver supports read-only snapshots.Signed-off-by: Yehuda Sadeh Signed-off-by: Sage Weil List of files: /linux-6.15/drivers/block/rbd_types.h