Changes in Makefile

129ab0d2 - kbuild: do not quote string values in include/config/auto.conf

Tue, 14 Dec 2021 02:53:53 +0000

kbuild: do not quote string values in include/config/auto.confThe previous commit fixed up all shell scripts to not includeinclude/config/auto.conf.Now that include/config/auto.conf is only included by Makefiles,we can change it into a more Make-friendly form.Previously, Kconfig output string values enclosed with double-quotes(both in the .config and include/config/auto.conf): CONFIG_X="foo bar"Unlike shell, Make handles double-quotes (and single-quotes as well)verbatim. We must rip them off when used.There are some patterns: [1] $(patsubst "%",%,$(CONFIG_X)) [2] $(CONFIG_X:"%"=%) [3] $(subst ",,$(CONFIG_X)) [4] $(shell echo $(CONFIG_X))These are not only ugly, but also fragile.[1] and [2] do not work if the value contains spaces, like CONFIG_X=" foo bar "[3] does not work correctly if the value contains double-quotes like CONFIG_X="foo\"bar"[4] seems to work better, but has a cost of forking a process.Anyway, quoted strings were always PITA for our Makefiles.This commit changes Kconfig to stop quoting in include/config/auto.conf.These are the string type symbols referenced in Makefiles or scripts: ACPI_CUSTOM_DSDT_FILE ARC_BUILTIN_DTB_NAME ARC_TUNE_MCPU BUILTIN_DTB_SOURCE CC_IMPLICIT_FALLTHROUGH CC_VERSION_TEXT CFG80211_EXTRA_REGDB_KEYDIR EXTRA_FIRMWARE EXTRA_FIRMWARE_DIR EXTRA_TARGETS H8300_BUILTIN_DTB INITRAMFS_SOURCE LOCALVERSION MODULE_SIG_HASH MODULE_SIG_KEY NDS32_BUILTIN_DTB NIOS2_DTB_SOURCE OPENRISC_BUILTIN_DTB SOC_CANAAN_K210_DTB_SOURCE SYSTEM_BLACKLIST_HASH_LIST SYSTEM_REVOCATION_KEYS SYSTEM_TRUSTED_KEYS TARGET_CPU UNUSED_KSYMS_WHITELIST XILINX_MICROBLAZE0_FAMILY XILINX_MICROBLAZE0_HW_VER XTENSA_VARIANT_NAMEI checked them one by one, and fixed up the code where necessary.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/drivers/base/firmware_loader/builtin/Makefile

48d09e97 - firmware_loader: formalize built-in firmware API

Thu, 21 Oct 2021 15:58:34 +0000

firmware_loader: formalize built-in firmware APIFormalize the built-in firmware with a proper API. This can laterbe used by other callers where all they need is built-in firmware.We export the firmware_request_builtin() call for now onlyunder the TEST_FIRMWARE symbol namespace as there are nodirect modular users for it. If they pop up they are freeto export it generally. Built-in code always gets access tothe callers and we'll demonstrate a hidden user which has beenlurking in the kernel for a while and the reason why using aproper API was better long term.Reviewed-by: Borislav Petkov Signed-off-by: Luis Chamberlain Link: https://lore.kernel.org/r/20211021155843.1969401-2-mcgrof@kernel.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/base/firmware_loader/builtin/Makefile

7f787701 - firmware_loader: remove unneeded 'comma' macro

Fri, 28 May 2021 17:34:03 +0000

firmware_loader: remove unneeded 'comma' macroCommit 553671b76859 ("firmware_loader: Fix labels with comma for builtinfirmware") added this line, which was unneeded.The macro 'comma' is defined in scripts/Kbuild.include.Signed-off-by: Masahiro Yamada Link: https://lore.kernel.org/r/20210528173404.169764-1-masahiroy@kernel.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/base/firmware_loader/builtin/Makefile

f5ae2ea6 - Fix built-in early-load Intel microcode alignment

Sun, 12 Jan 2020 13:00:53 +0000

Fix built-in early-load Intel microcode alignmentIntel Software Developer's Manual, volume 3, chapter 9.11.6 says: "Note that the microcode update must be aligned on a 16-byte boundary and the size of the microcode update must be 1-KByte granular"When early-load Intel microcode is loaded from initramfs, userspace tool'iucode_tool' has already 16-byte aligned those microcode bits in thatinitramfs image. Image that was created something like this: iucode_tool --write-earlyfw=FOO.cpio microcode-files...However, when early-load Intel microcode is loaded from built-infirmware BLOB using CONFIG_EXTRA_FIRMWARE= kernel config option, that16-byte alignment is not guaranteed.Fix this by forcing all built-in firmware BLOBs to 16-byte alignment.[ If we end up having other firmware with much bigger alignment requirements, we might need to introduce some method for the firmware to specify it, this is the minimal "just increase the alignment a bit to account for this one special case" patch - Linus ]Signed-off-by: Jari Ruusu Cc: Borislav Petkov Cc: Fenghua Yu Cc: Luis Chamberlain Cc: stable@kernel.orgSigned-off-by: Linus Torvalds List of files: /linux-6.15/drivers/base/firmware_loader/builtin/Makefile

553671b7 - firmware_loader: Fix labels with comma for builtin firmware

Fri, 15 Nov 2019 22:59:11 +0000

firmware_loader: Fix labels with comma for builtin firmwareSome firmware images contain a comma, such as:EXTRA_FIRMWARE "brcm/brcmfmac4334-sdio.samsung,gt-s7710.txt"as Broadcom firmware simply tags the device tree compatiblestring at the end of the firmware parameter file. And thecompatible string contains a comma.This doesn't play well with gas:drivers/base/firmware_loader/builtin/brcm/brcmfmac4334-sdio.samsung,gt-s7710.txt.gen.S: Assembler messages:drivers/base/firmware_loader/builtin/brcm/brcmfmac4334-sdio.samsung,gt-s7710.txt.gen.S:4: Error: bad instruction `_fw_brcm_brcmfmac4334_sdio_samsung,gt_s7710_txt_bin:'drivers/base/firmware_loader/builtin/brcm/brcmfmac4334-sdio.samsung,gt-s7710.txt.gen.S:9: Error: bad instruction `_fw_brcm_brcmfmac4334_sdio_samsung,gt_s7710_txt_name:'drivers/base/firmware_loader/builtin/brcm/brcmfmac4334-sdio.samsung,gt-s7710.txt.gen.S:15: Error: can't resolve `.rodata' {.rodata section} - `_fw_brcm_brcmfmac4334_sdio_samsung' {*UND* section}make[6]: *** [../scripts/Makefile.build:357: drivers/base/firmware_loader/builtin/brcm/brcmfmac4334-sdio.samsung,gt-s7710.txt.gen.o] Error 1We need to get rid of the comma from the labels used by theassembly stub generator.Replacing a comma using GNU Make subst requires a helpervariable.Cc: Stephan Gerhold Signed-off-by: Linus Walleij Link: https://lore.kernel.org/r/20191115225911.3260-1-linus.walleij@linaro.orgAcked-by: Luis Chamberlain Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/base/firmware_loader/builtin/Makefile

f96182e9 - firmware_loader: move firmware/ to drivers/base/firmware_loader/builtin/

Fri, 11 Jan 2019 09:52:00 +0000

firmware_loader: move firmware/ to drivers/base/firmware_loader/builtin/Currently, the 'firmware' directory only contains a single Makefileto embed extra firmware into the kernel.Move it to the more relevant place.Signed-off-by: Masahiro Yamada Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/base/firmware_loader/builtin/Makefile