Changes in cmac.c

cdd30ebb - module: Convert symbol namespace to string literal

Mon, 02 Dec 2024 14:59:47 +0000

module: Convert symbol namespace to string literalClean up the existing export namespace code along the same lines ofcommit 33def8498fdd ("treewide: Convert macro and uses of __section(foo)to __section("foo")") and for the same reason, it is not desired for thenamespace argument to be a macro expansion itself.Scripted using git grep -l -e MODULE_IMPORT_NS -e EXPORT_SYMBOL_NS | while read file; do awk -i inplace ' /^#define EXPORT_SYMBOL_NS/ { gsub(/__stringify$ns$/, "ns"); print; next; } /^#define MODULE_IMPORT_NS/ { gsub(/__stringify$ns$/, "ns"); print; next; } /MODULE_IMPORT_NS/ { $0 = gensub(/MODULE_IMPORT_NS$([^)]*)$/, "MODULE_IMPORT_NS(\"\\1\")", "g"); } /EXPORT_SYMBOL_NS/ { if ($0 ~ /(EXPORT_SYMBOL_NS[^(]*)$([^,]+),/) { if ($0 !~ /(EXPORT_SYMBOL_NS[^(]*)\(([^,]+), ([^)]+)$/ && $0 !~ /(EXPORT_SYMBOL_NS[^(]*)/ && $0 !~ /^my/) { getline line; gsub(/[[:space:]]*\\$/, ""); gsub(/[[:space:]]/, "", line); $0 = $0 " " line; } $0 = gensub(/(EXPORT_SYMBOL_NS[^(]*)$([^,]+), ([^)]+)$/, "\\1(\\2, \"\\3\")", "g"); } } { print }' $file; doneRequested-by: Masahiro Yamada Signed-off-by: Peter Zijlstra (Intel) Link: https://mail.google.com/mail/u/2/#inbox/FMfcgzQXKWgMmjdFwwdsfgxzKpVHWPlcAcked-by: Greg KH Signed-off-by: Linus Torvalds List of files: /linux-6.15/crypto/cmac.c

f9dc9f2e - crypto: cmac - remove unnecessary alignment logic

Thu, 19 Oct 2023 05:53:33 +0000

crypto: cmac - remove unnecessary alignment logicThe cmac template is setting its alignmask to that of its underlying'cipher'. Yet, it doesn't care itself about how its inputs and outputsare aligned, which is ostensibly the point of the alignmask. Instead,cmac actually just uses its alignmask itself to runtime-align certainfields in its tfm and desc contexts appropriately for its underlyingcipher. That is almost entirely pointless too, though, since cmac isalready using the cipher API functions that handle alignment themselves,and few ciphers set a nonzero alignmask anyway. Also, even withoutruntime alignment, an alignment of at least 4 bytes can be guaranteed.Thus, at best this code is optimizing for the rare case of ciphers thatset an alignmask >= 7, at the cost of hurting the common cases.Therefore, this patch removes the manual alignment code from cmac andmakes it stop setting an alignmask.Signed-off-by: Eric Biggers Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/cmac.c

ed51bba1 - crypto: cmac - Add support for cloning

Fri, 19 May 2023 08:28:37 +0000

crypto: cmac - Add support for cloningAllow cmac to be cloned. The underlying cipher needs to supportcloning by not having a cra_init function (all implementations ofaes that do not require a fallback can be cloned).Signed-off-by: Herbert Xu Acked-by: Ard Biesheuvel Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/cmac.c

cf2eddc9 - crypto: cmac - Use modern init_tfm/exit_tfm

Fri, 19 May 2023 08:28:32 +0000

crypto: cmac - Use modern init_tfm/exit_tfmUse the modern init_tfm/exit_tfm interface instead of the obsoletecra_init/cra_exit interface.Signed-off-by: Herbert Xu Acked-by: Ard Biesheuvel Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/cmac.c

0eb76ba2 - crypto: remove cipher routines from public crypto API

Fri, 11 Dec 2020 12:27:15 +0000

crypto: remove cipher routines from public crypto APIThe cipher routines in the crypto API are mostly intended for templatesimplementing skcipher modes generically in software, and shouldn't beused outside of the crypto subsystem. So move the prototypes and allrelated definitions to a new header file under include/crypto/internal.Also, let's use the new module namespace feature to move the symbolexports into a new namespace CRYPTO_INTERNAL.Signed-off-by: Ard Biesheuvel Acked-by: Eric Biggers Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/cmac.c

7bcb2c99 - crypto: algapi - use common mechanism for inheriting flags

Fri, 10 Jul 2020 06:20:38 +0000

crypto: algapi - use common mechanism for inheriting flagsThe flag CRYPTO_ALG_ASYNC is "inherited" in the sense that when atemplate is instantiated, the template will have CRYPTO_ALG_ASYNC set ifany of the algorithms it uses has CRYPTO_ALG_ASYNC set.We'd like to add a second flag (CRYPTO_ALG_ALLOCATES_MEMORY) that gets"inherited" in the same way. This is difficult because the handling ofCRYPTO_ALG_ASYNC is hardcoded everywhere. Address this by: - Add CRYPTO_ALG_INHERITED_FLAGS, which contains the set of flags that have these inheritance semantics. - Add crypto_algt_inherited_mask(), for use by template ->create() methods. It returns any of these flags that the user asked to be unset and thus must be passed in the 'mask' to crypto_grab_*(). - Also modify crypto_check_attr_type() to handle computing the 'mask' so that most templates can just use this. - Make crypto_grab_*() propagate these flags to the template instance being created so that templates don't have to do this themselves.Make crypto/simd.c propagate these flags too, since it "wraps" anotheralgorithm, similar to a template.Based on a patch by Mikulas Patocka (https://lore.kernel.org/r/alpine.LRH.2.02.2006301414580.30526@file01.intranet.prod.int.rdu2.redhat.com).Signed-off-by: Eric Biggers Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/cmac.c

a39c66cc - crypto: shash - convert shash_free_instance() to new style

Fri, 03 Jan 2020 04:04:38 +0000

crypto: shash - convert shash_free_instance() to new styleConvert shash_free_instance() and its users to the new way of freeinginstances, where a ->free() method is installed to the instance structitself. This replaces the weakly-typed method crypto_template::free().This will allow removing support for the old way of freeing instances.Also give shash_free_instance() a more descriptive name to reflect thatit's only for instances with a single spawn, not for any instance.Signed-off-by: Eric Biggers Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/cmac.c

d5ed3b65 - crypto: cipher - make crypto_spawn_cipher() take a crypto_cipher_spawn

Fri, 03 Jan 2020 03:59:05 +0000

crypto: cipher - make crypto_spawn_cipher() take a crypto_cipher_spawnNow that all users of single-block cipher spawns have been converted touse 'struct crypto_cipher_spawn' rather than the less specifically typed'struct crypto_spawn', make crypto_spawn_cipher() take a pointer to a'struct crypto_cipher_spawn' rather than a 'struct crypto_spawn'.Signed-off-by: Eric Biggers Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/cmac.c

1d0459cd - crypto: cmac - use crypto_grab_cipher() and simplify error paths

Fri, 03 Jan 2020 03:59:02 +0000

crypto: cmac - use crypto_grab_cipher() and simplify error pathsMake the cmac template use the new function crypto_grab_cipher() toinitialize its cipher spawn.This is needed to make all spawns be initialized in a consistent way.This required making cmac_create() allocate the instance directly ratherthan use shash_alloc_instance().Also simplify the error handling by taking advantage of crypto_drop_*()now accepting (as a no-op) spawns that haven't been initialized yet, andby taking advantage of crypto_grab_*() now handling ERR_PTR() names.Signed-off-by: Eric Biggers Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/cmac.c

2874c5fd - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152

Mon, 27 May 2019 06:55:01 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license as published by the free software foundation either version 2 of the license or at your option any later versionextracted by the scancode license scanner the SPDX license identifier GPL-2.0-or-laterhas been chosen to replace the boilerplate/reference in 3029 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Allison Randal Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190527070032.746973796@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/crypto/cmac.c

c4741b23 - crypto: run initcalls for generic implementations earlier

Fri, 12 Apr 2019 04:57:42 +0000

crypto: run initcalls for generic implementations earlierUse subsys_initcall for registration of all templates and genericalgorithm implementations, rather than module_init. Then changecryptomgr to use arch_initcall, to place it before the subsys_initcalls.This is needed so that when both a generic and optimized implementationof an algorithm are built into the kernel (not loadable modules), thegeneric implementation is registered before the optimized one.Otherwise, the self-tests for the optimized implementation are unable toallocate the generic implementation for the new comparison fuzz tests.Note that on arm, a side effect of this change is that self-tests forgeneric implementations may run before the unaligned access handler hasbeen installed. So, unaligned accesses will crash the kernel. This isarguably a good thing as it makes it easier to detect that type of bug.Signed-off-by: Eric Biggers Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/cmac.c

db91af0f - crypto: algapi - make crypto_xor() and crypto_inc() alignment agnostic

Sun, 05 Feb 2017 10:06:12 +0000

crypto: algapi - make crypto_xor() and crypto_inc() alignment agnosticInstead of unconditionally forcing 4 byte alignment for all genericchaining modes that rely on crypto_xor() or crypto_inc() (which mayresult in unnecessary copying of data when the underlying hardwarecan perform unaligned accesses efficiently), make those functionsdeal with unaligned input explicitly, but only if the Kconfig symbolHAVE_EFFICIENT_UNALIGNED_ACCESS is set. This will allow us to dropthe alignmasks from the CBC, CMAC, CTR, CTS, PCBC and SEQIV drivers.For crypto_inc(), this simply involves making the 4-byte strideconditional on HAVE_EFFICIENT_UNALIGNED_ACCESS being set, given thatit typically operates on 16 byte buffers.For crypto_xor(), an algorithm is implemented that simply runs throughthe input using the largest strides possible if unaligned accesses areallowed. If they are not, an optimal sequence of memory accesses isemitted that takes the relative alignment of the input buffers intoaccount, e.g., if the relative misalignment of dst and src is 4 bytes,the entire xor operation will be completed using 4 byte loads and stores(modulo unaligned bits at the start and end). Note that all expressionsinvolving misalign are simply eliminated by the compiler whenHAVE_EFFICIENT_UNALIGNED_ACCESS is defined.Signed-off-by: Ard Biesheuvel Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/cmac.c

f16743e0 - crypto: cmac - fix alignment of 'consts'

Mon, 10 Oct 2016 17:15:15 +0000

crypto: cmac - fix alignment of 'consts'The per-transform 'consts' array is accessed as __be64 incrypto_cmac_digest_setkey() but was only guaranteed to be aligned to__alignof__(long). Fix this by aligning it to __alignof__(__be64).Signed-off-by: Eric Biggers Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/cmac.c

48ee41bf - crypto: cmac - return -EINVAL if block size is unsupported

Mon, 10 Oct 2016 17:15:14 +0000

crypto: cmac - return -EINVAL if block size is unsupportedcmac_create() previously returned 0 if a cipher with a block size otherthan 8 or 16 bytes was specified. It should return -EINVAL instead.Granted, this doesn't actually change any behavior because cryptomgrcurrently ignores any return value other than -EAGAIN from template->create() functions.Signed-off-by: Eric Biggers Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/cmac.c

4943ba16 - crypto: include crypto- module prefix in template

Tue, 25 Nov 2014 00:32:38 +0000

crypto: include crypto- module prefix in templateThis adds the module loading prefix "crypto-" to the template lookupas well.For example, attempting to load 'vfat(blowfish)' via AF_ALG now correctlyincludes the "crypto-" prefix at every level, correctly rejecting "vfat": net-pf-38 algif-hash crypto-vfat(blowfish) crypto-vfat(blowfish)-all crypto-vfatReported-by: Mathias Krause Signed-off-by: Kees Cook Acked-by: Mathias Krause Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/cmac.c

93b5e86a - crypto: add CMAC support to CryptoAPI

Mon, 08 Apr 2013 07:48:44 +0000

crypto: add CMAC support to CryptoAPIPatch adds support for NIST recommended block cipher mode CMAC to CryptoAPI.This work is based on Tom St Denis' earlier patch, http://marc.info/?l=linux-crypto-vger&m=135877306305466&w=2Cc: Tom St Denis Signed-off-by: Jussi Kivilinna Acked-by: David S. Miller Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/cmac.c