Changes in algif_aead.c

dc97391e - sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES)

Fri, 23 Jun 2023 22:55:12 +0000

sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES)Remove ->sendpage() and ->sendpage_locked(). sendmsg() withMSG_SPLICE_PAGES should be used instead. This allows multiple pages andmultipage folios to be passed through.Signed-off-by: David Howells Acked-by: Marc Kleine-Budde # for net/cancc: Jens Axboe cc: Matthew Wilcox cc: linux-afs@lists.infradead.orgcc: mptcp@lists.linux.devcc: rds-devel@oss.oracle.comcc: tipc-discussion@lists.sourceforge.netcc: virtualization@lists.linux-foundation.orgLink: https://lore.kernel.org/r/20230623225513.2732256-16-dhowells@redhat.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/crypto/algif_aead.c

bf63e250 - crypto: af_alg: Support MSG_SPLICE_PAGES

Tue, 06 Jun 2023 13:08:54 +0000

crypto: af_alg: Support MSG_SPLICE_PAGESMake AF_ALG sendmsg() support MSG_SPLICE_PAGES. This causes pages to bespliced from the source iterator.This allows ->sendpage() to be replaced by something that can handlemultiple multipage folios in a single transaction.Signed-off-by: David Howells cc: Herbert Xu cc: "David S. Miller" cc: Eric Dumazet cc: Jakub Kicinski cc: Paolo Abeni cc: Jens Axboe cc: Matthew Wilcox cc: linux-crypto@vger.kernel.orgcc: netdev@vger.kernel.orgAcked-by: Herbert Xu Signed-off-by: Paolo Abeni List of files: /linux-6.15/crypto/algif_aead.c

c1abe6f5 - crypto: af_alg: Use extract_iter_to_sg() to create scatterlists

Tue, 06 Jun 2023 13:08:52 +0000

crypto: af_alg: Use extract_iter_to_sg() to create scatterlistsUse extract_iter_to_sg() to decant the destination iterator into ascatterlist in af_alg_get_rsgl(). af_alg_make_sg() can then be removed.Signed-off-by: David Howells cc: Herbert Xu cc: "David S. Miller" cc: Eric Dumazet cc: Jakub Kicinski cc: Paolo Abeni cc: Jens Axboe cc: Matthew Wilcox cc: linux-crypto@vger.kernel.orgcc: netdev@vger.kernel.orgAcked-by: Herbert Xu Signed-off-by: Paolo Abeni List of files: /linux-6.15/crypto/algif_aead.c

cbdad1f2 - crypto: algif_aead - Do not set MAY_BACKLOG on the async path

Fri, 31 Jul 2020 07:03:50 +0000

crypto: algif_aead - Do not set MAY_BACKLOG on the async pathThe async path cannot use MAY_BACKLOG because it is not meant toblock, which is what MAY_BACKLOG does. On the other hand, boththe sync and async paths can make use of MAY_SLEEP.Fixes: 83094e5e9e49 ("crypto: af_alg - add async support to...")Cc: Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/algif_aead.c

4eb57bcd - crypto: algif_aead - delete duplicated word

Fri, 31 Jul 2020 02:39:19 +0000

crypto: algif_aead - delete duplicated wordDrop the doubled word "is".Signed-off-by: Randy Dunlap Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.orgSigned-off-by: Herbert Xu List of files: /linux-6.15/crypto/algif_aead.c

21dfbcd1 - crypto: algif_aead - fix uninitialized ctx->init

Wed, 12 Aug 2020 12:58:25 +0000

crypto: algif_aead - fix uninitialized ctx->initIn skcipher_accept_parent_nokey() the whole af_alg_ctx structure iscleared by memset() after allocation, so add such memset() also toaead_accept_parent_nokey() so that the new "init" field is alsoinitialized to zero. Without that the initial ctx->init checks mightrandomly return true and cause errors.While there, also remove the redundant zero assignments in bothfunctions.Found via libkcapi testsuite.Cc: Stephan Mueller Fixes: f3c802a1f300 ("crypto: algif_aead - Only wake up when ctx->more is zero")Suggested-by: Herbert Xu Signed-off-by: Ondrej Mosnacek Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/algif_aead.c

a44d9e72 - net: make ->{get,set}sockopt in proto_ops optional

Fri, 17 Jul 2020 06:23:31 +0000

net: make ->{get,set}sockopt in proto_ops optionalJust check for a NULL method instead of wiring upsock_no_{get,set}sockopt.Signed-off-by: Christoph Hellwig Acked-by: Marc Kleine-Budde Signed-off-by: David S. Miller List of files: /linux-6.15/crypto/algif_aead.c

f3c802a1 - crypto: algif_aead - Only wake up when ctx->more is zero

Fri, 29 May 2020 14:23:49 +0000

crypto: algif_aead - Only wake up when ctx->more is zeroAEAD does not support partial requests so we must not wake upwhile ctx->more is set. In order to distinguish between thecase of no data sent yet and a zero-length request, a new initflag has been added to ctx.SKCIPHER has also been modified to ensure that at least a blockof data is available if there is more data to come.Fixes: 2d97591ef43d ("crypto: af_alg - consolidation of...")Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/algif_aead.c

34c86f4c - crypto: af_alg - fix use-after-free in af_alg_accept() due to bh_lock_sock()

Mon, 08 Jun 2020 06:48:43 +0000

crypto: af_alg - fix use-after-free in af_alg_accept() due to bh_lock_sock()The locking in af_alg_release_parent is broken as the BH socketlock can only be taken if there is a code-path to handle the casewhere the lock is owned by process-context. Instead of addingsuch handling, we can fix this by changing the ref counts toatomic_t.This patch also modifies the main refcnt to include both normaland nokey sockets. This way we don't have to fudge the nokeyref count when a socket changes from nokey to normal.Credits go to Mauricio Faria de Oliveira who diagnosed this bugand sent a patch for it:https://lore.kernel.org/linux-crypto/20200605161657.535043-1-mfo@canonical.com/Reported-by: Brian Moyles Reported-by: Mauricio Faria de Oliveira Fixes: 37f96694cf73 ("crypto: af_alg - Use bh_lock_sock in...")Cc: Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/algif_aead.c

2874c5fd - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152

Mon, 27 May 2019 06:55:01 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license as published by the free software foundation either version 2 of the license or at your option any later versionextracted by the scancode license scanner the SPDX license identifier GPL-2.0-or-laterhas been chosen to replace the boilerplate/reference in 3029 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Allison Randal Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190527070032.746973796@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/crypto/algif_aead.c

8d605398 - crypto: null - Remove VLA usage of skcipher

Wed, 19 Sep 2018 02:10:51 +0000

crypto: null - Remove VLA usage of skcipherIn the quest to remove all stack VLA usage from the kernel[1], thisreplaces struct crypto_skcipher and SKCIPHER_REQUEST_ON_STACK() usagewith struct crypto_sync_skcipher and SYNC_SKCIPHER_REQUEST_ON_STACK(),which uses a fixed stack size.[1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.comSigned-off-by: Kees Cook Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/algif_aead.c

a11e1d43 - Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL

Thu, 28 Jun 2018 16:43:44 +0000

Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLLThe poll() changes were not well thought out, and completelyunexplained. They also caused a huge performance regression, because"->poll()" was no longer a trivial file operation that just called downto the underlying file operations, but instead did at least two indirectcalls.Indirect calls are sadly slow now with the Spectre mitigation, but theperformance problem could at least be largely mitigated by changing the"->get_poll_head()" operation to just have a per-file-descriptor pointerto the poll head instead. That gets rid of one of the new indirections.But that doesn't fix the new complexity that is completely unwarrantedfor the regular case. The (undocumented) reason for the poll() changeswas some alleged AIO poll race fixing, but we don't make the common caseslower and more complex for some uncommon special case, so this allreally needs way more explanations and most likely a fundamentalredesign.[ This revert is a revert of about 30 different commits, not reverted individually because that would just be unnecessarily messy - Linus ]Cc: Al Viro Cc: Christoph Hellwig Signed-off-by: Linus Torvalds List of files: /linux-6.15/crypto/algif_aead.c

76e43e37 - treewide: Use array_size() in sock_kmalloc()

Tue, 12 Jun 2018 21:28:11 +0000

treewide: Use array_size() in sock_kmalloc()The sock_kmalloc() function has no 2-factor argument form, somultiplication factors need to be wrapped in array_size(). This patchreplaces cases of: sock_kmalloc(handle, a * b, gfp)with: sock_kmalloc(handle, array_size(a, b), gfp)as well as handling cases of: sock_kmalloc(handle, a * b * c, gfp)with: sock_kmalloc(handle, array3_size(a, b, c), gfp)This does, however, attempt to ignore constant size factors like: sock_kmalloc(handle, 4 * 1024, gfp)though any constants defined via macros get caught up in the conversion.Any factors with a sizeof() of "unsigned char", "char", and "u8" weredropped, since they're redundant.The Coccinelle script used for this was:// Fix redundant parens around sizeof().@@expression HANDLE;type TYPE;expression THING, E;@@( sock_kmalloc(HANDLE,- (sizeof(TYPE)) * E+ sizeof(TYPE) * E , ...)| sock_kmalloc(HANDLE,- (sizeof(THING)) * E+ sizeof(THING) * E , ...))// Drop single-byte sizes and redundant parens.@@expression HANDLE;expression COUNT;typedef u8;typedef __u8;@@( sock_kmalloc(HANDLE,- sizeof(u8) * (COUNT)+ COUNT , ...)| sock_kmalloc(HANDLE,- sizeof(__u8) * (COUNT)+ COUNT , ...)| sock_kmalloc(HANDLE,- sizeof(char) * (COUNT)+ COUNT , ...)| sock_kmalloc(HANDLE,- sizeof(unsigned char) * (COUNT)+ COUNT , ...)| sock_kmalloc(HANDLE,- sizeof(u8) * COUNT+ COUNT , ...)| sock_kmalloc(HANDLE,- sizeof(__u8) * COUNT+ COUNT , ...)| sock_kmalloc(HANDLE,- sizeof(char) * COUNT+ COUNT , ...)| sock_kmalloc(HANDLE,- sizeof(unsigned char) * COUNT+ COUNT , ...))// 2-factor product with sizeof(type/expression) and identifier or constant.@@expression HANDLE;type TYPE;expression THING;identifier COUNT_ID;constant COUNT_CONST;@@( sock_kmalloc(HANDLE,- sizeof(TYPE) * (COUNT_ID)+ array_size(COUNT_ID, sizeof(TYPE)) , ...)| sock_kmalloc(HANDLE,- sizeof(TYPE) * COUNT_ID+ array_size(COUNT_ID, sizeof(TYPE)) , ...)| sock_kmalloc(HANDLE,- sizeof(TYPE) * (COUNT_CONST)+ array_size(COUNT_CONST, sizeof(TYPE)) , ...)| sock_kmalloc(HANDLE,- sizeof(TYPE) * COUNT_CONST+ array_size(COUNT_CONST, sizeof(TYPE)) , ...)| sock_kmalloc(HANDLE,- sizeof(THING) * (COUNT_ID)+ array_size(COUNT_ID, sizeof(THING)) , ...)| sock_kmalloc(HANDLE,- sizeof(THING) * COUNT_ID+ array_size(COUNT_ID, sizeof(THING)) , ...)| sock_kmalloc(HANDLE,- sizeof(THING) * (COUNT_CONST)+ array_size(COUNT_CONST, sizeof(THING)) , ...)| sock_kmalloc(HANDLE,- sizeof(THING) * COUNT_CONST+ array_size(COUNT_CONST, sizeof(THING)) , ...))// 2-factor product, only identifiers.@@expression HANDLE;identifier SIZE, COUNT;@@ sock_kmalloc(HANDLE,- SIZE * COUNT+ array_size(COUNT, SIZE) , ...)// 3-factor product with 1 sizeof(type) or sizeof(expression), with// redundant parens removed.@@expression HANDLE;expression THING;identifier STRIDE, COUNT;type TYPE;@@( sock_kmalloc(HANDLE,- sizeof(TYPE) * (COUNT) * (STRIDE)+ array3_size(COUNT, STRIDE, sizeof(TYPE)) , ...)| sock_kmalloc(HANDLE,- sizeof(TYPE) * (COUNT) * STRIDE+ array3_size(COUNT, STRIDE, sizeof(TYPE)) , ...)| sock_kmalloc(HANDLE,- sizeof(TYPE) * COUNT * (STRIDE)+ array3_size(COUNT, STRIDE, sizeof(TYPE)) , ...)| sock_kmalloc(HANDLE,- sizeof(TYPE) * COUNT * STRIDE+ array3_size(COUNT, STRIDE, sizeof(TYPE)) , ...)| sock_kmalloc(HANDLE,- sizeof(THING) * (COUNT) * (STRIDE)+ array3_size(COUNT, STRIDE, sizeof(THING)) , ...)| sock_kmalloc(HANDLE,- sizeof(THING) * (COUNT) * STRIDE+ array3_size(COUNT, STRIDE, sizeof(THING)) , ...)| sock_kmalloc(HANDLE,- sizeof(THING) * COUNT * (STRIDE)+ array3_size(COUNT, STRIDE, sizeof(THING)) , ...)| sock_kmalloc(HANDLE,- sizeof(THING) * COUNT * STRIDE+ array3_size(COUNT, STRIDE, sizeof(THING)) , ...))// 3-factor product with 2 sizeof(variable), with redundant parens removed.@@expression HANDLE;expression THING1, THING2;identifier COUNT;type TYPE1, TYPE2;@@( sock_kmalloc(HANDLE,- sizeof(TYPE1) * sizeof(TYPE2) * COUNT+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2)) , ...)| sock_kmalloc(HANDLE,- sizeof(TYPE1) * sizeof(THING2) * (COUNT)+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2)) , ...)| sock_kmalloc(HANDLE,- sizeof(THING1) * sizeof(THING2) * COUNT+ array3_size(COUNT, sizeof(THING1), sizeof(THING2)) , ...)| sock_kmalloc(HANDLE,- sizeof(THING1) * sizeof(THING2) * (COUNT)+ array3_size(COUNT, sizeof(THING1), sizeof(THING2)) , ...)| sock_kmalloc(HANDLE,- sizeof(TYPE1) * sizeof(THING2) * COUNT+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2)) , ...)| sock_kmalloc(HANDLE,- sizeof(TYPE1) * sizeof(THING2) * (COUNT)+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2)) , ...))// 3-factor product, only identifiers, with redundant parens removed.@@expression HANDLE;identifier STRIDE, SIZE, COUNT;@@( sock_kmalloc(HANDLE,- (COUNT) * STRIDE * SIZE+ array3_size(COUNT, STRIDE, SIZE) , ...)| sock_kmalloc(HANDLE,- COUNT * (STRIDE) * SIZE+ array3_size(COUNT, STRIDE, SIZE) , ...)| sock_kmalloc(HANDLE,- COUNT * STRIDE * (SIZE)+ array3_size(COUNT, STRIDE, SIZE) , ...)| sock_kmalloc(HANDLE,- (COUNT) * (STRIDE) * SIZE+ array3_size(COUNT, STRIDE, SIZE) , ...)| sock_kmalloc(HANDLE,- COUNT * (STRIDE) * (SIZE)+ array3_size(COUNT, STRIDE, SIZE) , ...)| sock_kmalloc(HANDLE,- (COUNT) * STRIDE * (SIZE)+ array3_size(COUNT, STRIDE, SIZE) , ...)| sock_kmalloc(HANDLE,- (COUNT) * (STRIDE) * (SIZE)+ array3_size(COUNT, STRIDE, SIZE) , ...)| sock_kmalloc(HANDLE,- COUNT * STRIDE * SIZE+ array3_size(COUNT, STRIDE, SIZE) , ...))// Any remaining multi-factor products, first at least 3-factor products// when they're not all constants...@@expression HANDLE;expression E1, E2, E3;constant C1, C2, C3;@@( sock_kmalloc(HANDLE, C1 * C2 * C3, ...)| sock_kmalloc(HANDLE,- E1 * E2 * E3+ array3_size(E1, E2, E3) , ...))// And then all remaining 2 factors products when they're not all constants.@@expression HANDLE;expression E1, E2;constant C1, C2;@@( sock_kmalloc(HANDLE, C1 * C2, ...)| sock_kmalloc(HANDLE,- E1 * E2+ array_size(E1, E2) , ...))Signed-off-by: Kees Cook List of files: /linux-6.15/crypto/algif_aead.c

b28fc822 - crypto: af_alg: convert to ->poll_mask

Thu, 11 Jan 2018 08:40:49 +0000

crypto: af_alg: convert to ->poll_maskSigned-off-by: Christoph Hellwig List of files: /linux-6.15/crypto/algif_aead.c

dc26c17f - crypto: aead - prevent using AEADs without setting key

Wed, 03 Jan 2018 19:16:30 +0000

crypto: aead - prevent using AEADs without setting keySimilar to what was done for the hash API, update the AEAD API to trackwhether each transform has been keyed, and reject encryption/decryptionif a key is needed but one hasn't been set.This isn't quite as important as the equivalent fix for the hash APIbecause AEADs always require a key, so are unlikely to be used withoutone. Still, tracking the key will prevent accidental unkeyed use.algif_aead also had to track the key anyway, so the new flag replacesthat and slightly simplifies the algif_aead implementation.Signed-off-by: Eric Biggers Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/algif_aead.c

3a2d4fb5 - crypto: null - Get rid of crypto_{get,put}_default_null_skcipher2()

Thu, 07 Dec 2017 18:56:34 +0000

crypto: null - Get rid of crypto_{get,put}_default_null_skcipher2()Since commit 499a66e6b689 ("crypto: null - Remove default nullblkcipher"), crypto_get_default_null_skcipher2() andcrypto_put_default_null_skcipher2() are the same as their non-2equivalents. So switch callers of the "2" versions over to the originalversions and remove the "2" versions.Signed-off-by: Eric Biggers Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/algif_aead.c

af955bf1 - crypto: af_alg - Fix race around ctx->rcvused by making it atomic_t

Tue, 19 Dec 2017 10:27:24 +0000

crypto: af_alg - Fix race around ctx->rcvused by making it atomic_tThis variable was increased and decreased without any protection.Result was an occasional misscount and negative wrap around resultingin false resource allocation failures.Fixes: 7d2c3f54e6f6 ("crypto: af_alg - remove locking in async callback")Signed-off-by: Jonathan Cameron Reviewed-by: Stephan Mueller Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/algif_aead.c

d53c5135 - crypto: af_alg - fix race accessing cipher request

Fri, 08 Dec 2017 10:50:37 +0000

crypto: af_alg - fix race accessing cipher requestWhen invoking an asynchronous cipher operation, the invocation of thecallback may be performed before the subsequent operations in theinitial code path are invoked. The callback deletes the cipher requestdata structure which implies that after the invocation of theasynchronous cipher operation, this data structure must not be accessedany more.The setting of the return code size with the request data structure musttherefore be moved before the invocation of the asynchronous cipheroperation.Fixes: e870456d8e7c ("crypto: algif_skcipher - overhaul memory management")Fixes: d887c52d6ae4 ("crypto: algif_aead - overhaul memory management")Reported-by: syzbot Cc: # v4.14+Signed-off-by: Stephan Mueller Acked-by: Jonathan Cameron Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/algif_aead.c

11edb555 - crypto: af_alg - wait for data at beginning of recvmsg

Wed, 29 Nov 2017 11:02:23 +0000

crypto: af_alg - wait for data at beginning of recvmsgThe wait for data is a non-atomic operation that can sleep and thereforepotentially release the socket lock. The release of the socket lockallows another thread to modify the context data structure. The waitingoperation for new data therefore must be called at the beginning ofrecvmsg. This prevents a race condition where checks of the members ofthe context data structure are performed by recvmsg while there is apotential for modification of these values.Fixes: e870456d8e7c ("crypto: algif_skcipher - overhaul memory management")Fixes: d887c52d6ae4 ("crypto: algif_aead - overhaul memory management")Reported-by: syzbot Cc: # v4.14+Signed-off-by: Stephan Mueller Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/algif_aead.c

b32a7dc8 - crypto: algif_aead - fix reference counting of null skcipher

Tue, 28 Nov 2017 07:23:05 +0000

crypto: algif_aead - fix reference counting of null skcipherIn the AEAD interface for AF_ALG, the reference to the "null skcipher"held by each tfm was being dropped in the wrong place -- when eachaf_alg_ctx was freed instead of when the aead_tfm was freed. Asdiscovered by syzkaller, a specially crafted program could use this tocause the null skcipher to be freed while it is still in use.Fix it by dropping the reference in the right place.Fixes: 72548b093ee3 ("crypto: algif_aead - copy AAD from src to dst")Reported-by: syzbot Cc: # v4.14+Signed-off-by: Eric Biggers Reviewed-by: Stephan Mueller Signed-off-by: Herbert Xu List of files: /linux-6.15/crypto/algif_aead.c