Changes in opal_proto.h

5429c8de - block: sed-opal: handle empty atoms when parsing response

Fri, 16 Feb 2024 21:04:17 +0000

block: sed-opal: handle empty atoms when parsing responseThe SED Opal response parsing function response_parse() does nothandle the case of an empty atom in the response. This causesthe entry count to be too high and the response fails to beparsed. Recognizing, but ignoring, empty atoms allows responsehandling to succeed.Signed-off-by: Greg Joyce Link: https://lore.kernel.org/r/20240216210417.3526064-2-gjoyce@linux.ibm.comSigned-off-by: Jens Axboe List of files: /linux-6.15/block/opal_proto.h

5c82efc1 - block: sed-opal: Implement IOC_OPAL_REVERT_LSP

Fri, 21 Jul 2023 21:15:33 +0000

block: sed-opal: Implement IOC_OPAL_REVERT_LSPThis is used in conjunction with IOC_OPAL_REVERT_TPR to return a drive toOriginal Factory State without erasing the data. If IOC_OPAL_REVERT_LSPis called with opal_revert_lsp.options bit OPAL_PRESERVE set priorto calling IOC_OPAL_REVERT_TPR, the drive global locking range will notbe erased.Signed-off-by: Greg Joyce Reviewed-by: Christoph Hellwig Reviewed-by: Jonathan Derrick Acked-by: Jarkko Sakkinen Link: https://lore.kernel.org/r/20230721211534.3437070-3-gjoyce@linux.vnet.ibm.comSigned-off-by: Jens Axboe List of files: /linux-6.15/block/opal_proto.h

8be19a02 - sed-opal: allow user authority to get locking range attributes.

Wed, 05 Apr 2023 11:12:21 +0000

sed-opal: allow user authority to get locking range attributes.Extend ACE set of locking range attributes accessible to userauthority. This patch allows user authority to get followinglocking range attribues when user get added to locking range viaIOC_OPAL_ADD_USR_TO_LR:locking range startlocking range endread lock enabledwrite lock enabledread lockedwrite lockedlock on resetactive keyNote: Admin1 authority always remains in the ACE. Otherwiseit breaks current userspace expecting Admin1 in the ACE (sedutils).See TCG OPAL2 s.4.3.1.7 "ACE_Locking_RangeNNNN_Get_RangeStartToActiveKey".Signed-off-by: Ondrej Kozina Tested-by: Luca Boccassi Tested-by: Milan Broz Acked-by: Christian Brauner Reviewed-by: Christoph Hellwig Link: https://lore.kernel.org/r/20230405111223.272816-4-okozina@redhat.comSigned-off-by: Jens Axboe List of files: /linux-6.15/block/opal_proto.h

175b6544 - sed-opal: add helper for adding user authorities in ACE.

Wed, 05 Apr 2023 11:12:20 +0000

sed-opal: add helper for adding user authorities in ACE.Move ACE construction away from add_user_to_lr routineand refactor it to be used also in later code.Also adds boolean operators defines from TCG Corespecification.Signed-off-by: Ondrej Kozina Tested-by: Luca Boccassi Tested-by: Milan Broz Link: https://lore.kernel.org/r/20230405111223.272816-3-okozina@redhat.comSigned-off-by: Jens Axboe List of files: /linux-6.15/block/opal_proto.h

c6ea7060 - block: sed-opal: Add ioctl to return device status

Tue, 16 Aug 2022 14:07:13 +0000

block: sed-opal: Add ioctl to return device statusProvide a mechanism to retrieve basic status information aboutthe device, including the "supported" flag indicating whetherSED-OPAL is supported. The information returned is from the variousfeature descriptors received during the discovery0 step, and sothis ioctl does nothing more than perform the discovery0 stepand then save the information received. See "struct opal_status"and OPAL_FL_* bits for the status information currently returned.This is necessary to be able to check whether a device is OPALenabled, set up, locked or unlocked from userspace programslike systemd-cryptsetup and libcryptsetup. Right now we justhave to assume the user 'knows' or blindly attempt setup/lock/unlockoperations.Signed-off-by: Douglas Miller Tested-by: Luca Boccassi Reviewed-by: Scott Bauer Acked-by: Christian Brauner (Microsoft) Link: https://lore.kernel.org/r/20220816140713.84893-1-luca.boccassi@gmail.comSigned-off-by: Jens Axboe List of files: /linux-6.15/block/opal_proto.h

88d6041d - block: sed-opal: Change the check condition for regular session validity

Tue, 03 Mar 2020 19:17:00 +0000

block: sed-opal: Change the check condition for regular session validityThis patch changes the check condition for the validity/authenticationof the session.1. The Host Session Number(HSN) in the response should match the HSN for the session.2. The TPER Session Number(TSN) can never be less than 4096 for a regular session.Reference:Section 3.2.2.1 of https://trustedcomputinggroup.org/wp-content/uploads/TCG_Storage_Opal_SSC_Application_Note_1-00_1-00-Final.pdfSection 3.3.7.1.1 of https://trustedcomputinggroup.org/wp-content/uploads/TCG_Storage_Architecture_Core_Spec_v2.01_r1.00.pdfCo-developed-by: Andrzej Jakowski Signed-off-by: Andrzej Jakowski Signed-off-by: Revanth Rajashekar Signed-off-by: Jens Axboe List of files: /linux-6.15/block/opal_proto.h

c6da429e - block: sed-opal: Introduce SUM_SET_LIST parameter and append it using 'add_token_u64'

Fri, 08 Nov 2019 23:09:04 +0000

block: sed-opal: Introduce SUM_SET_LIST parameter and append it using 'add_token_u64'In function 'activate_lsp', rather than hard-coding the short atomheader(0x83), we need to let the function 'add_short_atom_header' appendthe header based on the parameter being appended.The parameter has been defined in Section 3.1.2.1 ofhttps://trustedcomputinggroup.org/wp-content/uploads/TCG_Storage-Opal_Feature_Set_Single_User_Mode_v1-00_r1-00-Final.pdfReviewed-by: Jon Derrick Signed-off-by: Revanth Rajashekar Signed-off-by: Jens Axboe List of files: /linux-6.15/block/opal_proto.h

62c441c6 - block: sed-opal: Introduce Opal Datastore UID

Thu, 31 Oct 2019 16:13:22 +0000

block: sed-opal: Introduce Opal Datastore UIDThis patch introduces Opal Datastore UID.The generic read/write table ioctl can use this UIDto access the Opal Datastore.Reviewed-by: Scott Bauer Reviewed-by: Jon Derrick Signed-off-by: Revanth Rajashekar Signed-off-by: Jens Axboe List of files: /linux-6.15/block/opal_proto.h

51f421c8 - block: sed-opal: Add support to read/write opal tables generically

Thu, 31 Oct 2019 16:13:21 +0000

block: sed-opal: Add support to read/write opal tables genericallyThis feature gives the user RW access to any opal table with admin1authority. The flags described in the new structure determines if the userwants to read/write the data. Flags are checked for valid values inorder to allow future features to be added to the ioctl.The user can provide the desired table's UID. Also, the ioctl provides asize and offset field and internally will loop data accesses to returnthe full data block. Read overrun is prevented by the initiator'ssec_send_recv() backend. The ioctl provides a private field with theintention to accommodate any future expansions to the ioctl.Reviewed-by: Scott Bauer Reviewed-by: Jon Derrick Signed-off-by: Revanth Rajashekar Signed-off-by: Jens Axboe List of files: /linux-6.15/block/opal_proto.h

238bdcdf - block: sed-opal: Removed duplicate OPAL_METHOD_LENGTH definition

Tue, 20 Aug 2019 15:30:51 +0000

block: sed-opal: Removed duplicate OPAL_METHOD_LENGTH definitionThe original commit adding the sed-opal library by mistake added twodefinitions of OPAL_METHOD_LENGTH, remove one of them.Signed-off-by: Revanth Rajashekar Reviewed-by: Scott Bauer Reviewed-by: Jon Derrick Signed-off-by: Jens Axboe List of files: /linux-6.15/block/opal_proto.h

5cc23ed7 - block: sed-opal: Add/remove spaces

Tue, 20 Aug 2019 15:30:49 +0000

block: sed-opal: Add/remove spacesSigned-off-by: Revanth Rajashekar Reviewed-by: Scott Bauer Reviewed-by: Jon Derrick Signed-off-by: Jens Axboe List of files: /linux-6.15/block/opal_proto.h

ff91064e - block: sed-opal: check size of shadow mbr

Tue, 21 May 2019 20:46:46 +0000

block: sed-opal: check size of shadow mbrCheck whether the shadow mbr does fit in the provided space on thetarget. Also a proper firmware should handle this case and return anerror we may prevent problems or even damage with crappy firmwares.Signed-off-by: Jonas Rabenstein Signed-off-by: David Kozub Reviewed-by: Scott Bauer Reviewed-by: Jon Derrick Signed-off-by: Jens Axboe List of files: /linux-6.15/block/opal_proto.h

8c16567d - block: switch all files cleared marked as GPLv2 to SPDX tags

Tue, 30 Apr 2019 18:42:39 +0000

block: switch all files cleared marked as GPLv2 to SPDX tagsAll these files have some form of the usual GPLv2 boilerplate. Switchthem to use SPDX tags instead.Reviewed-by: Chaitanya Kulkarni Signed-off-by: Christoph Hellwig Signed-off-by: Jens Axboe List of files: /linux-6.15/block/opal_proto.h

a4ddbd1b - block: sed-opal: add token for OPAL_LIFECYCLE

Thu, 14 Feb 2019 00:16:03 +0000

block: sed-opal: add token for OPAL_LIFECYCLEDefine OPAL_LIFECYCLE token and use it instead of literals inget_lsp_lifecycle.Acked-by: Jon Derrick Reviewed-by: Christoph Hellwig Reviewed-by: Scott Bauer Signed-off-by: David Kozub Signed-off-by: Jens Axboe List of files: /linux-6.15/block/opal_proto.h

dbec491b - block: sed-opal: Set MBRDone on S3 resume path if TPER is MBREnabled

Fri, 01 Sep 2017 14:53:35 +0000

block: sed-opal: Set MBRDone on S3 resume path if TPER is MBREnabledUsers who are booting off their Opal enabled drives are havingissues when they have a shadow MBR set up after s3/resume cycle.When the Drive has a shadow MBR setup the MBRDone flag is set tofalse upon power loss (S3/S4/S5). When the MBRDone flag is falseI/O to LBA 0 -> LBA_END_MBR are remapped to the shadow mbrof the drive. If the drive contains useful data in the 0 -> end_mbrrange upon s3 resume the user can never get to that data as thedrive will keep remapping it to the MBR. To fix this when we unlockon S3 resume, we need to tell the drive that we're done with theshadow mbr (even though we didnt use it) by setting true to MBRDone.This way the drive will stop the remapping and the user can accesstheir data.Acked-by Jon Derrick: Signed-off-by: Scott Bauer Signed-off-by: Jens Axboe List of files: /linux-6.15/block/opal_proto.h

4f1244c8 - block/sed-opal: allocate struct opal_dev dynamically

Fri, 17 Feb 2017 12:59:39 +0000

block/sed-opal: allocate struct opal_dev dynamicallyInsted of bloating the containing structure with it all the time thisallocates struct opal_dev dynamically. Additionally this allows movingthe definition of struct opal_dev into sed-opal.c. For this a newprivate data field is added to it that is passed to the send/receivecallback. After that a lot of internals can be made private as well.Signed-off-by: Christoph Hellwig Tested-by: Scott Bauer Reviewed-by: Scott Bauer Signed-off-by: Jens Axboe List of files: /linux-6.15/block/opal_proto.h

455a7b23 - block: Add Sed-opal library

Fri, 03 Feb 2017 19:50:31 +0000

block: Add Sed-opal libraryThis patch implements the necessary logic to bring an Opalenabled drive out of a factory-enabled into a workingOpal state.This patch set also enables logic to save a password tobe replayed during a resume from suspend.Signed-off-by: Scott Bauer Signed-off-by: Rafael Antognolli Reviewed-by: Christoph Hellwig Signed-off-by: Jens Axboe List of files: /linux-6.15/block/opal_proto.h