Changes in debugfs.c

bcea31e2 - x86/xen: eliminate some private header files

Wed, 10 Jul 2024 09:37:18 +0000

x86/xen: eliminate some private header filesUnder arch/x86/xen there is one large private header file xen-ops.hcontaining most of the Xen-private x86 related declarations, and thenthere are several small headers with a handful of declarations each.Merge the small headers into xen-ops.h.While doing that, move the declaration of xen_fifo_events fromxen-ops.h into include/xen/events.h where it should have been from thebeginning.Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky Message-ID: <20240710093718.14552-3-jgross@suse.com>Signed-off-by: Juergen Gross List of files: /linux-6.15/arch/x86/xen/debugfs.c

ad091376 - x86: xen: no need to check return value of debugfs_create functions

Tue, 22 Jan 2019 14:35:42 +0000

x86: xen: no need to check return value of debugfs_create functionsWhen calling debugfs functions, there is no need to ever check thereturn value. The function can work or not, but the code logic shouldnever do something different based on this.Cc: Boris Ostrovsky Cc: Stefano Stabellini Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: "H. Peter Anvin" Cc: Cc: Reviewed-by: Juergen Gross Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/arch/x86/xen/debugfs.c

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/arch/x86/xen/debugfs.c

7a2463dc - x86/xen: Audit and remove any unnecessary uses of module.h

Thu, 14 Jul 2016 00:18:59 +0000

x86/xen: Audit and remove any unnecessary uses of module.hHistorically a lot of these existed because we did not havea distinction between what was modular code and what was providingsupport to modules via EXPORT_SYMBOL and friends. That changedwhen we forked out support for the latter into the export.h file.This means we should be able to reduce the usage of module.hin code that is obj-y Makefile or bool Kconfig. The advantagein doing so is that module.h itself sources about 15 other headers;adding significantly to what we feed cpp, and it can obscure whatheaders we are effectively using.Since module.h was the source for init.h (for __init) and forexport.h (for EXPORT_SYMBOL) we consider each obj-y/bool instancefor the presence of either and replace as needed.Signed-off-by: Paul Gortmaker Acked-by: Juergen Gross Cc: Boris Ostrovsky Cc: David Vrabel Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: xen-devel@lists.xenproject.orgLink: http://lkml.kernel.org/r/20160714001901.31603-7-paul.gortmaker@windriver.comSigned-off-by: Ingo Molnar List of files: /linux-6.15/arch/x86/xen/debugfs.c

9fe2a701 - debugfs: Add support to print u32 array in debugfs

Fri, 23 Mar 2012 08:06:28 +0000

debugfs: Add support to print u32 array in debugfsMove the code from Xen to debugfs to make the code commonfor other users as well.Accked-by: Greg Kroah-Hartman Signed-off-by: Srivatsa Vaddagiri Signed-off-by: Suzuki Poulose [v1: Fixed rebase issues][v2: Fixed PPC compile issues]Signed-off-by: Raghavendra K T Signed-off-by: Konrad Rzeszutek Wilk List of files: /linux-6.15/arch/x86/xen/debugfs.c

f4ae40a6 - switch debugfs to umode_t

Sun, 24 Jul 2011 08:33:43 +0000

switch debugfs to umode_tSigned-off-by: Al Viro List of files: /linux-6.15/arch/x86/xen/debugfs.c

6038f373 - llseek: automatically add .llseek fop

Sun, 15 Aug 2010 16:52:59 +0000

llseek: automatically add .llseek fopAll file_operations should get a .llseek operation so we can makenonseekable_open the default for future file operations without a.llseek pointer.The three cases that we can automatically detect are no_llseek, seq_lseekand default_llseek. For cases where we can we can automatically prove thatthe file offset is always ignored, we use noop_llseek, which maintainsthe current behavior of not returning an error from a seek.New drivers should normally not use noop_llseek but instead use no_llseekand call nonseekable_open at open time. Existing drivers can be convertedto do the same when the maintainer knows for certain that no user coderelies on calling seek on the device file.The generated code is often incorrectly indented and right now containscomments that clarify for each added line why a specific variant waschosen. In the version that gets submitted upstream, the comments willbe gone and I will manually fix the indentation, because there does notseem to be a way to do that using coccinelle.Some amount of new code is currently sitting in linux-next that should getthe same modifications, which I will do at the end of the merge window.Many thanks to Julia Lawall for helping me learn to write a semanticpatch that does all this.===== begin semantic patch =====// This adds an llseek= method to all file operations,// as a preparation for making no_llseek the default.//// The rules are// - use no_llseek explicitly if we do nonseekable_open// - use seq_lseek for sequential files// - use default_llseek if we know we access f_pos// - use noop_llseek if we know we don't access f_pos,// but we still want to allow users to call lseek//@ open1 exists @identifier nested_open;@@nested_open(...){<+...nonseekable_open(...)...+>}@ open exists@identifier open_f;identifier i, f;identifier open1.nested_open;@@int open_f(struct inode *i, struct file *f){<+...(nonseekable_open(...)|nested_open(...))...+>}@ read disable optional_qualifier exists @identifier read_f;identifier f, p, s, off;type ssize_t, size_t, loff_t;expression E;identifier func;@@ssize_t read_f(struct file *f, char *p, size_t s, loff_t *off){<+...( *off = E| *off += E| func(..., off, ...)| E = *off)...+>}@ read_no_fpos disable optional_qualifier exists @identifier read_f;identifier f, p, s, off;type ssize_t, size_t, loff_t;@@ssize_t read_f(struct file *f, char *p, size_t s, loff_t *off){... when != off}@ write @identifier write_f;identifier f, p, s, off;type ssize_t, size_t, loff_t;expression E;identifier func;@@ssize_t write_f(struct file *f, const char *p, size_t s, loff_t *off){<+...( *off = E| *off += E| func(..., off, ...)| E = *off)...+>}@ write_no_fpos @identifier write_f;identifier f, p, s, off;type ssize_t, size_t, loff_t;@@ssize_t write_f(struct file *f, const char *p, size_t s, loff_t *off){... when != off}@ fops0 @identifier fops;@@struct file_operations fops = { ...};@ has_llseek depends on fops0 @identifier fops0.fops;identifier llseek_f;@@struct file_operations fops = {... .llseek = llseek_f,...};@ has_read depends on fops0 @identifier fops0.fops;identifier read_f;@@struct file_operations fops = {... .read = read_f,...};@ has_write depends on fops0 @identifier fops0.fops;identifier write_f;@@struct file_operations fops = {... .write = write_f,...};@ has_open depends on fops0 @identifier fops0.fops;identifier open_f;@@struct file_operations fops = {... .open = open_f,...};// use no_llseek if we call nonseekable_open////////////////////////////////////////////@ nonseekable1 depends on !has_llseek && has_open @identifier fops0.fops;identifier nso ~= "nonseekable_open";@@struct file_operations fops = {... .open = nso, ...+.llseek = no_llseek, /* nonseekable */};@ nonseekable2 depends on !has_llseek @identifier fops0.fops;identifier open.open_f;@@struct file_operations fops = {... .open = open_f, ...+.llseek = no_llseek, /* open uses nonseekable */};// use seq_lseek for sequential files/////////////////////////////////////@ seq depends on !has_llseek @identifier fops0.fops;identifier sr ~= "seq_read";@@struct file_operations fops = {... .read = sr, ...+.llseek = seq_lseek, /* we have seq_read */};// use default_llseek if there is a readdir///////////////////////////////////////////@ fops1 depends on !has_llseek && !nonseekable1 && !nonseekable2 && !seq @identifier fops0.fops;identifier readdir_e;@@// any other fop is used that changes posstruct file_operations fops = {... .readdir = readdir_e, ...+.llseek = default_llseek, /* readdir is present */};// use default_llseek if at least one of read/write touches f_pos/////////////////////////////////////////////////////////////////@ fops2 depends on !fops1 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @identifier fops0.fops;identifier read.read_f;@@// read fops use offsetstruct file_operations fops = {... .read = read_f, ...+.llseek = default_llseek, /* read accesses f_pos */};@ fops3 depends on !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @identifier fops0.fops;identifier write.write_f;@@// write fops use offsetstruct file_operations fops = {... .write = write_f, ...+ .llseek = default_llseek, /* write accesses f_pos */};// Use noop_llseek if neither read nor write accesses f_pos///////////////////////////////////////////////////////////@ fops4 depends on !fops1 && !fops2 && !fops3 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @identifier fops0.fops;identifier read_no_fpos.read_f;identifier write_no_fpos.write_f;@@// write fops use offsetstruct file_operations fops = {... .write = write_f, .read = read_f,...+.llseek = noop_llseek, /* read and write both use no f_pos */};@ depends on has_write && !has_read && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @identifier fops0.fops;identifier write_no_fpos.write_f;@@struct file_operations fops = {... .write = write_f, ...+.llseek = noop_llseek, /* write uses no f_pos */};@ depends on has_read && !has_write && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @identifier fops0.fops;identifier read_no_fpos.read_f;@@struct file_operations fops = {... .read = read_f, ...+.llseek = noop_llseek, /* read uses no f_pos */};@ depends on !has_read && !has_write && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @identifier fops0.fops;@@struct file_operations fops = {...+.llseek = noop_llseek, /* no read or write fn */};===== End semantic patch =====Signed-off-by: Arnd Bergmann Cc: Julia Lawall Cc: Christoph Hellwig List of files: /linux-6.15/arch/x86/xen/debugfs.c

5a0e3ad6 - include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h

Wed, 24 Mar 2010 08:04:11 +0000

include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.hpercpu.h is included by sched.h and module.h and thus ends up beingincluded when building most .c files. percpu.h includes slab.h whichin turn includes gfp.h making everything defined by the two filesuniversally available and complicating inclusion dependencies.percpu.h -> slab.h dependency is about to be removed. Prepare forthis change by updating users of gfp and slab facilities include thoseheaders directly instead of assuming availability. As this conversionneeds to touch large number of source files, the following script isused as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.pyThe script does the followings.* Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h.* When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order.* If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file.The conversion was done in the following steps.1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files.2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files.3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind.4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually.5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary.6. percpu.h was updated not to include slab.h.7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point.Given the fact that I had only a couple of failures from tests on step6, I'm fairly confident about the coverage of this conversion patch.If there is a breakage, it's likely to be something in one of the archheaders which should be easily discoverable easily on most builds ofthe specific arch.Signed-off-by: Tejun Heo Guess-its-ok-by: Christoph Lameter Cc: Ingo Molnar Cc: Lee Schermerhorn List of files: /linux-6.15/arch/x86/xen/debugfs.c

828c0950 - const: constify remaining file_operations

Thu, 01 Oct 2009 22:43:56 +0000

const: constify remaining file_operations[akpm@linux-foundation.org: fix KVM]Signed-off-by: Alexey Dobriyan Acked-by: Mike Frysinger Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/arch/x86/xen/debugfs.c

994025ca - xen: add debugfs support

Thu, 21 Aug 2008 00:02:19 +0000

xen: add debugfs supportAdd support for exporting statistics on mmu updates, multicallbatching and pv spinlocks into debugfs. The base path is xen/ andeach subsystem adds its own directory: mmu, multicalls, spinlocks.In each directory, writing 1 to "zero_stats" will cause thecorresponding stats to be zeroed the next time they're updated.Signed-off-by: Jeremy Fitzhardinge Acked-by: Jan Beulich Signed-off-by: Ingo Molnar List of files: /linux-6.15/arch/x86/xen/debugfs.c