Changes in check.c

89f579ce - x86/headers: Fix -Wmissing-prototypes warning

Thu, 22 Nov 2018 02:04:09 +0000

x86/headers: Fix -Wmissing-prototypes warningWhen building the kernel with W=1 we get a lot of -Wmissing-prototypeswarnings, which are trivial in nature and easy to fix - and which maymask some real future bugs if the prototypes get out of sync withthe function definition.This patch fixes most of -Wmissing-prototypes warnings whichare in the root directory of arch/x86/kernel, not includingthe subdirectories.These are the warnings fixed in this patch: arch/x86/kernel/signal.c:865:17: warning: no previous prototype for ‘sys32_x32_rt_sigreturn’ [-Wmissing-prototypes] arch/x86/kernel/signal_compat.c:164:6: warning: no previous prototype for ‘sigaction_compat_abi’ [-Wmissing-prototypes] arch/x86/kernel/traps.c:625:46: warning: no previous prototype for ‘sync_regs’ [-Wmissing-prototypes] arch/x86/kernel/traps.c:640:24: warning: no previous prototype for ‘fixup_bad_iret’ [-Wmissing-prototypes] arch/x86/kernel/traps.c:929:13: warning: no previous prototype for ‘trap_init’ [-Wmissing-prototypes] arch/x86/kernel/irq.c:270:28: warning: no previous prototype for ‘smp_x86_platform_ipi’ [-Wmissing-prototypes] arch/x86/kernel/irq.c:301:16: warning: no previous prototype for ‘smp_kvm_posted_intr_ipi’ [-Wmissing-prototypes] arch/x86/kernel/irq.c:314:16: warning: no previous prototype for ‘smp_kvm_posted_intr_wakeup_ipi’ [-Wmissing-prototypes] arch/x86/kernel/irq.c:328:16: warning: no previous prototype for ‘smp_kvm_posted_intr_nested_ipi’ [-Wmissing-prototypes] arch/x86/kernel/irq_work.c:16:28: warning: no previous prototype for ‘smp_irq_work_interrupt’ [-Wmissing-prototypes] arch/x86/kernel/irqinit.c:79:13: warning: no previous prototype for ‘init_IRQ’ [-Wmissing-prototypes] arch/x86/kernel/quirks.c:672:13: warning: no previous prototype for ‘early_platform_quirks’ [-Wmissing-prototypes] arch/x86/kernel/tsc.c:1499:15: warning: no previous prototype for ‘calibrate_delay_is_known’ [-Wmissing-prototypes] arch/x86/kernel/process.c:653:13: warning: no previous prototype for ‘arch_post_acpi_subsys_init’ [-Wmissing-prototypes] arch/x86/kernel/process.c:717:15: warning: no previous prototype for ‘arch_randomize_brk’ [-Wmissing-prototypes] arch/x86/kernel/process.c:784:6: warning: no previous prototype for ‘do_arch_prctl_common’ [-Wmissing-prototypes] arch/x86/kernel/reboot.c:869:6: warning: no previous prototype for ‘nmi_panic_self_stop’ [-Wmissing-prototypes] arch/x86/kernel/smp.c:176:27: warning: no previous prototype for ‘smp_reboot_interrupt’ [-Wmissing-prototypes] arch/x86/kernel/smp.c:260:28: warning: no previous prototype for ‘smp_reschedule_interrupt’ [-Wmissing-prototypes] arch/x86/kernel/smp.c:281:28: warning: no previous prototype for ‘smp_call_function_interrupt’ [-Wmissing-prototypes] arch/x86/kernel/smp.c:291:28: warning: no previous prototype for ‘smp_call_function_single_interrupt’ [-Wmissing-prototypes] arch/x86/kernel/ftrace.c:840:6: warning: no previous prototype for ‘arch_ftrace_update_trampoline’ [-Wmissing-prototypes] arch/x86/kernel/ftrace.c:934:7: warning: no previous prototype for ‘arch_ftrace_trampoline_func’ [-Wmissing-prototypes] arch/x86/kernel/ftrace.c:946:6: warning: no previous prototype for ‘arch_ftrace_trampoline_free’ [-Wmissing-prototypes] arch/x86/kernel/crash.c:114:6: warning: no previous prototype for ‘crash_smp_send_stop’ [-Wmissing-prototypes] arch/x86/kernel/crash.c:351:5: warning: no previous prototype for ‘crash_setup_memmap_entries’ [-Wmissing-prototypes] arch/x86/kernel/crash.c:424:5: warning: no previous prototype for ‘crash_load_segments’ [-Wmissing-prototypes] arch/x86/kernel/machine_kexec_64.c:372:7: warning: no previous prototype for ‘arch_kexec_kernel_image_load’ [-Wmissing-prototypes] arch/x86/kernel/paravirt-spinlocks.c:12:16: warning: no previous prototype for ‘__native_queued_spin_unlock’ [-Wmissing-prototypes] arch/x86/kernel/paravirt-spinlocks.c:18:6: warning: no previous prototype for ‘pv_is_native_spin_unlock’ [-Wmissing-prototypes] arch/x86/kernel/paravirt-spinlocks.c:24:16: warning: no previous prototype for ‘__native_vcpu_is_preempted’ [-Wmissing-prototypes] arch/x86/kernel/paravirt-spinlocks.c:30:6: warning: no previous prototype for ‘pv_is_native_vcpu_is_preempted’ [-Wmissing-prototypes] arch/x86/kernel/kvm.c:258:1: warning: no previous prototype for ‘do_async_page_fault’ [-Wmissing-prototypes] arch/x86/kernel/jailhouse.c:200:6: warning: no previous prototype for ‘jailhouse_paravirt’ [-Wmissing-prototypes] arch/x86/kernel/check.c:91:13: warning: no previous prototype for ‘setup_bios_corruption_check’ [-Wmissing-prototypes] arch/x86/kernel/check.c:139:6: warning: no previous prototype for ‘check_for_bios_corruption’ [-Wmissing-prototypes] arch/x86/kernel/devicetree.c:32:13: warning: no previous prototype for ‘early_init_dt_scan_chosen_arch’ [-Wmissing-prototypes] arch/x86/kernel/devicetree.c:42:13: warning: no previous prototype for ‘add_dtb’ [-Wmissing-prototypes] arch/x86/kernel/devicetree.c:108:6: warning: no previous prototype for ‘x86_of_pci_init’ [-Wmissing-prototypes] arch/x86/kernel/devicetree.c:314:13: warning: no previous prototype for ‘x86_dtb_init’ [-Wmissing-prototypes] arch/x86/kernel/tracepoint.c:16:5: warning: no previous prototype for ‘trace_pagefault_reg’ [-Wmissing-prototypes] arch/x86/kernel/tracepoint.c:22:6: warning: no previous prototype for ‘trace_pagefault_unreg’ [-Wmissing-prototypes] arch/x86/kernel/head64.c:113:22: warning: no previous prototype for ‘__startup_64’ [-Wmissing-prototypes] arch/x86/kernel/head64.c:262:15: warning: no previous prototype for ‘__startup_secondary_64’ [-Wmissing-prototypes] arch/x86/kernel/head64.c:350:12: warning: no previous prototype for ‘early_make_pgtable’ [-Wmissing-prototypes][ mingo: rewrote the changelog, fixed build errors. ]Signed-off-by: Yi Wang Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: akataria@vmware.comCc: akpm@linux-foundation.orgCc: andy.shevchenko@gmail.comCc: anton@enomsg.orgCc: ard.biesheuvel@linaro.orgCc: bhe@redhat.comCc: bhelgaas@google.comCc: bp@alien8.deCc: ccross@android.comCc: devicetree@vger.kernel.orgCc: douly.fnst@cn.fujitsu.comCc: dwmw@amazon.co.ukCc: dyoung@redhat.comCc: ebiederm@xmission.comCc: frank.rowand@sony.comCc: frowand.list@gmail.comCc: ivan.gorinov@intel.comCc: jailhouse-dev@googlegroups.comCc: jan.kiszka@siemens.comCc: jgross@suse.comCc: jroedel@suse.deCc: keescook@chromium.orgCc: kexec@lists.infradead.orgCc: konrad.wilk@oracle.comCc: kvm@vger.kernel.orgCc: linux-efi@vger.kernel.orgCc: linux-pci@vger.kernel.orgCc: luto@kernel.orgCc: m.mizuma@jp.fujitsu.comCc: namit@vmware.comCc: oleg@redhat.comCc: pasha.tatashin@oracle.comCc: pbonzini@redhat.comCc: prarit@redhat.comCc: pravin.shedge4linux@gmail.comCc: rajvi.jingar@intel.comCc: rkrcmar@redhat.comCc: robh+dt@kernel.orgCc: robh@kernel.orgCc: rostedt@goodmis.orgCc: takahiro.akashi@linaro.orgCc: thomas.lendacky@amd.comCc: tony.luck@intel.comCc: up2wing@gmail.comCc: virtualization@lists.linux-foundation.orgCc: zhe.he@windriver.comCc: zhong.weidong@zte.com.cnLink: http://lkml.kernel.org/r/1542852249-19820-1-git-send-email-wang.yi59@zte.com.cnSigned-off-by: Ingo Molnar List of files: /linux-6.15/arch/x86/kernel/check.c

b1e3a25f - x86/corruption-check: Use pr_*() instead of printk()

Tue, 14 Aug 2018 15:33:43 +0000

x86/corruption-check: Use pr_*() instead of printk()pr_*() is the preferred style.Signed-off-by: He Zhe Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: gregkh@linuxfoundation.orgCc: kstewart@linuxfoundation.orgCc: pombredanne@nexb.comLink: http://lkml.kernel.org/r/1534260823-87917-2-git-send-email-zhe.he@windriver.com[ Moved all console output into a single line. ]Signed-off-by: Ingo Molnar List of files: /linux-6.15/arch/x86/kernel/check.c

ccde460b - x86/corruption-check: Fix panic in memory_corruption_check() when boot option without value is provided

Tue, 14 Aug 2018 15:33:42 +0000

x86/corruption-check: Fix panic in memory_corruption_check() when boot option without value is providedmemory_corruption_check[{_period|_size}]()'s handlers do not check inputargument before passing it to kstrtoul() or simple_strtoull(). The argumentwould be a NULL pointer if each of the kernel parameters, without itsvalue, is set in command line and thus cause the following panic.PANIC: early exception 0xe3 IP 10:ffffffff73587c22 error 0 cr2 0x0[ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 4.18-rc8+ #2[ 0.000000] RIP: 0010:kstrtoull+0x2/0x10...[ 0.000000] Call Trace[ 0.000000] ? set_corruption_check+0x21/0x49[ 0.000000] ? do_early_param+0x4d/0x82[ 0.000000] ? parse_args+0x212/0x330[ 0.000000] ? rdinit_setup+0x26/0x26[ 0.000000] ? parse_early_options+0x20/0x23[ 0.000000] ? rdinit_setup+0x26/0x26[ 0.000000] ? parse_early_param+0x2d/0x39[ 0.000000] ? setup_arch+0x2f7/0xbf4[ 0.000000] ? start_kernel+0x5e/0x4c2[ 0.000000] ? load_ucode_bsp+0x113/0x12f[ 0.000000] ? secondary_startup_64+0xa5/0xb0This patch adds checks to prevent the panic.Signed-off-by: He Zhe Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: gregkh@linuxfoundation.orgCc: kstewart@linuxfoundation.orgCc: pombredanne@nexb.comCc: stable@vger.kernel.orgLink: http://lkml.kernel.org/r/1534260823-87917-1-git-send-email-zhe.he@windriver.comSigned-off-by: Ingo Molnar List of files: /linux-6.15/arch/x86/kernel/check.c

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/arch/x86/kernel/check.c

13fe86f4 - x86/mm: Make kernel/check.c explicitly non-modular

Mon, 24 Aug 2015 23:34:55 +0000

x86/mm: Make kernel/check.c explicitly non-modularThe Kconfig currently controlling compilation of this code is: arch/x86/Kconfig:config X86_CHECK_BIOS_CORRUPTION arch/x86/Kconfig: bool "Check for low memory corruption"...meaning that it currently is not being built as a module byanyone.Lets remove the couple traces of modularity so that when readingthe code there is no doubt it is builtin-only.Since module_init translates to device_initcall in thenon-modular case, the init ordering remains unchanged with thiscommit.Signed-off-by: Paul Gortmaker Cc: H. Peter Anvin Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/1440459295-21814-4-git-send-email-paul.gortmaker@windriver.comSigned-off-by: Ingo Molnar List of files: /linux-6.15/arch/x86/kernel/check.c

fc6daaf9 - mm/memblock: add extra "flags" to memblock to allow selection of memory based on attribute

Wed, 24 Jun 2015 23:58:09 +0000

mm/memblock: add extra "flags" to memblock to allow selection of memory based on attributeSome high end Intel Xeon systems report uncorrectable memory errors as arecoverable machine check. Linux has included code for some time toprocess these and just signal the affected processes (or even recovercompletely if the error was in a read only page that can be replaced byreading from disk).But we have no recovery path for errors encountered during kernel codeexecution. Except for some very specific cases were are unlikely to everbe able to recover.Enter memory mirroring. Actually 3rd generation of memory mirroing.Gen1: All memory is mirrored Pro: No s/w enabling - h/w just gets good data from other side of the mirror Con: Halves effective memory capacity available to OS/applicationsGen2: Partial memory mirror - just mirror memory begind some memory controllers Pro: Keep more of the capacity Con: Nightmare to enable. Have to choose between allocating from mirrored memory for safety vs. NUMA local memory for performanceGen3: Address range partial memory mirror - some mirror on each memory controller Pro: Can tune the amount of mirror and keep NUMA performance Con: I have to write memory management code to implementThe current plan is just to use mirrored memory for kernel allocations.This has been broken into two phases:1) This patch series - find the mirrored memory, use it for boot time allocations2) Wade into mm/page_alloc.c and define a ZONE_MIRROR to pick up the unused mirrored memory from mm/memblock.c and only give it out to select kernel allocations (this is still being scoped because page_alloc.c is scary).This patch (of 3):Add extra "flags" to memblock to allow selection of memory based onattribute. No functional changesSigned-off-by: Tony Luck Cc: Xishi Qiu Cc: Hanjun Guo Cc: Xiexiuqi Cc: Ingo Molnar Cc: Thomas Gleixner Cc: "H. Peter Anvin" Cc: Yinghai Lu Cc: Naoya Horiguchi Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/arch/x86/kernel/check.c

9a28f9dc - x86/mm: memblock: switch to use NUMA_NO_NODE

Tue, 21 Jan 2014 23:50:53 +0000

x86/mm: memblock: switch to use NUMA_NO_NODEUpdate X86 code to use NUMA_NO_NODE instead of MAX_NUMNODES whilecalling memblock APIs, because memblock API will be changed to useNUMA_NO_NODE and will produce warning during boot otherwise.See: https://lkml.org/lkml/2013/12/9/898Signed-off-by: Grygorii Strashko Cc: Santosh Shilimkar Cc: Stephen Rothwell Cc: Tejun Heo Cc: Yinghai Lu Acked-by: David Rientjes Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/arch/x86/kernel/check.c

5abe68e4 - x86: kernel/check.c simple_strtoul cleanup

Sun, 06 May 2012 17:55:08 +0000

x86: kernel/check.c simple_strtoul cleanupChange set_corruption_check() and set_corruption_check_period()in kernel/check.c to call kstrtoul() instead of callingobsoleted simple_strtoul().Signed-off-by: Shuah Khan Link: http://lkml.kernel.org/r/1336326908.2897.12.camel@lorien2Signed-off-by: H. Peter Anvin List of files: /linux-6.15/arch/x86/kernel/check.c

24aa0788 - memblock, x86: Replace memblock_x86_reserve/free_range() with generic ones

Tue, 12 Jul 2011 09:16:06 +0000

memblock, x86: Replace memblock_x86_reserve/free_range() with generic onesOther than sanity check and debug message, the x86 specific version ofmemblock reserve/free functions are simple wrappers around the genericversions - memblock_reserve/free().This patch adds debug messages with caller identification to thegeneric versions and replaces x86 specific ones and kills them.arch/x86/include/asm/memblock.h and arch/x86/mm/memblock.c are emptyafter this change and removed.Signed-off-by: Tejun Heo Link: http://lkml.kernel.org/r/1310462166-31469-14-git-send-email-tj@kernel.orgCc: Yinghai Lu Cc: Benjamin Herrenschmidt Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Signed-off-by: H. Peter Anvin List of files: /linux-6.15/arch/x86/kernel/check.c

8d89ac80 - x86: Replace memblock_x86_find_in_range_size() with for_each_free_mem_range()

Tue, 12 Jul 2011 09:16:00 +0000

x86: Replace memblock_x86_find_in_range_size() with for_each_free_mem_range()setup_bios_corruption_check() and memtest do_one_pass() open codememblock free area iteration using memblock_x86_find_in_range_size().Convert them to use for_each_free_mem_range() instead.This leaves memblock_x86_find_in_range_size() andmemblock_x86_check_reserved_size() unused. Kill them.Signed-off-by: Tejun Heo Link: http://lkml.kernel.org/r/1310462166-31469-8-git-send-email-tj@kernel.orgCc: Yinghai Lu Cc: Benjamin Herrenschmidt Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Signed-off-by: H. Peter Anvin List of files: /linux-6.15/arch/x86/kernel/check.c

1f5026a7 - memblock: Kill MEMBLOCK_ERROR

Tue, 12 Jul 2011 07:58:09 +0000

memblock: Kill MEMBLOCK_ERROR25818f0f28 (memblock: Make MEMBLOCK_ERROR be 0) thankfully madeMEMBLOCK_ERROR 0 and there already are codes which expect error returnto be 0. There's no point in keeping MEMBLOCK_ERROR around. End itsmisery.Signed-off-by: Tejun Heo Link: http://lkml.kernel.org/r/1310457490-3356-6-git-send-email-tj@kernel.orgCc: Yinghai Lu Cc: Benjamin Herrenschmidt Signed-off-by: H. Peter Anvin List of files: /linux-6.15/arch/x86/kernel/check.c

a7bd1daf - x86: Don't check for BIOS corruption in first 64K when there's no need to

Fri, 25 Feb 2011 20:31:55 +0000

x86: Don't check for BIOS corruption in first 64K when there's no need toDue to commit 781c5a67f152c17c3e4a9ed9647f8c0be6ea5ae9 it islikely that the number of areas to scan for BIOS corruption is 0 -- especially when the first 64K is already reserved(X86_RESERVE_LOW is 64K by default).If that's the case then don't set up the scan.Signed-off-by: Naga Chumbalkar Cc: LKML-Reference: <20110225202838.2229.71011.sendpatchset@nchumbalkar.americas.hpqcorp.net>Signed-off-by: Ingo Molnar List of files: /linux-6.15/arch/x86/kernel/check.c

72d7c3b3 - x86: Use memblock to replace early_res

Wed, 25 Aug 2010 20:39:17 +0000

x86: Use memblock to replace early_res1. replace find_e820_area with memblock_find_in_range2. replace reserve_early with memblock_x86_reserve_range3. replace free_early with memblock_x86_free_range.4. NO_BOOTMEM will switch to use memblock too.5. use _e820, _early wrap in the patch, in following patch, will replace them all6. because memblock_x86_free_range support partial free, we can remove some special care7. Need to make sure that memblock_find_in_range() is called after memblock_x86_fill() so adjust some calling later in setup.c::setup_arch() -- corruption_check and mptable_update-v2: Move reserve_brk() early Before fill_memblock_area, to avoid overlap between brk and memblock_find_in_range() that could happen We have more then 128 RAM entry in E820 tables, and memblock_x86_fill() could use memblock_find_in_range() to find a new place for memblock.memory.region array. and We don't need to use extend_brk() after fill_memblock_area() So move reserve_brk() early before fill_memblock_area().-v3: Move find_smp_config early To make sure memblock_find_in_range not find wrong place, if BIOS doesn't put mptable in right place.-v4: Treat RESERVED_KERN as RAM in memblock.memory. and they are already in memblock.reserved already.. use __NOT_KEEP_MEMBLOCK to make sure memblock related code could be freed later.-v5: Generic version __memblock_find_in_range() is going from high to low, and for 32bit active_region for 32bit does include high pages need to replace the limit with memblock.default_alloc_limit, aka get_max_mapped()-v6: Use current_limit instead-v7: check with MEMBLOCK_ERROR instead of -1ULL or -1L-v8: Set memblock_can_resize early to handle EFI with more RAM entries-v9: update after kmemleak changes in mainlineSuggested-by: David S. Miller Suggested-by: Benjamin Herrenschmidt Suggested-by: Thomas Gleixner Signed-off-by: Yinghai Lu Signed-off-by: H. Peter Anvin List of files: /linux-6.15/arch/x86/kernel/check.c

6d7942dc - x86: fix 64k corruption-check

Sat, 14 Mar 2009 21:32:41 +0000

x86: fix 64k corruption-checkImpact: fix boot crashNeed to exit early if the addr is far above 64k.The crash got exposed by: 78a8b35: x86: make e820_update_range() handle small range updateSigned-off-by: Yinghai Lu Cc: LKML-Reference: <49BC2279.2030101@kernel.org>Signed-off-by: Ingo Molnar List of files: /linux-6.15/arch/x86/kernel/check.c

5c0e6f03 - x86: fix code paths used by update_mptable

Thu, 12 Mar 2009 13:07:23 +0000

x86: fix code paths used by update_mptableImpact: fix crashes under Xen due to unrobust e820 codefind_e820_area_size() must return a properly distinguishable andout-of-bounds value when it fails, and -1UL does not meet thatcriteria on i386/PAE. Additionally, callers of the function mustcheck against that value.early_reserve_e820() should be prepared for the region found to beoutside of the addressable range on 32-bits.e820_update_range_map() should not blindly update e820, but should doall it work on the map it got a pointer passed for (which in 50% of thecases is &e820_saved). It must also not call e820_add_region(), as thatagain acts on e820 unconditionally.The issues were found when trying to make this option work in our Xenkernel (i.e. where some of the silent assumptions made in the codewould not hold).Signed-off-by: Jan Beulich LKML-Reference: <49B9171B.76E4.0078.0@novell.com>Signed-off-by: Ingo Molnar List of files: /linux-6.15/arch/x86/kernel/check.c

b43d196c - x86: corruption-check: some post-move cleanups

Sun, 05 Oct 2008 19:21:32 +0000

x86: corruption-check: some post-move cleanupsImpact: cleanupnow that the code is moved and converted to a work queue,there's some minor cleanups that can be done.Signed-off-by: Arjan van de Ven Signed-off-by: Ingo Molnar List of files: /linux-6.15/arch/x86/kernel/check.c

304e629b - x86: corruption check: run the corruption checks from a work queue

Sun, 05 Oct 2008 19:09:03 +0000

x86: corruption check: run the corruption checks from a work queueImpact: change the implementation of the debug featurethe periodic corruption checks are better off run from a work queue; there'snothing time critical about them and this way the amount ofinterrupt-context work is reduced.Signed-off-by: Arjan van de Ven Signed-off-by: Ingo Molnar List of files: /linux-6.15/arch/x86/kernel/check.c

6784f7d0 - x86: corruption check: move the corruption checks into their own file

Sun, 05 Oct 2008 18:33:42 +0000

x86: corruption check: move the corruption checks into their own fileImpact: cleanupThe corruption check code is rather sizable and it's likely to grow overtime when we add checks for more types of corruptions (there's a fewcandidates in kerneloops.org that I want to add checks for)... so lets moveit to its own fileSigned-off-by: Arjan van de Ven Signed-off-by: Ingo Molnar List of files: /linux-6.15/arch/x86/kernel/check.c