Changes in Makefile

127b0e05 - vdso: Rename included Makefile

Tue, 04 Feb 2025 12:05:36 +0000

vdso: Rename included MakefileAs the Makefile is included into other Makefiles it can not be used todefine objects to be built from the current source directory.However the generic datastore will introduce such a local source file.Rename the included Makefile so it is clear how it is to be used and tomake room for a regular Makefile in lib/vdso/.Signed-off-by: Thomas Weißschuh Signed-off-by: Thomas Gleixner Link: https://lore.kernel.org/all/20250204-vdso-store-rng-v3-4-13a4669dfc8c@linutronix.de List of files: /linux-6.15/arch/s390/kernel/vdso32/Makefile

7f7f6f7a - Makefile: remove redundant tool coverage variables

Mon, 06 May 2024 13:35:43 +0000

Makefile: remove redundant tool coverage variablesNow Kbuild provides reasonable defaults for objtool, sanitizers, andprofilers.Remove redundant variables.Note:This commit changes the coverage for some objects: - include arch/mips/vdso/vdso-image.o into UBSAN, GCOV, KCOV - include arch/sparc/vdso/vdso-image-*.o into UBSAN - include arch/sparc/vdso/vma.o into UBSAN - include arch/x86/entry/vdso/extable.o into KASAN, KCSAN, UBSAN, GCOV, KCOV - include arch/x86/entry/vdso/vdso-image-*.o into KASAN, KCSAN, UBSAN, GCOV, KCOV - include arch/x86/entry/vdso/vdso32-setup.o into KASAN, KCSAN, UBSAN, GCOV, KCOV - include arch/x86/entry/vdso/vma.o into GCOV, KCOV - include arch/x86/um/vdso/vma.o into KASAN, GCOV, KCOVI believe these are positive effects because all of them are kernelspace objects.Signed-off-by: Masahiro Yamada Reviewed-by: Kees Cook Tested-by: Roberto Sassu List of files: /linux-6.15/arch/s390/kernel/vdso32/Makefile

185445c7 - s390/vdso: Use standard stack frame layout

Mon, 29 Apr 2024 12:28:43 +0000

s390/vdso: Use standard stack frame layoutBy default user space is compiled with standard stack frame layout and notwith the packed stack layout. The vdso code however inherited the-mpacked-stack compiler option from the kernel. Remove this option to makesure the vdso is compiled with standard stack frame layout.This makes sure that the stack frame backchain location for vdso generatedstack frames is the same like for calling code (if compiled with defaultoptions). This allows to manually walk stack frames without DWARFinformation, like the kernel is doing it e.g. with arch_stack_walk_user().Fixes: 4bff8cb54502 ("s390: convert to GENERIC_VDSO")Reviewed-by: Jens Remus Signed-off-by: Heiko Carstens Signed-off-by: Alexander Gordeev List of files: /linux-6.15/arch/s390/kernel/vdso32/Makefile

10f70525 - s390/vdso: Generate unwind information for C modules

Mon, 29 Apr 2024 15:02:52 +0000

s390/vdso: Generate unwind information for C modulesGDB fails to unwind vDSO functions with error message "PC not saved",for instance when stepping through gettimeofday().Add -fasynchronous-unwind-tables to CFLAGS to generate .eh_frameDWARF unwind information for the vDSO C modules.Fixes: 4bff8cb54502 ("s390: convert to GENERIC_VDSO")Signed-off-by: Jens Remus Signed-off-by: Alexander Gordeev List of files: /linux-6.15/arch/s390/kernel/vdso32/Makefile

b1992c37 - kbuild: use $(src) instead of $(srctree)/$(src) for source directory

Sat, 27 Apr 2024 14:55:02 +0000

kbuild: use $(src) instead of $(srctree)/$(src) for source directoryKbuild conventionally uses $(obj)/ for generated files, and $(src)/ forchecked-in source files. It is merely a convention without any functionaldifference. In fact, $(obj) and $(src) are exactly the same, as definedin scripts/Makefile.build: src := $(obj)When the kernel is built in a separate output directory, $(src) doesnot accurately reflect the source directory location. While Kbuildresolves this discrepancy by specifying VPATH=$(srctree) to search forsource files, it does not cover all cases. For example, when adding aheader search path for local headers, -I$(srctree)/$(src) is typicallypassed to the compiler.This introduces inconsistency between upstream and downstream Makefilesbecause $(src) is used instead of $(srctree)/$(src) for the latter.To address this inconsistency, this commit changes the semantics of$(src) so that it always points to the directory in the source tree.Going forward, the variables used in Makefiles will have the followingmeanings: $(obj) - directory in the object tree $(src) - directory in the source tree (changed by this commit) $(objtree) - the top of the kernel object tree $(srctree) - the top of the kernel source treeConsequently, $(srctree)/$(src) in upstream Makefiles need to be replacedwith $(src).Signed-off-by: Masahiro Yamada Reviewed-by: Nicolas Schier List of files: /linux-6.15/arch/s390/kernel/vdso32/Makefile

b957df3b - arch: use $(obj)/ instead of $(src)/ for preprocessed linker scripts

Sat, 27 Apr 2024 14:54:59 +0000

arch: use $(obj)/ instead of $(src)/ for preprocessed linker scriptsThese are generated files. Prefix them with $(obj)/ instead of $(src)/.Signed-off-by: Masahiro Yamada Acked-by: Helge Deller Reviewed-by: Nicolas Schier List of files: /linux-6.15/arch/s390/kernel/vdso32/Makefile

0628c039 - s390/vdso: drop '-fPIC' from LDFLAGS

Wed, 31 Jan 2024 03:14:28 +0000

s390/vdso: drop '-fPIC' from LDFLAGS'-fPIC' as an option to the linker does not do what it seems like itshould. With ld.bfd, it is treated as '-f PIC', which does not makesense based on the meaning of '-f': -f SHLIB, --auxiliary SHLIB Auxiliary filter for shared object symbol tableWhen building with ld.lld (currently under review in a GitHub pullrequest), it just errors out because '-f' means nothing and neither does'-fPIC': ld.lld: error: unknown argument '-fPIC''-fPIC' was blindly copied from CFLAGS when the vDSO stopped beinglinked with '$(CC)', it should not be needed. Remove it to clear up thebuild failure with ld.lld.Fixes: 2b2a25845d53 ("s390/vdso: Use $(LD) instead of $(CC) to link vDSO")Link: https://github.com/llvm/llvm-project/pull/75643Signed-off-by: Nathan Chancellor Reviewed-by: Fangrui Song Link: https://lore.kernel.org/r/20240130-s390-vdso-drop-fpic-from-ldflags-v1-1-094ad104fc55@kernel.orgSigned-off-by: Heiko Carstens List of files: /linux-6.15/arch/s390/kernel/vdso32/Makefile

56769ba4 - kbuild: unify vdso_install rules

Sat, 14 Oct 2023 10:54:35 +0000

kbuild: unify vdso_install rulesCurrently, there is no standard implementation for vdso_install,leading to various issues: 1. Code duplication Many architectures duplicate similar code just for copying files to the install destination. Some architectures (arm, sparc, x86) create build-id symlinks, introducing more code duplication. 2. Unintended updates of in-tree build artifacts The vdso_install rule depends on the vdso files to install. It may update in-tree build artifacts. This can be problematic, as explained in commit 19514fc665ff ("arm, kbuild: make "make install" not depend on vmlinux"). 3. Broken code in some architectures Makefile code is often copied from one architecture to another without proper adaptation. 'make vdso_install' for parisc does not work. 'make vdso_install' for s390 installs vdso64, but not vdso32.To address these problems, this commit introduces a generic vdso_installrule.Architectures that support vdso_install need to define vdso-install-yin arch/*/Makefile. vdso-install-y lists the files to install.For example, arch/x86/Makefile looks like this: vdso-install-$(CONFIG_X86_64) += arch/x86/entry/vdso/vdso64.so.dbg vdso-install-$(CONFIG_X86_X32_ABI) += arch/x86/entry/vdso/vdsox32.so.dbg vdso-install-$(CONFIG_X86_32) += arch/x86/entry/vdso/vdso32.so.dbg vdso-install-$(CONFIG_IA32_EMULATION) += arch/x86/entry/vdso/vdso32.so.dbgThese files will be installed to $(MODLIB)/vdso/ with the .dbg suffix,if exists, stripped away.vdso-install-y can optionally take the second field after the colonseparator. This is needed because some architectures install a vdsofile as a different base name.The following is a snippet from arch/arm64/Makefile. vdso-install-$(CONFIG_COMPAT_VDSO) += arch/arm64/kernel/vdso32/vdso.so.dbg:vdso32.soThis will rename vdso.so.dbg to vdso32.so during installation. If sucharchitectures change their implementation so that the base names match,this workaround will go away.Signed-off-by: Masahiro Yamada Acked-by: Sven Schnelle # s390Reviewed-by: Nicolas Schier Reviewed-by: Guo Ren Acked-by: Helge Deller # pariscAcked-by: Catalin Marinas Acked-by: Russell King (Oracle) List of files: /linux-6.15/arch/s390/kernel/vdso32/Makefile

d15e4314 - s390/vdso: filter out mno-pic-data-is-text-relative cflag

Fri, 23 Jun 2023 13:12:05 +0000

s390/vdso: filter out mno-pic-data-is-text-relative cflagcmd_vdso_check checks if there are any dynamic relocations invdso64.so.dbg. When kernel is compiled with-mno-pic-data-is-text-relative, R_390_RELATIVE relocs are generated andthis results in kernel build error.kpatch uses -mno-pic-data-is-text-relative option when building thekernel to prevent relative addressing between code and data. The flagavoids relocation error when klp text and data are too far apartkpatch does not patch vdso code and hence themno-pic-data-is-text-relative flag is not essential.Signed-off-by: Sumanth Korikkar Acked-by: Ilya Leoshkevich Signed-off-by: Alexander Gordeev List of files: /linux-6.15/arch/s390/kernel/vdso32/Makefile

0dd0bbc2 - s390/vdso: check for undefined symbols after build

Wed, 21 Jun 2023 07:18:52 +0000

s390/vdso: check for undefined symbols after buildWhen adding an undefined symbol the build still succeeds, butuserspace is crashing trying to execute vdso because theundefined symbol is not resolved. Add the check for undefinedsymbols to prevent this.Signed-off-by: Sven Schnelle Acked-by: Heiko Carstens Signed-off-by: Alexander Gordeev List of files: /linux-6.15/arch/s390/kernel/vdso32/Makefile

aff69273 - vdso: Improve cmd_vdso_check to check all dynamic relocations

Fri, 10 Mar 2023 19:07:50 +0000

vdso: Improve cmd_vdso_check to check all dynamic relocationsThe actual intention is that no dynamic relocation exists in the VDSO. Forthis the VDSO build validates that the resulting .so file does not have anyrelocations which are specified via $(ARCH_REL_TYPE_ABS) per architecture,which is fragile as e.g. ARM64 lacks an entry for R_AARCH64_RELATIVE. Asideof that ARCH_REL_TYPE_ABS is a misnomer as it checks for relativerelocations too.However, some GNU ld ports produce unneeded R_*_NONE relocation entries. Ifa port fails to determine the exact .rel[a].dyn size, the trailing zerosbecome R_*_NONE relocations. E.g. ld's powerpc port recently fixedhttps://sourceware.org/bugzilla/show_bug.cgi?id=29540). R_*_NONE aregenerally a no-op in the dynamic loaders. So just ignore them.Remove the ARCH_REL_TYPE_ABS defines and just validate that the resulting.so file does not contain any R_* relocation entries except R_*_NONE.Signed-off-by: Fangrui Song Signed-off-by: Thomas Gleixner Tested-by: Vincenzo Frascino # for aarch64Reviewed-by: Christophe Leroy Reviewed-by: Vincenzo Frascino # for vDSO, aarch64Acked-by: Michael Ellerman (powerpc)Link: https://lore.kernel.org/r/20230310190750.3323802-1-maskray@google.com List of files: /linux-6.15/arch/s390/kernel/vdso32/Makefile

7b737adc - s390/vdso: remove -nostdlib compiler flag

Sun, 07 Nov 2021 16:21:11 +0000

s390/vdso: remove -nostdlib compiler flagThe -nostdlib option requests the compiler to not use the standardsystem startup files or libraries when linking. It is effective onlywhen $(CC) is used as a linker driver.Since commit 2b2a25845d53 ("s390/vdso: Use $(LD) instead of $(CC) tolink vDSO"), $(LD) is directly used, hence -nostdlib is unneeded.Signed-off-by: Masahiro Yamada Link: https://lore.kernel.org/r/20211107162111.323701-1-masahiroy@kernel.orgSigned-off-by: Heiko Carstens List of files: /linux-6.15/arch/s390/kernel/vdso32/Makefile

e37b3dd0 - s390: enable KCSAN

Wed, 28 Jul 2021 11:59:04 +0000

s390: enable KCSANs390x GCC and SystemZ Clang have ThreadSanitizer support now [1] [2],so enable KCSAN for s390.[1] https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=ea22954e7c58[2] https://reviews.llvm.org/D105629Signed-off-by: Ilya Leoshkevich Signed-off-by: Heiko Carstens List of files: /linux-6.15/arch/s390/kernel/vdso32/Makefile

98f7cd23 - s390/vdso32: add vdso32.lds to targets

Fri, 09 Jul 2021 14:49:43 +0000

s390/vdso32: add vdso32.lds to targetsThis fixes a permanent rebuild of the 32 bit vdso. The RPM build processwas first calling 'make bzImage' and 'make modules' as a second step.This caused a recompilation of vdso32.so, which in turn also changedthe build-id of vmlinux.Fixes: 779df2248739 ("s390/vdso: add minimal compat vdso")Signed-off-by: Sven Schnelle Reviewed-by: Alexander Gordeev Signed-off-by: Heiko Carstens List of files: /linux-6.15/arch/s390/kernel/vdso32/Makefile

779df224 - s390/vdso: add minimal compat vdso

Fri, 25 Jun 2021 12:50:08 +0000

s390/vdso: add minimal compat vdsoAdd a small vdso for 31 bit compat application that providestrampolines for calls to sigreturn,rt_sigreturn,syscall_restart.This is requird for moving these syscalls away from the signalframe to the vdso. Note that this patch effectively disablesCONFIG_COMPAT when using clang to compile the kernel. clangdoesn't support 31 bit mode.We want to redirect sigreturn and restart_syscall to the vdso. However,the kernel cannot parse the ELF vdso file, so we need to generate headerfiles which contain the offsets of the syscall instructions in the vdsopage.Signed-off-by: Sven Schnelle Reviewed-by: Heiko Carstens Signed-off-by: Vasily Gorbik List of files: /linux-6.15/arch/s390/kernel/vdso32/Makefile

ce968f60 - s390/vdso: drop unnecessary cc-ldoption

Tue, 23 Apr 2019 21:00:56 +0000

s390/vdso: drop unnecessary cc-ldoptionTowards the goal of removing cc-ldoption, it seems that --hash-style=was added to binutils 2.17.50.0.2 in 2006. The minimal required versionof binutils for the kernel according toDocumentation/process/changes.rst is 2.20.Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.htmlCc: clang-built-linux@googlegroups.comSuggested-by: Masahiro Yamada Signed-off-by: Nick Desaulniers Signed-off-by: Heiko Carstens Signed-off-by: Martin Schwidefsky List of files: /linux-6.15/arch/s390/kernel/vdso32/Makefile

b44b136a - s390/vdso: add missing FORCE to build targets

Fri, 19 Oct 2018 13:37:01 +0000

s390/vdso: add missing FORCE to build targetsAccording to Documentation/kbuild/makefiles.txt all build targets usingif_changed should use FORCE as well. Add missing FORCE to make surevdso targets are rebuild properly when not just immediate prerequisiteshave changed but also when build command differs.Reviewed-by: Philipp Rudo Signed-off-by: Vasily Gorbik Signed-off-by: Martin Schwidefsky List of files: /linux-6.15/arch/s390/kernel/vdso32/Makefile

34849845 - s390/kasan: avoid vdso instrumentation

Fri, 17 Nov 2017 12:02:36 +0000

s390/kasan: avoid vdso instrumentationvdso is mapped into user space processes, which won't have kasanshodow mapped.Reviewed-by: Martin Schwidefsky Signed-off-by: Vasily Gorbik Signed-off-by: Martin Schwidefsky List of files: /linux-6.15/arch/s390/kernel/vdso32/Makefile

bc3703f2 - s390/kernel: emit CFI data in .debug_frame and discard .eh_frame sections

Mon, 20 Nov 2017 10:41:07 +0000

s390/kernel: emit CFI data in .debug_frame and discard .eh_frame sectionsUsing perf probe and libdw on kernel modules failed to find CFIdata for symbols. The CFI data is stored in the .eh_frame section.The elfutils libdw is not able to extract the CFI data correctly,because the .eh_frame section requires "non-simple" relocationsfor kernel modules.The suggestion is to avoid these "non-simple" relocations by emittingthe CFI data in the .debug_frame section. Let gcc emit respectivedirectives by specifying the -fno-asynchronous-unwind-tables option.Using the .debug_frame section for CFI data, the .eh_frame sectionbecomes unused and, thus, discard it for kernel and modules buildsThe vDSO requires the .eh_frame section and, hence, emit the CFI datain both, the .eh_frame and .debug_frame sections.See also discussion on elfutils/libdw bugzilla:https://sourceware.org/bugzilla/show_bug.cgi?id=22452Suggested-by: Mark Wielaard Signed-off-by: Hendrik Brueckner Reviewed-by: Heiko Carstens Signed-off-by: Martin Schwidefsky List of files: /linux-6.15/arch/s390/kernel/vdso32/Makefile

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/arch/s390/kernel/vdso32/Makefile