Changes in test_emulate_step.c

0c3beacf - asm-generic: introduce text-patching.h

Wed, 23 Oct 2024 16:27:06 +0000

asm-generic: introduce text-patching.hSeveral architectures support text patching, but they name the headerfiles that declare patching functions differently.Make all such headers consistently named text-patching.h and add an emptyheader in asm-generic for architectures that do not support text patching.Link: https://lkml.kernel.org/r/20241023162711.2579610-4-rppt@kernel.orgSigned-off-by: Mike Rapoport (Microsoft) Reviewed-by: Christoph Hellwig Acked-by: Geert Uytterhoeven # m68kAcked-by: Arnd Bergmann Reviewed-by: Luis Chamberlain Tested-by: kdevops Cc: Andreas Larsson Cc: Andy Lutomirski Cc: Ard Biesheuvel Cc: Borislav Petkov (AMD) Cc: Brian Cain Cc: Catalin Marinas Cc: Christophe Leroy Cc: Dave Hansen Cc: Dinh Nguyen Cc: Guo Ren Cc: Helge Deller Cc: Huacai Chen Cc: Ingo Molnar Cc: Johannes Berg Cc: John Paul Adrian Glaubitz Cc: Kent Overstreet Cc: Liam R. Howlett Cc: Mark Rutland Cc: Masami Hiramatsu (Google) Cc: Matt Turner Cc: Max Filippov Cc: Michael Ellerman Cc: Michal Simek Cc: Oleg Nesterov Cc: Palmer Dabbelt Cc: Peter Zijlstra Cc: Richard Weinberger Cc: Russell King Cc: Song Liu Cc: Stafford Horne Cc: Steven Rostedt (Google) Cc: Suren Baghdasaryan Cc: Thomas Bogendoerfer Cc: Thomas Gleixner Cc: Uladzislau Rezki (Sony) Cc: Vineet Gupta Cc: Will Deacon Signed-off-by: Andrew Morton List of files: /linux-6.15/arch/powerpc/lib/test_emulate_step.c

de40303b - powerpc/ppc-opcode: Define and use PPC_RAW_SETB()

Thu, 07 Jul 2022 14:55:16 +0000

powerpc/ppc-opcode: Define and use PPC_RAW_SETB()We have PPC_INST_SETB then build the 'setb' instruction in theuser.Instead, define PPC_RAW_SETB() and use it.Signed-off-by: Christophe Leroy Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/b08a4f26919a8f8cdcf7544ab552d9c1c63418b5.1657205708.git.christophe.leroy@csgroup.eu List of files: /linux-6.15/arch/powerpc/lib/test_emulate_step.c

2a83afe7 - powerpc/64: Drop ppc_inst_as_str()

Tue, 31 May 2022 06:59:36 +0000

powerpc/64: Drop ppc_inst_as_str()The ppc_inst_as_str() macro tries to make printing variable length,aka "prefixed", instructions convenient. It mostly succeeds, but it doeshide an on-stack buffer, which triggers stack protector.More problematically it doesn't compile at all with GCC 12,with -Wdangling-pointer, due to the fact that it returns the char bufferdeclared inside the macro: arch/powerpc/kernel/trace/ftrace.c: In function '__ftrace_modify_call': ./include/linux/printk.h:475:44: error: using a dangling pointer to '__str' [-Werror=dangling-pointer=] 475 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__) ... arch/powerpc/kernel/trace/ftrace.c:567:17: note: in expansion of macro 'pr_err' 567 | pr_err("Not expected bl: opcode is %s\n", ppc_inst_as_str(op)); | ^~~~~~ ./arch/powerpc/include/asm/inst.h:156:14: note: '__str' declared here 156 | char __str[PPC_INST_STR_LEN]; \ | ^~~~~This could be fixed by having the caller declare the buffer, but in someplaces there'd need to be two buffers. In all cases whereppc_inst_as_str() is used the output is not really meant for userconsumption, it's almost always indicative of a kernel bug.A simpler solution is to just print the value as an unsigned long. Fornormal instructions the output is identical. For prefixed instructionsthe value is printed as a single 64-bit quantity, whereas previously thelow half was printed first. But that is good enough for debug output,especially as prefixed instructions will be rare in kernel code inpractice.Old: c000000000111170 60420000 ori r2,r2,0 c000000000111174 04100001 e580fb00 .long 0xe580fb0004100001New: c00000000010f90c 60420000 ori r2,r2,0 c00000000010f910 e580fb0004100001 .long 0xe580fb0004100001Reported-by: Bagas Sanjaya Reported-by: Petr Mladek Signed-off-by: Michael Ellerman Tested-by: Bagas Sanjaya Link: https://lore.kernel.org/r/20220531065936.3674348-1-mpe@ellerman.id.au List of files: /linux-6.15/arch/powerpc/lib/test_emulate_step.c

c545b9f0 - powerpc/inst: Define ppc_inst_t

Mon, 29 Nov 2021 17:49:38 +0000

powerpc/inst: Define ppc_inst_tIn order to stop using 'struct ppc_inst' on PPC32,define a ppc_inst_t typedef.Signed-off-by: Christophe Leroy Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/fe5baa2c66fea9db05a8b300b3e8d2880a42596c.1638208156.git.christophe.leroy@csgroup.eu List of files: /linux-6.15/arch/powerpc/lib/test_emulate_step.c

59dc5bfc - powerpc/64s: avoid reloading (H)SRR registers if they are still valid

Thu, 17 Jun 2021 15:51:03 +0000

powerpc/64s: avoid reloading (H)SRR registers if they are still validWhen an interrupt is taken, the SRR registers are set to return to whereit left off. Unless they are modified in the meantime, or the returnaddress or MSR are modified, there is no need to reload these registerswhen returning from interrupt.Introduce per-CPU flags that track the validity of SRR and HSRRregisters. These are cleared when returning from interrupt, whenusing the registers for something else (e.g., OPAL calls), whenadjusting the return address or MSR of a context, and when contextswitching (which changes the return address and MSR).This improves the performance of interrupt returns.Signed-off-by: Nicholas Piggin [mpe: Fold in fixup patch from Nick]Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20210617155116.2167984-5-npiggin@gmail.com List of files: /linux-6.15/arch/powerpc/lib/test_emulate_step.c

f30becb5 - powerpc: Replace PPC_INST_NOP by PPC_RAW_NOP()

Thu, 20 May 2021 10:23:11 +0000

powerpc: Replace PPC_INST_NOP by PPC_RAW_NOP()On the road to removing all PPC_INST_xx defines inasm/ppc-opcodes.h, change PPC_INST_NOP to PPC_RAW_NOP().Signed-off-by: Christophe Leroy Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/ad46c195ca1b8572629ef07ba6bfe247585239a6.1621506159.git.christophe.leroy@csgroup.eu List of files: /linux-6.15/arch/powerpc/lib/test_emulate_step.c

148a0476 - powerpc: Rework PPC_RAW_xxx() macros for prefixed instructions

Thu, 20 May 2021 10:23:00 +0000

powerpc: Rework PPC_RAW_xxx() macros for prefixed instructionsAt the time being, we have PPC_RAW_PLXVP() and PPC_RAW_PSTXVP() whichprovide a 64 bits value, and then it gets split by open coding toformat it into a 'struct ppc_inst' instruction.Instead, define a PPC_RAW_xxx_P() and a PPC_RAW_xxx_S() to be usedas is.Signed-off-by: Christophe Leroy Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/5d146b31b943e7ad674894421db4feef54804b9b.1621506159.git.christophe.leroy@csgroup.eu List of files: /linux-6.15/arch/powerpc/lib/test_emulate_step.c

60060d70 - powerpc/sstep: Add tests for setb instruction

Tue, 11 May 2021 12:18:33 +0000

powerpc/sstep: Add tests for setb instructionThis adds selftests for setb instruction.Signed-off-by: Sathvika Vasireddy Tested-by: Naveen N. Rao Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/b05b61ccb5f10279d46fed490796f32ea2ccc270.1620727160.git.sathvika@linux.vnet.ibm.com List of files: /linux-6.15/arch/powerpc/lib/test_emulate_step.c

35785b29 - powerpc/sstep: Add testcases for VSX vector paired load/store instructions

Sun, 11 Oct 2020 05:09:08 +0000

powerpc/sstep: Add testcases for VSX vector paired load/store instructionsAdd testcases for VSX vector paired load/store instructions.Sample o/p: emulate_step_test: lxvp : PASS emulate_step_test: stxvp : PASS emulate_step_test: lxvpx : PASS emulate_step_test: stxvpx : PASS emulate_step_test: plxvp : PASS emulate_step_test: pstxvp : PASSSigned-off-by: Balamuruhan S Signed-off-by: Ravi Bangoria Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20201011050908.72173-6-ravi.bangoria@linux.ibm.com List of files: /linux-6.15/arch/powerpc/lib/test_emulate_step.c

b859c95c - powerpc/test_emulate_step: Add testcases for divde[.] and divdeu[.] instructions

Tue, 28 Jul 2020 13:03:08 +0000

powerpc/test_emulate_step: Add testcases for divde[.] and divdeu[.] instructionsAdd testcases for divde, divde., divdeu, divdeu. emulated instructionsto cover few scenarios, - with same dividend and divisor to have undefine RT for divdeu[.] - with divide by zero to have undefine RT for both divde[.] and divdeu[.] - with negative dividend to cover -|divisor| < r <= 0 if the dividend is negative for divde[.] - normal case with proper dividend and divisor for both divde[.] and divdeu[.]Signed-off-by: Balamuruhan S Reviewed-by: Sandipan Das Acked-by: Naveen N. Rao Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20200728130308.1790982-4-bala24@linux.ibm.com List of files: /linux-6.15/arch/powerpc/lib/test_emulate_step.c

70cc062c - powerpc/test_emulate_sstep: Fix build error

Thu, 23 Jul 2020 23:02:26 +0000

powerpc/test_emulate_sstep: Fix build errorppc64_book3e_allmodconfig fails with: arch/powerpc/lib/test_emulate_step.c: In function 'test_pld': arch/powerpc/lib/test_emulate_step.c:113:7: error: implicit declaration of function 'cpu_has_feature' 113 | if (!cpu_has_feature(CPU_FTR_ARCH_31)) { | ^~~~~~~~~~~~~~~Add an include of cpu_has_feature.h to fix it.Fixes: b6b54b42722a ("powerpc/sstep: Add tests for prefixed integer load/stores")Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20200724004109.1461709-1-mpe@ellerman.id.au List of files: /linux-6.15/arch/powerpc/lib/test_emulate_step.c

e93ad65e - powerpc/test_emulate_step: Move extern declaration to sstep.h

Fri, 26 Jun 2020 09:51:58 +0000

powerpc/test_emulate_step: Move extern declaration to sstep.hfix checkpatch.pl warnings by moving extern declaration from sourcefile to headerfile.Signed-off-by: Balamuruhan S Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20200626095158.1031507-5-bala24@linux.ibm.com List of files: /linux-6.15/arch/powerpc/lib/test_emulate_step.c

7e67c73b - powerpc/test_emulate_step: Add negative tests for prefixed addi

Fri, 26 Jun 2020 09:51:56 +0000

powerpc/test_emulate_step: Add negative tests for prefixed additestcases for `paddi` instruction to cover the negative case,if R is equal to 1 and RA is not equal to 0, the instructionform is invalid.Signed-off-by: Balamuruhan S Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20200626095158.1031507-3-bala24@linux.ibm.com List of files: /linux-6.15/arch/powerpc/lib/test_emulate_step.c

93c3a0ba - powerpc/test_emulate_step: Enhancement to test negative scenarios

Fri, 26 Jun 2020 09:51:55 +0000

powerpc/test_emulate_step: Enhancement to test negative scenariosadd provision to declare test is a negative scenario, verifywhether emulation fails and avoid executing it.Signed-off-by: Balamuruhan S Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20200626095158.1031507-2-bala24@linux.ibm.com List of files: /linux-6.15/arch/powerpc/lib/test_emulate_step.c

50428fdc - powerpc: Add a ppc_inst_as_str() helper

Tue, 02 Jun 2020 05:27:25 +0000

powerpc: Add a ppc_inst_as_str() helperThere are quite a few places where instructions are printed, this isdone using a '%x' format specifier. With the introduction of prefixedinstructions, this does not work well. Currently in these places,ppc_inst_val() is used for the value for %x so only the first word ofprefixed instructions are printed.When the instructions are word instructions, only a single word shouldbe printed. For prefixed instructions both the prefix and suffix shouldbe printed. To accommodate both of these situations, instead of a '%x'specifier use '%s' and introduce a helper, __ppc_inst_as_str() whichreturns a char *. The char * __ppc_inst_as_str() returns is buffer thatis passed to it by the caller.It is cumbersome to require every caller of __ppc_inst_as_str() to nowdeclare a buffer. To make it more convenient to use __ppc_inst_as_str(),wrap it in a macro that uses a compound statement to allocate a bufferon the caller's stack before calling it.Signed-off-by: Jordan Niethe Reviewed-by: Joel Stanley Acked-by: Segher Boessenkool [mpe: Drop 0x prefix to match most existings uses, especially xmon]Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20200602052728.18227-1-jniethe5@gmail.com List of files: /linux-6.15/arch/powerpc/lib/test_emulate_step.c

4f825900 - powerpc/sstep: Add tests for Prefixed Add Immediate

Mon, 25 May 2020 02:59:23 +0000

powerpc/sstep: Add tests for Prefixed Add ImmediateUse the existing support for testing compute type instructions to testPrefixed Add Immediate (paddi). The R bit of the paddi instructioncontrols whether current instruction address is used. Add test casesfor when R=1 and for R=0. paddi has a 34 bit immediate field formed byconcatenating si0 and si1. Add tests for the extreme values of thisfield.Skip the paddi tests if ISA v3.1 is unsupported.Some of these test cases were added by Balamuruhan S.Signed-off-by: Jordan Niethe [mpe: Fix conflicts with ppc-opcode.h changes, squash in .balign]Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20200525025923.19843-5-jniethe5@gmail.com List of files: /linux-6.15/arch/powerpc/lib/test_emulate_step.c

301ebf7d - powerpc/sstep: Let compute tests specify a required cpu feature

Mon, 25 May 2020 02:59:22 +0000

powerpc/sstep: Let compute tests specify a required cpu featureAn a array of struct compute_test's are used to declare tests forcompute instructions. Add a cpu_feature field to struct compute_test asan optional way to specify a cpu feature that must be present. If notpresent then skip the test.Signed-off-by: Jordan Niethe Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20200525025923.19843-4-jniethe5@gmail.com List of files: /linux-6.15/arch/powerpc/lib/test_emulate_step.c

1c89cf7f - powerpc/sstep: Set NIP in instruction emulation tests

Mon, 25 May 2020 02:59:21 +0000

powerpc/sstep: Set NIP in instruction emulation testsThe tests for emulation of compute instructions execute andemulate an instruction and then compare the results to verify theemulation. In ISA v3.1 there are instructions that operate relative tothe NIP. Therefore set the NIP in the regs used for the emulatedinstruction to the location of the executed instruction so they willgive the same result.This is a rework of a patch by Balamuruhan S.Signed-off-by: Jordan Niethe Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20200525025923.19843-3-jniethe5@gmail.com List of files: /linux-6.15/arch/powerpc/lib/test_emulate_step.c

0396de6d - powerpc/sstep: Add tests for prefixed floating-point load/stores

Mon, 25 May 2020 02:59:20 +0000

powerpc/sstep: Add tests for prefixed floating-point load/storesAdd tests for the prefixed versions of the floating-point load/storesthat are currently tested. This includes the following instructions: * Prefixed Load Floating-Point Single (plfs) * Prefixed Load Floating-Point Double (plfd) * Prefixed Store Floating-Point Single (pstfs) * Prefixed Store Floating-Point Double (pstfd)Skip the new tests if ISA v3.10 is unsupported.Signed-off-by: Jordan Niethe [mpe: Fix conflicts with ppc-opcode.h changes]Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20200525025923.19843-2-jniethe5@gmail.com List of files: /linux-6.15/arch/powerpc/lib/test_emulate_step.c

b6b54b42 - powerpc/sstep: Add tests for prefixed integer load/stores

Mon, 25 May 2020 02:59:19 +0000

powerpc/sstep: Add tests for prefixed integer load/storesAdd tests for the prefixed versions of the integer load/stores thatare currently tested. This includes the following instructions: * Prefixed Load Doubleword (pld) * Prefixed Load Word and Zero (plwz) * Prefixed Store Doubleword (pstd)Skip the new tests if ISA v3.1 is unsupported.Signed-off-by: Jordan Niethe [mpe: Fix conflicts with ppc-opcode.h changes]Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20200525025923.19843-1-jniethe5@gmail.com List of files: /linux-6.15/arch/powerpc/lib/test_emulate_step.c