Changes in Makefile

127b0e05 - vdso: Rename included Makefile

Tue, 04 Feb 2025 12:05:36 +0000

vdso: Rename included MakefileAs the Makefile is included into other Makefiles it can not be used todefine objects to be built from the current source directory.However the generic datastore will introduce such a local source file.Rename the included Makefile so it is clear how it is to be used and tomake room for a regular Makefile in lib/vdso/.Signed-off-by: Thomas Weißschuh Signed-off-by: Thomas Gleixner Link: https://lore.kernel.org/all/20250204-vdso-store-rng-v3-4-13a4669dfc8c@linutronix.de List of files: /linux-6.15/arch/powerpc/kernel/vdso/Makefile

a5371018 - powerpc/Makefile: Allow overriding CPP

Thu, 07 Nov 2024 11:26:46 +0000

powerpc/Makefile: Allow overriding CPPUnlike all other arches, powerpc doesn't allow the user to override CPP,because it sets it unconditionally in the arch Makefile. This can leadto strange build failures.Instead add the required flags to KBUILD_CPPFLAGS, which are passedto CPP, CC and AS invocations by the generic Makefile logic.Reported-by: Arnd Bergmann Tested-by: Nathan Chancellor Reviewed-by: Nathan Chancellor Closes: https://lore.kernel.org/all/20240607061629.530301-1-arnd@kernel.orgSigned-off-by: Arnd Bergmann [mpe: Rebase, write change log, add Arnd's SoB as communicated privately]Signed-off-by: Michael Ellerman Link: https://patch.msgid.link/20241107112646.32401-1-mpe@ellerman.id.au List of files: /linux-6.15/arch/powerpc/kernel/vdso/Makefile

d677ce52 - powerpc/vdso: Drop -mstack-protector-guard flags in 32-bit files with clang

Wed, 30 Oct 2024 18:41:37 +0000

powerpc/vdso: Drop -mstack-protector-guard flags in 32-bit files with clangUnder certain conditions, the 64-bit '-mstack-protector-guard' flags mayend up in the 32-bit vDSO flags, resulting in build failures due to thestructure of clang's argument parsing of the stack protector options,which validates the arguments of the stack protector guard flagsunconditionally in the frontend, choking on the 64-bit values whentargeting 32-bit: clang: error: invalid value 'r13' in 'mstack-protector-guard-reg=', expected one of: r2 clang: error: invalid value 'r13' in 'mstack-protector-guard-reg=', expected one of: r2 make[3]: *** [arch/powerpc/kernel/vdso/Makefile:85: arch/powerpc/kernel/vdso/vgettimeofday-32.o] Error 1 make[3]: *** [arch/powerpc/kernel/vdso/Makefile:87: arch/powerpc/kernel/vdso/vgetrandom-32.o] Error 1Remove these flags by adding them to the CC32FLAGSREMOVE variable, whichalready handles situations similar to this. Additionally, reformat andalign a comment better for the expanding CONFIG_CC_IS_CLANG block.Cc: stable@vger.kernel.org # v6.1+Signed-off-by: Nathan Chancellor Signed-off-by: Michael Ellerman Link: https://patch.msgid.link/20241030-powerpc-vdso-drop-stackp-flags-clang-v1-1-d95e7376d29c@kernel.org List of files: /linux-6.15/arch/powerpc/kernel/vdso/Makefile

4b058c9f - powerpc/vdso: allow r30 in vDSO code generation of getrandom

Wed, 25 Sep 2024 17:50:22 +0000

powerpc/vdso: allow r30 in vDSO code generation of getrandomFor gettimeofday, -ffixed-r30 was passed to work around a bug in Gocode, where the vDSO trampoline forgot to save and restore this registeracross function calls. But Go requires a different trampoline for everycall, and there's no reason that new Go code needs to be broken and addmore bugs. So remove -ffixed-r30 for getrandom.Fixes: 8072b39c3a75 ("powerpc/vdso: Wire up getrandom() vDSO implementation on VDSO64")Signed-off-by: Jason A. Donenfeld Signed-off-by: Michael Ellerman Link: https://msgid.link/20240925175021.1526936-2-Jason@zx2c4.com List of files: /linux-6.15/arch/powerpc/kernel/vdso/Makefile

8072b39c - powerpc/vdso: Wire up getrandom() vDSO implementation on VDSO64

Mon, 02 Sep 2024 19:17:22 +0000

powerpc/vdso: Wire up getrandom() vDSO implementation on VDSO64Extend getrandom() vDSO implementation to VDSO64.Tested on QEMU on both ppc64_defconfig and ppc64le_defconfig.Results from a Power9 (PowerNV):~ # ./vdso_test_getrandom bench-single vdso: 25000000 times in 0.787943615 seconds libc: 25000000 times in 14.101887252 seconds syscall: 25000000 times in 14.047475082 secondsSigned-off-by: Christophe Leroy Tested-by: Madhavan Srinivasan Acked-by: Michael Ellerman Signed-off-by: Jason A. Donenfeld List of files: /linux-6.15/arch/powerpc/kernel/vdso/Makefile

53cee505 - powerpc/vdso: Wire up getrandom() vDSO implementation on VDSO32

Mon, 02 Sep 2024 19:17:21 +0000

powerpc/vdso: Wire up getrandom() vDSO implementation on VDSO32To be consistent with other VDSO functions, the function is called__kernel_getrandom()__arch_chacha20_blocks_nostack() fonction is implemented basicallywith 32 bits operations. It performs 4 QUARTERROUND operations inparallele. There are enough registers to avoid using the stack:On input: r3: output bytes r4: 32-byte key input r5: 8-byte counter input/output r6: number of 64-byte blocks to write to outputDuring operation: stack: pointer to counter (r5) and non-volatile registers (r14-131) r0: counter of blocks (initialised with r6) r4: Value '4' after key has been read, used for indexing r5-r12: key r14-r15: block counter r16-r31: chacha stateAt the end: r0, r6-r12: Zeroised r5, r14-r31: RestoredPerformance on powerpc 885 (using kernel selftest): ~# ./vdso_test_getrandom bench-single vdso: 25000000 times in 62.938002291 seconds libc: 25000000 times in 535.581916866 seconds syscall: 25000000 times in 531.525042806 secondsPerformance on powerpc 8321 (using kernel selftest): ~# ./vdso_test_getrandom bench-single vdso: 25000000 times in 16.899318858 seconds libc: 25000000 times in 131.050596522 seconds syscall: 25000000 times in 129.794790389 secondsThis first patch adds support for VDSO32. As selftests cannot easilybe generated only for VDSO32, and because the following patch bringssupport for VDSO64 anyway, this patch opts out all code in__arch_chacha20_blocks_nostack() so that vdso_test_chacha will notfail to compile and will not crash on PPC64/PPC64LE, allthough theselftest itself will fail.Signed-off-by: Christophe Leroy Acked-by: Michael Ellerman Signed-off-by: Jason A. Donenfeld List of files: /linux-6.15/arch/powerpc/kernel/vdso/Makefile

a6b67eb0 - powerpc/vdso: Refactor CFLAGS for CVDSO build

Mon, 02 Sep 2024 19:17:20 +0000

powerpc/vdso: Refactor CFLAGS for CVDSO buildIn order to avoid two much duplication when we add new VDSOfunctionnalities in C like getrandom, refactor common CFLAGS.Signed-off-by: Christophe Leroy Acked-by: Michael Ellerman Signed-off-by: Jason A. Donenfeld List of files: /linux-6.15/arch/powerpc/kernel/vdso/Makefile

b163596a - powerpc/vdso32: Add crtsavres

Mon, 02 Sep 2024 19:17:19 +0000

powerpc/vdso32: Add crtsavresCommit 08c18b63d965 ("powerpc/vdso32: Add missing _restgpr_31_x to fixbuild failure") added _restgpr_31_x to the vdso for gettimeofday, butthe work on getrandom shows that we will need more of those functions.Remove _restgpr_31_x and link in crtsavres.o so that we get allsave/restore functions when optimising the kernel for size.Signed-off-by: Christophe Leroy Acked-by: Ard Biesheuvel Acked-by: Michael Ellerman Signed-off-by: Jason A. Donenfeld List of files: /linux-6.15/arch/powerpc/kernel/vdso/Makefile

7f7f6f7a - Makefile: remove redundant tool coverage variables

Mon, 06 May 2024 13:35:43 +0000

Makefile: remove redundant tool coverage variablesNow Kbuild provides reasonable defaults for objtool, sanitizers, andprofilers.Remove redundant variables.Note:This commit changes the coverage for some objects: - include arch/mips/vdso/vdso-image.o into UBSAN, GCOV, KCOV - include arch/sparc/vdso/vdso-image-*.o into UBSAN - include arch/sparc/vdso/vma.o into UBSAN - include arch/x86/entry/vdso/extable.o into KASAN, KCSAN, UBSAN, GCOV, KCOV - include arch/x86/entry/vdso/vdso-image-*.o into KASAN, KCSAN, UBSAN, GCOV, KCOV - include arch/x86/entry/vdso/vdso32-setup.o into KASAN, KCSAN, UBSAN, GCOV, KCOV - include arch/x86/entry/vdso/vma.o into GCOV, KCOV - include arch/x86/um/vdso/vma.o into KASAN, GCOV, KCOVI believe these are positive effects because all of them are kernelspace objects.Signed-off-by: Masahiro Yamada Reviewed-by: Kees Cook Tested-by: Roberto Sassu List of files: /linux-6.15/arch/powerpc/kernel/vdso/Makefile

b1992c37 - kbuild: use $(src) instead of $(srctree)/$(src) for source directory

Sat, 27 Apr 2024 14:55:02 +0000

kbuild: use $(src) instead of $(srctree)/$(src) for source directoryKbuild conventionally uses $(obj)/ for generated files, and $(src)/ forchecked-in source files. It is merely a convention without any functionaldifference. In fact, $(obj) and $(src) are exactly the same, as definedin scripts/Makefile.build: src := $(obj)When the kernel is built in a separate output directory, $(src) doesnot accurately reflect the source directory location. While Kbuildresolves this discrepancy by specifying VPATH=$(srctree) to search forsource files, it does not cover all cases. For example, when adding aheader search path for local headers, -I$(srctree)/$(src) is typicallypassed to the compiler.This introduces inconsistency between upstream and downstream Makefilesbecause $(src) is used instead of $(srctree)/$(src) for the latter.To address this inconsistency, this commit changes the semantics of$(src) so that it always points to the directory in the source tree.Going forward, the variables used in Makefiles will have the followingmeanings: $(obj) - directory in the object tree $(src) - directory in the source tree (changed by this commit) $(objtree) - the top of the kernel object tree $(srctree) - the top of the kernel source treeConsequently, $(srctree)/$(src) in upstream Makefiles need to be replacedwith $(src).Signed-off-by: Masahiro Yamada Reviewed-by: Nicolas Schier List of files: /linux-6.15/arch/powerpc/kernel/vdso/Makefile

b957df3b - arch: use $(obj)/ instead of $(src)/ for preprocessed linker scripts

Sat, 27 Apr 2024 14:54:59 +0000

arch: use $(obj)/ instead of $(src)/ for preprocessed linker scriptsThese are generated files. Prefix them with $(obj)/ instead of $(src)/.Signed-off-by: Masahiro Yamada Acked-by: Helge Deller Reviewed-by: Nicolas Schier List of files: /linux-6.15/arch/powerpc/kernel/vdso/Makefile

42449052 - powerpc/vdso: No need to undef powerpc for 64-bit build

Wed, 06 Dec 2023 11:55:46 +0000

powerpc/vdso: No need to undef powerpc for 64-bit buildThe vdso Makefile adds -U$(ARCH) to CPPFLAGS for the vdso64.lds linkerscript. ARCH is always powerpc, so it becomes -Upowerpc, which meansundefine the "powerpc" symbol.But the 64-bit compiler doesn't define powerpc in the first place,compare: $ gcc-5.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc -m32 -E -dM - Link: https://msgid.link/20231206115548.1466874-2-mpe@ellerman.id.au List of files: /linux-6.15/arch/powerpc/kernel/vdso/Makefile

8ad57add - powerpc/build: vdso linker warning for orphan sections

Fri, 09 Jun 2023 05:10:02 +0000

powerpc/build: vdso linker warning for orphan sectionsAdd --orphan-handlin for vdsos, and adjust vdso linker scripts to dealwith orphan sections.Signed-off-by: Nicholas Piggin Signed-off-by: Michael Ellerman Link: https://msgid.link/20230609051002.3342-1-npiggin@gmail.com List of files: /linux-6.15/arch/powerpc/kernel/vdso/Makefile

a7e5eb53 - powerpc/vdso: Include CLANG_FLAGS explicitly in ldflags-y

Thu, 01 Jun 2023 18:46:33 +0000

powerpc/vdso: Include CLANG_FLAGS explicitly in ldflags-yA future change will move CLANG_FLAGS from KBUILD_{A,C}FLAGS toKBUILD_CPPFLAGS so that '--target' is available while preprocessing.When that occurs, the following error appears when building the compatPowerPC vDSO: clang: error: unsupported option '-mbig-endian' for target 'x86_64-pc-linux-gnu' make[3]: *** [.../arch/powerpc/kernel/vdso/Makefile:76: arch/powerpc/kernel/vdso/vdso32.so.dbg] Error 1Explicitly add CLANG_FLAGS to ldflags-y, so that '--target' will alwaysbe present.Signed-off-by: Nathan Chancellor Signed-off-by: Masahiro Yamada List of files: /linux-6.15/arch/powerpc/kernel/vdso/Makefile

aff69273 - vdso: Improve cmd_vdso_check to check all dynamic relocations

Fri, 10 Mar 2023 19:07:50 +0000

vdso: Improve cmd_vdso_check to check all dynamic relocationsThe actual intention is that no dynamic relocation exists in the VDSO. Forthis the VDSO build validates that the resulting .so file does not have anyrelocations which are specified via $(ARCH_REL_TYPE_ABS) per architecture,which is fragile as e.g. ARM64 lacks an entry for R_AARCH64_RELATIVE. Asideof that ARCH_REL_TYPE_ABS is a misnomer as it checks for relativerelocations too.However, some GNU ld ports produce unneeded R_*_NONE relocation entries. Ifa port fails to determine the exact .rel[a].dyn size, the trailing zerosbecome R_*_NONE relocations. E.g. ld's powerpc port recently fixedhttps://sourceware.org/bugzilla/show_bug.cgi?id=29540). R_*_NONE aregenerally a no-op in the dynamic loaders. So just ignore them.Remove the ARCH_REL_TYPE_ABS defines and just validate that the resulting.so file does not contain any R_* relocation entries except R_*_NONE.Signed-off-by: Fangrui Song Signed-off-by: Thomas Gleixner Tested-by: Vincenzo Frascino # for aarch64Reviewed-by: Christophe Leroy Reviewed-by: Vincenzo Frascino # for vDSO, aarch64Acked-by: Michael Ellerman (powerpc)Link: https://lore.kernel.org/r/20230310190750.3323802-1-maskray@google.com List of files: /linux-6.15/arch/powerpc/kernel/vdso/Makefile

2fb857bc - powerpc/kcsan: Add exclusions from instrumentation

Mon, 06 Feb 2023 02:17:57 +0000

powerpc/kcsan: Add exclusions from instrumentationExclude various incompatible compilation units from KCSANinstrumentation.Signed-off-by: Rohan McLure Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20230206021801.105268-2-rmclure@linux.ibm.com List of files: /linux-6.15/arch/powerpc/kernel/vdso/Makefile

4e3feaad - powerpc/vdso: Filter clang's auto var init zero enabler when linking

Tue, 24 Jan 2023 16:19:28 +0000

powerpc/vdso: Filter clang's auto var init zero enabler when linkingAfter commit 8d9acfce3332 ("kbuild: Stop using '-Qunused-arguments' withclang"), the PowerPC vDSO shows the following error with clang-13 andolder when CONFIG_INIT_STACK_ALL_ZERO is enabled: clang: error: argument unused during compilation: '-enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang' [-Werror,-Wunused-command-line-argument]clang-14 added a change to make sure this flag never triggers-Wunused-command-line-argument, so it is fixed with newer releases. Forolder releases that the kernel still supports building with, just filterout this flag, as has been done for other flags.Fixes: f0a42fbab447 ("powerpc/vdso: Improve linker flags")Fixes: 8d9acfce3332 ("kbuild: Stop using '-Qunused-arguments' with clang")Link: https://github.com/llvm/llvm-project/commit/ca6d5813d17598cd180995fb3bdfca00f364475fSigned-off-by: Nathan Chancellor Signed-off-by: Masahiro Yamada List of files: /linux-6.15/arch/powerpc/kernel/vdso/Makefile

05e05bfc - powerpc/vdso: Remove an unsupported flag from vgettimeofday-32.o with clang

Thu, 12 Jan 2023 03:05:05 +0000

powerpc/vdso: Remove an unsupported flag from vgettimeofday-32.o with clangWhen clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, itwarns: clang-16: error: argument unused during compilation: '-fno-stack-clash-protection' [-Werror,-Wunused-command-line-argument]This warning happens because vgettimeofday-32.c gets its base CFLAGSfrom the main kernel, which may contain flags that are only supported ona 64-bit target but not a 32-bit one, which is the case here.-fstack-clash-protection and its negation are only suppported by the64-bit powerpc target but that flag is included in an invocation for a32-bit powerpc target, so clang points out that while the flag is onethat it recognizes, it is not actually used by this compiler job.To eliminate the warning, remove -fno-stack-clash-protection fromvgettimeofday-32.c's CFLAGS when using clang, as has been done for otherflags previously.Signed-off-by: Nathan Chancellor Reviewed-by: Nick Desaulniers Tested-by: Linux Kernel Functional Testing Tested-by: Anders Roxell Signed-off-by: Masahiro Yamada List of files: /linux-6.15/arch/powerpc/kernel/vdso/Makefile

f0a42fba - powerpc/vdso: Improve linker flags

Thu, 12 Jan 2023 03:05:04 +0000

powerpc/vdso: Improve linker flagsWhen clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, thereare several warnings in the PowerPC vDSO: clang-16: error: -Wl,-soname=linux-vdso32.so.1: 'linker' input unused [-Werror,-Wunused-command-line-argument] clang-16: error: -Wl,--hash-style=both: 'linker' input unused [-Werror,-Wunused-command-line-argument] clang-16: error: argument unused during compilation: '-shared' [-Werror,-Wunused-command-line-argument] clang-16: error: argument unused during compilation: '-nostdinc' [-Werror,-Wunused-command-line-argument] clang-16: error: argument unused during compilation: '-Wa,-maltivec' [-Werror,-Wunused-command-line-argument]The first group of warnings point out that linker flags were being addedto all invocations of $(CC), even though they will only be used duringthe final vDSO link. Move those flags to ldflags-y.The second group of warnings are compiler or assembler flags that willbe unused during linking. Filter them out from KBUILD_CFLAGS so thatthey are not used during linking.Additionally, '-z noexecstack' was added directly to the ld_and_checkrule in commit 1d53c0192b15 ("powerpc/vdso: link with -z noexecstack")but now that there is a common ldflags variable, it can be moved there.Signed-off-by: Nathan Chancellor Reviewed-by: Nick Desaulniers Tested-by: Linux Kernel Functional Testing Tested-by: Anders Roxell Signed-off-by: Masahiro Yamada List of files: /linux-6.15/arch/powerpc/kernel/vdso/Makefile

024734d1 - powerpc/vdso: Remove unused '-s' flag from ASFLAGS

Thu, 12 Jan 2023 03:05:03 +0000

powerpc/vdso: Remove unused '-s' flag from ASFLAGSWhen clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, itwarns: clang-16: error: argument unused during compilation: '-s' [-Werror,-Wunused-command-line-argument]The compiler's '-s' flag is a linking option (it is passed along to thelinker directly), which means it does nothing when the linker is notinvoked by the compiler. The kernel builds all .o files with '-c', whichstops the compilation pipeline before linking, so '-s' can be safelydropped from ASFLAGS.Signed-off-by: Nathan Chancellor Reviewed-by: Nick Desaulniers Reviewed-by: Segher Boessenkool Tested-by: Linux Kernel Functional Testing Tested-by: Anders Roxell Acked-by: Michael Ellerman Signed-off-by: Masahiro Yamada List of files: /linux-6.15/arch/powerpc/kernel/vdso/Makefile