Changes in Makefile

127b0e05 - vdso: Rename included Makefile

Tue, 04 Feb 2025 12:05:36 +0000

vdso: Rename included MakefileAs the Makefile is included into other Makefiles it can not be used todefine objects to be built from the current source directory.However the generic datastore will introduce such a local source file.Rename the included Makefile so it is clear how it is to be used and tomake room for a regular Makefile in lib/vdso/.Signed-off-by: Thomas Weißschuh Signed-off-by: Thomas Gleixner Link: https://lore.kernel.org/all/20250204-vdso-store-rng-v3-4-13a4669dfc8c@linutronix.de List of files: /linux-6.15/arch/mips/vdso/Makefile

7f7f6f7a - Makefile: remove redundant tool coverage variables

Mon, 06 May 2024 13:35:43 +0000

Makefile: remove redundant tool coverage variablesNow Kbuild provides reasonable defaults for objtool, sanitizers, andprofilers.Remove redundant variables.Note:This commit changes the coverage for some objects: - include arch/mips/vdso/vdso-image.o into UBSAN, GCOV, KCOV - include arch/sparc/vdso/vdso-image-*.o into UBSAN - include arch/sparc/vdso/vma.o into UBSAN - include arch/x86/entry/vdso/extable.o into KASAN, KCSAN, UBSAN, GCOV, KCOV - include arch/x86/entry/vdso/vdso-image-*.o into KASAN, KCSAN, UBSAN, GCOV, KCOV - include arch/x86/entry/vdso/vdso32-setup.o into KASAN, KCSAN, UBSAN, GCOV, KCOV - include arch/x86/entry/vdso/vma.o into GCOV, KCOV - include arch/x86/um/vdso/vma.o into KASAN, GCOV, KCOVI believe these are positive effects because all of them are kernelspace objects.Signed-off-by: Masahiro Yamada Reviewed-by: Kees Cook Tested-by: Roberto Sassu List of files: /linux-6.15/arch/mips/vdso/Makefile

b1992c37 - kbuild: use $(src) instead of $(srctree)/$(src) for source directory

Sat, 27 Apr 2024 14:55:02 +0000

kbuild: use $(src) instead of $(srctree)/$(src) for source directoryKbuild conventionally uses $(obj)/ for generated files, and $(src)/ forchecked-in source files. It is merely a convention without any functionaldifference. In fact, $(obj) and $(src) are exactly the same, as definedin scripts/Makefile.build: src := $(obj)When the kernel is built in a separate output directory, $(src) doesnot accurately reflect the source directory location. While Kbuildresolves this discrepancy by specifying VPATH=$(srctree) to search forsource files, it does not cover all cases. For example, when adding aheader search path for local headers, -I$(srctree)/$(src) is typicallypassed to the compiler.This introduces inconsistency between upstream and downstream Makefilesbecause $(src) is used instead of $(srctree)/$(src) for the latter.To address this inconsistency, this commit changes the semantics of$(src) so that it always points to the directory in the source tree.Going forward, the variables used in Makefiles will have the followingmeanings: $(obj) - directory in the object tree $(src) - directory in the source tree (changed by this commit) $(objtree) - the top of the kernel object tree $(srctree) - the top of the kernel source treeConsequently, $(srctree)/$(src) in upstream Makefiles need to be replacedwith $(src).Signed-off-by: Masahiro Yamada Reviewed-by: Nicolas Schier List of files: /linux-6.15/arch/mips/vdso/Makefile

aff69273 - vdso: Improve cmd_vdso_check to check all dynamic relocations

Fri, 10 Mar 2023 19:07:50 +0000

vdso: Improve cmd_vdso_check to check all dynamic relocationsThe actual intention is that no dynamic relocation exists in the VDSO. Forthis the VDSO build validates that the resulting .so file does not have anyrelocations which are specified via $(ARCH_REL_TYPE_ABS) per architecture,which is fragile as e.g. ARM64 lacks an entry for R_AARCH64_RELATIVE. Asideof that ARCH_REL_TYPE_ABS is a misnomer as it checks for relativerelocations too.However, some GNU ld ports produce unneeded R_*_NONE relocation entries. Ifa port fails to determine the exact .rel[a].dyn size, the trailing zerosbecome R_*_NONE relocations. E.g. ld's powerpc port recently fixedhttps://sourceware.org/bugzilla/show_bug.cgi?id=29540). R_*_NONE aregenerally a no-op in the dynamic loaders. So just ignore them.Remove the ARCH_REL_TYPE_ABS defines and just validate that the resulting.so file does not contain any R_* relocation entries except R_*_NONE.Signed-off-by: Fangrui Song Signed-off-by: Thomas Gleixner Tested-by: Vincenzo Frascino # for aarch64Reviewed-by: Christophe Leroy Reviewed-by: Vincenzo Frascino # for vDSO, aarch64Acked-by: Michael Ellerman (powerpc)Link: https://lore.kernel.org/r/20230310190750.3323802-1-maskray@google.com List of files: /linux-6.15/arch/mips/vdso/Makefile

f048158c - MIPS: remove CONFIG_MIPS_LD_CAN_LINK_VDSO

Fri, 20 Jan 2023 06:33:51 +0000

MIPS: remove CONFIG_MIPS_LD_CAN_LINK_VDSOGiven commit e4412739472b ("Documentation: raise minimum supportedversion of binutils to 2.25"), CONFIG_MIPS_LD_CAN_LINK_VDSO is always'y'.Signed-off-by: Masahiro Yamada Reviewed-by: Nathan Chancellor Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Bogendoerfer List of files: /linux-6.15/arch/mips/vdso/Makefile

d42f0c6a - MIPS: Use "grep -E" instead of "egrep"

Fri, 18 Nov 2022 08:28:11 +0000

MIPS: Use "grep -E" instead of "egrep"The latest version of grep claims the egrep is now obsolete so the buildnow contains warnings that look like: egrep: warning: egrep is obsolescent; using grep -Efix this up by moving the related file to use "grep -E" instead.Here are the steps to install the latest grep: wget http://ftp.gnu.org/gnu/grep/grep-3.8.tar.gz tar xf grep-3.8.tar.gz cd grep-3.8 && ./configure && make sudo make install export PATH=/usr/local/bin:$PATHSigned-off-by: Tiezhu Yang Signed-off-by: Thomas Bogendoerfer List of files: /linux-6.15/arch/mips/vdso/Makefile

e0a8b93e - mips: Enable KCSAN

Mon, 31 Jan 2022 10:17:09 +0000

mips: Enable KCSANThis patch enables KCSAN for the 64-bit version. Updated rulesfor the incompatible compilation units (vdso, boot/compressed).Signed-off-by: Nemanja Rakovic Signed-off-by: Thomas Bogendoerfer List of files: /linux-6.15/arch/mips/vdso/Makefile

bdbf2038 - MIPS: VDSO: remove -nostdlib compiler flag

Sun, 07 Nov 2021 16:19:38 +0000

MIPS: VDSO: remove -nostdlib compiler flagThe -nostdlib option requests the compiler to not use the standardsystem startup files or libraries when linking. It is effective onlywhen $(CC) is used as a linker driver.Since commit 2ff906994b6c ("MIPS: VDSO: Use $(LD) instead of $(CC) tolink VDSO"), $(LD) is directly used, hence -nostdlib is unneeded.Signed-off-by: Masahiro Yamada Signed-off-by: Thomas Bogendoerfer List of files: /linux-6.15/arch/mips/vdso/Makefile

1b6bc35a - MIPS: Makefile: Replace -pg with CC_FLAGS_FTRACE

Tue, 20 Apr 2021 07:00:52 +0000

MIPS: Makefile: Replace -pg with CC_FLAGS_FTRACEThis patch replaces the "open-coded" -pg compile flag with a CC_FLAGS_FTRACEmakefile variable which architectures can override if a different optionshould be used for code generation.Signed-off-by: zhaoxiao Signed-off-by: Thomas Bogendoerfer List of files: /linux-6.15/arch/mips/vdso/Makefile

76d7fff2 - MIPS: VDSO: Use CLANG_FLAGS instead of filtering out '--target='

Fri, 15 Jan 2021 19:26:22 +0000

MIPS: VDSO: Use CLANG_FLAGS instead of filtering out '--target='Commit ee67855ecd9d ("MIPS: vdso: Allow clang's --target flag in VDSOcflags") allowed the '--target=' flag from the main Makefile to filterthrough to the vDSO. However, it did not bring any of the other clangspecific flags for controlling the integrated assembler and the GNUtools locations (--prefix=, --gcc-toolchain=, and -no-integrated-as).Without these, we will get a warning (visible with tinyconfig):arch/mips/vdso/elf.S:14:1: warning: DWARF2 only supports one section percompilation unit.pushsection .note.Linux, "a",@note ; .balign 4 ; .long 2f - 1f ; .long4484f - 3f ; .long 0 ; 1:.asciz "Linux" ; 2:.balign 4 ; 3:^arch/mips/vdso/elf.S:34:2: warning: DWARF2 only supports one section percompilation unit .section .mips_abiflags, "a" ^All of these flags are bundled up under CLANG_FLAGS in the main Makefileand exported so that they can be added to Makefiles that set their ownCFLAGS. Use this value instead of filtering out '--target=' so there isno warning and all of the tools are properly used.Cc: stable@vger.kernel.orgFixes: ee67855ecd9d ("MIPS: vdso: Allow clang's --target flag in VDSO cflags")Link: https://github.com/ClangBuiltLinux/linux/issues/1256Reported-by: Anders Roxell Signed-off-by: Nathan Chancellor Tested-by: Anders Roxell Signed-off-by: Thomas Bogendoerfer List of files: /linux-6.15/arch/mips/vdso/Makefile

a9684337 - kbuild: explicitly specify the build id style

Tue, 22 Sep 2020 23:21:40 +0000

kbuild: explicitly specify the build id styleld's --build-id defaults to "sha1" style, while lld defaults to "fast".The build IDs are very different between the two, which may confuseprograms that reference them.Signed-off-by: Bill Wendling Acked-by: David S. Miller Signed-off-by: Masahiro Yamada List of files: /linux-6.15/arch/mips/vdso/Makefile

893ab004 - kbuild: remove cc-option test of -fno-stack-protector

Fri, 26 Jun 2020 18:59:12 +0000

kbuild: remove cc-option test of -fno-stack-protectorSome Makefiles already pass -fno-stack-protector unconditionally.For example, arch/arm64/kernel/vdso/Makefile, arch/x86/xen/Makefile.No problem report so far about hard-coding this option. So, we canassume all supported compilers know -fno-stack-protector.GCC 4.8 and Clang support this option (https://godbolt.org/z/_HDGzN)Get rid of cc-option from -fno-stack-protector.Remove CONFIG_CC_HAS_STACKPROTECTOR_NONE, which is always 'y'.Note:arch/mips/vdso/Makefile adds -fno-stack-protector twice, firstunconditionally, and second conditionally. I removed the second one.Signed-off-by: Masahiro Yamada Reviewed-by: Kees Cook Acked-by: Ard Biesheuvel Reviewed-by: Nick Desaulniers List of files: /linux-6.15/arch/mips/vdso/Makefile

2ff90699 - MIPS: VDSO: Use $(LD) instead of $(CC) to link VDSO

Tue, 28 Apr 2020 22:14:18 +0000

MIPS: VDSO: Use $(LD) instead of $(CC) to link VDSOCurrently, the VDSO is being linked through $(CC). This does not matchhow the rest of the kernel links objects, which is through the $(LD)variable.When clang is built in a default configuration, it first attempts to usethe target triple's default linker then the system's default linker,unless told otherwise through -fuse-ld=... We do not use -fuse-ld=because it can be brittle and we have support for invoking $(LD)directly. See commit fe00e50b2db8c ("ARM: 8858/1: vdso: use $(LD)instead of $(CC) to link VDSO") and commit 691efbedc60d2 ("arm64: vdso:use $(LD) instead of $(CC) to link VDSO") for examples of doing this inthe VDSO.Do the same thing here. Replace the custom linking logic with $(cmd_ld)and ldflags-y so that $(LD) is respected. We need to explicitly add twoflags to the linker that were implicitly passed by the compiler:-G 0 (which comes from ccflags-vdso) and --eh-frame-hdr.Before this patch (generated by adding '-v' to VDSO_LDFLAGS):/libexec/gcc/mips64-linux/9.3.0/collect2 \-plugin /libexec/gcc/mips64-linux/9.3.0/liblto_plugin.so \-plugin-opt=/libexec/gcc/mips64-linux/9.3.0/lto-wrapper \-plugin-opt=-fresolution=/tmp/ccGEi5Ka.res \--eh-frame-hdr \-G 0 \-EB \-mips64r2 \-shared \-melf64btsmip \-o arch/mips/vdso/vdso.so.dbg.raw \-L/lib/gcc/mips64-linux/9.3.0/64 \-L/lib/gcc/mips64-linux/9.3.0 \-L/lib/gcc/mips64-linux/9.3.0/../../../../mips64-linux/lib \-Bsymbolic \--no-undefined \-soname=linux-vdso.so.1 \-EB \--hash-style=sysv \--build-id \-T arch/mips/vdso/vdso.lds \arch/mips/vdso/elf.o \arch/mips/vdso/vgettimeofday.o \arch/mips/vdso/sigreturn.oAfter this patch:/bin/mips64-linux-ld \-m elf64btsmip \-Bsymbolic \--no-undefined \-soname=linux-vdso.so.1 \-EB \-nostdlib \-shared \-G 0 \--eh-frame-hdr \--hash-style=sysv \--build-id \-T arch/mips/vdso/vdso.lds \arch/mips/vdso/elf.o \arch/mips/vdso/vgettimeofday.oarch/mips/vdso/sigreturn.o \-o arch/mips/vdso/vdso.so.dbg.rawNote that we leave behind -mips64r2. Turns out that ld ignores it (seeget_emulation in ld/ldmain.c). This is true of current trunk and 2.23,which is the minimum supported version for the kernel:https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=ld/ldmain.c;hb=aa4209e7b679afd74a3860ce25659e71cc4847d5#l593https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=ld/ldmain.c;hb=a55e30b51bc6227d8d41f707654d0a5620978dcf#l641Before this patch, LD=ld.lld did nothing:$ llvm-readelf -p.comment arch/mips/vdso/vdso.so.dbg | sed 's/(.*//'String dump of section '.comment':[ 0] ClangBuiltLinux clang version 11.0.0After this patch, it does:$ llvm-readelf -p.comment arch/mips/vdso/vdso.so.dbg | sed 's/(.*//'String dump of section '.comment':[ 0] Linker: LLD 11.0.0[ 62] ClangBuiltLinux clang version 11.0.0Link: https://github.com/ClangBuiltLinux/linux/issues/785Signed-off-by: Nathan Chancellor Signed-off-by: Thomas Bogendoerfer List of files: /linux-6.15/arch/mips/vdso/Makefile

e91946d6 - MIPS: VDSO: Move disabling the VDSO logic to Kconfig

Tue, 28 Apr 2020 22:14:16 +0000

MIPS: VDSO: Move disabling the VDSO logic to KconfigAfter commit 9553d16fa671 ("init/kconfig: Add LD_VERSION Kconfig"), wehave access to GNU ld's version at configuration time. As a result, wecan make it clearer under what configuration circumstances the MIPS VDSOneeds to be disabled.This is a prerequisite for getting rid of the MIPS VDSO binutilswarning and linking the VDSO when LD is ld.lld. Wrapping the call told-ifversion with CONFIG_LD_IS_LLD does not work because the configvalues are wiped away during 'make clean'.Signed-off-by: Nathan Chancellor Signed-off-by: Thomas Bogendoerfer List of files: /linux-6.15/arch/mips/vdso/Makefile

72cf3b3d - MIPS: vdso: Wrap -mexplicit-relocs in cc-option

Mon, 17 Feb 2020 21:11:49 +0000

MIPS: vdso: Wrap -mexplicit-relocs in cc-optionClang does not support this option and errors out:clang-11: error: unknown argument: '-mexplicit-relocs'Clang does not appear to need this flag like GCC does because the jalrcheck that was added in commit 976c23af3ee5 ("mips: vdso: add buildtime check that no 'jalr t9' calls left") passes just fine with$ make ARCH=mips CC=clang CROSS_COMPILE=mipsel-linux-gnu- malta_defconfig arch/mips/vdso/even before commit d3f703c4359f ("mips: vdso: fix 'jalr t9' crash invdso code").-mrelax-pic-calls has been supported since clang 9, which is theearliest version that could build a working MIPS kernel, and it is thedefault for clang so just leave it be.Fixes: d3f703c4359f ("mips: vdso: fix 'jalr t9' crash in vdso code")Link: https://github.com/ClangBuiltLinux/linux/issues/890Signed-off-by: Nathan Chancellor Reviewed-by: Nick Desaulniers Tested-by: Nick Desaulniers Signed-off-by: Paul Burton Cc: Ralf Baechle Cc: linux-mips@vger.kernel.orgCc: linux-kernel@vger.kernel.orgCc: clang-built-linux@googlegroups.com List of files: /linux-6.15/arch/mips/vdso/Makefile

976c23af - mips: vdso: add build time check that no 'jalr t9' calls left

Tue, 11 Feb 2020 19:24:34 +0000

mips: vdso: add build time check that no 'jalr t9' calls leftvdso shared object cannot have GOT based PIC 'jalr t9' callsbecause nobody set GOT table in vdso. Contributing into vdso.o files are compiled in PIC mode and as result for internalstatic functions calls compiler will generate 'jalr t9'instructions. Those are supposed to be converted into PCrelative 'bal' calls by linker when relocation are processed.Mips global GOT entries do have dynamic relocations and theywill be caught by cmd_vdso_check Makefile rule. Static PICcalls go through mips local GOT entries that do not havedynamic relocations. For those 'jalr t9' calls could be presentbut without dynamic relocations and they need to be convertedto 'bal' calls by linker.Add additional build time check to make sure that no 'jalr t9'slip through because of some toolchain misconfiguration thatprevents 'jalr t9' to 'bal' conversion.Signed-off-by: Victor Kamensky Signed-off-by: Paul Burton Cc: linux-mips@vger.kernel.orgCc: Ralf Baechle Cc: James Hogan Cc: Vincenzo Frascino Cc: bruce.ashfield@gmail.comCc: richard.purdie@linuxfoundation.org List of files: /linux-6.15/arch/mips/vdso/Makefile

07015d7a - MIPS: Disable VDSO time functionality on microMIPS

Sat, 15 Feb 2020 20:38:36 +0000

MIPS: Disable VDSO time functionality on microMIPSA check we're about to add to pick up on function calls that depend onbogus use of the GOT in the VDSO picked up on instances of such functioncalls in microMIPS builds. Since the code appears genuinely problematic,and given the relatively small amount of use & testing that microMIPSsees, go ahead & disable the VDSO for microMIPS builds.Signed-off-by: Paul Burton List of files: /linux-6.15/arch/mips/vdso/Makefile

d3f703c4 - mips: vdso: fix 'jalr t9' crash in vdso code

Tue, 11 Feb 2020 19:24:33 +0000

mips: vdso: fix 'jalr t9' crash in vdso codeObserved that when kernel is built with Yocto mips64-poky-linux-gcc,and mips64-poky-linux-gnun32-gcc toolchain, resulting vdso contains'jalr t9' instructions in its code and since in vdso case nobodysets GOT table code crashes when instruction reached. On other handobserved that when kernel is built mips-poky-linux-gcc toolchain, thesame 'jalr t9' instruction are replaced with PC relative functioncalls using 'bal' instructions.The difference boils down to -mrelax-pic-calls and -mexplicit-relocsgcc options that gets different default values depending on gcctarget triplets and corresponding binutils. -mrelax-pic-calls gotenabled by default only in mips-poky-linux-gcc case. MIPS binutilsld relies on R_MIPS_JALR relocation to convert 'jalr t9' into 'bal'and such relocation is generated only if -mrelax-pic-calls optionis on.Please note 'jalr t9' conversion to 'bal' can happen only to staticfunctions. These static PIC calls use mips local GOT entries thatare supposed to be filled with start of DSO value by run-time linker(missing in VDSO case) and they do not have dynamic relocations.Global mips GOT entries must have dynamic relocations and they shouldbe prevented by cmd_vdso_check Makefile rule.Solution call out -mrelax-pic-calls and -mexplicit-relocs optionsexplicitly while compiling MIPS vdso code. That would get correctand consistent between different toolchains behaviour.Reported-by: Bruce Ashfield Signed-off-by: Victor Kamensky Signed-off-by: Paul Burton Cc: linux-mips@vger.kernel.orgCc: Ralf Baechle Cc: James Hogan Cc: Vincenzo Frascino Cc: richard.purdie@linuxfoundation.org List of files: /linux-6.15/arch/mips/vdso/Makefile

5f2fb52f - kbuild: rename hostprogs-y/always to hostprogs/always-y

Sat, 01 Feb 2020 16:49:24 +0000

kbuild: rename hostprogs-y/always to hostprogs/always-yIn old days, the "host-progs" syntax was used for specifying hostprograms. It was renamed to the current "hostprogs-y" in 2004.It is typically useful in scripts/Makefile because it allows Kbuild toselectively compile host programs based on the kernel configuration.This commit renames like follows: always -> always-y hostprogs-y -> hostprogsSo, scripts/Makefile will look like this: always-$(CONFIG_BUILD_BIN2C) += ... always-$(CONFIG_KALLSYMS) += ... ... hostprogs := $(always-y) $(always-m)I think this makes more sense because a host program is always a hostprogram, irrespective of the kernel configuration. We want to specifywhich ones to compile by CONFIG options, so always-y will be handier.The "always", "hostprogs-y", "hostprogs-m" will be kept for backwardcompatibility for a while.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/arch/mips/vdso/Makefile

99570c3d - MIPS: vdso: Define BUILD_VDSO32 when building a 32bit kernel

Thu, 16 Jan 2020 19:43:41 +0000

MIPS: vdso: Define BUILD_VDSO32 when building a 32bit kernelThe confinement of the 32bit specific VDSO functions missed to defineBUILD_VDSO32 when building a 32bit MIPS kernel:arch/mips/vdso/vgettimeofday.c: In function __vdso_clock_gettime:arch/mips/vdso/vgettimeofday.c:17:9: error: implicit declaration of function __cvdso_clock_gettime32arch/mips/vdso/vgettimeofday.c: In function __vdso_clock_getres:arch/mips/vdso/vgettimeofday.c:39:9: error: implicit declaration of function __cvdso_clock_getres_time32Force the define for 32bit builds in the VDSO Makefile.Fixes: bf279849ad59 ("lib/vdso: Build 32 bit specific functions in the right context")Reported-by: kbuild test robot Signed-off-by: Thomas Gleixner Acked-by: Paul Burton Link: https://lore.kernel.org/r/87d0bjfaqa.fsf@nanos.tec.linutronix.de List of files: /linux-6.15/arch/mips/vdso/Makefile