Changes in ftrace.c

ddd068d8 - MIPS: ftrace: Declare ftrace_get_parent_ra_addr() as static

Sat, 04 Jan 2025 14:47:08 +0000

MIPS: ftrace: Declare ftrace_get_parent_ra_addr() as staticDeclare ftrace_get_parent_ra_addr() as static to suppress clangcompiler warning that 'no previous prototype'. This function isnot intended to be called from other parts.Fix follow error with clang-19:arch/mips/kernel/ftrace.c:251:15: error: no previous prototype for function 'ftrace_get_parent_ra_addr' [-Werror,-Wmissing-prototypes] 251 | unsigned long ftrace_get_parent_ra_addr(unsigned long self_ra, unsigned long | ^arch/mips/kernel/ftrace.c:251:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 251 | unsigned long ftrace_get_parent_ra_addr(unsigned long self_ra, unsigned long | ^ | static1 error generated.Signed-off-by: WangYuli Acked-by: Masami Hiramatsu (Google) Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Bogendoerfer List of files: /linux-6.15/arch/mips/kernel/ftrace.c

9a91dd50 - MIPS: kernel: Remove not needed set_fs calls

Thu, 01 Apr 2021 12:56:34 +0000

MIPS: kernel: Remove not needed set_fs callsflush_icache_range always does flush kernel address ranges, so noneed to do the set_fs dance.Signed-off-by: Thomas Bogendoerfer Reviewed-by: Christoph Hellwig List of files: /linux-6.15/arch/mips/kernel/ftrace.c

b1468f30 - Revert "MIPS: kernel: {ftrace,kgdb}: Set correct address limit for cache flushes"

Wed, 10 Feb 2021 16:16:13 +0000

Revert "MIPS: kernel: {ftrace,kgdb}: Set correct address limit for cache flushes"This reverts commit 6ebda44f366478d1eea180d93154e7d97b591f50.All icache flushes in this code paths are done via flush_icache_range(),which only uses normal cache instruction. And this is the correct thingfor EVA mode, too. So no need to do set_fs(KERNEL_DS) here.Signed-off-by: Thomas Bogendoerfer Reviewed-by: Christoph Hellwig List of files: /linux-6.15/arch/mips/kernel/ftrace.c

39116103 - MIPS: ftrace: Remove redundant #ifdef CONFIG_DYNAMIC_FTRACE

Fri, 14 Aug 2020 02:40:24 +0000

MIPS: ftrace: Remove redundant #ifdef CONFIG_DYNAMIC_FTRACEThere exists redundant #ifdef CONFIG_DYNAMIC_FTRACE in ftrace.c, remove it.Signed-off-by: Zejiang Tang Reviewed-by: Steven Rostedt (VMware) Signed-off-by: Thomas Bogendoerfer List of files: /linux-6.15/arch/mips/kernel/ftrace.c

4f85c956 - MIPS: ftrace: Reword prepare_ftrace_return() comment block

Fri, 07 Jun 2019 11:36:40 +0000

MIPS: ftrace: Reword prepare_ftrace_return() comment blockImprove the comment block for prepare_ftrace_return().Signed-off-by: Geert Uytterhoeven Signed-off-by: Paul Burton Cc: Ralf Baechle Cc: James Hogan Cc: Steven Rostedt Cc: Ingo Molnar Cc: linux-mips@vger.kernel.orgCc: linux-kernel@vger.kernel.org List of files: /linux-6.15/arch/mips/kernel/ftrace.c

736706be - get rid of legacy 'get_ds()' function

Mon, 04 Mar 2019 18:39:05 +0000

get rid of legacy 'get_ds()' functionEvery in-kernel use of this function defined it to KERNEL_DS (either asan actual define, or as an inline function). It's an entirelyhistorical artifact, and long long long ago used to actually read thesegment selector valueof '%ds' on x86.Which in the kernel is always KERNEL_DS.Inspired by a patch from Jann Horn that just did this for a very smallsubset of users (the ones in fs/), along with Al who suggested a script.I then just took it to the logical extreme and removed all the remaininggunk.Roughly scripted with git grep -l '(get_ds())' -- :^tools/ | xargs sed -i 's/(get_ds())/(KERNEL_DS)/' git grep -lw 'get_ds' -- :^tools/ | xargs sed -i '/^#define get_ds()/d'plus manual fixups to remove a few unusual usage patterns, the couple ofinline function cases and to fix up a comment that had become stale.The 'get_ds()' function remains in an x86 kvm selftest, since in userspace it actually does something relevant.Inspired-by: Jann Horn Inspired-by: Al Viro Signed-off-by: Linus Torvalds List of files: /linux-6.15/arch/mips/kernel/ftrace.c

be856439 - mips: add +1 to __NR_syscalls in uapi header

Thu, 13 Dec 2018 09:07:36 +0000

mips: add +1 to __NR_syscalls in uapi headerAll other architectures are hold a value for __NR_syscalls willbe equal to the last system call number +1.But in mips architecture, __NR_syscalls hold the value equal tototal number of system exits in the architecture. One of thepatch in this patch series will genarate uapi header files.In order to make the implementation common across all architect-ures, add +1 to __NR_syscalls, which will be equal to the lastsystem call number +1.Signed-off-by: Firoz Khan Signed-off-by: Paul Burton Cc: linux-mips@vger.kernel.orgCc: Ralf Baechle Cc: James Hogan Cc: Greg Kroah-Hartman Cc: Philippe Ombredanne Cc: Thomas Gleixner Cc: Kate Stewart Cc: y2038@lists.linaro.orgCc: linux-kernel@vger.kernel.orgCc: linux-arch@vger.kernel.orgCc: arnd@arndb.deCc: deepa.kernel@gmail.comCc: marcin.juszkiewicz@linaro.org List of files: /linux-6.15/arch/mips/kernel/ftrace.c

8712b27c - MIPS: function_graph: Simplify with function_graph_enter()

Sun, 18 Nov 2018 22:25:18 +0000

MIPS: function_graph: Simplify with function_graph_enter()The function_graph_enter() function does the work of calling the functiongraph hook function and the management of the shadow stack, simplifying thework done in the architecture dependent prepare_ftrace_return().Have MIPS use the new code, and remove the shadow stack management as well ashaving to set up the trace structure.This is needed to prepare for a fix of a design bug on how the curr_ret_stackis used.Cc: Ralf Baechle Cc: Paul Burton Cc: James Hogan Cc: linux-mips@linux-mips.orgCc: stable@kernel.orgFixes: 03274a3ffb449 ("tracing/fgraph: Adjust fgraph depth before calling trace return callback")Reviewed-by: Masami Hiramatsu Signed-off-by: Steven Rostedt (VMware) List of files: /linux-6.15/arch/mips/kernel/ftrace.c

83aa53eb - MIPS: ftrace: Remove pointer comparison to 0 in prepare_ftrace_return

Wed, 17 Jan 2018 11:31:57 +0000

MIPS: ftrace: Remove pointer comparison to 0 in prepare_ftrace_returnReplace pointer comparison to 0 with NULL in prepare_ftrace_returnto improve code readability. Identified with coccinelle script'badzero.cocci'.Signed-off-by: Mathieu Malaterre Reviewed-by: James Hogan Cc: Ralf Baechle Cc: Steven Rostedt Cc: Ingo Molnar Cc: linux-mips@linux-mips.orgPatchwork: https://patchwork.linux-mips.org/patch/18494/Signed-off-by: James Hogan List of files: /linux-6.15/arch/mips/kernel/ftrace.c

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/arch/mips/kernel/ftrace.c

87051ec1 - MIPS: ftrace: fix init functions tracing

Tue, 23 May 2017 10:56:43 +0000

MIPS: ftrace: fix init functions tracingSince introduction of tracing for init functions the in_kernel_space()check is no longer correct, as it ignores the init sections. As aresult, when probes are inserted (and disabled) in the init functions,a branch instruction is inserted instead of a nop, which is likely toresult in random crashes during boot.Remove the MIPS-specific in_kernel_space() method and replace it with ageneric core_kernel_text() that also checks for init sections duringsystem boot stage.Fixes: 42c269c88dc1 ("ftrace: Allow for function tracing to record init functions on boot up")Signed-off-by: Marcin Nowakowski Tested-by: Matt Redfearn Cc: Steven Rostedt Cc: Ingo Molnar Cc: linux-mips@linux-mips.orgPatchwork: https://patchwork.linux-mips.org/patch/16092/Signed-off-by: Ralf Baechle List of files: /linux-6.15/arch/mips/kernel/ftrace.c

9a7c348b - ftrace: Add return address pointer to ftrace_ret_stack

Fri, 19 Aug 2016 11:52:57 +0000

ftrace: Add return address pointer to ftrace_ret_stackStoring this value will help prevent unwinders from getting out of syncwith the function graph tracer ret_stack. Now instead of needing astateful iterator, they can compare the return address pointer to findthe right ret_stack entry.Note that an array of 50 ftrace_ret_stack structs is allocated for everytask. So when an arch implements this, it will add either 200 or 400bytes of memory usage per task (depending on whether it's a 32-bit or64-bit platform).Signed-off-by: Josh Poimboeuf Acked-by: Steven Rostedt Cc: Andy Lutomirski Cc: Andy Lutomirski Cc: Borislav Petkov Cc: Brian Gerst Cc: Byungchul Park Cc: Denys Vlasenko Cc: Frederic Weisbecker Cc: H. Peter Anvin Cc: Kees Cook Cc: Linus Torvalds Cc: Nilay Vaish Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/a95cfcc39e8f26b89a430c56926af0bb217bc0a1.1471607358.git.jpoimboe@redhat.comSigned-off-by: Ingo Molnar List of files: /linux-6.15/arch/mips/kernel/ftrace.c

dce0e7d5 - MIPS: ftrace: Fix dynamic tracing of kernel modules

Thu, 24 Jul 2014 05:55:02 +0000

MIPS: ftrace: Fix dynamic tracing of kernel modulesDynamic tracing of kernel modules is broken on 32-bit MIPS. When modulesare loaded, the kernel crashes when dynamic tracing is enabled with: cd /sys/kernel/debug/tracing echo > set_ftrace_filter echo function > current_tracer1) arch/mips/kernel/ftrace.cWhen the kernel boots, or when a module is initialized, ftrace_make_nop()modifies every _mcount call site to eliminate the ftrace overhead.However, when ftrace is later enabled for a call site, ftrace_make_call()does not currently restore the _mcount call correctly for module call sites.Added ftrace_modify_code_2r() and modified ftrace_make_call() to fix this.2) arch/mips/kernel/mcount.S_mcount assembly routine is supposed to have the caller's _mcount call siteaddress in register a0. However, a0 is currently not calculated correctly formodule call sites. a0 should be (ra - 20) or (ra - 24), depending on whetherthe kernel was built with KBUILD_MCOUNT_RA_ADDRESS or not.This fix has been tested on Broadcom BMIPS5000 processor. Dynamic tracingnow works for both built-in functions and module functions.Signed-off-by: Petri Gynther Cc: linux-mips@linux-mips.orgCc: rostedt@goodmis.orgCc: alcooperx@gmail.comCc: cminyard@mvista.comPatchwork: https://patchwork.linux-mips.org/patch/7476/Signed-off-by: Ralf Baechle List of files: /linux-6.15/arch/mips/kernel/ftrace.c

6a8a5051 - MIPS: ftrace: Add call to ftrace_graph_is_dead() in function graph code

Wed, 25 Jun 2014 13:53:21 +0000

MIPS: ftrace: Add call to ftrace_graph_is_dead() in function graph codeftrace_stop() is going away as it disables parts of function tracingthat affects users that should not be affected. But ftrace_graph_stop()is built on ftrace_stop(). Here's another example of killing all offunction tracing because something went wrong with function graphtracing.Instead of disabling all users of function tracing on function grapherror, disable only function graph tracing. To do this, the arch codemust call ftrace_graph_is_dead() before it implements function graph.Cc: Ralf Baechle Tested-by: James Hogan Signed-off-by: Steven Rostedt List of files: /linux-6.15/arch/mips/kernel/ftrace.c

6ebda44f - MIPS: kernel: {ftrace,kgdb}: Set correct address limit for cache flushes

Mon, 16 Dec 2013 12:06:55 +0000

MIPS: kernel: {ftrace,kgdb}: Set correct address limit for cache flushesWhen flushing the icache, make sure the address limit is correctso the appropriate 'cache' instruction will be used. This has noimpact on cores operating in non-eva mode. However, when EVA isenabled, we ensure that 'cache' will be used instead of 'cachee'.Signed-off-by: Leonid Yegoshin Signed-off-by: Markos Chandras List of files: /linux-6.15/arch/mips/kernel/ftrace.c

a4671094 - MIPS: ftrace: Fix icache flush range error

Sat, 22 Feb 2014 07:46:49 +0000

MIPS: ftrace: Fix icache flush range errorIn 32-bit mode, the start address passed to flush_icache_range isshifted by 4 bytes before the second safe_store_code() call.This causes system crash from time to time because the first 4 bytesmight not be flushed properly. This bug exists since linux-3.8.Also remove obsoleted comment while at it.Signed-off-by: Viller Hsiao Cc: linux-mips@linux-mips.orgCc: rostedt@goodmis.orgCc: fweisbec@gmail.comCc: mingo@redhat.comCc: Qais.Yousef@imgtec.comPatchwork: https://patchwork.linux-mips.org/patch/6586/Signed-off-by: Ralf Baechle List of files: /linux-6.15/arch/mips/kernel/ftrace.c

3a36cb11 - ftrace: Do not pass data to ftrace_dyn_arch_init

Mon, 24 Feb 2014 18:59:59 +0000

ftrace: Do not pass data to ftrace_dyn_arch_initAs the data parameter is not really used by any ftrace_dyn_arch_init,remove that from ftrace_dyn_arch_init. This also removes the addrlocal variable from ftrace_init which is now unused.Note the documentation was imprecise as it did not suggest to set(*data) to 0.Link: http://lkml.kernel.org/r/1393268401-24379-4-git-send-email-jslaby@suse.czCc: Frederic Weisbecker Cc: Ingo Molnar Cc: linux-arch@vger.kernel.orgSigned-off-by: Jiri Slaby Signed-off-by: Steven Rostedt List of files: /linux-6.15/arch/mips/kernel/ftrace.c

af64a7cb - ftrace: Pass retval through return in ftrace_dyn_arch_init()

Mon, 24 Feb 2014 18:59:58 +0000

ftrace: Pass retval through return in ftrace_dyn_arch_init()No architecture uses the "data" parameter in ftrace_dyn_arch_init() in anyway, it just sets the value to 0. And this is used as a return valuein the caller -- ftrace_init, which just checks the retval againstzero.Note there is also "return 0" in every ftrace_dyn_arch_init. So it isenough to check the retval and remove all the indirect sets of data onall archs.Link: http://lkml.kernel.org/r/1393268401-24379-3-git-send-email-jslaby@suse.czCc: linux-arch@vger.kernel.orgSigned-off-by: Jiri Slaby Signed-off-by: Steven Rostedt List of files: /linux-6.15/arch/mips/kernel/ftrace.c

46e12c07 - MIPS: O32 / 32-bit: Always copy 4 stack arguments.

Sat, 14 Jul 2012 07:22:05 +0000

MIPS: O32 / 32-bit: Always copy 4 stack arguments.This gets us rid of the hard to maintain table of the number of syscallarguments and paves the way for further restructuring of the syscallcode.Signed-off-by: Ralf Baechle List of files: /linux-6.15/arch/mips/kernel/ftrace.c

19e2e172 - MIPS: Provide arch_syscall_addr.

Fri, 13 Jul 2012 21:38:17 +0000

MIPS: Provide arch_syscall_addr.The generic version is wrong for MIPS.Signed-off-by: Ralf Baechle List of files: /linux-6.15/arch/mips/kernel/ftrace.c