Changes in pgtable.h

0fff2aa9 - arm64: mm: Drop dead code for pud special bit handling

Thu, 20 Mar 2025 18:34:05 +0000

arm64: mm: Drop dead code for pud special bit handlingKeith Busch observed some incorrect macros defined in arm64 code [1].It turns out the two lines should never be needed and won't be exposed toanyone, because aarch64 doesn't select HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD,hence ARCH_SUPPORTS_PUD_PFNMAP is always N. The only archs that supportTHP PUDs so far are x86 and powerpc.Instead of fixing the lines (with no way to test it..), remove the twolines that are in reality dead code, to avoid confusing readers.Fixes tag is attached to reflect where the wrong macros were introduced,but explicitly not copying stable, because there's no real issue to befixed. So it's only about removing the dead code so far.[1] https://lore.kernel.org/all/Z9tDjOk-JdV_fCY4@kbusch-mbp.dhcp.thefacebook.com/#tCc: Alex Williamson Cc: Donald Dutile Cc: Will Deacon Fixes: 3e509c9b03f9 ("mm/arm64: support large pfn mappings")Reported-by: Keith Busch Signed-off-by: Peter Xu Reviewed-by: Donald Dutile Reviewed-by: Anshuman Khandual Link: https://lore.kernel.org/r/20250320183405.12659-1-peterx@redhat.comSigned-off-by: Catalin Marinas List of files: /linux-6.15/arch/arm64/include/asm/pgtable.h

d1770e90 - arm64/mm: Check pmd_table() in pmd_trans_huge()

Fri, 21 Feb 2025 04:42:26 +0000

arm64/mm: Check pmd_table() in pmd_trans_huge()Check for pmd_table() in pmd_trans_huge() rather then just checking for thePMD_TABLE_BIT. But ensure all present-invalid entries are handled correctlyby always setting PTE_VALID before checking with pmd_table().Cc: Will Deacon Cc: Ard Biesheuvel Cc: Ryan Roberts Cc: Mark Rutland Cc: linux-arm-kernel@lists.infradead.orgCc: linux-kernel@vger.kernel.orgSigned-off-by: Ryan Roberts Signed-off-by: Anshuman Khandual Link: https://lore.kernel.org/r/20250221044227.1145393-8-anshuman.khandual@arm.comSigned-off-by: Catalin Marinas List of files: /linux-6.15/arch/arm64/include/asm/pgtable.h

bfb1d2b9 - arm64/mm: Check PUD_TYPE_TABLE in pud_bad()

Fri, 21 Feb 2025 04:42:25 +0000

arm64/mm: Check PUD_TYPE_TABLE in pud_bad()pud_bad() is currently defined in terms of pud_table(). Although for someconfigs, pud_table() is hard-coded to true i.e. when using 64K base pagesor when page table levels are less than 3.pud_bad() is intended to check that the pud is configured correctly. Hencelet's open-code the same check that the full version of pud_table() usesinto pud_bad(). Then it always performs the check regardless of the config.Cc: Will Deacon Cc: Ard Biesheuvel Cc: Ryan Roberts Cc: Mark Rutland Cc: linux-arm-kernel@lists.infradead.orgCc: linux-kernel@vger.kernel.orgSigned-off-by: Ryan Roberts Signed-off-by: Anshuman Khandual Link: https://lore.kernel.org/r/20250221044227.1145393-7-anshuman.khandual@arm.comSigned-off-by: Catalin Marinas List of files: /linux-6.15/arch/arm64/include/asm/pgtable.h

4fa8a9c0 - arm64/mm: Check PXD_TYPE_TABLE in [p4d|pgd]_bad()

Fri, 21 Feb 2025 04:42:24 +0000

arm64/mm: Check PXD_TYPE_TABLE in [p4d|pgd]_bad()Check page table entries against PXD_TYPE_TABLE on PXD_TYPE_MASK mask bitsin [p4d|pgd]_bad() while determining a table entry instead of just checkingonly for PXD_TABLE_BIT.Cc: Will Deacon Cc: Ard Biesheuvel Cc: Ryan Roberts Cc: Mark Rutland Cc: linux-arm-kernel@lists.infradead.orgCc: linux-kernel@vger.kernel.orgSigned-off-by: Anshuman Khandual Link: https://lore.kernel.org/r/20250221044227.1145393-6-anshuman.khandual@arm.comSigned-off-by: Catalin Marinas List of files: /linux-6.15/arch/arm64/include/asm/pgtable.h

1601df9e - arm64/mm: Clear PXX_TYPE_MASK and set PXD_TYPE_SECT in [pmd|pud]_mkhuge()

Fri, 21 Feb 2025 04:42:23 +0000

arm64/mm: Clear PXX_TYPE_MASK and set PXD_TYPE_SECT in [pmd|pud]_mkhuge()Clear PXX_TYPE_MASK in [pmd|pud]_mkhuge() while creating section mappingsinstead of just the PXX_TABLE_BIT and also set PXD_TYPE_SECT. Also ensurePTE_VALID does not get modified in these helpers, because present-invalidentries should preserve their state across.Cc: Will Deacon Cc: Ard Biesheuvel Cc: Ryan Roberts Cc: Mark Rutland Cc: linux-arm-kernel@lists.infradead.orgCc: linux-kernel@vger.kernel.orgSigned-off-by: Anshuman Khandual Link: https://lore.kernel.org/r/20250221044227.1145393-5-anshuman.khandual@arm.comSigned-off-by: Catalin Marinas List of files: /linux-6.15/arch/arm64/include/asm/pgtable.h

dba95480 - arm64/mm: Clear PXX_TYPE_MASK in mk_[pmd|pud]_sect_prot()

Fri, 21 Feb 2025 04:42:22 +0000

arm64/mm: Clear PXX_TYPE_MASK in mk_[pmd|pud]_sect_prot()Clear PXX_TYPE_MASK bits in mk_[pmd|pud]_sect_prot() while creating sectionmappings instead of just clearing the PXX_TABLE_BIT.Cc: Will Deacon Cc: Ard Biesheuvel Cc: Ryan Roberts Cc: Mark Rutland Cc: linux-arm-kernel@lists.infradead.orgCc: linux-kernel@vger.kernel.orgSigned-off-by: Anshuman Khandual Link: https://lore.kernel.org/r/20250221044227.1145393-4-anshuman.khandual@arm.comSigned-off-by: Catalin Marinas List of files: /linux-6.15/arch/arm64/include/asm/pgtable.h

2d7872f3 - arm64/mm: Convert __pte_to_phys() and __phys_to_pte_val() as functions

Thu, 27 Feb 2025 02:24:12 +0000

arm64/mm: Convert __pte_to_phys() and __phys_to_pte_val() as functionsWhen CONFIG_ARM64_PA_BITS_52 is enabled, page table helpers __pte_to_phys()and __phys_to_pte_val() are functions which return phys_addr_t and pteval_trespectively as expected. But otherwise without this config being enabled,they are defined as macros and their return types are implicit.Until now this has worked out correctly as both pte_t and phys_addr_t datatypes have been 64 bits. But with the introduction of 128 bit page tables,pte_t becomes 128 bits. Hence this ends up with incorrect widths after theconversions, which leads to compiler warnings.Fix these warnings by converting __pte_to_phys() and __phys_to_pte_val()as functions instead where the return types are handled explicitly.Cc: Will Deacon Cc: linux-arm-kernel@lists.infradead.orgCc: linux-kernel@vger.kernel.orgSigned-off-by: Anshuman Khandual Reviewed-by: Ryan Roberts Link: https://lore.kernel.org/r/20250227022412.2015835-1-anshuman.khandual@arm.comSigned-off-by: Catalin Marinas List of files: /linux-6.15/arch/arm64/include/asm/pgtable.h

fe2169f5 - arm64/mm: Replace open encodings with PXD_TABLE_BIT

Tue, 07 Jan 2025 01:55:29 +0000

arm64/mm: Replace open encodings with PXD_TABLE_BIT[pgd|p4d]_bad() helpers have open encodings for their respective table bitswhich can be replaced with corresponding macros. This makes things clearer,thus improving their readability as well.Cc: Catalin Marinas Cc: Will Deacon Cc: Ard Biesheuvel Cc: Ryan Roberts Cc: Mark Rutland Cc: linux-arm-kernel@lists.infradead.orgCc: linux-kernel@vger.kernel.orgSigned-off-by: Anshuman Khandual Acked-by: Catalin Marinas Reviewed-by: Ryan Roberts Reviewed-by: Gavin Shan Link: https://lore.kernel.org/r/20250107015529.798319-1-anshuman.khandual@arm.comSigned-off-by: Will Deacon List of files: /linux-6.15/arch/arm64/include/asm/pgtable.h

16922658 - arm64/mm: Rename pte_mkpresent() as pte_mkvalid()

Tue, 07 Jan 2025 02:30:16 +0000

arm64/mm: Rename pte_mkpresent() as pte_mkvalid()pte_present() is no longer synonymous with pte_valid() as it also tests forpte_present_invalid() as well. Hence pte_mkpresent() is misleading, becauseall that does is make an entry mapped, via setting PTE_VALID. Hence renamethe helper as pte_mkvalid() which reflects its functionality appropriately.Cc: Catalin Marinas Cc: Will Deacon Cc: Ard Biesheuvel Cc: Ryan Roberts Cc: Mark Rutland Cc: linux-arm-kernel@lists.infradead.orgCc: linux-kernel@vger.kernel.orgSigned-off-by: Anshuman Khandual Acked-by: Catalin Marinas Link: https://lore.kernel.org/r/20250107023016.829416-1-anshuman.khandual@arm.comSigned-off-by: Will Deacon List of files: /linux-6.15/arch/arm64/include/asm/pgtable.h

e281bd22 - arm64: asm: Fix typo in pgtable.h

Tue, 03 Dec 2024 09:33:23 +0000

arm64: asm: Fix typo in pgtable.hThe word 'trasferring' is wrong, so fix it.Signed-off-by: Zhu Jun Link: https://lore.kernel.org/r/20241203093323.7831-1-zhujun2@cmss.chinamobile.comSigned-off-by: Will Deacon List of files: /linux-6.15/arch/arm64/include/asm/pgtable.h

a0e33f52 - arm64/mm: Replace open encodings with PXD_TABLE_BIT

Mon, 02 Dec 2024 08:38:50 +0000

arm64/mm: Replace open encodings with PXD_TABLE_BIT[pgd|p4d]_bad() helpers have open encodings for their respective table bitswhich can be replaced with corresponding macros. This makes things clearer,thus improving their readability as well.Cc: Catalin Marinas Cc: Will Deacon Cc: Ard Biesheuvel Cc: Ryan Roberts Cc: Mark Rutland Cc: linux-arm-kernel@lists.infradead.orgCc: linux-kernel@vger.kernel.orgSigned-off-by: Anshuman Khandual Reviewed-by: Ryan Roberts Reviewed-by: Gavin Shan Link: https://lore.kernel.org/r/20241202083850.73207-1-anshuman.khandual@arm.comSigned-off-by: Will Deacon List of files: /linux-6.15/arch/arm64/include/asm/pgtable.h

b349a5a2 - arm64: pgtable: Warn unexpected pmdp_test_and_clear_young()

Sat, 02 Nov 2024 10:42:35 +0000

arm64: pgtable: Warn unexpected pmdp_test_and_clear_young()Young bit operation on PMD table entry is only supported ifFEAT_HAFT enabled system wide. Add a warning for notifyingthe misbehaviour.Signed-off-by: Yicong Yang Reviewed-by: Catalin Marinas Link: https://lore.kernel.org/r/20241102104235.62560-6-yangyicong@huawei.comSigned-off-by: Catalin Marinas List of files: /linux-6.15/arch/arm64/include/asm/pgtable.h

62df5870 - arm64: Enable ARCH_HAS_NONLEAF_PMD_YOUNG

Sat, 02 Nov 2024 10:42:34 +0000

arm64: Enable ARCH_HAS_NONLEAF_PMD_YOUNGWith the support of FEAT_HAFT, the NONLEAF_PMD_YOUNG can be enabledon arm64 since the hardware is capable of updating the AF flag forPMD table descriptor. Since the AF bit of the table descriptorshares the same bit position in block descriptors, we only needto implement arch_has_hw_nonleaf_pmd_young() and select relatedconfigs. The related pmd_young test/update operations keeps thesame with and already implemented for transparent page support.Currently ARCH_HAS_NONLEAF_PMD_YOUNG is used to improve theefficiency of lru-gen aging.Signed-off-by: Yicong Yang Reviewed-by: Catalin Marinas Link: https://lore.kernel.org/r/20241102104235.62560-5-yangyicong@huawei.comSigned-off-by: Catalin Marinas List of files: /linux-6.15/arch/arm64/include/asm/pgtable.h

baec2397 - arm64/mm: Sanity check PTE address before runtime P4D/PUD folding

Tue, 05 Nov 2024 09:39:20 +0000

arm64/mm: Sanity check PTE address before runtime P4D/PUD foldingThe runtime P4D/PUD folding logic assumes that the respective pgd_t* andp4d_t* arguments are pointers into actual page tables that are part ofthe hierarchy being operated on.This may not always be the case, and we have been bitten once by thisalready [0], where the argument was actually a stack variable, and inthis case, the logic does not work at all.So let's add a VM_BUG_ON() for each case, to ensure that the address ofthe provided page table entry is consistent with the address beingtranslated.[0] https://lore.kernel.org/all/20240725090345.28461-1-will@kernel.org/T/#uSigned-off-by: Ard Biesheuvel Link: https://lore.kernel.org/r/20241105093919.1312049-2-ardb+git@google.comSigned-off-by: Catalin Marinas List of files: /linux-6.15/arch/arm64/include/asm/pgtable.h

ced84170 - arm64/mm: Drop setting PTE_TYPE_PAGE in pte_mkcont()

Mon, 04 Nov 2024 04:16:17 +0000

arm64/mm: Drop setting PTE_TYPE_PAGE in pte_mkcont()PTE_TYPE_PAGE bits were being set in pte_mkcont() because PTE_TABLE_BITwas being cleared in pte_mkhuge(). But after arch_make_huge_pte()modification in commit f8192813dcbe ("arm64/mm: Re-organizearch_make_huge_pte()"), which dropped pte_mkhuge() completely, settingback PTE_TYPE_PAGE bits is no longer necessary. Change pte_mkcont() toonly set PTE_CONT.Cc: Will Deacon Cc: Ard Biesheuvel Cc: Ryan Roberts Cc: Mark Rutland Cc: linux-arm-kernel@lists.infradead.orgCc: linux-kernel@vger.kernel.orgSigned-off-by: Anshuman Khandual Link: https://lore.kernel.org/r/20241104041617.3804617-1-anshuman.khandual@arm.comSigned-off-by: Catalin Marinas List of files: /linux-6.15/arch/arm64/include/asm/pgtable.h

f8192813 - arm64/mm: Re-organize arch_make_huge_pte()

Tue, 29 Oct 2024 04:45:29 +0000

arm64/mm: Re-organize arch_make_huge_pte()Core HugeTLB defines a fallback definition for arch_make_huge_pte(), whichcalls platform provided pte_mkhuge(). But if any platform already providesan override for arch_make_huge_pte(), then it does not need to provide thehelper pte_mkhuge().arm64 override for arch_make_huge_pte() calls pte_mkhuge() internally, thuscreating an impression, that both of these callbacks are being used in coreHugeTLB and hence required to be defined. This drops off pte_mkhuge() whichwas never required to begin with as there could not be any section mappingsat the PTE level. Re-organize arch_make_huge_pte() based on requested pagesize and create the entry for the applicable page table level as needed. Italso removes a redundancy of clearing PTE_TABLE_BIT bit followed by settingboth PTE_TABLE_BIT and PTE_VALID bits (via PTE_TYPE_MASK) in the pte, whilecreating CONT_PTE_SIZE size entries.Cc: Will Deacon Cc: Ard Biesheuvel Cc: Ryan Roberts Cc: Mark Rutland Cc: linux-arm-kernel@lists.infradead.orgCc: linux-kernel@vger.kernel.orgSigned-off-by: Anshuman Khandual Link: https://lore.kernel.org/r/20241029044529.2624785-1-anshuman.khandual@arm.comSigned-off-by: Catalin Marinas List of files: /linux-6.15/arch/arm64/include/asm/pgtable.h

42be24a4 - arm64: Enable memory encrypt for Realms

Thu, 17 Oct 2024 13:14:32 +0000

arm64: Enable memory encrypt for RealmsUse the memory encryption APIs to trigger a RSI call to request atransition between protected memory and shared memory (or vice versa)and updating the kernel's linear map of modified pages to flip the topbit of the IPA. This requires that block mappings are not used in thedirect map for realm guests.Reviewed-by: Catalin Marinas Reviewed-by: Gavin Shan Signed-off-by: Suzuki K Poulose Co-developed-by: Steven Price Signed-off-by: Steven Price Link: https://lore.kernel.org/r/20241017131434.40935-10-steven.price@arm.comSigned-off-by: Catalin Marinas List of files: /linux-6.15/arch/arm64/include/asm/pgtable.h

8ef41786 - arm64/mm: Change pgattr_change_is_safe() arguments as pteval_t

Tue, 01 Oct 2024 04:58:04 +0000

arm64/mm: Change pgattr_change_is_safe() arguments as pteval_tpgattr_change_is_safe() processes two distinct page table entries that justhappen to be 64 bits for all levels. This changes both arguments to reflectthe actual data type being processed in the function.This change is important when moving to FEAT_D128 based 128 bit page tablesbecause it makes it simple to change the entry size in one place.Cc: Will Deacon Cc: Mark Rutland Cc: Ard Biesheuvel Cc: linux-arm-kernel@lists.infradead.orgCc: linux-kernel@vger.kernel.orgReviewed-by: Ryan Roberts Signed-off-by: Anshuman Khandual Link: https://lore.kernel.org/r/20241001045804.1119881-1-anshuman.khandual@arm.comSigned-off-by: Catalin Marinas List of files: /linux-6.15/arch/arm64/include/asm/pgtable.h

3e509c9b - mm/arm64: support large pfn mappings

Mon, 26 Aug 2024 20:43:52 +0000

mm/arm64: support large pfn mappingsSupport huge pfnmaps by using bit 56 (PTE_SPECIAL) for "special" onpmds/puds. Provide the pmd/pud helpers to set/get special bit.There's one more thing missing for arm64 which is the pxx_pgprot() forpmd/pud. Add them too, which is mostly the same as the pte version bydropping the pfn field. These helpers are essential to be used in the newfollow_pfnmap*() API to report valid pgprot_t results.Note that arm64 doesn't yet support huge PUD yet, but it's stillstraightforward to provide the pud helpers that we need altogether. OnlyPMD helpers will make an immediate benefit until arm64 will support hugePUDs first in general (e.g. in THPs).Link: https://lkml.kernel.org/r/20240826204353.2228736-19-peterx@redhat.comSigned-off-by: Peter Xu Cc: Catalin Marinas Cc: Will Deacon Cc: Alexander Gordeev Cc: Alex Williamson Cc: Aneesh Kumar K.V Cc: Borislav Petkov Cc: Christian Borntraeger Cc: Dave Hansen Cc: David Hildenbrand Cc: Gavin Shan Cc: Gerald Schaefer Cc: Heiko Carstens Cc: Ingo Molnar Cc: Jason Gunthorpe Cc: Matthew Wilcox Cc: Niklas Schnelle Cc: Paolo Bonzini Cc: Ryan Roberts Cc: Sean Christopherson Cc: Sven Schnelle Cc: Thomas Gleixner Cc: Vasily Gorbik Cc: Zi Yan Signed-off-by: Andrew Morton List of files: /linux-6.15/arch/arm64/include/asm/pgtable.h

0515e022 - mm: always define pxx_pgprot()

Mon, 26 Aug 2024 20:43:42 +0000

mm: always define pxx_pgprot()There're: - 8 archs (arc, arm64, include, mips, powerpc, s390, sh, x86) that support pte_pgprot(). - 2 archs (x86, sparc) that support pmd_pgprot(). - 1 arch (x86) that support pud_pgprot().Always define them to be used in generic code, and then we don't need tofiddle with "#ifdef"s when doing so.Link: https://lkml.kernel.org/r/20240826204353.2228736-9-peterx@redhat.comSigned-off-by: Peter Xu Reviewed-by: Jason Gunthorpe Cc: Alexander Gordeev Cc: Alex Williamson Cc: Aneesh Kumar K.V Cc: Borislav Petkov Cc: Catalin Marinas Cc: Christian Borntraeger Cc: Dave Hansen Cc: David Hildenbrand Cc: Gavin Shan Cc: Gerald Schaefer Cc: Heiko Carstens Cc: Ingo Molnar Cc: Matthew Wilcox Cc: Niklas Schnelle Cc: Paolo Bonzini Cc: Ryan Roberts Cc: Sean Christopherson Cc: Sven Schnelle Cc: Thomas Gleixner Cc: Vasily Gorbik Cc: Will Deacon Cc: Zi Yan Signed-off-by: Andrew Morton List of files: /linux-6.15/arch/arm64/include/asm/pgtable.h