199da871 - arch, crash: move arch_crash_save_vmcoreinfo() out to file vmcore_info.c

Mon, 29 Jan 2024 13:50:33 +0000

arch, crash: move arch_crash_save_vmcoreinfo() out to file vmcore_info.cNathan reported below building error:=====$ curl -LSso .config https://git.alpinelinux.org/aports/plain/community/linux-edge/config-edge.armv7$ make -skj"$(nproc)" ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- olddefconfig all..arm-linux-gnueabi-ld: arch/arm/kernel/machine_kexec.o: in function `arch_crash_save_vmcoreinfo':machine_kexec.c:(.text+0x488): undefined reference to `vmcoreinfo_append_str'====On architecutres, like arm, s390, ppc, sh, functionarch_crash_save_vmcoreinfo() is located in machine_kexec.c and it canonly be compiled in when CONFIG_KEXEC_CORE=y.That's not right because arch_crash_save_vmcoreinfo() is used to exportarch specific vmcoreinfo. CONFIG_VMCORE_INFO is supposed to control itscompiling in. However, CONFIG_VMVCORE_INFO could be independent ofCONFIG_KEXEC_CORE, e.g CONFIG_PROC_KCORE=y will select CONFIG_VMVCORE_INFO.Or CONFIG_KEXEC/CONFIG_KEXEC_FILE is set while CONFIG_CRASH_DUMP isnot set, it will report linking error.So, on arm, s390, ppc and sh, move arch_crash_save_vmcoreinfo out toa new file vmcore_info.c. Let CONFIG_VMCORE_INFO decide if compiling inarch_crash_save_vmcoreinfo().[akpm@linux-foundation.org: remove stray newlines at eof]Link: https://lkml.kernel.org/r/20240129135033.157195-3-bhe@redhat.comSigned-off-by: Baoquan He Reported-by: Nathan Chancellor Closes: https://lore.kernel.org/all/20240126045551.GA126645@dev-arch.thelio-3990X/T/#uCc: Al Viro Cc: Eric W. Biederman Cc: Hari Bathini Cc: Klara Modin Cc: Michael Kelley Cc: Pingfan Liu Cc: Stephen Rothwell Cc: Yang Li Signed-off-by: Andrew Morton List of files: /linux-6.15/arch/arm/kernel/vmcore_info.c

Changes in vmcore_info.c

199da871 - arch, crash: move arch_crash_save_vmcoreinfo() out to file vmcore_info.c