Changes in bios32.c

09cc9006 - PCI: Introduce pci_dev_for_each_resource()

Thu, 30 Mar 2023 16:24:30 +0000

PCI: Introduce pci_dev_for_each_resource()Instead of open-coding it everywhere introduce a tiny helper that can beused to iterate over each resource of a PCI device, and convert the mostobvious users into it.While at it drop doubled empty line before pdev_sort_resources().No functional changes intended.Suggested-by: Andy Shevchenko Link: https://lore.kernel.org/r/20230330162434.35055-4-andriy.shevchenko@linux.intel.comSigned-off-by: Mika Westerberg Signed-off-by: Andy Shevchenko Signed-off-by: Bjorn Helgaas Reviewed-by: Krzysztof Wilczyński List of files: /linux-6.15/arch/arm/kernel/bios32.c

fc177304 - ARM/PCI: Remove unused fields from struct hw_pci

Wed, 16 Sep 2020 10:30:45 +0000

ARM/PCI: Remove unused fields from struct hw_pciThe msi_ctrl, io_optional and align_resource fields in struct hw_pci arecurrently unused by arm/mach PCI host controller drivers and we won'tbe adding any new users.Remove them and related code.Link: https://lore.kernel.org/r/20200904141607.4066-1-lorenzo.pieralisi@arm.comLink: https://lore.kernel.org/r/20200916103045.28651-1-lorenzo.pieralisi@arm.comSigned-off-by: Lorenzo Pieralisi Signed-off-by: Lorenzo Pieralisi Reviewed-by: Rob Herring Cc: Rob Herring Cc: Russell King List of files: /linux-6.15/arch/arm/kernel/bios32.c

6da5238f - ARM: 8993/1: remove it8152 PCI controller driver

Tue, 14 Jul 2020 13:09:44 +0000

ARM: 8993/1: remove it8152 PCI controller driverThe it8152 PCI host controller was only used by cm-x2xx platforms.Since these platforms were removed, there is no point to keep it8152driver.Acked-by: Arnd Bergmann Signed-off-by: Mike Rapoport Signed-off-by: Russell King List of files: /linux-6.15/arch/arm/kernel/bios32.c

7153884c - PCI: Remove PCI_REASSIGN_ALL_RSRC use on arm and arm64

Thu, 30 Nov 2017 17:21:57 +0000

PCI: Remove PCI_REASSIGN_ALL_RSRC use on arm and arm64On arm, PCI_REASSIGN_ALL_RSRC is used only in pcibios_assign_all_busses(),which helps decide whether to reconfigure bridge bus numbers. It hasnothing to do with BAR assignments. On arm64 and powerpc,pcibios_assign_all_busses() tests PCI_REASSIGN_ALL_BUS, which makes moresense.Align arm with arm64 and powerpc, so they all use PCI_REASSIGN_ALL_BUS forpcibios_assign_all_busses().Remove PCI_REASSIGN_ALL_RSRC from the generic, Tegra, Versatile, andR-Car drivers. These drivers are used only on arm or arm64, wherePCI_REASSIGN_ALL_RSRC is not used after this change, so removing itshould have no effect.No functional change intended.Signed-off-by: Bjorn Helgaas Reviewed-by: Manikanta Maddireddy Reviewed-by: Lorenzo Pieralisi List of files: /linux-6.15/arch/arm/kernel/bios32.c

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/arch/arm/kernel/bios32.c

f01fc417 - ARM/PCI: Fix pcibios_init_resource() struct pci_host_bridge leak

Mon, 10 Jul 2017 12:34:08 +0000

ARM/PCI: Fix pcibios_init_resource() struct pci_host_bridge leakSince commit 97ad2bdcbe85 ("ARM/PCI: Convert PCI scan API topci_scan_root_bus_bridge()") the space for struct pci_sys_data is allocatedby pci_alloc_host_bridge() as part of the struct pci_host_bridge.Therefore, failure paths must deallocate the entire pci_host_bridge byusing pci_free_host_bridge().Fixes: 97ad2bdcbe85 ("ARM/PCI: Convert PCI scan API to pci_scan_root_bus_bridge()")Signed-off-by: Lorenzo Pieralisi [bhelgaas: changelog]Signed-off-by: Bjorn Helgaas Cc: Jason Cooper Cc: Russell King Cc: Andrew Lunn List of files: /linux-6.15/arch/arm/kernel/bios32.c

16508469 - ARM/PCI: Remove pci_fixup_irqs() call for bios32 host controllers

Wed, 28 Jun 2017 20:14:04 +0000

ARM/PCI: Remove pci_fixup_irqs() call for bios32 host controllersLegacy PCI host controllers (ie host controllers that set-up the PCI busthrough the ARM pci_common_init() API) are currently relying onpci_fixup_irqs() to assign legacy PCI irqs to devices. This is not idealin that pci_fixup_irqs() assigns IRQs for all PCI devices present in a givensystem some of which may well be enabled by the time pci_fixup_irqs() iscalled (ie a system with multiple host controllers). With the introductionof struct pci_host_bridge.(*map_irq) pointer it is possible to assign IRQsfor all devices originating from a PCI host bridge at probe time; this isimplemented through pci_assign_irq() that relies on the structpci_host_bridge.map_irq pointer to map IRQ for a given device.The benefits this brings are twofold: - the IRQ for a device is assigned once at probe time - the IRQ assignment works also for hotplugged devicesRemove pci_fixup_irqs() call from bios32 code and rely on pci_assign_irq()to carry out the IRQ mapping at device probe time.The map_irq() and swizzle_irq() struct pci_host_bridge callbacks are set-upin the struct pci_host_bridge created in the bios32 pcibios_init_hw()function and mach-* code paths (for PCI mach implementations that require aspecific struct hw_pci.(*scan) function callback).Signed-off-by: Lorenzo Pieralisi [bhelgaas: folded in fixes from Lorenzo:http://lkml.kernel.org/r/20170701140629.GC8977@red-moon]Signed-off-by: Bjorn Helgaas Cc: Jason Cooper Cc: Russell King Cc: Andrew Lunn List of files: /linux-6.15/arch/arm/kernel/bios32.c

97ad2bdc - ARM/PCI: Convert PCI scan API to pci_scan_root_bus_bridge()

Wed, 28 Jun 2017 20:13:55 +0000

ARM/PCI: Convert PCI scan API to pci_scan_root_bus_bridge()The introduction of pci_scan_root_bus_bridge() provides a PCI core API toscan a PCI root bus backed by an already initialized struct pci_host_bridgeobject, which simplifies the bus scan interface and makes the PCI scan rootbus interface easier to generalize as members are added to the structpci_host_bridge.Convert ARM bios32 code to pci_scan_root_bus_bridge() to improve the PCIroot bus scanning interface.Signed-off-by: Lorenzo Pieralisi [bhelgaas: fold in warning fix from Arnd Bergmann :http://lkml.kernel.org/r/20170621215323.3921382-1-arnd@arndb.de][bhelgaas: set bridge->ops for mv78xx0][bhelgaas: fold in fixes from Lorenzo Pieralisi :http://lkml.kernel.org/r/20170701135457.GB8977@red-moon]Signed-off-by: Bjorn Helgaas Cc: Jason Cooper Cc: Russell King Cc: Andrew Lunn List of files: /linux-6.15/arch/arm/kernel/bios32.c

00d2904f - ARM/PCI: Use generic pci_mmap_resource_range()

Wed, 12 Apr 2017 12:26:00 +0000

ARM/PCI: Use generic pci_mmap_resource_range()Signed-off-by: David Woodhouse Signed-off-by: Bjorn Helgaas List of files: /linux-6.15/arch/arm/kernel/bios32.c

f66e2258 - PCI: Add BAR index argument to pci_mmap_page_range()

Wed, 12 Apr 2017 12:25:58 +0000

PCI: Add BAR index argument to pci_mmap_page_range()In all cases we know which BAR it is. Passing it in means that arch code(or generic code; watch this space) won't have to go looking for it again.Signed-off-by: David Woodhouse Signed-off-by: Bjorn Helgaas List of files: /linux-6.15/arch/arm/kernel/bios32.c

313cb902 - ARM/PCI: Remove arch-specific pcibios_enable_device()

Wed, 08 Jun 2016 11:04:50 +0000

ARM/PCI: Remove arch-specific pcibios_enable_device()On systems with PCI_PROBE_ONLY set, we rely on BAR assignments fromfirmware. Previously we did not insert those resources into the resourcetree, so we had to skip pci_enable_resources() because it fails ifresources are not in the resource tree.Now that we *do* insert resources even when PCI_PROBE_ONLY is set, we nolonger need the ARM-specific pcibios_enable_device(). Remove it so weuse the generic version.[bhelgaas: changelog]Signed-off-by: Lorenzo Pieralisi Signed-off-by: Bjorn Helgaas Acked-by: Will Deacon CC: Arnd Bergmann CC: Russell King List of files: /linux-6.15/arch/arm/kernel/bios32.c

b30742aa - ARM/PCI: Claim bus resources on PCI_PROBE_ONLY set-ups

Thu, 23 Jun 2016 10:36:22 +0000

ARM/PCI: Claim bus resources on PCI_PROBE_ONLY set-upsWe claim PCI BAR and bridge window resources in pci_bus_assign_resources(),but when PCI_PROBE_ONLY is set, we treat those resources as immutable anddon't call pci_bus_assign_resources(), so the resources aren't put in theresource tree.When the resources aren't in the tree, they don't show up in /proc/iomem,we can't detect conflicts, and we need special cases elsewhere forPCI_PROBE_ONLY or resources without a parent pointer.Claim all PCI BAR and window resources in the PCI_PROBE_ONLY case.If a PCI_PROBE_ONLY platform assigns conflicting resources, Linux can't fixthe conflicts. Previously we didn't notice the conflicts, but now we will,which may expose new failures.[bhelgaas: changelog, add resource comment, remove size/assign comments]Signed-off-by: Lorenzo Pieralisi Signed-off-by: Bjorn Helgaas CC: Russell King List of files: /linux-6.15/arch/arm/kernel/bios32.c

1fa05101 - ARM: Make PCI I/O space optional

Tue, 21 Jun 2016 15:54:29 +0000

ARM: Make PCI I/O space optionalFor callers of pci_common_init_dev(), we previously always required a PCII/O port resource. If the caller's ->setup() function had added an I/Oresource, we used that; otherwise, we added a default 64K I/O port spacefor it.There are PCI host bridges that do not support I/O port space, and weshould not add fictitious spaces for them.If a caller sets struct hw_pci.io_optional, assume it is responsible foradding any I/O port resource it desires, and do not add any default I/Oport space.Tested-by: Geert Uytterhoeven Signed-off-by: Bjorn Helgaas List of files: /linux-6.15/arch/arm/kernel/bios32.c

903589ca - ARM: 8554/1: kernel: pci: remove pci=firmware command line parameter handling

Fri, 01 Apr 2016 09:47:22 +0000

ARM: 8554/1: kernel: pci: remove pci=firmware command line parameter handlingAccording to kernel documentation, the pci=firmware command lineparameter is only meant to be used on IXP2000 ARM platforms to preventthe kernel from assigning PCI resources configured by the bootloader.Since the IXP2000 ARM platforms support has been removed from thekernel in commit:commit c65f2abf54a6 ("ARM: remove ixp23xx and ixp2000 platforms")its platforms specific kernel parameters should be removedtoo from the kernel documentation along with the kernel codecurrently handling them in that they have just become obsolete.This patch removes the pci=firmware command line parameter handlingfrom ARM code and the related kernel parameters documentationsection.Signed-off-by: Lorenzo Pieralisi Acked-by: Bjorn Helgaas Acked-by: Lennert Buytenhek Cc: Arnd Bergmann Cc: Lennert Buytenhek Cc: Jonathan Corbet Cc: Bjorn Helgaas Cc: Rob Herring Signed-off-by: Russell King List of files: /linux-6.15/arch/arm/kernel/bios32.c

7c7a0e94 - ARM/PCI: Move align_resource function pointer to pci_host_bridge structure

Wed, 11 Nov 2015 01:12:25 +0000

ARM/PCI: Move align_resource function pointer to pci_host_bridge structureCommit b3a72384fe29 ("ARM/PCI: Replace pci_sys_data->align_resource withglobal function pointer") introduced an ARM-specific align_resource()function pointer. This is not portable to other arches and doesn't workfor platforms with two different PCIe host bridge controllers.Move the function pointer to the pci_host_bridge structure so each hostbridge driver can specify its own align_resource() function.Signed-off-by: Gabriele Paoloni Signed-off-by: Bjorn Helgaas Reviewed-by: Arnd Bergmann List of files: /linux-6.15/arch/arm/kernel/bios32.c

b3a72384 - ARM/PCI: Replace pci_sys_data->align_resource with global function pointer

Fri, 30 Oct 2015 00:57:14 +0000

ARM/PCI: Replace pci_sys_data->align_resource with global function pointerdw_pcie_host_init() creates the PCI host bridge with pci_common_init_dev(),an ARM-specific function that supplies the ARM-specific pci_sys_datastructure as the PCI "sysdata". To use dw_pcie_host_init() on otherarchitectures, we will copy the internals of pci_common_init_dev() intopcie-designware.c instead of calling it, and dw_pcie_host_init() willsupply the DesignWare pcie_port structure as "sysdata".Most ARM "sysdata" users are specific to non-DesignWare host bridges;they'll be unaffected because those bridges will continue to have the ARMpci_sys_data. Most of the rest are ARM-generic functions called bypci_common_init_dev(); these will be unaffected because dw_pcie_host_init()will no longer call pci_common_init().But the ARM pcibios_align_resource() can be called by the PCI core for anybridge, so it can't depend on sysdata since it may be either pci_sys_dataor pcie_port.Remove the pcibios_align_resource() dependency on sysdata by replacing thepci_sys_data->align_resource pointer with a global function pointer.This is less general (we can no longer have per-host bridgealign_resource() methods), but the pci_sys_data->align_resource pointer wasused only by Marvell (see mvebu_pcie_enable()), so this would only be aproblem if we had a system with a combination of Marvell and other hostbridges[bhelgaas: changelog]Signed-off-by: Gabriele Paoloni Signed-off-by: Zhou Wang Signed-off-by: Bjorn Helgaas Acked-by: Pratyush Anand List of files: /linux-6.15/arch/arm/kernel/bios32.c

b5e5e8a1 - ARM/PCI: Remove msi_controller from struct pci_sys_data

Tue, 04 Aug 2015 16:58:49 +0000

ARM/PCI: Remove msi_controller from struct pci_sys_dataARM now uses pci_bus->msi to store the msi_controller pointer, so we don'tneed to save it in struct pci_sys_data, and we don't need to implementpcibios_msi_controller() to get it out of pci_sys_data.Remove msi_controller from struct pci_sys_data andpcibios_msi_controller().[bhelgaas: changelog, split into separate patch]Signed-off-by: Lorenzo Pieralisi Signed-off-by: Bjorn Helgaas Reviewed-by: Jingoo Han List of files: /linux-6.15/arch/arm/kernel/bios32.c

8953aab1 - ARM/PCI, designware, xilinx: Use pci_scan_root_bus_msi()

Wed, 29 Jul 2015 11:33:18 +0000

ARM/PCI, designware, xilinx: Use pci_scan_root_bus_msi()ARM previously stored the msi_controller pointer in its sysdata, structpci_sys_data, and implemented pcibios_msi_controller() to retrieve it.That made PCI host controller drivers specific to ARM because they had toput the msi_controller pointer in the ARM-specific pci_sys_data.There is now a generic mechanism, pci_scan_root_bus_msi(), for giving themsi_controller pointer to the PCI core. Use this for all ARM systems andfor the DesignWare and Xilinx PCI host controller drivers.This removes an ARM dependency from the DesignWare, DRA7xx, EXYNOS, i.MX6,Keystone, Layerscape, SPEAr13xx, and Xilinx drivers.[bhelgaas: changelog, split into separate patch]Suggested-by: Russell King Signed-off-by: Lorenzo Pieralisi Signed-off-by: Bjorn Helgaas Acked-by: Jingoo Han CC: Pratyush Anand CC: Arnd Bergmann CC: Simon Horman CC: Russell King CC: Thomas Petazzoni CC: Thierry Reding CC: Michal Simek CC: Marc Zyngier List of files: /linux-6.15/arch/arm/kernel/bios32.c

ada8b675 - ARM/PCI: Replace panic with WARN messages on failures

Wed, 29 Jul 2015 11:33:17 +0000

ARM/PCI: Replace panic with WARN messages on failuresIn the ARM PCI bios32 layer, failures to dynamically allocate pci_sys_datafor a PCI bus, or a PCI bus scan failure have to be considered seriouswarnings but they should not trigger a system panic so that at least thesystem is given a chance to be debugged.This patch replaces the panic statements with WARN() messages to improveerror reporting in the ARM PCI bios32 layer.Signed-off-by: Lorenzo Pieralisi Signed-off-by: Bjorn Helgaas Reviewed-by: Jingoo Han Acked-by: Marc Zyngier CC: Russell King CC: Marc Zyngier List of files: /linux-6.15/arch/arm/kernel/bios32.c

808b27a5 - ARM/PCI: Set MPS before pci_bus_add_devices()

Tue, 21 Jul 2015 21:35:19 +0000

ARM/PCI: Set MPS before pci_bus_add_devices()The MPS configuration should be done *before* pci_bus_add_devices(). Afterpci_bus_add_devices(), drivers may be bound to devices, and the PCI coreshouldn't touch device configuration while a driver owns the device.[bhelgaas: remove check for bus being non-NULL]Reported-by: Bjorn Helgaas Signed-off-by: Murali Karicheri Signed-off-by: Bjorn Helgaas List of files: /linux-6.15/arch/arm/kernel/bios32.c