Changes in kgdb.c

58d9ceb7 - ARC: pt_regs: create seperate type for ecr

Fri, 22 May 2020 00:44:32 +0000

ARC: pt_regs: create seperate type for ecrReduces duplication in each ISA specific pt_regsTested-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202308151342.ROQ9Urvv-lkp@intel.comSigned-off-by: Vineet Gupta List of files: /linux-6.15/arch/arc/kernel/kgdb.c

8e97bf39 - ARC: kgdb: add 'fallthrough' to prevent a warning

Thu, 22 Apr 2021 05:16:53 +0000

ARC: kgdb: add 'fallthrough' to prevent a warningUse the 'fallthrough' macro to document that this switch casedoes indeed fall through to the next case.../arch/arc/kernel/kgdb.c: In function 'kgdb_arch_handle_exception':../arch/arc/kernel/kgdb.c:141:6: warning: this statement may fall through [-Wimplicit-fallthrough=] 141 | if (kgdb_hex2long(&ptr, &addr)) | ^../arch/arc/kernel/kgdb.c:144:2: note: here 144 | case 'D': | ^~~~Cc: linux-snps-arc@lists.infradead.orgSigned-off-by: Randy Dunlap Signed-off-by: Vineet Gupta List of files: /linux-6.15/arch/arc/kernel/kgdb.c

d2912cb1 - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500

Tue, 04 Jun 2019 08:11:33 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500Based on 2 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation #extracted by the scancode license scanner the SPDX license identifier GPL-2.0-onlyhas been chosen to replace the boilerplate/reference in 4122 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Enrico Weigelt Reviewed-by: Kate Stewart Reviewed-by: Allison Randal Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190604081206.933168790@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/arch/arc/kernel/kgdb.c

cc028297 - kgdb/treewide: constify struct kgdb_arch arch_kgdb_ops

Thu, 06 Dec 2018 20:07:40 +0000

kgdb/treewide: constify struct kgdb_arch arch_kgdb_opscheckpatch.pl reports the following: WARNING: struct kgdb_arch should normally be const #28: FILE: arch/mips/kernel/kgdb.c:397: +struct kgdb_arch arch_kgdb_ops = {This report makes sense, as all other ops struct, thisone should also be const. This patch does the change.Cc: Vineet Gupta Cc: Russell King Cc: Catalin Marinas Cc: Will Deacon Cc: Yoshinori Sato Cc: Richard Kuo Cc: Michal Simek Cc: Ralf Baechle Cc: Paul Burton Cc: James Hogan Cc: Ley Foon Tan Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: Rich Felker Cc: "David S. Miller" Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: x86@kernel.orgAcked-by: Daniel Thompson Acked-by: Paul Burton Signed-off-by: Christophe Leroy Acked-by: Borislav Petkov Acked-by: Michael Ellerman (powerpc)Signed-off-by: Daniel Thompson List of files: /linux-6.15/arch/arc/kernel/kgdb.c

3cd99ac3 - kgdb: Fix kgdb_roundup_cpus() for arches who used smp_call_function()

Wed, 05 Dec 2018 03:38:26 +0000

kgdb: Fix kgdb_roundup_cpus() for arches who used smp_call_function()When I had lockdep turned on and dropped into kgdb I got a nice splaton my system. Specifically it hit: DEBUG_LOCKS_WARN_ON(current->hardirq_context)Specifically it looked like this: sysrq: SysRq : DEBUG ------------[ cut here ]------------ DEBUG_LOCKS_WARN_ON(current->hardirq_context) WARNING: CPU: 0 PID: 0 at .../kernel/locking/lockdep.c:2875 lockdep_hardirqs_on+0xf0/0x160 CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.19.0 #27 pstate: 604003c9 (nZCv DAIF +PAN -UAO) pc : lockdep_hardirqs_on+0xf0/0x160 ... Call trace: lockdep_hardirqs_on+0xf0/0x160 trace_hardirqs_on+0x188/0x1ac kgdb_roundup_cpus+0x14/0x3c kgdb_cpu_enter+0x53c/0x5cc kgdb_handle_exception+0x180/0x1d4 kgdb_compiled_brk_fn+0x30/0x3c brk_handler+0x134/0x178 do_debug_exception+0xfc/0x178 el1_dbg+0x18/0x78 kgdb_breakpoint+0x34/0x58 sysrq_handle_dbg+0x54/0x5c __handle_sysrq+0x114/0x21c handle_sysrq+0x30/0x3c qcom_geni_serial_isr+0x2dc/0x30c ... ... irq event stamp: ...45 hardirqs last enabled at (...44): [...] __do_softirq+0xd8/0x4e4 hardirqs last disabled at (...45): [...] el1_irq+0x74/0x130 softirqs last enabled at (...42): [...] _local_bh_enable+0x2c/0x34 softirqs last disabled at (...43): [...] irq_exit+0xa8/0x100 ---[ end trace adf21f830c46e638 ]---Looking closely at it, it seems like a really bad idea to be callinglocal_irq_enable() in kgdb_roundup_cpus(). If nothing else that seemslike it could violate spinlock semantics and cause a deadlock.Instead, let's use a private csd alongsidesmp_call_function_single_async() to round up the other CPUs. Usingsmp_call_function_single_async() doesn't require interrupts to beenabled so we can remove the offending bit of code.In order to avoid duplicating this across all the architectures thatuse the default kgdb_roundup_cpus(), we'll add a "weak" implementationto debug_core.c.Looking at all the people who previously had copies of this code,there were a few variants. I've attempted to keep the variantsworking like they used to. Specifically:* For arch/arc we passed NULL to kgdb_nmicallback() instead of get_irq_regs().* For arch/mips there was a bit of extra code around kgdb_nmicallback()NOTE: In this patch we will still get into trouble if we try to roundup a CPU that failed to round up before. We'll try to round it upagain and potentially hang when we try to grab the csd lock. That'snot new behavior but we'll still try to do better in a future patch.Suggested-by: Daniel Thompson Signed-off-by: Douglas Anderson Cc: Vineet Gupta Cc: Russell King Cc: Catalin Marinas Cc: Will Deacon Cc: Richard Kuo Cc: Ralf Baechle Cc: Paul Burton Cc: James Hogan Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: Yoshinori Sato Cc: Rich Felker Cc: "David S. Miller" Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: "H. Peter Anvin" Acked-by: Will Deacon Signed-off-by: Daniel Thompson List of files: /linux-6.15/arch/arc/kernel/kgdb.c

9ef7fa50 - kgdb: Remove irq flags from roundup

Wed, 05 Dec 2018 03:38:25 +0000

kgdb: Remove irq flags from roundupThe function kgdb_roundup_cpus() was passed a parameter that wasdocumented as:> the flags that will be used when restoring the interrupts. There is> local_irq_save() call before kgdb_roundup_cpus().Nobody used those flags. Anyone who wanted to temporarily turn oninterrupts just did local_irq_enable() and local_irq_disable() withoutlooking at them. So we can definitely remove the flags.Signed-off-by: Douglas Anderson Cc: Vineet Gupta Cc: Russell King Cc: Catalin Marinas Cc: Will Deacon Cc: Richard Kuo Cc: Ralf Baechle Cc: Paul Burton Cc: James Hogan Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: Yoshinori Sato Cc: Rich Felker Cc: "David S. Miller" Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: "H. Peter Anvin" Acked-by: Will Deacon Signed-off-by: Daniel Thompson List of files: /linux-6.15/arch/arc/kernel/kgdb.c

68db0cf1 - sched/headers: Prepare for new header dependencies before moving code to

Wed, 08 Feb 2017 17:51:37 +0000

sched/headers: Prepare for new header dependencies before moving code to We are going to split out of , whichwill have to be picked up from other headers and a couple of .c files.Create a trivial placeholder file that justmaps to to make this patch obviously correct andbisectable.Include the new header in the files that are going to need it.Acked-by: Linus Torvalds Cc: Mike Galbraith Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: linux-kernel@vger.kernel.orgSigned-off-by: Ingo Molnar List of files: /linux-6.15/arch/arc/kernel/kgdb.c

4fbf81ca - ARC: kgdb: generic kgdb_arch_pc() suffices

Mon, 20 Oct 2014 16:17:04 +0000

ARC: kgdb: generic kgdb_arch_pc() sufficesThe ARC version of kgdb_arch_pc() is identical to the generic version inkernel/debug/debug_core.c. Drop the ARC version so we use the generic one.Signed-off-by: Vineet Gupta Signed-off-by: Bjorn Helgaas List of files: /linux-6.15/arch/arc/kernel/kgdb.c

3d01c1ce - arc: kgdb: add default implementation for kgdb_roundup_cpus()

Thu, 24 Oct 2013 03:50:09 +0000

arc: kgdb: add default implementation for kgdb_roundup_cpus()arc supports kgdb, but need update -- add function kgdb_roundup_cpus(),or can not pass compiling. At present, add the simple generic one justlike other architectures(e.g. tile, mips ...).The related error (with allmodconfig): kernel/built-in.o: In function `kgdb_cpu_enter': kernel/debug/debug_core.c:580: undefined reference to `kgdb_roundup_cpus'Signed-off-by: Chen Gang Signed-off-by: Vineet Gupta List of files: /linux-6.15/arch/arc/kernel/kgdb.c

38a9ff6d - ARC: Remove explicit passing around of ECR

Wed, 12 Jun 2013 09:43:40 +0000

ARC: Remove explicit passing around of ECRWith ECR now part of pt_regs* No need to propagate from lowest asm handlers as arg* No need to save it in tsk->thread.cause_code* Avoid bit chopping to access the bit-fieldsMore code consolidation, cleanupSigned-off-by: Vineet Gupta List of files: /linux-6.15/arch/arc/kernel/kgdb.c

502a0c77 - ARC: pt_regs update #5: Use real ECR for pt_regs->event vs. synth values

Tue, 11 Jun 2013 13:26:54 +0000

ARC: pt_regs update #5: Use real ECR for pt_regs->event vs. synth valuespt_regs->event was set with artificial values to identify the low levelsystem event (syscall trap / breakpoint trap / exceptions / interrupts)With r8 saving out of the way, the full word can be used to save realECR (Exception Cause Register) which helps idenify the event naturally,including additional info such as cause code, param.Only for Interrupts, where ECR is not applicable, do we resort tosynthetic non ECR values.SAVE_ALL_TRAP/EXCEPTIONS can now be merged as they both use ECR withdifferent runtime values.The ptrace helpers now use the sub-fields of ECR to distinguish theevents (e.g. vector 0x25 is trap, param 0 is syscall...)The following benefits will follow:(1) This centralizes the location of where ECR is saved and will allow the cleanup of task->thread.cause_code ECR placeholder which is set in non-uniform way. Then ARC VM code can safely rely on it being there for purpose of finer grained VM_EXEC dcache flush (based on exec fault: I-TLB Miss)(2) Further, ECR being passed around from low level handlers as arg can be eliminated as it is part of standard reg-file in pt_regsSigned-off-by: Vineet Gupta List of files: /linux-6.15/arch/arc/kernel/kgdb.c

1540c85b - ARC: make allyesconfig build breakages

Thu, 07 Mar 2013 11:17:23 +0000

ARC: make allyesconfig build breakages CC drivers/mmc/host/mmc_spi.odrivers/mmc/host/mmc_spi.c:118: error: redefinition of 'struct scratch'make[3]: *** [drivers/mmc/host/mmc_spi.o] Error 1make[2]: *** [drivers/mmc/host] Error 2make[1]: *** [drivers/mmc] Error 2make: *** [drivers] Error 2 CC arch/arc/kernel/kgdb.oIn file included from include/linux/kgdb.h:20, from arch/arc/kernel/kgdb.c:11:/home/vineetg/arc/k.org/arc-port/arch/arc/include/asm/kgdb.h:34:warning: 'struct pt_regs' declared inside parameter list/home/vineetg/arc/k.org/arc-port/arch/arc/include/asm/kgdb.h:34:warning: its scope is only this definition or declaration, which isprobably not what you wantarch/arc/kernel/kgdb.c:172: error: conflicting types for 'kgdb_trap' CC arch/arc/kernel/kgdb.oarch/arc/kernel/kgdb.c: In function 'pt_regs_to_gdb_regs':arch/arc/kernel/kgdb.c:62: error: dereferencing pointer to incompletetypeSigned-off-by: Vineet Gupta List of files: /linux-6.15/arch/arc/kernel/kgdb.c

f46121bd - ARC: kgdb support

Fri, 18 Jan 2013 09:42:24 +0000

ARC: kgdb supportSigned-off-by: Mischa Jonker Signed-off-by: Vineet Gupta Cc: Jason Wessel Acked-by: Jason Wessel List of files: /linux-6.15/arch/arc/kernel/kgdb.c