54a19b4d - docs: ABI: cleanup several ABI documents

Fri, 30 Oct 2020 07:40:50 +0000

docs: ABI: cleanup several ABI documentsThere are some ABI documents that, while they don't generateany warnings, they have issues when parsed by get_abi.pl scripton its output result.Address them, in order to provide a clean output.Reviewed-by: Tom Rix # for fpga-managerReviewed-By: Kajol Jain # for sysfs-bus-event_source-devices-hv_gpci and sysfs-bus-event_source-devices-hv_24x7Acked-by: Jonathan Cameron #for IIOAcked-by: Oded Gabbay # for HabanalabsAcked-by: Vaibhav Jain # for sysfs-bus-papr-pmemAcked-by: Cezary Rojewski # for catptAcked-by: Suzuki K Poulose Acked-by: Ilya Dryomov # for rbdAcked-by: Jonathan Corbet Signed-off-by: Mauro Carvalho Chehab Link: https://lore.kernel.org/r/5bc78e5b68ed1e9e39135173857cb2e753be868f.1604042072.git.mchehab+huawei@kernel.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/Documentation/ABI/testing/sysfs-class-led-trigger-usbport

0f247626 - usb: core: Introduce a USB port LED trigger

Fri, 16 Sep 2016 14:13:48 +0000

usb: core: Introduce a USB port LED triggerThis commit adds a new trigger responsible for turning on LED when USBdevice gets connected to the selected USB port. This can can useful forvarious home routers that have USB port(s) and a proper LED telling usera device is connected.The trigger gets its documentation file but basically it just requiresenabling it and selecting USB ports (e.g. echo 1 > ports/usb1-1).There was a long discussion on design of this driver. Its current stateis a result of picking them most adjustable solution as others couldn'thandle all cases.1) It wasn't possible for the driver to register separated trigger for each USB port. Some physical USB ports are handled by more than one controller and so by more than one USB port. E.g. USB 2.0 physical port may be handled by OHCI's port and EHCI's port. It's also not possible to assign more than 1 trigger to a single LED and implementing such feature would be tricky due to syncing triggers and sysfs conflicts with old triggers.2) Another idea was to register trigger per USB hub. This wouldn't allow handling devices with multiple USB LEDs and controllers (hubs) controlling more than 1 physical port. It's common for hubs to have few ports and each may have its own LED.This final trigger is highly flexible. It allows selecting any USB portsfor any LED. It was also modified (comparing to the initial version) toallow choosing ports rather than having user /guess/ proper names. Itwas successfully tested on SmartRG SR400ac which has 3 USB LEDs,2 physical ports and 3 controllers.It was noted USB subsystem already has usb-gadget and usb-host triggersbut they are pretty trivial ones. They indicate activity only and can'thave ports specified.In future it may be good idea to consider adding activity support tousbport as well. This should allow switching to this more generic driverand maybe marking old ones as obsolete.This can be implemented with another sysfs file for setting mode. Thedefault mode wouldn't change so there won't be ABI breakage and so suchfeature can be safely implemented later.There was also an idea of supporting other devices (PCI, SDIO, etc.) butas this driver already contains some USB specific code (and will getmore) these should be probably separated drivers (triggers).Signed-off-by: Rafał Miłecki Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/Documentation/ABI/testing/sysfs-class-led-trigger-usbport

Changes in sysfs-class-led-trigger-usbport

54a19b4d - docs: ABI: cleanup several ABI documents

0f247626 - usb: core: Introduce a USB port LED trigger