Changes in misc

d0b2dbfa - Remove $FreeBSD$: one-line sh pattern

Wed, 16 Aug 2023 17:55:03 +0000

Remove $FreeBSD$: one-line sh patternRemove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/ List of files: /freebsd-14.2/usr.sbin/bsdconfig/startup/misc

405c3050 - Remove iBCS2, part1: userspace

Wed, 19 Dec 2018 21:56:54 +0000

Remove iBCS2, part1: userspaceiBCS2 was disconnected from the build in 2015 (see r291419)bsdconfig parts submitted by dteske.Reviewed by: kib (previous version)Sponsored by: The FreeBSD Foundation List of files: /freebsd-14.2/usr.sbin/bsdconfig/startup/misc

efe3b0de - Remove SVR4 (System V Release 4) binary compatibility support.

Tue, 28 Feb 2017 05:14:42 +0000

Remove SVR4 (System V Release 4) binary compatibility support.UNIX System V Release 4 is operating system released in 1988. It ceasedto exist in early 2000-s. List of files: /freebsd-14.2/usr.sbin/bsdconfig/startup/misc

d4ae33f0 - Performance and debugging enhancements:

Sat, 07 Dec 2013 00:31:01 +0000

Performance and debugging enhancements:+ Remove UNAME_P=$(...) from startup/misc -- already supplied by common.subr+ Use f_getvar instead of $(eval echo \$$var) -- f_getvar is sub-shell free+ Add `-e' and `-k var' options to f_eval_catch -- increasing use-cases+ Use f_eval_catch to display errors on failure -- reducing duplicated code+ Use f_eval_catch when we need output from a command -- improving debugging+ Optimize f_isinter of strings.subr for performance -- now sub-shell free+ Improve error checking on pidfiles -- using f_eval_catch and f_isinteger+ Use $var_to_set arg of f_ifconfig_{inet,netmask} -- eliminate sub-shells+ Use f_sprintf instead of $(printf ...) -- consolidate sub-shells+ Use $var_to_set arg of f_route_get_default -- eliminate sub-shells+ Add f_count to replace $(set -- ...;echo $#) -- eliminate sub-shells+ Add f_count_ifs to replace $(IFS=x;set -- ...;echo $#) -- no sub-shells+ Replace var="$var${var:+ }..." in loops with var="$var ..." with a follow- up var="${var# }" to trim leading whitespace -- optimize loops+ Use $var_to_set arg of f_resolv_conf_nameservers -- eliminate sub-shells+ Comments for the f_eval_catch function+ Remove a duplicate `local ... desc ...' in f_device_get_all of device.subr+ Use $var_to_set arg of f_device_capacity -- eliminate sub-shells+ Whitespace fixes in f_dialog_init of dialog.subr+ Optimize f_inet_atoi of media/tcpip.subr for performance -- sub-shell free+ In several cases, send stderr to /dev/null -- clean up runtime execution+ Change f_err of common.subr to go to program stderr not terminal stderr, allowing redirection of output from functions that use f_err+ Disable debugging when using f_getvar to get variable argument to f_startup_rcconf_map_expand of startup/rcconf.subr+ Use f_replace_all instead of $(echo ... | tr | sed) -- performance+ Add a $var_to_set option to f_index_{file,menusel_{command,keyword}} of common.subr -- centralize sub-shells List of files: /freebsd-14.2/usr.sbin/bsdconfig/startup/misc

f677a9e2 - Introduce centralized [X]dialog(1) exit codes to `dialog.subr' and make-use

Wed, 09 Oct 2013 08:12:26 +0000

Introduce centralized [X]dialog(1) exit codes to `dialog.subr' and make-usethroughout the bsdconfig(8) code. While we're here, add an explicit argumentto lvalue-seeking invocations of "return" that previously had no argument.Also, consolidate a single instance of double-newline and remove somecomments that are no longer required (given increased readability with newexit codes).Approved by: re (glebius) List of files: /freebsd-14.2/usr.sbin/bsdconfig/startup/misc

8e37a7c8 - Fix typos in the BSD License.

Sun, 07 Jul 2013 18:51:44 +0000

Fix typos in the BSD License. List of files: /freebsd-14.2/usr.sbin/bsdconfig/startup/misc

f8ea072a - Be consistent with other usr.sbin programs w/respect to the copyright

Sun, 07 Jul 2013 18:21:30 +0000

Be consistent with other usr.sbin programs w/respect to the copyrightwording ("All rights reserved."); I had the casing wrong on many instances. List of files: /freebsd-14.2/usr.sbin/bsdconfig/startup/misc

c9c67103 - More whitespace.

Mon, 24 Jun 2013 20:58:54 +0000

More whitespace. List of files: /freebsd-14.2/usr.sbin/bsdconfig/startup/misc

1a134945 - Style -- no ;; needed on fallback clause within case-statement.

Wed, 19 Jun 2013 18:44:55 +0000

Style -- no ;; needed on fallback clause within case-statement. List of files: /freebsd-14.2/usr.sbin/bsdconfig/startup/misc

aaeba1c1 - Perform some code consolidation and replace nested case-statements with

Tue, 18 Jun 2013 23:18:32 +0000

Perform some code consolidation and replace nested case-statements withmore logical if-else statements for each menu selection. List of files: /freebsd-14.2/usr.sbin/bsdconfig/startup/misc

2a90fca0 - Remove extraneous characters ('<<<') from `Exit' menutag in the "Security"

Sat, 08 Jun 2013 16:28:08 +0000

Remove extraneous characters ('<<<') from `Exit' menutag in the "Security"and "Startup"->"Misc" modules to make the menus appear more consistent withthe numerous other modules and look a little cleaner.PR: ports/169316 List of files: /freebsd-14.2/usr.sbin/bsdconfig/startup/misc

f4844f65 - Improvements to whitespace and comments.

Sun, 02 Jun 2013 22:34:40 +0000

Improvements to whitespace and comments. List of files: /freebsd-14.2/usr.sbin/bsdconfig/startup/misc

052f8969 - Standardize the way functions build their arguments leading up to a dialog

Sun, 02 Jun 2013 20:02:50 +0000

Standardize the way functions build their arguments leading up to a dialoginvocation. Specifically, "top-load" your arguments and in the order in-which they will be displayed. For example, many [if not all] widgets displayinformation in the following order, top-to-bottom (visually):+ backtitle (displayed behind the widget at top-left)+ title (at the top of the `window')+ prompt text (just below the title and above whatever widget you choose)+ Depending on widget, _one_ of the following: - menu list - radio list - check list - text input box with initial text - [Xdialog(1)] 2x or 3x text input boxes - [dialog(1)] a multi-part form - progress bar - etc. (many more widget choices)+ buttons (right below the selected widget)+ [dialog(1)] the hline (displayed at bottom of `window')NOTE: Xdialog(1) accepts and silently ignores --hlineWhen building local arguments for your dialog invocation, if the value can'tbe cleanly loaded into a local, add "# Calculated below" to the end of thelocal declaration while retaining the block order of argument declarations.Move other local declarations that are not associated with this top-loadingthe dialog arguments to right-above where they are first-used.Also, standardize on the names of the arguments. For example, always use$prompt (instead of sometimes $msg and sometimes $prompt); use $menu_listor $shell_list or $radio_list for those respective widgets; ad nauseum.While we're doing this, flush-out full arguments for many invocations thatwere passing NULL strings (making it unapparent if you were staring at thisone invocation what argument that NULL string was supposed to represent).Last, while we're in startup/rcconf let's remove the unnecessary use of aGLOBAL (RCCONF_MENU_LIST) for the menu_list. List of files: /freebsd-14.2/usr.sbin/bsdconfig/startup/misc

77599778 - Improve the dialog(1) API in dialog.subr by adding f_dialog_default_store()

Sun, 02 Jun 2013 09:02:12 +0000

Improve the dialog(1) API in dialog.subr by adding f_dialog_default_store()and f_dialog_default_fetch(). Operating similar to functions introduced bySVN r251236 and r251242, these functions operate as a pair for helping trackthe default-item data (for the --menu, --checklist, and --radiolistwidgets).This replaces the direct usage of a global to store the data with anabstract method for readability and to centralize the code. List of files: /freebsd-14.2/usr.sbin/bsdconfig/startup/misc

ec7120b5 - Similar to r251236, improve the portion of dialog(1) API in dialog.subr

Sun, 02 Jun 2013 05:45:25 +0000

Similar to r251236, improve the portion of dialog(1) API in dialog.subrresponsible for retrieving stored input (for the --inputbox and --passwordwidgets).When we (Ron McDowell and I) developed the first version of bsdconfig, itused temporary files to store responses from dialog(1). That hasn't beentrue for a very long time, so the need to always execute some clean-upfunction is long-deprecated. The function that used to perform these clean-up routines for these widgets was f_dialog_inputstr().We really don't need f_dialog_inputstr() for its originally designed purposeas all dialog invocations no longer require temporary files.Just as in r251236, redesign f_dialog_inputstr() in the following four ways:1. Rename f_dialog_inputstr() to f_dialog_inputstr_fetch()2. Introduce the new first-argument of $var_to_set to reduce forking3. Create a corresponding f_dialog_inputstr_store() to abstract storage4. Offload the sanitization to a new function, f_dialog_line_sanitize()It should be noted that f_dialog_line_sanitize() -- unlike its cousin fromSVN r251236, f_dialog_data_sanitize() -- trims leading/trailing whitespacefrom the user's input. This helps prevent errors and common mistakes causedby the fact that the new cdialog implementation allows the right-arrowcursor key to go beyond the last byte of realtime input (adding whitespaceat the end of the typed value).While we're centralizing the sanitization, let's rewrite f_dialog_input()while we're here to likewise reduce forking. The f_dialog_input() functionnow expects the first argument of $var_to_set instead of producing resultson standard-out.These changes greatly improve readability and also improve performance. List of files: /freebsd-14.2/usr.sbin/bsdconfig/startup/misc

fd962ac6 - Improve portion of the dialog(1) API in dialog.subr responsible for

Sat, 01 Jun 2013 23:58:44 +0000

Improve portion of the dialog(1) API in dialog.subr responsible forretrieving stored data (for the --menu, --calendar, --timebox, --checklist,and --radiolist widgets).When we (Ron McDowell and I) developed the first version of bsdconfig, itused temporary files to store responses from dialog(1). That hasn't beentrue for some very long time, so the need to always store the return statusof dialog(1) and then call some function to clean-up is long-deprecated. Thefunction that used to do the clean-up was f_dialog_menutag().We really don't need f_dialog_menutag() for its originally designed purpose,as all dialog invocations (even when in a sub-shell) do not use temporaryfiles anymore.However, we do need to keep f_dialog_menutag() around because it still fillsthe need of being able to abstract the procedure for fetching stored dataprovided by functions that display the aforementioned widgets.In re-designing f_dialog_menutag(), four important changes are made:1. Rename f_dialog_menutag() to f_dialog_menutag_fetch()2. Introduce the new first-argument of $var_to_set to reduce number of forks3. Create a corresponding f_dialog_menutag_store() to abstract the storage4. Offload the sanitization to a new function, f_dialog_data_sanitize()NOTE: That last one is important. Not all functions need to store their datafor later fetching, meanwhile every invocation of dialog should be sanitized(as we learned early-on in the i18n-effort -- underlying libraries will spitwarnings to stderr for bad values of $LANG and since dialog outputs itsresponses to stderr, we need to sanitize every response of these warnings).These changes greatly improve readbaility and also improve performance byreducing unnecessary forking. List of files: /freebsd-14.2/usr.sbin/bsdconfig/startup/misc

74036c4d - Improve portion of the dialog(1) API in dialog.subr responsible for

Fri, 31 May 2013 19:07:17 +0000

Improve portion of the dialog(1) API in dialog.subr responsible forcalculating widget sizes. Instead of forking a sub-shell to calculate theoptimum size for a widget, use a byRef style call-out to set variables inthe parent namespace. For example, instead of: size=$( f_dialog_buttonbox_size title btitle msg ) $DIALOG --title title --backtitle btitle --msgbox msg $sizeThe new API replaces the above with the following: f_dialog_buttonbox_size height width title btitle msg $DIALOG --title title --backtitle btitle --msgbox msg $height $widthThis reduces the number of forks, improves performance, and makes the codemore readable by revealing the argument-order for widget sizing. It alsomakes performing minor adjustments to the calculated values easier asyou no longer have to split-out the response (which required knowledge ofordering so was counter-intuitive). List of files: /freebsd-14.2/usr.sbin/bsdconfig/startup/misc

c3755aa3 - Centralize standard getopts arguments, both for convenience and to correct

Tue, 14 May 2013 03:21:13 +0000

Centralize standard getopts arguments, both for convenience and to correcta bug in which certain combinations of arguments produced unexpected resultssuch as `-dX' (now properly produces debugging and X11), `-XS' (now properlyproduces X11 in secure mode), `-df-' (enables debugging when reading ascript from standard-input, etc. Multi-word variations such as `-d -X',`-X -S', `-d -f-', `-d -f -', etc. also work as expected. Also tested werevariations in argument order, which are now working as expected. List of files: /freebsd-14.2/usr.sbin/bsdconfig/startup/misc

d3a0f918 - UI improvements. First, implement --default-item whenever and wherever

Mon, 22 Apr 2013 05:52:06 +0000

UI improvements. First, implement --default-item whenever and whereverpossible to save keystrokes. Second, overhaul startup/rcdelete for muchimproved performance. Last, but not least, kill-off useage of --clearand implement --keep-tite in harmony to minimize jarring transitions.Also, fix local variable names where necessary while we're here withother minor comment-enhancements/typo-corrections. List of files: /freebsd-14.2/usr.sbin/bsdconfig/startup/misc

e14ddd1f - Add new flags `-d' (sets debug=1) and `-D file' (sets debugFile) and

Mon, 22 Apr 2013 05:02:34 +0000

Add new flags `-d' (sets debug=1) and `-D file' (sets debugFile) andimprove debugging initialization. Also fixup USAGE statements while we'rehere. Also, change initialization of main program to _not_ change workingdirectory, allowing the debugFile to be relative without confusion. List of files: /freebsd-14.2/usr.sbin/bsdconfig/startup/misc