en Copyright 2015 Java http://172.16.0.5:8080/history/freebsd-14.2/tests/sys/cddl/zfs/include/libtest.kshlib#d0b2dbfa Remove $FreeBSD$: one-line sh patternRemove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/ List of files: /freebsd-14.2/tests/sys/cddl/zfs/include/libtest.kshlib Wed, 16 Aug 2023 17:55:03 +0000 Warner Losh <imp@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-14.2/tests/sys/cddl/zfs/include/libtest.kshlib#11ed0a95 zfs tests: stop writing to arbitrary devicesTL;DR: Three ZFS tests created ZFS pools on all unmounted devices listedin /etc/fstab, corrupting their contents. Stop that.Imagine my surprise when the ESP on my main dev/test VM would "randomly"become corrupted, making it unbootable. Three tests collect various devicesfrom the system and try to add them to a test pool. The test expects thisto fail because it _assumes_ these devices are in use and ZFS will correctlyreject the request.My /etc/fstab has two entries for devices in /dev: /dev/gpt/swap0 none swap sw,trimonce,late /dev/gpt/esp0 /boot/efi msdosfs rw,noautoNote the `noauto` on the ESP. In a remarkable example of irony, I chosethis because it should keep the ESP more protected from corruption;in fact, mounting it would have protected it from this case.The tests added all of these devices to a test pool in a _single command_,expecting the command to fail. The swap device was in use, so the commandcorrectly failed, but the ESP was added and therefore corrupted. However,since the command correctly failed, the test didn't notice the ESP problem.If each device had been added with its own command, the test _might_ havenoticed that one of them incorrectly succeeded. However, two of thesetests would not have noticed:hotspare_create_001_neg was incorrectly specified as needing the Solarisdumpadm command, so it was skipped. _Some_ of the test needs that command,but it checks for its presence and runs fine without it.Due to bug 241070, zpool_add_005_pos was marked as an expected failure.Due to the coarse level of integration with ATF, this test would still"pass" even if it failed for the wrong reason. I wrote bug 267554 toreconsider the use of atf_expect_fail in these tests.Let's further consider the use of various devices found around the system.In addition to devices in /etc/fstab, the tests also used mounted deviceslisted by the `mount` command. If ZFS behaves correctly, it will refuseto added mounted devices and swap devices to a pool. However, these areunit tests used by developers to ensure that ZFS still works after theymodify it, so it's reasonable to expect ZFS to do the _wrong_ thingsometimes. Using random host devices is unsafe.Fix the root problem by using only the disks provided via the "disks"variable in kyua.conf. Use one to create a UFS file system and mount it.Use another as a swap device. Use a third as a dump device, but expectit to fail due to bug 241070.While I'm here:Due to commit 6b6e2954dd65, we can simply add a second dump device andremove it in cleanup. We no longer need to save, replace, and restore thepre-existing dump device.The cleanup_devices function used `camcontrol inquiry` to distinguish disksfrom other devices, such as partitions. That works fine for SCSI, but notfor ATA or VirtIO block. Use `geom disk list` instead.PR: 241070PR: 267554Reviewed by: asomersSponsored by: Dell Inc.Differential Revision: https://reviews.freebsd.org/D37257 List of files: /freebsd-14.2/tests/sys/cddl/zfs/include/libtest.kshlib Thu, 03 Nov 2022 02:42:54 +0000 Eric van Gyzen <vangyzen@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-14.2/tests/sys/cddl/zfs/include/libtest.kshlib#c43f30ee ZFS: fix the redundancy tests* Fix force_sync_path, which ensures that a file is fully flushed to disk. Apparently "zpool history"'s performance has improved, but exporting and importing the pool still works.* Fix file_dva by using undocumented zdb syntax to clarify that we're interested in the pool's root file system, not the pool itself. This should also fix the zpool_clear_001_pos test.* Remove a redundant cleanup stepMFC after: 2 weeksSponsored by: AxcientDifferential Revision: https://reviews.freebsd.org/D21901 List of files: /freebsd-14.2/tests/sys/cddl/zfs/include/libtest.kshlib Mon, 07 Oct 2019 20:21:23 +0000 Alan Somers <asomers@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-14.2/tests/sys/cddl/zfs/include/libtest.kshlib#5a2fc464 ZFS test suite: fix uses of illumos /dev/[r]dsk/ and /dev/zvol/[r]dsk/ List of files: /freebsd-14.2/tests/sys/cddl/zfs/include/libtest.kshlib Tue, 27 Mar 2018 11:49:15 +0000 Andriy Gapon <avg@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-14.2/tests/sys/cddl/zfs/include/libtest.kshlib#a7478ad1 zfs test suite: support device paths with intermediate directoriesThe code assumed that disks (devices) used for testing are always namedlike /dev/foo, but there is no reason for that restriction and we caneasily support paths like /dev/stripe/bar. List of files: /freebsd-14.2/tests/sys/cddl/zfs/include/libtest.kshlib Thu, 15 Mar 2018 12:47:34 +0000 Andriy Gapon <avg@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-14.2/tests/sys/cddl/zfs/include/libtest.kshlib#ee00e55c zfs test suite: fix a typo, da0 vs $disk List of files: /freebsd-14.2/tests/sys/cddl/zfs/include/libtest.kshlib Thu, 15 Mar 2018 12:35:22 +0000 Andriy Gapon <avg@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-14.2/tests/sys/cddl/zfs/include/libtest.kshlib#2fae26bd Add the ZFS test suiteIt was originally written by Sun as part of the STF (Solaris test framework).They open sourced it in OpenSolaris, then HighCloud partially ported it toFreeBSD, and Spectra Logic finished the port. We also added many testcases,fixed many broken ones, and converted them all to the ATF framework. We've hadhelp along the way from avg, araujo, smh, and brd.By default most of the tests are disabled. Set the disks Kyua variable toenable them.Submitted by: asomers, will, justing, ken, brd, avg, araujo, smhSponsored by: Spectra Logic Corp, HighCloud List of files: /freebsd-14.2/tests/sys/cddl/zfs/include/libtest.kshlib Fri, 23 Feb 2018 16:31:00 +0000 Alan Somers <asomers@FreeBSD.org>