Changes in ng_socket.c

2e8d60c6 - ng_socket: Treat EEXIST from kern_kldload() as success

Tue, 09 Apr 2024 10:04:47 +0000

ng_socket: Treat EEXIST from kern_kldload() as successEEXIST is possible in a race condition.Inspired by: ffc72591b1f5 (Don't worry if a module is already loaded ...)Reviewed by: glebiusMFC after: 1 weekDifferential Revision: https://reviews.freebsd.org/D44633(cherry picked from commit f6f67f58c19db4f25f5c2cf4869efc7054493a55) List of files: /freebsd-14.2/sys/netgraph/ng_socket.c

95ee2897 - sys: Remove $FreeBSD$: two-line .h pattern

Wed, 16 Aug 2023 17:54:11 +0000

sys: Remove $FreeBSD$: two-line .h patternRemove /^\s*\*\n \*\s+\$FreeBSD\$$\n/ List of files: /freebsd-14.2/sys/netgraph/ng_socket.c

e7d02be1 - protosw: refactor protosw and domain static declaration and load

Wed, 17 Aug 2022 18:50:32 +0000

protosw: refactor protosw and domain static declaration and loado Assert that every protosw has pr_attach. Now this structure is only for socket protocols declarations and nothing else.o Merge struct pr_usrreqs into struct protosw. This was suggested in 1996 by wollman@ (see 7b187005d18ef), and later reiterated in 2006 by rwatson@ (see 6fbb9cf860dcd).o Make struct domain hold a variable sized array of protosw pointers. For most protocols these pointers are initialized statically. Those domains that may have loadable protocols have spacers. IPv4 and IPv6 have 8 spacers each (andre@ dff3237ee54ea).o For inetsw and inet6sw leave a comment noting that many protosw entries very likely are dead code.o Refactor pf_proto_[un]register() into protosw_[un]register().o Isolate pr_*_notsupp() methods into uipc_domain.cReviewed by: melifaroDifferential revision: https://reviews.freebsd.org/D36232 List of files: /freebsd-14.2/sys/netgraph/ng_socket.c

74967928 - ng_socket: don't assign NULL in C99 sparse initializer

Mon, 09 May 2022 17:42:48 +0000

ng_socket: don't assign NULL in C99 sparse initializer List of files: /freebsd-14.2/sys/netgraph/ng_socket.c

644ca084 - domains: make domain_init() initialize only global state

Mon, 03 Jan 2022 18:15:22 +0000

domains: make domain_init() initialize only global stateNow that each module handles its global and VNET initializationitself, there is no VNET related stuff left to do in domain_init().Differential revision: https://reviews.freebsd.org/D33541 List of files: /freebsd-14.2/sys/netgraph/ng_socket.c

7045b160 - socket: Implement SO_RERROR

Wed, 28 Jul 2021 15:46:59 +0000

socket: Implement SO_RERRORSO_RERROR indicates that receive buffer overflows should be handled aserrors. Historically receive buffer overflows have been ignored andprograms could not tell if they missed messages or messages had beentruncated because of overflows. Since programs historically do notexpect to get receive overflow errors, this behavior is not thedefault.This is really really important for programs that use route(4) to keepin sync with the system. If we loose a message then we need to reloadthe full system state, otherwise the behaviour from that point isundefined and can lead to chasing bogus bug reports.Reviewed by: philip (network), kbowling (transport), gbe (manpages)MFC after: 2 weeksDifferential Revision: https://reviews.freebsd.org/D26652 List of files: /freebsd-14.2/sys/netgraph/ng_socket.c

f161d294 - Add missing sockaddr length and family validation to various protocols

Mon, 03 May 2021 16:51:04 +0000

Add missing sockaddr length and family validation to various protocolsSeveral protocol methods take a sockaddr as input. In some cases thesockaddr lengths were not being validated, or were validated after someout-of-bounds accesses could occur. Add requisite checking to variousprotocol entry points, and convert some existing checks to assertionswhere appropriate.Reported by: syzkaller+KASANReviewed by: tuexen, melifaroMFC after: 2 weeksSponsored by: The FreeBSD FoundationDifferential Revision: https://reviews.freebsd.org/D29519 List of files: /freebsd-14.2/sys/netgraph/ng_socket.c

924d1c9a - Revert "SO_RERROR indicates that receive buffer overflows should be handled as errors."

Mon, 08 Feb 2021 22:30:39 +0000

Revert "SO_RERROR indicates that receive buffer overflows should be handled as errors."Wrong version of the change was pushed inadvertenly.This reverts commit 4a01b854ca5c2e5124958363b3326708b913af71. List of files: /freebsd-14.2/sys/netgraph/ng_socket.c

4a01b854 - SO_RERROR indicates that receive buffer overflows should be handled as errors.

Sun, 07 Feb 2021 17:21:18 +0000

SO_RERROR indicates that receive buffer overflows should be handled as errors.Historically receive buffer overflows have been ignored and programscould not tell if they missed messages or messages had been truncatedbecause of overflows. Since programs historically do not expect to getreceive overflow errors, this behavior is not the default.This is really really important for programs that use route(4) to keep in syncwith the system. If we loose a message then we need to reload the full systemstate, otherwise the behaviour from that point is undefined and can leadto chasing bogus bug reports. List of files: /freebsd-14.2/sys/netgraph/ng_socket.c

3326f7e9 - [ng_socket] Don't take the SOCKBUF_LOCK() twice in the RX data path.

Thu, 17 Dec 2020 18:15:07 +0000

[ng_socket] Don't take the SOCKBUF_LOCK() twice in the RX data path.This is just a minor optimization, but it's sensitive. This gives an improvement of 30-50 kpps.Reviewed by: kp, markj, glebius, lutz_donnerhacke.deApproved by: vmaffione (mentor)Sponsored by: vstack.comDifferential Revision: https://reviews.freebsd.org/D27382 List of files: /freebsd-14.2/sys/netgraph/ng_socket.c

662c1305 - net: clean up empty lines in .c and .h files

Tue, 01 Sep 2020 21:19:14 +0000

net: clean up empty lines in .c and .h files List of files: /freebsd-14.2/sys/netgraph/ng_socket.c

7029da5c - Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (17 of many)

Wed, 26 Feb 2020 14:26:36 +0000

Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (17 of many)r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that arestill not MPSAFE (or already are but aren’t properly marked).Use it in preparation for a general review of all nodes.This is non-functional change that adds annotations to SYSCTL_NODE andSYSCTL_PROC nodes using one of the soon-to-be-required flags.Mark all obvious cases as MPSAFE. All entries that haven't been markedas MPSAFE before are by default marked as NEEDGIANTApproved by: kib (mentor, blanket)Commented by: kib, gallatin, melifaroDifferential Revision: https://reviews.freebsd.org/D23718 List of files: /freebsd-14.2/sys/netgraph/ng_socket.c

039eb22c - Rework second part of r357558. Unroll the macro and allocate memory in

Fri, 21 Feb 2020 04:18:15 +0000

Rework second part of r357558. Unroll the macro and allocate memory insleepable manner before entering the epoch for the send. List of files: /freebsd-14.2/sys/netgraph/ng_socket.c

be3d57e6 - Revert one half of previous change r357558. Don't enter the epoch on

Fri, 21 Feb 2020 04:10:41 +0000

Revert one half of previous change r357558. Don't enter the epoch onsends to control socket. Control socket messages can run constructorsof nodes and other stuff that is allowed to M_WAITOK.PR: 244241 List of files: /freebsd-14.2/sys/netgraph/ng_socket.c

940508a5 - Enter the network epoch when ng_socket sends data or control from user

Wed, 05 Feb 2020 03:06:29 +0000

Enter the network epoch when ng_socket sends data or control from userland to the netgraph and potentially further down the network stack. List of files: /freebsd-14.2/sys/netgraph/ng_socket.c

323b076e - sys: use our nitems() macro when param.h is available.

Thu, 21 Apr 2016 19:40:10 +0000

sys: use our nitems() macro when param.h is available.This should cover all the remaining cases in the kernel.Discussed in: freebsd-current List of files: /freebsd-14.2/sys/netgraph/ng_socket.c

155d72c4 - sys/net* : for pointers replace 0 with NULL.

Fri, 15 Apr 2016 17:30:33 +0000

sys/net* : for pointers replace 0 with NULL.Mostly cosmetical, no functional change.Found with devel/coccinelle. List of files: /freebsd-14.2/sys/netgraph/ng_socket.c

f0188618 - Fix multiple incorrect SYSCTL arguments in the kernel:

Tue, 21 Oct 2014 07:31:21 +0000

Fix multiple incorrect SYSCTL arguments in the kernel:- Wrong integer type was specified.- Wrong or missing "access" specifier. The "access" specifiersometimes included the SYSCTL type, which it should not, except forprocedural SYSCTL nodes.- Logical OR where binary OR was expected.- Properly assert the "access" argument passed to all SYSCTL macros,using the CTASSERT macro. This applies to both static- and dynamicallycreated SYSCTLs.- Properly assert the the data type for both static and dynamicSYSCTLs. In the case of static SYSCTLs we only assert that the datapointed to by the SYSCTL data pointer has the correct size, hencethere is no easy way to assert types in the C language outside aC-function.- Rewrote some code which doesn't pass a constant "access" specifierwhen creating dynamic SYSCTL nodes, which is now a requirement.- Updated "EXAMPLES" section in SYSCTL manual page.MFC after: 3 daysSponsored by: Mellanox Technologies List of files: /freebsd-14.2/sys/netgraph/ng_socket.c

37863816 - Use NG_WAITOK as ng_package_msg() argument instead of M_WAITOK.

Thu, 22 May 2014 06:40:07 +0000

Use NG_WAITOK as ng_package_msg() argument instead of M_WAITOK.Submitted by: Dmitry Luhtionov List of files: /freebsd-14.2/sys/netgraph/ng_socket.c

8338a34a - In ng_getsockaddr() allocate memory prior to obtaining lock.

Thu, 16 Feb 2012 14:44:52 +0000

In ng_getsockaddr() allocate memory prior to obtaining lock.Reported & tested by: Mykola Dzham List of files: /freebsd-14.2/sys/netgraph/ng_socket.c