Changes in fuse_node.c

2d19c2cd - fusefs: correct a comment

Thu, 04 Apr 2024 20:18:56 +0000

fusefs: correct a comment[skip ci]Sponsored by: Axcient(cherry picked from commit c1326c01df81dd06739ddf1946e1968ddaba0c8e) List of files: /freebsd-14.2/sys/fs/fuse/fuse_node.c

739488cc - fusefs: fix invalid value for st_birthtime.tv_nsec

Thu, 25 Jan 2024 15:19:37 +0000

fusefs: fix invalid value for st_birthtime.tv_nsecIf a file system's on-disk format does not support st_birthtime, itisn't clear what value it should return in stat(2). Neither our manpage nor the OpenGroup specifies. But our convention for UFS andmsdosfs is to return { .tv_sec = -1, .tv_nsec = 0 }. fusefs isdifferent. It returns { .tv_sec = -1, .tv_nsec = -1 }. It's done thatever since the initial import in SVN r241519.Most software apparently handles this just fine. It must, because we'vehad no complaints. But the Rust standard library will panic whenreading such a timestamp during std::fs::metadata, even if the callerdoesn't care about that particular value. That's a separate bug, andshould be fixed.Change our invalid value to match msdosfs and ufs, pacifying the Ruststandard library.PR: 276602Sponsored by: AxcientReviewed by: emasteDifferential Revision: https://reviews.freebsd.org/D43590(cherry picked from commit 55b80e2ca52c4b27c4920d372a6e71ac9ab7da9e) List of files: /freebsd-14.2/sys/fs/fuse/fuse_node.c

685dc743 - sys: Remove $FreeBSD$: one-line .c pattern

Wed, 16 Aug 2023 17:54:36 +0000

sys: Remove $FreeBSD$: one-line .c patternRemove /^[\s*]*__FBSDID$"\$FreeBSD\$"$;?\s*\n/ List of files: /freebsd-14.2/sys/fs/fuse/fuse_node.c

ba8cc6d7 - vfs: use __enum_uint8 for vtype and vstate

Sun, 12 Mar 2023 19:31:27 +0000

vfs: use __enum_uint8 for vtype and vstateThis whacks hackery around only reading v_type once.Bump __FreeBSD_version to 1400093 List of files: /freebsd-14.2/sys/fs/fuse/fuse_node.c

829f0bcb - vfs: add the concept of vnode state transitions

Mon, 19 Dec 2022 13:00:30 +0000

vfs: add the concept of vnode state transitionsTo quote from a comment above vput_final:* XXX Some filesystems pass in an exclusively locked vnode and strongly depend* on the lock being held all the way until VOP_INACTIVE. This in particular* happens with UFS which adds half-constructed vnodes to the hash, where they* can be found by other code.As is there is no mechanism which allows filesystems to denote that avnode is fully initialized, consequently problems like the above areonly found the hard way(tm).Add rudimentary support for state transitions, which in particular allowto assert the vnode is not legally unlocked until its fate is decided(either construction finishes or vgone is called to abort it).The new field lands in a 1-byte hole, thus it does not grow the struct.Bump __FreeBSD_version to 1400077Reviewed by: kib (previous version)Tested by: phoDifferential Revision: https://reviews.freebsd.org/D37759 List of files: /freebsd-14.2/sys/fs/fuse/fuse_node.c

0bef4927 - fusefs: handle evil servers that return illegal inode numbers

Wed, 04 May 2022 23:36:17 +0000

fusefs: handle evil servers that return illegal inode numbers* If during FUSE_CREATE, FUSE_MKDIR, etc the server returns the same inode number for the new file as for its parent directory, reject it. Previously this would triggers a recurse-on-non-recursive lock panic.* If during FUSE_LINK the server returns a different inode number for the new name as for the old one, reject it. Obviously, that can't be a hard link.* If during FUSE_LOOKUP the server returns the same inode number for the new file as for its parent directory, reject it. Nothing good can come of this.PR: 263662Reported by: Robert Morris MFC after: 2 weeksReviewed by: pfgDifferential Revision: https://reviews.freebsd.org/D35128 List of files: /freebsd-14.2/sys/fs/fuse/fuse_node.c

3d856234 - fusefs: Address -Wunused-but-set-variable warnings

Thu, 20 Jan 2022 13:25:00 +0000

fusefs: Address -Wunused-but-set-variable warningsReviewed by: asomersMFC after: 1 weekDifferential Revision: https://reviews.freebsd.org/D33957 List of files: /freebsd-14.2/sys/fs/fuse/fuse_node.c

13d593a5 - Fix a race in fusefs that can corrupt a file's size.

Mon, 29 Nov 2021 02:17:34 +0000

Fix a race in fusefs that can corrupt a file's size.VOPs like VOP_SETATTR can change a file's size, with the vnodeexclusively locked. But VOPs like VOP_LOOKUP look up the file size fromthe server without the vnode locked. So a race is possible. Forexample:1) One thread calls VOP_SETATTR to truncate a file. It locks the vnode and sends FUSE_SETATTR to the server.2) A second thread calls VOP_LOOKUP and fetches the file's attributes from the server. Then it blocks trying to acquire the vnode lock.3) FUSE_SETATTR returns and the first thread releases the vnode lock.4) The second thread acquires the vnode lock and caches the file's attributes, which are now out-of-date.Fix this race by recording a timestamp in the vnode of the last timethat its filesize was modified. Check that timestamp during VOP_LOOKUPand VFS_VGET. If it's newer than the time at which FUSE_LOOKUP wasissued to the server, ignore the attributes returned by FUSE_LOOKUP.PR: 259071Reported by: Agata Reviewed by: pfgMFC after: 2 weeksDifferential Revision: https://reviews.freebsd.org/D33158 List of files: /freebsd-14.2/sys/fs/fuse/fuse_node.c

25927e06 - fusefs: correctly handle an inode that changes file types

Mon, 06 Dec 2021 05:43:17 +0000

fusefs: correctly handle an inode that changes file typesCorrectly handle the situation where a FUSE server unlinks a file, thencreates a new file of a different type but with the same inode number.Previously fuse_vnop_lookup in this situation would return EAGAIN. Butsince it didn't call vgone(), the vnode couldn't be reused right away.Fix this by immediately calling vgone() and reallocating a new vnode.This problem can occur in three code paths, during VOP_LOOKUP,VOP_SETATTR, or following FUSE_GETATTR, which usually happens duringVOP_GETATTR but can occur during other vops, too. Note that the correctresponse actually doesn't depend on whether the entry cache has expired.In fact, during VOP_LOOKUP, we can't even tell. Either it has expiredalready, or else the vnode got reclaimed by vnlru.Also, correct the error code during the VOP_SETATTR path.PR: 258022Reported by: chogata@moosefs.proMFC after: 2 weeksReviewed by: pfgDifferential Revision: https://reviews.freebsd.org/D33283 List of files: /freebsd-14.2/sys/fs/fuse/fuse_node.c

91972cfc - fusefs: update atime on reads when using cached attributes

Mon, 29 Nov 2021 01:53:31 +0000

fusefs: update atime on reads when using cached attributesWhen using cached attributes, whether or not the data cache is enabled,fusefs must update a file's atime whenever it reads from it, so long asit wasn't mounted with -o noatime. Update it in-kernel, and flush it tothe server on close or during the next setattr operation.The downside is that close() will now frequently trigger a FUSE_SETATTRupcall. But if you care about performance, you should be using-o noatime anyway.MFC after: 2 weeksReviewed by: pfgDifferential Revision: https://reviews.freebsd.org/D33145 List of files: /freebsd-14.2/sys/fs/fuse/fuse_node.c

b4a58fbf - vfs: remove cn_thread

Fri, 01 Oct 2021 21:16:54 +0000

vfs: remove cn_threadIt is always curthread.Reviewed by: kibDifferential Revision: https://reviews.freebsd.org/D32453 List of files: /freebsd-14.2/sys/fs/fuse/fuse_node.c

5d94aaac - fusefs: quiet some cache-related warnings

Sun, 03 Oct 2021 16:59:04 +0000

fusefs: quiet some cache-related warningsIf the FUSE server does something that would make our cache incoherent,we should print a warning to the user. However, we previously warned insome situations when we shouldn't, such as if the file's size changed onthe server _after_ our own attribute cache had expired. This changesuppresses the warning in cases like that. It also moves the warninglogic to a single place within the code.PR: 256936Reported by: Agata Tested by: Agata , jSML4ThWwBID69YC@protonmail.comMFC after: 2 weeks List of files: /freebsd-14.2/sys/fs/fuse/fuse_node.c

2bfd8992 - vnode: move write cluster support data to inodes.

Mon, 15 Feb 2021 04:35:59 +0000

vnode: move write cluster support data to inodes.The data is only needed by filesystems that1. use buffer cache2. utilize clustering write support.Requested by: mjgReviewed by: asomers (previous version), fsu (ext2 parts), mckusickTested by: phoSponsored by: The FreeBSD FoundationDifferential Revision: https://reviews.freebsd.org/D28679 List of files: /freebsd-14.2/sys/fs/fuse/fuse_node.c

586ee69f - fs: clean up empty lines in .c and .h files

Tue, 01 Sep 2020 21:18:40 +0000

fs: clean up empty lines in .c and .h files List of files: /freebsd-14.2/sys/fs/fuse/fuse_node.c

b0ecfb42 - fusefs: avoid cache corruption with buggy fuse servers

Wed, 11 Mar 2020 04:29:45 +0000

fusefs: avoid cache corruption with buggy fuse serversThe FUSE protocol allows the client (kernel) to cache a file's size, if theserver (userspace daemon) allows it. A well-behaved daemon obviously shouldnot change a file's size while a client has it cached. But a buggy daemonmight. If the kernel ever detects that that has happened, then it shouldinvalidate the entire cache for that file. Previously, we would not onlycache stale data, but in the case of a file extension while we had the sizecached, we accidentally extended the cache with zeros.PR: 244178Reported by: Ben RUBSON Reviewed by: cemMFC after: 2 weeksDifferential Revision: https://reviews.freebsd.org/D24012 List of files: /freebsd-14.2/sys/fs/fuse/fuse_node.c

388820fb - fusefs: add missing CLTFLAG_MPSAFE annotation

Wed, 15 Jan 2020 01:31:28 +0000

fusefs: add missing CLTFLAG_MPSAFE annotation List of files: /freebsd-14.2/sys/fs/fuse/fuse_node.c

427d205c - fusefs: remove superfluous counter_u64_zero

Tue, 06 Aug 2019 00:50:25 +0000

fusefs: remove superfluous counter_u64_zeroReported by: glebiusSponsored by: The FreeBSD Foundation List of files: /freebsd-14.2/sys/fs/fuse/fuse_node.c

07e86257 - fusefs: fix the build with some NODEBUG kernels

Sat, 13 Jul 2019 21:41:12 +0000

fusefs: fix the build with some NODEBUG kernelssystm.h needs to be included before counter.hSponsored by: The FreeBSD Foundation List of files: /freebsd-14.2/sys/fs/fuse/fuse_node.c

8aafc8c3 - [skip ci] update copyright headers in fusefs files

Fri, 28 Jun 2019 04:18:10 +0000

[skip ci] update copyright headers in fusefs filesSponsored by: The FreeBSD Foundation List of files: /freebsd-14.2/sys/fs/fuse/fuse_node.c

560a55d0 - fusefs: convert statistical sysctls to use counter(9)

Thu, 27 Jun 2019 16:30:25 +0000

fusefs: convert statistical sysctls to use counter(9)counter(9) is more performant than using atomic instructions to updatesysctls that just report statistics to userland.Sponsored by: The FreeBSD Foundation List of files: /freebsd-14.2/sys/fs/fuse/fuse_node.c