Changes in devfs_vnops.c

9ccd5394 - devfs_allocv(): style

Tue, 07 May 2024 12:33:01 +0000

devfs_allocv(): style(cherry picked from commit 6d79564fe341c8dbf09405cae1a0a76460aaf8aa) List of files: /freebsd-14.2/sys/fs/devfs/devfs_vnops.c

cde0347c - cdevpriv(9): add iterator

Fri, 22 Mar 2024 02:58:00 +0000

cdevpriv(9): add iterator(cherry picked from commit d3efbe0132b24e8660df836905cda7662f85a154) List of files: /freebsd-14.2/sys/fs/devfs/devfs_vnops.c

7dff3d1c - kcmp(2): implement for devfs files

Fri, 19 Jan 2024 21:36:50 +0000

kcmp(2): implement for devfs files(cherry picked from commit 5c41d888de1aba0e82531fb6df4cc3b6989d37bd) List of files: /freebsd-14.2/sys/fs/devfs/devfs_vnops.c

23332e34 - devfs: add integrity asserts for cdevp_list

Tue, 19 Sep 2023 13:44:34 +0000

devfs: add integrity asserts for cdevp_listIt's possible for misuse of cdev KPIs or for bugs in devfs itself toresult in e.g. a cdev object's container being freed while still on theglobal list used to populate each devfs mount; see PR 273418 for arecent example.Since a node may be marked inactive well before it is reaped from thelist, add a new flag solely to track list membership, and employ it insome basic list integrity assertions to catch bad actors.Discussed with: kib, mjg(cherry picked from commit 67864268da53b792836f13be10299de8cd62997e) List of files: /freebsd-14.2/sys/fs/devfs/devfs_vnops.c

95ee2897 - sys: Remove $FreeBSD$: two-line .h pattern

Wed, 16 Aug 2023 17:54:11 +0000

sys: Remove $FreeBSD$: two-line .h patternRemove /^\s*\*\n \*\s+\$FreeBSD\$$\n/ List of files: /freebsd-14.2/sys/fs/devfs/devfs_vnops.c

4d846d26 - spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSD

Wed, 10 May 2023 15:40:58 +0000

spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSDThe SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catchup to that fact and revert to their recommended match of BSD-2-Clause.Discussed with: pfgMFC After: 3 daysSponsored by: Netflix List of files: /freebsd-14.2/sys/fs/devfs/devfs_vnops.c

829f0bcb - vfs: add the concept of vnode state transitions

Mon, 19 Dec 2022 13:00:30 +0000

vfs: add the concept of vnode state transitionsTo quote from a comment above vput_final:* XXX Some filesystems pass in an exclusively locked vnode and strongly depend* on the lock being held all the way until VOP_INACTIVE. This in particular* happens with UFS which adds half-constructed vnodes to the hash, where they* can be found by other code.As is there is no mechanism which allows filesystems to denote that avnode is fully initialized, consequently problems like the above areonly found the hard way(tm).Add rudimentary support for state transitions, which in particular allowto assert the vnode is not legally unlocked until its fate is decided(either construction finishes or vgone is called to abort it).The new field lands in a 1-byte hole, thus it does not grow the struct.Bump __FreeBSD_version to 1400077Reviewed by: kib (previous version)Tested by: phoDifferential Revision: https://reviews.freebsd.org/D37759 List of files: /freebsd-14.2/sys/fs/devfs/devfs_vnops.c

5b5b7e2c - vfs: always retain path buffer after lookup

Sat, 17 Sep 2022 09:10:38 +0000

vfs: always retain path buffer after lookupThis removes some of the complexity needed to maintain HASBUF andallows for removing injecting SAVENAME by filesystems.Reviewed by: kib (previous version)Differential Revision: https://reviews.freebsd.org/D36542 List of files: /freebsd-14.2/sys/fs/devfs/devfs_vnops.c

497240de - Retire clone_drain_lock

Fri, 19 Aug 2022 21:20:51 +0000

Retire clone_drain_lockIt is only ever xlocked in drain_dev_clone_events and the only consumer ofthat routine does not need it -- eventhandler code already makes sure therelevant callback is no longer running.Reviewed by: kibDifferential Revision: https://reviews.freebsd.org/D36268 List of files: /freebsd-14.2/sys/fs/devfs/devfs_vnops.c

8ea3ceda - fs: fix a few common typos in source code comments

Sun, 06 Feb 2022 12:48:31 +0000

fs: fix a few common typos in source code comments- s/quadradically/quadratically/- s/persistant/persistent/Obtained from: NetBSDMFC after: 3 days List of files: /freebsd-14.2/sys/fs/devfs/devfs_vnops.c

66c5fbca - insmntque1(): remove useless arguments

Fri, 28 Jan 2022 00:57:09 +0000

insmntque1(): remove useless argumentsAlso remove once-used functions to clean up after failed insmntque1(),which were destructor callbacks in previous life.Reviewed by: markjTested by: phoSponsored by: The FreeBSD FoundationDifferential revision: https://reviews.freebsd.org/D34071 List of files: /freebsd-14.2/sys/fs/devfs/devfs_vnops.c

2a7e4cf8 - Revert b58ca5df0bb7 ("vfs: remove the now unused insmntque1")

Thu, 27 Jan 2022 16:24:32 +0000

Revert b58ca5df0bb7 ("vfs: remove the now unused insmntque1")I was somehow convinced that insmntque calls insmntque1 with a NULLdestructor. Unfortunately this worked well enough to not immediatelyblow up in simple testing.Keep not using the destructor in previously patched filesystems thoughas it avoids unnecessary casts.Noted by: kibReported by: pho List of files: /freebsd-14.2/sys/fs/devfs/devfs_vnops.c

3af3e99c - devfs: stop using insmntque1

Wed, 26 Jan 2022 23:51:41 +0000

devfs: stop using insmntque1It adds nothing of value over insmntque. List of files: /freebsd-14.2/sys/fs/devfs/devfs_vnops.c

3ffcfa59 - vfs: add vop_stdadd_writecount_nomsync

Fri, 26 Nov 2021 09:02:19 +0000

vfs: add vop_stdadd_writecount_nomsyncThis avoids needing to inspect the mount point every time.Reviewed by: kib (previous version)Differential Revision: https://reviews.freebsd.org/D33125 List of files: /freebsd-14.2/sys/fs/devfs/devfs_vnops.c

2b68eb8e - vfs: remove thread argument from VOP_STAT

Fri, 01 Oct 2021 22:25:39 +0000

vfs: remove thread argument from VOP_STATand fo_stat. List of files: /freebsd-14.2/sys/fs/devfs/devfs_vnops.c

b4a58fbf - vfs: remove cn_thread

Fri, 01 Oct 2021 21:16:54 +0000

vfs: remove cn_threadIt is always curthread.Reviewed by: kibDifferential Revision: https://reviews.freebsd.org/D32453 List of files: /freebsd-14.2/sys/fs/devfs/devfs_vnops.c

243b324f - devfs: Avoid comparison with an uninitialized var in devfs_fp_check()

Mon, 03 May 2021 16:43:29 +0000

devfs: Avoid comparison with an uninitialized var in devfs_fp_check()devvn_refthread() will initialize *devp only if it succeeds, so check forsuccess before comparing with fp->f_data. Other devvn_refthread()callers are careful to do this.Reported by: KMSANReviewed by: kibSponsored by: The FreeBSD FoundationDifferential Revision: https://reviews.freebsd.org/D30068 List of files: /freebsd-14.2/sys/fs/devfs/devfs_vnops.c

3bc17248 - devfs: fix use count leak when using TIOCSCTTY

Mon, 08 Feb 2021 22:10:57 +0000

devfs: fix use count leak when using TIOCSCTTYby matching devfs_ctty_refFixes: 3b44443626603f65 ("devfs: rework si_usecount to track opens") List of files: /freebsd-14.2/sys/fs/devfs/devfs_vnops.c

3b444436 - devfs: rework si_usecount to track opens

Tue, 11 Aug 2020 14:27:57 +0000

devfs: rework si_usecount to track opensThis removes a lot of special casing from the VFS layer.Reviewed by: kib (previous version)Tested by: pho (previous version)Differential Revision: https://reviews.freebsd.org/D25612 List of files: /freebsd-14.2/sys/fs/devfs/devfs_vnops.c

7b19bdda - devfs: save on spurious relocking for devfs_populate

Mon, 10 Aug 2020 10:36:43 +0000

devfs: save on spurious relocking for devfs_populateTested by: pho List of files: /freebsd-14.2/sys/fs/devfs/devfs_vnops.c