Changes in control.c

c13f564f - xen: improve shutdown hook

Thu, 23 Nov 2023 15:27:20 +0000

xen: improve shutdown hookMake better use of the shutdown flags. In particular this now handlesstandard reboot where RB_POWERCYCLE is not set, and indicates a crashwhen the system has panicked.While here, give the function a prefix.Reviewed by: royger, markjMFC after: 2 weeksSponsored by: The FreeBSD FoundationDifferential Revision: https://reviews.freebsd.org/D42343(cherry picked from commit 9e0b0f5de67fd46bddf0e12ef7b71d76a7ec1667) List of files: /freebsd-14.2/sys/dev/xen/control/control.c

685dc743 - sys: Remove $FreeBSD$: one-line .c pattern

Wed, 16 Aug 2023 17:54:36 +0000

sys: Remove $FreeBSD$: one-line .c patternRemove /^[\s*]*__FBSDID$"\$FreeBSD\$"$;?\s*\n/ List of files: /freebsd-14.2/sys/dev/xen/control/control.c

4d846d26 - spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSD

Wed, 10 May 2023 15:40:58 +0000

spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSDThe SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catchup to that fact and revert to their recommended match of BSD-2-Clause.Discussed with: pfgMFC After: 3 daysSponsored by: Netflix List of files: /freebsd-14.2/sys/dev/xen/control/control.c

a6c80304 - Adjust function definitions in xen's control.c to avoid clang 15 warnings

Tue, 26 Jul 2022 12:11:09 +0000

Adjust function definitions in xen's control.c to avoid clang 15 warningsWith clang 15, the following -Werror warnings are produced: sys/dev/xen/control/control.c:188:15: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] xctrl_poweroff() ^ void sys/dev/xen/control/control.c:194:13: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] xctrl_reboot() ^ void sys/dev/xen/control/control.c:207:14: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] xctrl_suspend() ^ void sys/dev/xen/control/control.c:344:12: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] xctrl_crash() ^ voidThis is because xctrl_poweroff(), xctrl_reboot(), xctrl_suspend(), andxctrl_crash() are declared with (void) argument lists, but defined withempty argument lists. Make the definitions match the declarations.MFC after: 3 days List of files: /freebsd-14.2/sys/dev/xen/control/control.c

f929eb1e - xen: Remove unused devclass arguments to DRIVER_MODULE.

Fri, 06 May 2022 22:46:58 +0000

xen: Remove unused devclass arguments to DRIVER_MODULE. List of files: /freebsd-14.2/sys/dev/xen/control/control.c

ad7dd514 - xen: switch to use headers in contrib

Wed, 13 Oct 2021 02:00:26 +0000

xen: switch to use headers in contribThese headers originate with the Xen project and shouldn't be mixed withthe main portion of the FreeBSD kernel. Notably they shouldn't be thetarget of clean-up commits.Switch to use the headers in sys/contrib/xen.Reviewed by: royger List of files: /freebsd-14.2/sys/dev/xen/control/control.c

ca46f328 - xen: use an hypercall for shutdown and reboot

Thu, 13 Jan 2022 13:47:18 +0000

xen: use an hypercall for shutdown and rebootWhen running as a Xen guest it's easier to use an hypercall in orderto do power management operations (power off, power cycle). Do thisfor all supported guest types (HVM and PVH). Note that for HVM thepower operation could also be done using ACPI, but there's no reasonto differentiate between PVH and HVM.While there fix the shutdown handler to properly differentiate betweenpower cycle and power off requests.Reported by: Freddy DISSAUXMFC: 1 weekSponsored by: Citrix Systems R&D List of files: /freebsd-14.2/sys/dev/xen/control/control.c

c6df6f53 - Create wrapper for Giant taken for newbus

Fri, 10 Dec 2021 00:04:45 +0000

Create wrapper for Giant taken for newbusCreate a wrapper for newbus to take giant and for busses to take it too.bus_topo_lock() should be called before interacting with newbus routinesand unlocked with bus_topo_unlock(). If you need the topology lock forsome reason, bus_topo_mtx() will provide that.Sponsored by: NetflixReviewed by: mavDifferential Revision: https://reviews.freebsd.org/D31831 List of files: /freebsd-14.2/sys/dev/xen/control/control.c

46c46edd - xen/control: print warning on call of xctrl_suspend()

Tue, 14 Jan 2014 01:41:15 +0000

xen/control: print warning on call of xctrl_suspend()Presently suspend/resume and migration aren't supported on Xen/ARM. Assuch this shouldn't ever occur.This likely applies to future Xen architectures (RISC-V) andxctrl_suspend() needs dependency on intr_machdep.h fixed.Submitted by: Elliott Mitchell Reviewed by: roygerDifferential Revision: https://reviews.freebsd.org/D29599 List of files: /freebsd-14.2/sys/dev/xen/control/control.c

0b4f30c2 - xen/control: introduce xen_pv_shutdown_handler()

Fri, 04 Apr 2014 23:52:05 +0000

xen/control: introduce xen_pv_shutdown_handler()While x86 only register PV shutdown handler for PV guests. ARM guestsare always using HVM and requires the PV shutdown handler.Submitted by: Elliott Mitchell Reviewed by: roygerDifferential Revision: https://reviews.freebsd.org/D29406 List of files: /freebsd-14.2/sys/dev/xen/control/control.c

d3705b5a - xen/control: gate x86 specific code in the preprocessor

Tue, 06 Apr 2021 08:18:47 +0000

xen/control: gate x86 specific code in the preprocessorCommit 152265223048 was implemented strictly for x86. Unfortunatelyone of the pieces was mixed into a common area breaking otherarchitectures. For now disable these bits on !x86, this should becleaned up later.Fixes: 152265223048 ('xen: fix dropping bitmap IPIs during resume')Reviewed by: roygerDifferential Revision: https://reviews.freebsd.org/D29306 List of files: /freebsd-14.2/sys/dev/xen/control/control.c

4e4e43dc - xen: allow limiting the amount of duplicated pending xenstore watches

Wed, 25 Nov 2020 11:34:38 +0000

xen: allow limiting the amount of duplicated pending xenstore watchesXenstore watches received are queued in a list and processed in adeferred thread. Such queuing was done without any checking, so aguest could potentially trigger a resource starvation against theFreeBSD kernel if such kernel is watching any user-controlled xenstorepath.Allowing limiting the amount of pending events a watch can accumulateto prevent a remote guest from triggering this resource starvationissue.For the PV device backends and frontends this limitation is onlyapplied to the other end /state node, which is limited to 1 pendingevent, the rest of the watched paths can still have unlimited pendingwatches because they are either local or controlled by a privilegeddomain.The xenstore user-space device gets special treatment as it's notpossible for the kernel to know whether the paths being watched byuser-space processes are controlled by a guest domain. For this reasonwatches set by the xenstore user-space device are limited to 1000pending events. Note this can be modified using themax_pending_watch_events sysctl of the device.This is XSA-349.Sponsored by: Citrix Systems R&DMFC after: 3 days List of files: /freebsd-14.2/sys/dev/xen/control/control.c

f1084587 - Suspend all writeable local filesystems on power suspend.

Thu, 05 Nov 2020 20:52:49 +0000

Suspend all writeable local filesystems on power suspend.This ensures that no writes are pending in memory, either metadata oruser data, but not including dirty pages not yet converted to fs writes.Only filesystems declared local are suspended.Note that this does not guarantee absence of the metadata errors orleaks if resume is not done: for instance, on UFS unlinked but openedinodes are leaked and require fsck to gc.Reviewed by: markjDiscussed with: impTested by: imp (previous version), phoSponsored by: The FreeBSD FoundationMFC after: 2 weeksDifferential revision: https://reviews.freebsd.org/D27054 List of files: /freebsd-14.2/sys/dev/xen/control/control.c

6c7cae4a - dev/xen: clean up empty lines in .c and .h files

Tue, 01 Sep 2020 21:45:08 +0000

dev/xen: clean up empty lines in .c and .h files List of files: /freebsd-14.2/sys/dev/xen/control/control.c

4149c6a3 - Remove double-calls to tc_get_timecount() to warm timecounters.

Wed, 10 Jun 2020 22:30:32 +0000

Remove double-calls to tc_get_timecount() to warm timecounters.It seems that second call does not add any useful state change for allimplemented timecounters.Discussed with: bdeSponsored by: The FreeBSD FoundationMFC after: 3 weeks List of files: /freebsd-14.2/sys/dev/xen/control/control.c

06592d60 - xen/control: short circuit xctrl_on_watch_event on spurious event

Thu, 28 May 2020 08:20:16 +0000

xen/control: short circuit xctrl_on_watch_event on spurious eventIf there's no data to read from xenstore short-circuitxctrl_on_watch_event to return early, there's no reason to continuesince the lack of data would prevent matching against any known eventtype.Sponsored by: Citrix Systems R&DMFC with: r352925MFC after: 1 week List of files: /freebsd-14.2/sys/dev/xen/control/control.c

06798cf5 - xen/ctrl: acknowledge all control requests

Tue, 01 Oct 2019 08:21:41 +0000

xen/ctrl: acknowledge all control requestsCurrently only suspend requests are acknowledged by writing an emptystring back to the xenstore control node, but poweroff or rebootrequests are not acknowledged and FreeBSD simply proceeds to performthe desired action.Fix this by acknowledging all requests, and remove the suspend specificack done in the handler.Sponsored by: Citrix Systems R&DMFC after: 3 days List of files: /freebsd-14.2/sys/dev/xen/control/control.c

718cf2cc - sys/dev: further adoption of SPDX licensing ID tags.

Mon, 27 Nov 2017 14:52:40 +0000

sys/dev: further adoption of SPDX licensing ID tags.Mainly focus on files that use BSD 2-Clause license, however the tool Iwas using misidentified many licenses so this was mostly a manual - errorprone - task.The Software Package Data Exchange (SPDX) group provides a specificationto make it easier for automated tools to detect and summarize well knownopensource licenses. We are gradually adopting the specification, notingthat the tags are considered only advisory and do not, in any way,superceed or replace the license texts. List of files: /freebsd-14.2/sys/dev/xen/control/control.c

41716b8d - xenstore: fix suspension when using the xenstore device

Tue, 07 Mar 2017 09:17:48 +0000

xenstore: fix suspension when using the xenstore deviceLock the xenstore request mutex when suspending user-space processes, in orderto prevent any process from holding this lock when going into suspension, orelse the xenstore suspend process is going to deadlock.Submitted by: Liuyingdong Reviewed by: roygerMFC after: 2 weeksDifferential revision: https://reviews.freebsd.org/D9638 List of files: /freebsd-14.2/sys/dev/xen/control/control.c

8dee0e9b - xen: add support for canceled suspend

Tue, 07 Mar 2017 09:16:51 +0000

xen: add support for canceled suspendWhen running on Xen, it's possible that a suspend request to the hypervisorfails (return from HYPERVISOR_suspend different than 0). This means that thesuspend hasn't succeed, and the resume procedure needs to properly handle thiscase.First of all, when such situation happens there's no need to reset the vectorcallback, hypercall page, shared info, event channels or grant table, becauseit's state is preserved. Also, the PV drivers don't need to be reset to theinitial state, since the connection with the backed has not been interrupted.Submitted by: Liuyingdong Reviewed by: roygerMFC after: 2 weeksDifferential revision: https://reviews.freebsd.org/D9635 List of files: /freebsd-14.2/sys/dev/xen/control/control.c