Changes in mps_mapping.c

685dc743 - sys: Remove $FreeBSD$: one-line .c pattern

Wed, 16 Aug 2023 17:54:36 +0000

sys: Remove $FreeBSD$: one-line .c patternRemove /^[\s*]*__FBSDID$"\$FreeBSD\$"$;?\s*\n/ List of files: /freebsd-14.2/sys/dev/mps/mps_mapping.c

4d846d26 - spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSD

Wed, 10 May 2023 15:40:58 +0000

spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSDThe SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catchup to that fact and revert to their recommended match of BSD-2-Clause.Discussed with: pfgMFC After: 3 daysSponsored by: Netflix List of files: /freebsd-14.2/sys/dev/mps/mps_mapping.c

d6f9a3c0 - mps(4): Remove a double word in a source code comment

Sun, 04 Sep 2022 11:48:21 +0000

mps(4): Remove a double word in a source code comment- s/the the/the/MFC after: 3 days List of files: /freebsd-14.2/sys/dev/mps/mps_mapping.c

b99419ae - mpr/mps(4): Make device mapping some more robust.

Sat, 24 Apr 2021 03:18:01 +0000

mpr/mps(4): Make device mapping some more robust.Allow new enclosure to replace previously existing one if there isno completely unused table entry, same as it is done for devices.If we can not process DPM due to corruption -- wipe it and restartfrom scratch. Otherwise I don't see a way to recover persistence ifsomething go wrong and there is no BIOS to recover it for us.Together this solves a problem that appeared when 9300-8i firmwareupdate to 16.00.10.00 somehow switched its mapping mode from DevicePersistence to Enclosure/Slot without wiping the DPM table. It madeHBA completely unusable, since overflowed and conflicting mappingtable was unable to map any of enclosures and so devices.Also while there make some enclosure mapping errors more informative.MFC after: 1 monthSponsored by: iXsystems, Inc. List of files: /freebsd-14.2/sys/dev/mps/mps_mapping.c

742c5f20 - mps: clean up empty lines in .c and .h files

Tue, 01 Sep 2020 22:07:00 +0000

mps: clean up empty lines in .c and .h files List of files: /freebsd-14.2/sys/dev/mps/mps_mapping.c

ac2fffa4 - Revert r327828, r327949, r327953, r328016-r328026, r328041:

Sun, 21 Jan 2018 15:42:36 +0000

Revert r327828, r327949, r327953, r328016-r328026, r328041:Uses of mallocarray(9).The use of mallocarray(9) has rocketed the required swap to build FreeBSD.This is likely caused by the allocation size attributes which put extra pressureon the compiler.Given that most of these checks are superfluous we have to choose betterwhere to use mallocarray(9). We still have more uses of mallocarray(9) buthopefully this is enough to bring swap usage to a reasonable level.Reported by: woschPR: 225197 List of files: /freebsd-14.2/sys/dev/mps/mps_mapping.c

26c1d774 - dev: make some use of mallocarray(9).

Sat, 13 Jan 2018 22:30:30 +0000

dev: make some use of mallocarray(9).Focus on code where we are doing multiplications within malloc(9). None ofthese is likely to overflow, however the change is still useful as somestatic checkers can benefit from the allocation attributes we use formallocarray.This initial sweep only covers malloc(9) calls with M_NOWAIT. No goodreason but I started doing the changes before r327796 and at that time itwas convenient to make sure the sorrounding code could handle NULL values. List of files: /freebsd-14.2/sys/dev/mps/mps_mapping.c

718cf2cc - sys/dev: further adoption of SPDX licensing ID tags.

Mon, 27 Nov 2017 14:52:40 +0000

sys/dev: further adoption of SPDX licensing ID tags.Mainly focus on files that use BSD 2-Clause license, however the tool Iwas using misidentified many licenses so this was mostly a manual - errorprone - task.The Software Package Data Exchange (SPDX) group provides a specificationto make it easier for automated tools to detect and summarize well knownopensource licenses. We are gradually adopting the specification, notingthat the tags are considered only advisory and do not, in any way,superceed or replace the license texts. List of files: /freebsd-14.2/sys/dev/mps/mps_mapping.c

757ff642 - Start overhauling debug printing in the MPS and MPR drivers. The focus of this

Sun, 27 Aug 2017 06:24:06 +0000

Start overhauling debug printing in the MPS and MPR drivers. The focus of thiscommit it to make initiazation less chatty in the normal case, and more usefuland informative when real debugging is turned on.Reviewed by: ken (earlier version)Sponsored by: Netflix List of files: /freebsd-14.2/sys/dev/mps/mps_mapping.c

635e58c7 - Fix several problems with mapping code.

Thu, 25 May 2017 19:14:44 +0000

Fix several problems with mapping code.Reviewed by: ken, scottl, asomers, ambrisko, mavApproved by: ken, mavMFC after: 1 weekDifferential Revision: https://reviews.freebsd.org/D10878 List of files: /freebsd-14.2/sys/dev/mps/mps_mapping.c

ee5c196b - Add sysctls for dumping out the device mapping tables. I'm finding this

Thu, 04 Feb 2016 23:38:55 +0000

Add sysctls for dumping out the device mapping tables. I'm finding thisuseful for debugging device-target translation bugs.MFC after: 3 daysSponsored by: Netflix List of files: /freebsd-14.2/sys/dev/mps/mps_mapping.c

bfa3cf97 - Clean up unused-but-set-variable spotted by gcc-4.9.

Mon, 01 Feb 2016 02:31:59 +0000

Clean up unused-but-set-variable spotted by gcc-4.9.Reviewed by: mav, slmApproved by: rodrigc (mentor)MFC after: 2 weeksSponsored by: gandi.net List of files: /freebsd-14.2/sys/dev/mps/mps_mapping.c

ef065d89 - - Updated all files with 2015 Avago copyright, and updated LSI's copyright

Tue, 24 Feb 2015 22:07:42 +0000

- Updated all files with 2015 Avago copyright, and updated LSI's copyright dates.- Changed all of the PCI device strings from LSI to Avago Technologies (LSI).- Added a sysctl variable to control how StartStopUnit behavior works. User can select to spin down disks based on if disk is SSD or HDD.- Inquiry data is required to tell if a disk will support SSU at shutdown or not. Due to the addition of mpssas_async, which gets Advanced Info but not Inquiry data, the setting of supports_SSU was moved to the mpssas_scsiio_complete function, which snoops for any Inquiry commands. And, since disks are shutdown as a target and not a LUN, this process was simplified by basing it on targets and not LUNs.- Added a sysctl variable that sets the amount of time to retry after sending a failed SATA ID command. This helps with some bad disks and large disks that require a lot of time to spin up. Part of this change was to add a callout to handle timeouts with the SATA ID command. The callout function is called mpssas_ata_id_timeout(). (Fixes PR 191348)- Changed the way resets work by allowing I/O to continue to devices that are not currently under a reset condition. This uses devq's instead of simq's and makes use of the MPSSAS_TARGET_INRESET flag. This change also adds a function called mpssas_prepare_tm().- Some changes were made to reduce code duplication when getting a SAS address for a SATA disk.- Fixed some formatting and whitespace.- Bump version of mps driver to 20.00.00.00-fbsdPR: 191348Reviewed by: ken, scottlApproved by: ken, scottlMFC after: 2 weeks List of files: /freebsd-14.2/sys/dev/mps/mps_mapping.c

e248a3d1 - Bring in LSI's phase19 changes

Wed, 30 Jul 2014 18:21:06 +0000

Bring in LSI's phase19 changes* Removed unused mpssas_discovery_timeout function.* Don't alter mapping boundaries if not raid firmware.* Check free_busaddr instead of post_busaddr (diff minimisation really)MFC after: 2 weeks List of files: /freebsd-14.2/sys/dev/mps/mps_mapping.c

9b91b192 - Merge in phase 14+ -> 16 mps driver fixes from LSI:

Mon, 22 Jul 2013 18:41:53 +0000

Merge in phase 14+ -> 16 mps driver fixes from LSI:---------------------------------------------------------------System panics during a Port reset with ouststanding I/O---------------------------------------------------------------It is possible to call mps_mapping_free_memory after thismemory is already freed, causing a panic. Removed this extracall to mps_mappiing_free_memory and call mps_mapping_exitin place of the mps_mapping_free_memory call so that anyoutstanding mapping items can be flushed before memory isfreed.---------------------------------------------------------------Correct memory leak during a Port reset with ouststanding I/O---------------------------------------------------------------In mps_reinit function, the mapping memory was not beingfreed before being re-allocated. Added line to call thememory free function for mapping memory.---------------------------------------------------------------Use CAM_SIM_QUEUED flag in Driver IO path.---------------------------------------------------------------This flag informs the XPT that successful abort of a CCBrequires an abort ccb to be issued to the SIM. Whileprocessing SCSI IO's, set the CAM_SIM_QUEUED flag in thestatus for the IO. When the command completes, clear thisflag.---------------------------------------------------------------Check for CAM_REQ_INPROG in I/O path.---------------------------------------------------------------Added a check in mpssas_action_scsiio for the In Progressstatus for the IO. If this flag is set, the IO has alreadybeen aborted by the upper layer (before CAM_SIM_QUEUED wasset) and there is no need to send the IO. The request willbe completed without error.---------------------------------------------------------------Improve "doorbell handshake method" for mps_get_iocfacts---------------------------------------------------------------Removed call to get Port Facts since this information isnot used currently.Added mps_iocfacts_allocate function to allocate memorythat is based on IOC Facts data. Added mps_iocfacts_freefunction to free memory that is based on IOC Facts data.Both of the functions are used when a Diag Reset is performedor when the driver is attached/detached. This is needed incase IOC Facts changes after a Diag Reset, which couldhappen if FW is upgraded.Moved call of mps_bases_static_config_pages from the attachroutine to after the IOC is ready to process accesses basedon the new memory allocations (instead of polling throughthe Doorbell).---------------------------------------------------------------Set TimeStamp in INIT message in millisecond format Set the IOC------------------------------------------------------------------------------------------------------------------------------Prefer mps_wait_command to mps_request_polled---------------------------------------------------------------Instead of using mps_request_polled, call mps_wait_commandwhenever possible. Change the mps_wait_command function tocheck the current context and either use interrupt contextor poll if required by using the pause or DELAY function.Added a check after waiting 50mSecs to see if the commandhas timed out. This is only done if polliing, the msleepcommand will automatically timeout if the command has takentoo long to complete.---------------------------------------------------------------Integrated RAID: Volume Activation Failed error message isdisplayed though the volume has been activated.---------------------------------------------------------------Instead of failing an IOCTL request that does not have alarge enough buffer to hold the complete reply, copy asmuch data from the reply as possible into the user's bufferand log a message saying that the user's buffer was smallerthan the returned data.---------------------------------------------------------------mapping_add_new_device failure due to persistent table FULL---------------------------------------------------------------When a new device is added, if it is determined that thedevice persistent table is being used and is full, insteadof displaying a message for this condition every time, onlylog a message if the MPS_INFO bit is set in the debug_flags.Submitted by: LSIMFC after: 1 week List of files: /freebsd-14.2/sys/dev/mps/mps_mapping.c

1610f95c - Overhaul error, information, and debug logging.

Fri, 19 Jul 2013 00:12:41 +0000

Overhaul error, information, and debug logging.Obtained from: NetflixMFC after: 3 days List of files: /freebsd-14.2/sys/dev/mps/mps_mapping.c

5d0b98f2 - Fix uninitialized warning in mps

Fri, 03 May 2013 10:37:59 +0000

Fix uninitialized warning in mpsReviewed by: pjd (mentor)Approved by: pjd (mentor)MFC after: 2 weeks List of files: /freebsd-14.2/sys/dev/mps/mps_mapping.c

be4aa869 - Bring in LSI's latest mps(4) 6Gb SAS and WarpDrive driver, version

Thu, 28 Jun 2012 03:48:54 +0000

Bring in LSI's latest mps(4) 6Gb SAS and WarpDrive driver, version14.00.00.01-fbsd.Their description of the changes is as follows:1. Copyright contents has been changed in all respective .c and .h files2. Support for WRITE12 and READ12 for direct-io (warpdrive only) has been added.3. Driver has added checks to see if Drive has READ_CAP_16 support before sending it down to the device. If SPC3_SID_PROTECT flag is set in the inquiry data, the device supports protection information, and must support the 16 byte read capacity command, otherwise continue without sending read cap 16. This will optimize driver performance, since it will not send READ_CAP_16 to the drive which does not have support of READ_CAP_16.4. With new approach, "MPTIOCTL_RESET_ADAPTER" IOCTL will not use DELAY() which is busy loop implementation. It will use (Better way to sleep without busy loop). Also from the HBA reset code path and some other places, DELAY() is replaced with msleep() or "pause()", which is based on sleep/wakeup style calls. Driver use msleep()/pause() instead of DELAY based on CAN_SLEEP/NO_SLEEP flags to avoid busy loop which is not required all the time.e.a a. While driver is getting loaded, driver calls most of the commands with NO_SLEEP. b. When Driver is functional and it needs Reinit of HBA, CAN_SLEEP flag is used.5. driver is not Endian safe. It will not work on Big Endian machines like Sparc and PowerPC platforms because it assumes it is running on a Little Endian machine. Driver code is modified such way that it does not assume CPU arch is Little Endian. a. All places where Driver interacts from HBA to Host, it converts Little Endian format to CPU format. b. All places where Driver interacts from Host to HBA, it converts CPU format to Little Endian.6. Findout memory leaks in FreeBSD Driver and resolve those, such as memory leak in targ's luns creation/deletion. Also added additional checks to see memory allocation success/fail.7. Add loginfo prints as debug message, i.e. When FW sends any loginfo, Driver should print those as debug message. This will help for debugging purpose.8. There is possibility to get config request timeout. Current driver is able to detect config request timetout, but it does not do anything on config_request timeout. Driver should call mps_reinit() if any request_poll (which is called as part of config_request) is time out.9. cdb length check is required for 32 byte CDB. Add correct mpi control value for 32 bit CDB as below while submitting SCSI IO Request to controller. mpi_control |= 4 << MPI2_SCSIIO_CONTROL_ADDCDBLEN_SHIFT;10. Check the actual status of Message unit reset (mps_message_unit_reset).Previously FreeBSD Driver just writes MPI2_FUNCTION_IOC_MESSAGE_UNIT_RESET and never check the ack (it just wait for 50 millisecond). So, Driver now check the status of "MPI2_FUNCTION_IOC_MESSAGE_UNIT_RESET" after writing it to the FW. Now it also checking for whether doorbell ack uses msleep with proper sleep flags, instead of .11. Previously CAM does not detect Multi-Lun Devices. In order to detect Multi-Lun Devices by CAM the driver needs following change set: a. There is "max_lun" field which Driver need to set based on hw/fw support. Currently LSI released driver does not set this field. b. Default of "max_lun" should not be 0 in OS, but it is currently set to 0 in CAM layer. c. Export max_lun capacity to 25512. Driver will not reset target info after port enable complete and also do Device removal when Device remove from FW. The detail description is as follows a. When Driver receive WD PD add events, it will add all information in driver local data structure. b. Only for WD, we have below checks after port enable completes, where driver clear off all information retrieved at #1. if ((sc->WD_available && (sc->WD_hide_expose == MPS_WD_HIDE_ALWAYS)) || (sc->WD_valid_config && (sc->WD_hide_expose == MPS_WD_HIDE_IF_VOLUME)) { // clear off target data structure. } It is mainly not to attach PDs to OS. FreeBSD does bus rescan as older Parallel scsi style. So Driver needs to handle which Drive is visible to OS. That is a reason we have to clear off targ information for PDs. Again, above logic was implemented long time ago. Similar concept we have for non-wd also. For that, LSI have introduced different logic to hide PDs. Eventually, because of above gap, when Phy goes offline, we observe below failure. That is what Driver is not doing complete removal of device with FW. (which was pointed by Scott) Apr 5 02:39:24 Freebsd7 kernel: mpslsi0: mpssas_prepare_remove Apr 5 02:39:24 Freebsd7 kernel: mpssas_prepare_remove 497 : invalid handle 0xe Now Driver will not reset target info after port enable complete and also will do Device removal when Device remove from FW.13. Returning "CAM_SEL_TIMEOUT" instead of "CAM_TID_INVALID" error code on request to the Target IDs that have no devices conected at that moment. As if "CAM_TID_INVALID" error code is returned to the CAM Layaer then it results in a huge chain of errors in verbose kernel messages on boot and every hot-plug event.Submitted by: Sreekanth Reddy MFC after: 3 days List of files: /freebsd-14.2/sys/dev/mps/mps_mapping.c

d043c564 - Bring in the LSI-supported version of the mps(4) driver.

Thu, 26 Jan 2012 18:17:21 +0000

Bring in the LSI-supported version of the mps(4) driver.This involves significant changes to the mps(4) driver, but is not acomplete rewrite.Some of the changes in this version of the driver: - Integrated RAID (IR) support. - Support for WarpDrive controllers. - Support for SCSI protection information (EEDP). - Support for TLR (Transport Level Retries), needed for tape drives. - Improved error recovery code. - ioctl interface compatible with LSI utilities.mps.4: Update the mps(4) driver man page somewhat for the driver changes. The list of supported hardware still needs to be updated to reflect the full list of supported cards.conf/files: Add the new driver files.mps/mpi/*: Updated version of the MPI header files, with a BSD style copyright.mps/*: See above for a description of the new driver features.modules/mps/Makefile: Add the new mps(4) driver files.Submitted by: Kashyap Desai Reviewed by: kenMFC after: 1 week List of files: /freebsd-14.2/sys/dev/mps/mps_mapping.c