en Copyright 2015 Java http://172.16.0.5:8080/history/freebsd-14.2/libexec/tftpd/#77362b5e tftpd: Code cleanup.MFC after: 3 daysSponsored by: Klara, Inc.Reviewed by: markjDifferential Revision: https://reviews.freebsd.org/D45871(cherry picked from commit c15290fb9d8fdf4b11b9c6e7406b67c73a98402d) List of files: /freebsd-14.2/libexec/tftpd/tftpd.c Fri, 05 Jul 2024 22:00:00 +0000 Dag-Erling Smørgrav <des@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-14.2/libexec/tftpd/#626ee3ca tftpd: Add missing `-S` option to synopsis.MFC after: 3 daysSponsored by: Klara, Inc.Reviewed by: imp, markjDifferential Revision: https://reviews.freebsd.org/D45129(cherry picked from commit 816c4d3dcf99adcd40a03d93431237ddbd23bbdf)tftpd: Drop unneeded includes.MFC after: 3 daysSponsored by: Klara, Inc.Reviewed by: imp, markjDifferential Revision: https://reviews.freebsd.org/D45130(cherry picked from commit 1111da6b7c612c571453a23a8dd02fd5e7e40b18)tftpd: Add missing include.This went unnoticed due to namespace pollution in our headers.MFC after: 3 daysSponsored by: Klara, Inc.Reviewed by: impDifferential Revision: https://reviews.freebsd.org/D45131(cherry picked from commit ae285a8cbf1212bdc1b3f81219635bc1395fadee)tftpd: Satisfy clang-analyzer.* Replace `random()` with `arc4random()`.* Change some variable types.* Drop some unused assignments.MFC after: 3 daysSponsored by: Klara, Inc.Reviewed by: imp, markjDifferential Revision: https://reviews.freebsd.org/D45132(cherry picked from commit 4d09eb87c5d5bec2e2832f50537e2ce6f75f4117)tftpd: silence gcc overflow warningsGCC 13 complains that we might be writing too much to an on-stack bufferwhen createing a filename.In practice there is a check that filename isn't too long given thetime format and other static characters so GCC is incorrect, but GCCisn't wrong that we're potentially trying to put a MAXPATHLEN lengthstring + some other characters into a MAXPATHLEN buffer (if you ignorethe check GCC can't realistically evaluate at compile time).Switch to snprintf to populate filename to ensure that future logicerrors don't result in a stack overflow.Shorten the questionably named yyyymmdd buffer enough to slience thewarning (checking the snprintf return value isn't sufficent) whilepreserving maximum flexibility for admins who use the -F option.MFC after: 3 daysSponsored by: Klara, Inc.Reviewed by: brooksDifferential Revision: https://reviews.freebsd.org/D45086(cherry picked from commit 25945af47e7a1d06c44c8c160045a866e90569ab) List of files: /freebsd-14.2/libexec/tftpd/tests/functional.c/freebsd-14.2/libexec/tftpd/tftp-io.c/freebsd-14.2/libexec/tftpd/tftpd.8 Fri, 10 May 2024 21:00:00 +0000 Dag-Erling Smørgrav <des@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-14.2/libexec/tftpd/#1d386b48 Remove $FreeBSD$: one-line .c patternRemove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/ List of files: /freebsd-14.2/libexec/tftpd/tftp-file.c/freebsd-14.2/libexec/tftpd/tftp-options.c/freebsd-14.2/libexec/tftpd/tftp-transfer.c Wed, 16 Aug 2023 17:00:00 +0000 Warner Losh <imp@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-14.2/libexec/tftpd/#d0b2dbfa Remove $FreeBSD$: one-line sh patternRemove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/ List of files: /freebsd-14.2/libexec/tftpd/Makefile/freebsd-14.2/libexec/tftpd/tests/Makefile Wed, 16 Aug 2023 17:00:00 +0000 Warner Losh <imp@FreeBSD.org>