Changes in Makefile

91c1c361 - libthr: remove explicit sys/cdefs.h includes

Wed, 06 Mar 2024 07:06:35 +0000

libthr: remove explicit sys/cdefs.h includes(cherry picked from commit f8bbbce458194ff4312c610d32a64ff4a3a71d45) List of files: /freebsd-14.2/lib/libthr/Makefile

d0b2dbfa - Remove $FreeBSD$: one-line sh pattern

Wed, 16 Aug 2023 17:55:03 +0000

Remove $FreeBSD$: one-line sh patternRemove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/ List of files: /freebsd-14.2/lib/libthr/Makefile

642cd511 - libthr: Add src.conf variable WITHOUT_PTHREADS_ASSERTIONS

Fri, 07 Jul 2023 00:30:02 +0000

libthr: Add src.conf variable WITHOUT_PTHREADS_ASSERTIONSThis patch fixes a bug which prevents building libthr without_PTHREADS_INVARIANTS defined. The default remains to build libthrwith -D_PTHREADS_INVARIANTS. However, with this patch, if one buildslibthr with WITHOUT_PTHREADS_ASSERTIONS=true then the latency toacquire+release a default pthread mutex is reduced by roughly 5%, and arobust mutex by roughly 18% (as measured by a simple synthetic test on aXeon E5-2697a based machine).Reviewed by: jhb, kib, mjgMFC after: 1 weekDifferential revision: https://reviews.freebsd.org/D40900 List of files: /freebsd-14.2/lib/libthr/Makefile

bbf4df17 - libthr: Disable stack unwinding on ARM.

Thu, 10 Feb 2022 20:47:08 +0000

libthr: Disable stack unwinding on ARM.When a thread exits, _Unwind_ForcedUnwind() is used to walk up stackframes executing pending cleanups pushed by pthread_cleanup_push().The cleanups are popped by thread_unwind_stop() which is passed as acallback function to _Unwind_ForcedUnwind().LLVM's libunwind uses a different function type for the callback on32-bit ARM relative to all other platforms. The previous unwind.hheader (as well as the unwind.h from libcxxrt) use the non-ARM type onall platforms, so this has likely been broken on 32-bit arm since itswitched to using LLVM's libunwind.For now, just disable stack unwinding on 32-bit arm to unbreak thebuild until a proper fix is tested. List of files: /freebsd-14.2/lib/libthr/Makefile

c00d3456 - Install unwind.h into /usr/include

Thu, 10 Feb 2022 17:57:49 +0000

Install unwind.h into /usr/includeInstall headers from LLVM's libunwind in place of the headers fromlibcxxrt and allow C applications to use the library.As part of this, remove include/unwind.h and switch libthr over tousing the installed unwind.h.Reviewed by: dim, emasteMFC after: 10 daysDifferential Revision: https://reviews.freebsd.org/D34065 List of files: /freebsd-14.2/lib/libthr/Makefile

9efbe526 - libthr: work around an ASAN false-positive

Mon, 02 Aug 2021 08:49:21 +0000

libthr: work around an ASAN false-positiveI got the following error with an ASAN-instrument libthr:==803==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fffffffcdb0 at pc 0x000801863396 bp 0x7ff8READ of size 4 at 0x7fffffffcdb0 thread T0 #0 0x801863395 in handle_signal /local/scratch/alr48/cheri/freebsd/lib/libthr/thread/thr_sig.c:262:2 #1 0x801860da2 in thr_sighandler /local/scratch/alr48/cheri/freebsd/lib/libthr/thread/thr_sig.c:246:2Address 0x7fffffffcdb0 is located in stack of thread T0 at offset 208 in frame #0 0x80186080f in thr_sighandler /local/scratch/alr48/cheri/freebsd/lib/libthr/thread/thr_sig.c:213 This frame has 1 object(s): [32, 64) 'act' (line 216) <== Memory access at offset 208 overflows this variableHINT: this may be a false positive if your program uses some custom stackThis seems like a false-positive since the line in question is`SIGSETOR(actp->sa_mask, ucp->uc_sigmask);` and it complains about a readoperation (from the ucontext_t argument) so this indicates to me that ASANdoes not understand that thr_sighandler() is a signal handler.Differential Revision: https://reviews.freebsd.org/D31074 List of files: /freebsd-14.2/lib/libthr/Makefile

c8c62548 - Don't add -Winline for WARNS=6

Mon, 22 Mar 2021 11:55:45 +0000

Don't add -Winline for WARNS=6This warning is very rarely useful (inline is a hint and not mandatory).This flag results in many warnings being printed when compiling C++code that uses the standard library with GCC.This flag was originally added in back in r94332 but the flag is a no-opin Clang ("This diagnostic flag exists for GCC compatibility, and has noeffect in Clang"). Removing it should make the GCC build output slightlymore readable.Reviewed By: jrtc27, impDifferential Revision: https://reviews.freebsd.org/D29235 List of files: /freebsd-14.2/lib/libthr/Makefile

fac6dee9 - Remove tests for obsolete compilers in the build system

Tue, 12 May 2020 15:22:40 +0000

Remove tests for obsolete compilers in the build systemAssume gcc is at least 6.4, the oldest xtoolchain in the ports tree.Assume clang is at least 6, which was in 11.2-RELEASE. Drop conditionsfor older compilers.Reviewed by: imp (earlier version), emaste, jhbMFC after: 2 weeksSponsored by: Dell EMC IsilonDifferential Revision: https://reviews.freebsd.org/D24802 List of files: /freebsd-14.2/lib/libthr/Makefile

5d00c5a6 - Fix initial exec TLS mode for dynamically loaded shared objects.

Fri, 29 Mar 2019 17:52:57 +0000

Fix initial exec TLS mode for dynamically loaded shared objects.If dso uses initial exec TLS mode, rtld tries to allocate TLS instatic space. If there is no space left, the dlopen(3) fails. If spaceif allocated, initial content from PT_TLS segment is distributed toall threads' pcbs, which was missed and caused un-initialized TLSsegment for such dso after dlopen(3).The mode is auto-detected either due to the relocation used, or if theDF_STATIC_TLS dynamic flag is set. In the later case, the TLS segmentis tried to allocate earlier, which increases chance of the dlopen(3)to succeed. LLD was recently fixed to properly emit the flag, ld.bdfdid it always.Initial test by: dumbbellTested by: emaste (amd64), ian (arm)Tested by: Gerald Aryeetey (arm64)Sponsored by: The FreeBSD FoundationMFC after: 2 weeksDifferential revision: https://reviews.freebsd.org/D19072 List of files: /freebsd-14.2/lib/libthr/Makefile

09b47fc1 - revert r341429 "disable BIND_NOW in libc, libthr, and rtld"

Thu, 28 Mar 2019 02:12:32 +0000

revert r341429 "disable BIND_NOW in libc, libthr, and rtld"r345620 by kib@ fixed the rtld issue that caused a crash at startupduring resolution of libc's ifuncs with BIND_NOW.PR: 233333Sponsored by: The FreeBSD Foundation List of files: /freebsd-14.2/lib/libthr/Makefile

d49ca25d - Rename rtld-elf/malloc.c to rtld-elf/rtld_malloc.c.

Wed, 30 Jan 2019 16:28:27 +0000

Rename rtld-elf/malloc.c to rtld-elf/rtld_malloc.c.Then malloc.c file name is too generic to use it for libthr.a.Sponsored by: The FreeBSD FoundationMFC after: 13 days List of files: /freebsd-14.2/lib/libthr/Makefile

381c2d2e - Untangle jemalloc and mutexes initialization.

Tue, 29 Jan 2019 22:46:44 +0000

Untangle jemalloc and mutexes initialization.The need to use libc malloc(3) from some places in libthr alwayscaused issues. For instance, per-thread key allocation was switched touse plain mmap(2) to get storage, because some third party mallocsused keys for implementation of calloc(3).Even more important, libthr calls calloc(3) during initialization ofpthread mutexes, and jemalloc uses pthread mutexes. Jemalloc providessome way to both postpone the initialization, and to makeinitialization to use specialized allocator, but this is very fragileand often breaks. See the referenced PR for another example.Add the small malloc implementation used by rtld, to libthr. Use it inthr_spec.c and for mutexes initialization. This avoids the issues withmutual dependencies between malloc and libthr in principle. Thedrawback is that some more allocations are not interceptable foralternate malloc implementations. There should be not too much memoryuse from this allocator, and the alternative, direct use of mmap(2) isobviously worse.PR: 235211MFC after: 2 weeksSponsored by: The FreeBSD FoundationDifferential revision: https://reviews.freebsd.org/D18988 List of files: /freebsd-14.2/lib/libthr/Makefile

0e450664 - disable BIND_NOW in libc, libthr, and rtld

Mon, 03 Dec 2018 15:59:46 +0000

disable BIND_NOW in libc, libthr, and rtldAn issue remains with BIND_NOW and processes using threads. For now,restore libc's BIND_NOW disable, and also disable BIND_NOW in rtld andlibthr.A patch is in review (D18400) that likely fixes this issue, but justdisable BIND_NOW pending further testing after it is committed.PR: 233333Sponsored by: The FreeBSD Foundation List of files: /freebsd-14.2/lib/libthr/Makefile

9c4a7c50 - Remove references to the LIBC_SCCS and SYSLIBC_SCCS C macros.

Wed, 23 May 2018 17:05:12 +0000

Remove references to the LIBC_SCCS and SYSLIBC_SCCS C macros.This language dates back to when libthr was libc_r that included its ownsyscalls and replaced libc entirely. It hasn't been relevant for a longtime. List of files: /freebsd-14.2/lib/libthr/Makefile

d511b20a - Add HAS_TESTS to all Makefiles that are currently using the

Wed, 02 Aug 2017 08:50:42 +0000

Add HAS_TESTS to all Makefiles that are currently using the`SUBDIR.${MK_TESTS}+= tests` idiom.This is a follow up to r321912. List of files: /freebsd-14.2/lib/libthr/Makefile

4b330699 - Convert traditional ${MK_TESTS} conditional idiom for including test

Wed, 02 Aug 2017 08:35:51 +0000

Convert traditional ${MK_TESTS} conditional idiom for including testdirectories to SUBDIR.${MK_TESTS} idiomThis is being done to pave the way for future work (and homogenity) in^/projects/make-check-sandbox .No functional change intended.MFC after: 1 weeks List of files: /freebsd-14.2/lib/libthr/Makefile

afba14e2 - libthr: increase WARNS to the default (6)

Fri, 26 May 2017 15:57:54 +0000

libthr: increase WARNS to the default (6)...and silence cast-align warnings from gcc.Reviewed by: kibMFC after: 3 daysSponsored by: Dell EMCDifferential Revision: https://reviews.freebsd.org/D10935 List of files: /freebsd-14.2/lib/libthr/Makefile

cfc1010f - Revert r318583 (libthr: use default WARNS level of 6)

Mon, 22 May 2017 13:21:28 +0000

Revert r318583 (libthr: use default WARNS level of 6)Revert this while I fix RISC-V, SPARC, and probably all architecturesthat use GCC.Reported by: kibPointy hat to: vangyzenSponsored by: Dell EMC List of files: /freebsd-14.2/lib/libthr/Makefile

0b2f3f20 - libthr: Use CLI flags instead of pragmas to disable warnings

Sat, 20 May 2017 17:33:47 +0000

libthr: Use CLI flags instead of pragmas to disable warningsPeople tweaking the build system or compilers tend to look intothe Makefile and not into the source. Having some warning controlsin the Makefile and some in the source code is surprising.Pragmas have the advantage that they leave the warnings enabledfor more code, but that advantage isn't very relevant in these cases.Requested by: kibReviewed by: kibMFC after: 3 daysSponsored by: Dell EMCDifferential Revision: https://reviews.freebsd.org/D10832 List of files: /freebsd-14.2/lib/libthr/Makefile

d71b2897 - libthr: use default WARNS level of 6

Sat, 20 May 2017 17:32:30 +0000

libthr: use default WARNS level of 6Reviewed by: kibMFC after: 3 daysSponsored by: Dell EMCDifferential Revision: https://reviews.freebsd.org/D10832 List of files: /freebsd-14.2/lib/libthr/Makefile