Changes in strfmon_test.c

4025b5b5 - libc: Purge unneeded cdefs.h

Wed, 01 Nov 2023 22:43:37 +0000

libc: Purge unneeded cdefs.hThese sys/cdefs.h are not needed. Purge them. They are mostly left-overfrom the $FreeBSD$ removal. A few in libc are still required for macrosthat cdefs.h defines. Keep those.Sponsored by: NetflixDifferential Revision: https://reviews.freebsd.org/D42385(cherry picked from commit 559a218c9b257775fb249b67945fe4a05b7a6b9f) List of files: /freebsd-14.2/lib/libc/tests/stdlib/strfmon_test.c

1d386b48 - Remove $FreeBSD$: one-line .c pattern

Wed, 16 Aug 2023 17:54:42 +0000

Remove $FreeBSD$: one-line .c patternRemove /^[\s*]*__FBSDID$"\$FreeBSD\$"$;?\s*\n/ List of files: /freebsd-14.2/lib/libc/tests/stdlib/strfmon_test.c

621bf918 - strfmon_l: Use specified locale for number formatting

Fri, 28 Oct 2022 01:24:48 +0000

strfmon_l: Use specified locale for number formattingstrfmon_l does not take fully into consideration the explicitly passedlocale to perform the formatting.Parallel universe bug report: https://sourceware.org/bugzilla/show_bug.cgi?id=19633Obtained from: DarwinReviewed by: kibPR: 267410Github PR: #620MFC after: 1 week List of files: /freebsd-14.2/lib/libc/tests/stdlib/strfmon_test.c

29972f06 - strfmon_test: Add a test for strfmon_l

Fri, 28 Oct 2022 02:53:43 +0000

strfmon_test: Add a test for strfmon_lAttempt to test the correctness of strfmon_l(3).Items marked with XXX represent an invalid output.Obtained from: https://github.com/NetBSD/src/commit/e7eba0044fe6128291cbb7e5923c7cf7d87318ccReviewed by: kibPR: 267410Github PR: #620MFC after: 1 week List of files: /freebsd-14.2/lib/libc/tests/stdlib/strfmon_test.c

edcee003 - strfmon_test: Reserve space for the null terminator

Thu, 27 Oct 2022 10:01:24 +0000

strfmon_test: Reserve space for the null terminatorOtherwise strfmon(3) could overflow the buffer.Here is mostly done for correctness and illustrative purposes, as thereis no chance it could actually happen.Reviewed by: kibPR: 267410Github PR: #620MFC after: 1 week List of files: /freebsd-14.2/lib/libc/tests/stdlib/strfmon_test.c

34f88528 - strfmon: Fix formatting of a second fixed-width value

Fri, 21 Oct 2022 19:34:09 +0000

strfmon: Fix formatting of a second fixed-width valueThere is a bug when formatting two consecutive values using fixed-widthsand the values need padding. This was because the value of pad_sizewas zeroed only every other time.Format Before After[%8n] [%8n] [ $123.45] [ $123.45] [ $123.45] [ $123.45]Reviewed by: kibPR: 267282Github PR: #619MFC after: 1 week List of files: /freebsd-14.2/lib/libc/tests/stdlib/strfmon_test.c

750fe3e6 - strfmon: Fix an edge case when sep_by_space is 2

Tue, 18 Oct 2022 02:24:03 +0000

strfmon: Fix an edge case when sep_by_space is 2Fix an edge case by printing the required space when, the currencysymbol succeeds the value, a space separates the sign from the value andthe sign position precedes the quantity and the currency symbol.In other words: n_cs_precedes = 0 n_sep_by_space = 2 n_sign_posn = 1From The Open Group's localeconv[1]:> When {p,n,int_p,int_n}_sep_by_space is 2:> If the currency symbol and sign string are adjacent, a space separates> them; otherwise, a space separates the sign string from the value. Format Before After [%n] [-123.45¤] [- 123.45¤][1]: https://pubs.opengroup.org/onlinepubs/9699919799/functions/localeconv.htmlObtained from: DarwinReviewed by: kibPR: 267282Github PR: #619MFC after: 1 week List of files: /freebsd-14.2/lib/libc/tests/stdlib/strfmon_test.c

947efadc - strfmon: Fix alignment when enclosed by parentheses

Fri, 14 Oct 2022 23:26:32 +0000

strfmon: Fix alignment when enclosed by parenthesesTake into consideration the possibility of quantities enclosed byparentheses when aligning.Matches the examples from The Open Group's:Format Before After%(#5n [$ 123.45] [ $ 123.45 ] Use an alternative pos/neg style [($ 123.45)] [($ 123.45)] [$ 3,456.78] [ $ 3,456.78 ]%!(#5n [ 123.45] [ 123.45 ] Disable the currency symbol [( 123.45)] [( 123.45)] [ 3,456.78] [ 3,456.78 ]https://pubs.opengroup.org/onlinepubs/9699919799/functions/strfmon.htmlSD5-XSH-ERN-29 is applied, updating the examples for %(#5n and %!(#5n.Obtained from: DarwinReviewed by: kibPR: 267282Github PR: #619MFC after: 1 week List of files: /freebsd-14.2/lib/libc/tests/stdlib/strfmon_test.c

6da51e19 - strfmon: Trim the SPACE from international currency symbol

Fri, 21 Oct 2022 16:13:27 +0000

strfmon: Trim the SPACE from international currency symbolThe international currency symbol (int_curr_symbol) has a mandatorySPACE character as the last character.Trim this space after reading it, otherwise this extra space will alwaysbe printed when displaying the int_curr_symbol.Fixes the output when the international currency format is selected(%i). Locale Format Before After en_US.UTF-8 [%i] [USD 123.45] [USD123.45] fr_FR.UTF-8 [%i] [123,45 EUR ] [123,45 EUR]Note that the en_US.UTF-8 locale states that no space should be printedbetween the currency symbol and the value (sep_by_space = 0).Reviewed by: kibPR: 267282Github PR: #619MFC after: 1 week List of files: /freebsd-14.2/lib/libc/tests/stdlib/strfmon_test.c

9e03b903 - strfmon: Avoid an out-of-bounds access

Thu, 13 Oct 2022 15:51:27 +0000

strfmon: Avoid an out-of-bounds accessAvoid an out-of-bounds access when trying to set the space_char using aninternational currency format (%i) and the C/POSIX locale.The current code tries to read the SPACE from int_curr_symbol[3]: currency_symbol = strdup(lc->int_curr_symbol); space_char = *(currency_symbol+3);But on C/POSIX locales, int_curr_symbol is empty.Three implementations have been examined: NetBSD[1], Darwin[2], andIllumos[3]. Only NetBSD has fixed it[4].Darwin and NetBSD also trim the mandatory final SPACE character afterreading it. Locale Format Darwin/NetBSD FreeBSD/Illumos en_US.UTF-8 [%i] [USD123.45] [USD 123.45] fr_FR.UTF-8 [%i] [123,45 EUR] [123,45 EUR ]This commit only fixes the out-of-bounds access.[1]: https://github.com/NetBSD/src/blob/trunk/lib/libc/stdlib/strfmon.c[2]: https://opensource.apple.com/source/Libc/Libc-1439.141.1/stdlib/NetBSD/strfmon.c.auto.html[3]: https://github.com/illumos/illumos-gate/blob/master/usr/src/lib/libc/port/locale/strfmon.c[4]: https://github.com/NetBSD/src/commit/3d7b5d498aa9609f2bc9ece9c734c5f493a8e239Reviewed by: kibPR: 267282Github PR: #619MFC after: 1 week List of files: /freebsd-14.2/lib/libc/tests/stdlib/strfmon_test.c

3f97d37a - strfmon_test: Add some tests

Sun, 16 Oct 2022 04:01:17 +0000

strfmon_test: Add some testsAttempt to test the correctness of strfmon(3).Some of them were inspired from the examples section at:https://pubs.opengroup.org/onlinepubs/9699919799/functions/strfmon.htmlItems marked with XXX represent an invalid output.Reviewed by: kibPR: 267282Github PR: #619MFC after: 1 week List of files: /freebsd-14.2/lib/libc/tests/stdlib/strfmon_test.c

f91301cc - strfmon_test: Fix typo and remove extra space

Sun, 16 Oct 2022 03:04:44 +0000

strfmon_test: Fix typo and remove extra spaceReviewed by: kibPR: 267282Github PR: #619MFC after: 1 week List of files: /freebsd-14.2/lib/libc/tests/stdlib/strfmon_test.c

8c1c50ff - Allow multi-byte thousands separators in strfmon(3)

Wed, 19 Dec 2018 22:57:47 +0000

Allow multi-byte thousands separators in strfmon(3)PR: 234010Reported by: Jon Tejnung Reviewed by: yuripvDifferential Revision: https://reviews.freebsd.org/D18605 List of files: /freebsd-14.2/lib/libc/tests/stdlib/strfmon_test.c