Changes in Makefile

d0b2dbfa - Remove $FreeBSD$: one-line sh pattern

Wed, 16 Aug 2023 17:55:03 +0000

Remove $FreeBSD$: one-line sh patternRemove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/ List of files: /freebsd-14.2/lib/csu/amd64/Makefile

c969310c - csu: Implement _start using as to satisfy unwinders on x86_64

Thu, 29 Jun 2023 16:34:39 +0000

csu: Implement _start using as to satisfy unwinders on x86_64The right unwinding stop indicator should be CFI-undefined PC.https://dwarfstd.org/doc/Dwarf3.pdf - page 118:If a Return Address register is defined in the virtual unwind table,and its rule is undefined (for example, by DW_CFA_undefined), thenthere is no return address and no call address, and the virtualunwind of stack activations is complete.This requires the crt code be built with unwind tables, for that remove-fno-asynchronous-unwind-tables to enable unwind tables generation.PR: 241562, 246322, 246537Reviewed by: kibDifferential Revision: https://reviews.freebsd.org/D40780 List of files: /freebsd-14.2/lib/csu/amd64/Makefile

51015e6d - csu: move common code to libc

Sun, 30 Oct 2022 23:47:44 +0000

csu: move common code to libcWhy? Most trivial point, it shaves around 600 bytes from the dynamicbinaries on amd64. Less trivial, the removed code is no longer part ofthe ABI, and we can ship updates to it with libc updates. Right now mostof the csu is linked into the binaries and require us to do somewhattricky ABI compat when it needs to change. For instance, the init_arraychange would be much simpler and does not require note tagging if wehave init calling code in libc.This could be improved more, by splitting dynamic and staticinitialization. For instance, &_DYNAMIC tests can be removed then.Such change, nonetheless, would require building libc three times.I left this for later, after this change stabilizes, if ever.Reviewed by: markjDiscussed with: jrtc27 (some objections, see the review), impTested by: markj (aarch64)Sponsored by: The FreeBSD FoundationMFC after: 3 weeksDifferential revision: https://reviews.freebsd.org/D37220 List of files: /freebsd-14.2/lib/csu/amd64/Makefile

b0ee263d - Consolidate duplicated logic in csu Makefiles to lib/csu/Makefile.inc.

Fri, 03 Jul 2020 00:09:41 +0000

Consolidate duplicated logic in csu Makefiles to lib/csu/Makefile.inc.Reviewed by: kibSponsored by: DARPADifferential Revision: https://reviews.freebsd.org/D25537 List of files: /freebsd-14.2/lib/csu/amd64/Makefile

99282790 - Remove the sed hack for ABI tag notes.

Mon, 15 Jun 2020 19:38:48 +0000

Remove the sed hack for ABI tag notes.The ELF notes compiled in C were placed in a section with the wrong type(SHT_PROGBITS instead of SHT_NOTE). Previously, sed was used on thegenerated assembly to rewrite the section type. Instead, write the notesin assembly which permits setting the correct section type directly.While here, move inline assembly entry points out of C and into assemblyfor aarch64, arm, and riscv.Reviewed by: kibTested on: amd64 (cirrus-ci), riscv64Sponsored by: DARPADifferential Revision: https://reviews.freebsd.org/D25211 List of files: /freebsd-14.2/lib/csu/amd64/Makefile

bdafb02f - Process irelocs for statically linked binaries from crt1 on x86.

Sat, 13 Oct 2018 23:52:55 +0000

Process irelocs for statically linked binaries from crt1 on x86.This makes statically linked binaries with ifuncs operational.Reported and tested by: mjgReviewed by: emaste, markjSponsored by: The FreeBSD FoundationApproved by: re (rgrimes)Differential revision: https://reviews.freebsd.org/D17363 List of files: /freebsd-14.2/lib/csu/amd64/Makefile

5944f899 - Rework r234502 to include a modified CFLAGS along with ACFLAGS.

Fri, 07 Apr 2017 19:53:14 +0000

Rework r234502 to include a modified CFLAGS along with ACFLAGS.On most architectures crt objects are compiled in a multiple-step processso that sed can be run on the generated assembly. As the final step,the C compiler generates an object file from the modified assembly output.Currently this last step uses $CC with only $ACFLAGS. However, for otheruses in the tree, $ACFLAGS is meant to include assembly-specific compilerflags that are in addition to $CFLAGS (see default .S.o rulesbsd.suffixes.mk). In particular, external toolchains may requireadditional flags to select a non-default target which will be presentin CFLAGS but not ACFLAGS. To support this while still mitigating theissue with CFLAGS described in r234502, include a modified CFLAGS thatexcludes "-g" when assembling the modified assembly files.Note that normally an assembler ($AS) is used to assemble .s flags toobject files (see bsd.suffixes.mk). However, llvm-based toolchains donot currently have a stand-alone assembler.Reviewed by: impSponsored by: DARPA / AFRLDifferential Revision: https://reviews.freebsd.org/D10085 List of files: /freebsd-14.2/lib/csu/amd64/Makefile

23f6875a - Use SRCTOP-relative paths and .CURDIR with :H instead of ".." specified paths

Fri, 20 Jan 2017 03:52:16 +0000

Use SRCTOP-relative paths and .CURDIR with :H instead of ".." specified pathsThis implifies pathing in make/displayed outputMFC after: 3 weeksSponsored by: Dell EMC Isilon List of files: /freebsd-14.2/lib/csu/amd64/Makefile

7c6cc9de - Fix installation of 32bit libraries after r288074.

Mon, 21 Sep 2015 21:44:02 +0000

Fix installation of 32bit libraries after r288074.FILES is not used when LIBRARIES_ONLY is set, which is used to build andinstall the lib32 sysroot. All of the csu files do quality as "libraries"for this case so just undefine LIBRARIES_ONLY.This is still better than the previous realinstall handling as it doesnot hook into META_MODE properly.Sponsored by: EMC / Isilon Storage Division List of files: /freebsd-14.2/lib/csu/amd64/Makefile

5ca34122 - Replace realinstall: and META_MODE staging hacks with FILES mechanism.

Mon, 21 Sep 2015 18:39:13 +0000

Replace realinstall: and META_MODE staging hacks with FILES mechanism.This partially reverts r270170 for lib/csu/i386 while retaining thechange for using bsd.lib.mk.These FILES groups could go into lib/csu/Makefile.inc but I've kept themin the Makefiles for clarity.Sponsored by: EMC / Isilon Storage Division List of files: /freebsd-14.2/lib/csu/amd64/Makefile

6e7d005c - Put lib/csu/amd64/Makefile back the way it is in head

Sun, 30 Nov 2014 18:42:29 +0000

Put lib/csu/amd64/Makefile back the way it is in headand handle staging via ../Makefile.inc List of files: /freebsd-14.2/lib/csu/amd64/Makefile

5608fd23 - Revert r267233 for now. PIE support needs to be reworked.

Tue, 19 Aug 2014 15:04:32 +0000

Revert r267233 for now. PIE support needs to be reworked.1. 50+% of NO_PIE use is fixed by adding -fPIC to INTERNALLIB and other build-only utility libraries.2. Another 40% is fixed by generating _pic.a variants of various libraries.3. Some of the NO_PIE use is a bit absurd as it is disabling PIE (and ASLR) where it never would work anyhow, such as csu or loader. This suggests there may be better ways of adding support to the tree. Many of these cases can be fixed such that -fPIE will work but there is really no reason to have it in those cases.4. Some of the uses are working around hacks done to some Makefiles that are really building libraries but have been using bsd.prog.mk because the code is cleaner. Had they been using bsd.lib.mk then NO_PIE would not have been needed.We likely do want to enable PIE by default (opt-out) for non-tree consumers(such as ports). For in-tree though we probably want to only enable PIE(opt-in) for common attack targets such as remote service daemons and setuidutilities. This is also a great performance compromise since ASLR is expectedto reduce performance. As such it does not make sense to enable it in allutilities such as ls(1) that have little benefit to having it enabled.Reported by: kib List of files: /freebsd-14.2/lib/csu/amd64/Makefile

864c53ea - In preparation for ASLR [1] support add WITH_PIE to support building with -fPIE.

Sun, 08 Jun 2014 17:29:31 +0000

In preparation for ASLR [1] support add WITH_PIE to support building with -fPIE.This is currently an opt-in build flag. Once ASLR support is ready and stableit should changed to opt-out and be enabled by default along with ASLR.Each application Makefile uses opt-out to ensure that ASLR will be enabled bydefault in new directories when the system is compiled with PIE/ASLR. [2]Mark known build failures as NO_PIE for now.The only known runtime failure was rtld.[1] http://www.bsdcan.org/2014/schedule/events/452.en.htmlSubmitted by: Shawn Webb Discussed between: des@ and Shawn Webb [2] List of files: /freebsd-14.2/lib/csu/amd64/Makefile

d2cc835c - After r217375, some startup objects under lib/csu are built in a special

Fri, 20 Apr 2012 21:00:39 +0000

After r217375, some startup objects under lib/csu are built in a specialway: first they are compiled to assembly, then some sed'ing is done onthe assembly, and lastly the assembly is compiled to an object file.This last step is done using ${CC}, and not ${AS}, because when thecompiler is clang, it outputs directives that are too advanced for ourold gas. So we use clang's integrated assembler instead. (When thecompiler is gcc, it just calls gas, and nothing is different, except oneextra fork.)However, in the .s to .o rules in lib/csu/$ARCH/Makefile, I still passedCFLAGS to the compiler, instead of ACFLAGS, which are specifically forcompiling .s files.In case you are using '-g' for debug info anywhere in your CFLAGS, itcauses the .s files to already contain debug information in the assemblyitself. In the next step, the .s files are also compiled using '-g',and if the compiler is clang, it complains: "error: input can't have.file dwarf directives when -g is used to generate dwarf debug info forassembly code".Fix this by using ${ACFLAGS} for compiling the .s files instead.Reported by: jasoneMFC after: 1 week List of files: /freebsd-14.2/lib/csu/amd64/Makefile

a22748db - Stop calling _init/_fini methods from crt1 for dynamic binaries. Do

Sun, 11 Mar 2012 20:04:09 +0000

Stop calling _init/_fini methods from crt1 for dynamic binaries. Docall preinit, init and fini arrays methods from crt1 for static binaries.Mark new crt1 with FreeBSD-specific ELF note.Move some common crt1 code into new MI file ignore_init.c, to reduceduplication. Also, conservatively adjust nearby sources for style.Reviewed by: kanTested by: andrew (arm), flo (sparc64)MFC after: 3 weeks List of files: /freebsd-14.2/lib/csu/amd64/Makefile

9ef4e3af - Apply a workaround for a binutils issue with the .note.ABI-tag section

Thu, 13 Jan 2011 20:44:31 +0000

Apply a workaround for a binutils issue with the .note.ABI-tag sectiongenerated from lib/csu/common/crtbrand.c (which ultimately ends up inexecutables and shared libraries, via crt1.o, gcrt1.o or Scrt1.o).For all arches except sparc, gcc emits the section directive for theabitag struct in crtbrand.c with a PROGBITS type. However, newerversions of binutils (after 2.16.90) require the section to be of NOTEtype, to guarantee that the .note.ABI-tag section correctly ends up inthe first page of the final executable.Unfortunately, there is no clean way to tell gcc to use another sectiontype, so crtbrand.c (or the C files that include it) must be compiled inmultiple steps:- Compile the .c file to a .s file.- Edit the .s file to change the 'progbits' type to 'note', for the section directive that defines the .note.ABI-tag section.- Compile the .s file to an object file.These steps are done in the invididual Makefiles for each applicable arch.Reviewed by: kib List of files: /freebsd-14.2/lib/csu/amd64/Makefile

5300f787 - MFC r200038:

Sun, 27 Dec 2009 20:39:58 +0000

MFC r200038:Properly support -fPIE by linking PIE binaries with specially-builtScrt1.o instead of crt1.o, since the later is built as non-PIC.Separate i386-elf crt1.c into the pure assembler part and C code,supplying all data extracted by assembler stub as explicit parameters.Hide and localize _start1 symbol used as an interface between asm andC code. List of files: /freebsd-14.2/lib/csu/amd64/Makefile

c09ba327 - Properly support -fPIE by linking PIE binaries with specially-built

Wed, 02 Dec 2009 16:34:20 +0000

Properly support -fPIE by linking PIE binaries with specially-builtScrt1.o instead of crt1.o, since the later is built as non-PIC.Separate i386-elf crt1.c into the pure assembler part and C code,supplying all data extracted by assembler stub as explicit parameters [1].Hide and localize _start1 symbol used as an interface between asm andC code.In collaboration with: kanInspired by: PR i386/127387 [1]Prodded and tested by: rdivacky [1]MFC after: 3 weeks List of files: /freebsd-14.2/lib/csu/amd64/Makefile

af8d325c - Add -fno-omit-frame-pointer to CFLAGS used to compile crt1.c on amd64.

Fri, 22 Aug 2008 09:23:39 +0000

Add -fno-omit-frame-pointer to CFLAGS used to compile crt1.c on amd64.For gcc' __builtin_frame_address() to work, all call frames need to saveframe pointer. In particular, this is important for the upper frame thatshould terminate the chain.No objections from: jhbPR: amd64/126543MFC after: 1 week List of files: /freebsd-14.2/lib/csu/amd64/Makefile

6de4623b - MFi386: revision 1.19.

Mon, 30 Jun 2003 12:53:39 +0000

MFi386: revision 1.19. List of files: /freebsd-14.2/lib/csu/amd64/Makefile