Changes in alias_pptp.c

738ebfa0 - libalias: Style cleanup

Fri, 14 May 2021 13:08:08 +0000

libalias: Style cleanuplibalias is a convolut of various coding styles modified by a seriesof different editors enforcing interesting convetions on spacing andcomments.This patch is a baseline to start with a perfomance rework oflibalias. Upcoming patches should be focus on the code, not on thestyle. That's why most annoying style errors should be fixedbeforehand.Reviewed by: hselaskyDiscussed by: emasteDifferential Revision: https://reviews.freebsd.org/D30259(cherry picked from commit effc8e57fbf03d7f1423c662caf2b63f0d1d21a9)At some places the ASSERT was inserted before variable declarations arefinished. This is fixed now.Reported by: kibReviewed by: kibDifferential Revision: https://reviews.freebsd.org/D30282(cherry picked from commit 2e6b07866f9e1520626a1523f6609cc411bdda1c) List of files: /freebsd-13.1/sys/netinet/libalias/alias_pptp.c

662c1305 - net: clean up empty lines in .c and .h files

Tue, 01 Sep 2020 21:19:14 +0000

net: clean up empty lines in .c and .h files List of files: /freebsd-13.1/sys/netinet/libalias/alias_pptp.c

2fb87f08 - Kill space at eols.

Wed, 25 Dec 2013 02:06:57 +0000

Kill space at eols. List of files: /freebsd-13.1/sys/netinet/libalias/alias_pptp.c

43197d29 - -don't pass down, to module's fingerprint function, unused data like

Wed, 08 Apr 2009 11:56:49 +0000

-don't pass down, to module's fingerprint function, unused data like a pointer to the ip header.-style-spacing List of files: /freebsd-13.1/sys/netinet/libalias/alias_pptp.c

be4f3cd0 - Summer of Code 2005: improve libalias - part 1 of 2

Tue, 26 Sep 2006 23:26:53 +0000

Summer of Code 2005: improve libalias - part 1 of 2With the first part of my previous Summer of Code work, we get:-made libalias modular: -support for 'particular' protocols (like ftp/irc/etcetc) is no more hardcoded inside libalias, but it's available through external modules loadable at runtime -modules are available both in kernel (/boot/kernel/alias_*.ko) and user land (/lib/libalias_*) -protocols/applications modularized are: cuseeme, ftp, irc, nbt, pptp, skinny and smedia-added logging support for kernel side-cleanupAfter a buildworld, do a 'mergemaster -i' to install the file libalias.confin /etc or manually copy it.During startup (and after every HUP signal) user land applications runningthe new libalias will try to read a file in /etc called libalias.conf:that file contains the list of modules to load.User land applications affected by this commit are ppp and natd:if libalias.conf is present in /etc you won't notice any difference.The only kernel land bit affected by this commit is ng_nat:if you are using ng_nat, and it doesn't correctly handleftp/irc/etcetc sessions anymore, remember to kldloadthe correspondent module (i.e. kldload alias_ftp).General information and details about the inner working are availablein the libalias man page under the section 'MODULAR ARCHITECTURE(AND ipfw(4) SUPPORT)'.NOTA BENE: this commit affects _ONLY_ libalias, ipfw in-kernel natsupport will be part of the next libalias-related commit.Approved by: glebiusReviewed by: glebius, ru List of files: /freebsd-13.1/sys/netinet/libalias/alias_pptp.c

75bc2620 - Always include alias.h before alias_local.h

Thu, 05 May 2005 21:55:17 +0000

Always include alias.h before alias_local.h List of files: /freebsd-13.1/sys/netinet/libalias/alias_pptp.c

c649a2e0 - Play with includes so that libalias can be compiled both as userland

Thu, 05 May 2005 19:27:32 +0000

Play with includes so that libalias can be compiled both as userlandlibrary and kernel module. List of files: /freebsd-13.1/sys/netinet/libalias/alias_pptp.c

5c7e7e80 - Fix Skinny and PPTP NAT'ing after the introduction of the {ip,tcp,udp}_next

Wed, 04 Aug 2004 15:17:08 +0000

Fix Skinny and PPTP NAT'ing after the introduction of the {ip,tcp,udp}_nextfunctions. Basically, the ip_next() function was used to get the PPTP andSkinny headers when tcp_next() should have been used instead. Symptoms ofthis included a segfault in natd when trying to process a PPTP or Skinnypacket.Approved by: des List of files: /freebsd-13.1/sys/netinet/libalias/alias_pptp.c

9fa0fd26 - Introduce inline {ip,udp,tcp}_next() functions which take a pointer to an

Tue, 06 Jul 2004 12:13:28 +0000

Introduce inline {ip,udp,tcp}_next() functions which take a pointer to an{ip,udp,tcp} header and return a void * pointing to the payload (i.e. thefirst byte past the end of the header and any required padding). Use themconsistently throughout libalias to a) reduce code duplication, b) improvecode legibility, c) get rid of a bunch of alignment warnings. List of files: /freebsd-13.1/sys/netinet/libalias/alias_pptp.c

ed01a582 - Make libalias WARNS?=6-clean. This mostly involves renaming variables

Mon, 05 Jul 2004 11:10:57 +0000

Make libalias WARNS?=6-clean. This mostly involves renaming variablesnamed link, foo_link or link_foo to lnk, foo_lnk or lnk_foo, fixingsigned / unsigned comparisons, and shoving unused function argumentsunder the carpet.I was hoping WARNS?=6 might reveal more serious problems, and perhapsthe source of the -O2 breakage, but found no smoking gun. List of files: /freebsd-13.1/sys/netinet/libalias/alias_pptp.c

2871c501 - Deal with aliasing warnings.

Wed, 31 Mar 2004 21:32:58 +0000

Deal with aliasing warnings.Reviewed by: ruApproved by: silence on the lists List of files: /freebsd-13.1/sys/netinet/libalias/alias_pptp.c

f0f93429 - Run through indent(1) so I can read the code without getting a headache.

Tue, 16 Mar 2004 21:30:41 +0000

Run through indent(1) so I can read the code without getting a headache.The result isn't quite knf, but it's knfer than the original, and farmore consistent. List of files: /freebsd-13.1/sys/netinet/libalias/alias_pptp.c

5e289f9e - Mostly mechanical rework of libalias:

Sat, 17 Jan 2004 10:52:21 +0000

Mostly mechanical rework of libalias:Makes it possible to have multiple packet aliasing instances in asingle process by moving all static and global variables into aninstance structure called "struct libalias".Redefine a new API based on s/PacketAlias/LibAlias/gAdd new "instance" argument to all functions in the new API.Implement old API in terms of the new API. List of files: /freebsd-13.1/sys/netinet/libalias/alias_pptp.c

e2505aa6 - Add __FBSDID's to libalias

Sun, 30 Sep 2001 21:03:33 +0000

Add __FBSDID's to libalias List of files: /freebsd-13.1/sys/netinet/libalias/alias_pptp.c

71593f95 - Make header files conform to style(9).

Sun, 25 Mar 2001 12:05:10 +0000

Make header files conform to style(9).Reviewed by (*): bde(*) alias_local.h only got a cursory glance. List of files: /freebsd-13.1/sys/netinet/libalias/alias_pptp.c

03453c5e - A significant rewrite of PPTP aliasing code.

Mon, 30 Oct 2000 12:39:41 +0000

A significant rewrite of PPTP aliasing code.PPTP links are no longer dropped by simple (and inappropriate in thiscase) "inactivity timeout" procedure, only when requested through thecontrol connection.It is now possible to have multiple PPTP servers running behind NAT.Just redirect the incoming TCP traffic to port 1723, everything elseis done transparently.Problems were reported and the fix was tested by: Michael Adler , David Andersen List of files: /freebsd-13.1/sys/netinet/libalias/alias_pptp.c

0eb10a09 - - Do not modify Peer's Call ID in outgoing Incoming-Call-Connected

Wed, 09 Aug 2000 11:25:44 +0000

- Do not modify Peer's Call ID in outgoing Incoming-Call-Connected PPTP control messages.- Cosmetics: replace `GRE link' with `PPTP link'.Reviewed by: Erik Salander List of files: /freebsd-13.1/sys/netinet/libalias/alias_pptp.c

934a4fb3 - Adjust TCP checksum rather than compute it afresh.

Mon, 07 Aug 2000 09:51:04 +0000

Adjust TCP checksum rather than compute it afresh.Submitted by: Erik Salander List of files: /freebsd-13.1/sys/netinet/libalias/alias_pptp.c

55a39fc5 - Added true support for PPTP aliasing. Some nice features include:

Tue, 20 Jun 2000 11:41:48 +0000

Added true support for PPTP aliasing. Some nice features include:- Multiple PPTP clients behind NAT to the same or different servers.- Single PPTP server behind NAT -- you just need to redirect TCP port 1723 to a local machine. Multiple servers behind NAT is possible but would require a simple API change.- No API changes!For more information on how this works see comments at the start ofthe alias_pptp.c.PacketAliasPptp() is no longer necessary and will be removed soon.Submitted by: Erik Salander Reviewed by: ruRewritten by: ruReviewed by: Erik Salander List of files: /freebsd-13.1/sys/netinet/libalias/alias_pptp.c