Changes in alias_db.c

791035c8 - libalias: fix divide by zero causing panic

Sat, 10 Jul 2021 11:00:56 +0000

libalias: fix divide by zero causing panicThe packet_limit can fall to 0, leading to a divide by zero abort inthe "packets % packet_limit".An possible solution would be to apply a lower limit of 1 after thecalculation of packet_limit, but since any number modulo 1 gives 0,the more efficient solution is to skip the modulo operation forpacket_limit <= 1.Reported by: Karl Denninger (cherry picked from commit 58080fbca09fda6d5f011d37059edbca8ceb4c58) List of files: /freebsd-13.1/sys/netinet/libalias/alias_db.c

3a96a25d - libalias: Switch to SPLAY trees

Thu, 27 May 2021 21:42:54 +0000

libalias: Switch to SPLAY treesCurrent data structure is using a hash of unordered lists. Thoseunordered lists are quite efficient, because the least recentlyinserted entries are most likely to be used again. In order to avoidlong search times in other cases, the lists are hashed into manybuckets. Unfortunatly a search for a miss needs an exhaustiveinspection and a careful definition of the hash.Splay trees offer a similar feature - almost O(1) for access of theleast recently used entries), and amortized O(ln(n) - for almost allother cases. Get rid of the hash.Now the data structure should able to quickly react to externalpackets without eating CPU cycles for breakfast, preventing a DoS.PR: 192888Discussed with: Dimitry LuhtionovDifferential Revision: https://reviews.freebsd.org/D30516Differential Revision: https://reviews.freebsd.org/D30536Differential Revision: https://reviews.freebsd.org/D30844(cherry picked from commit 935fc93af157dee352eb4b6c83f8a2a9e7fd9a4e)(cherry picked from commit d261e57deacb0d00d9e827447f235df83dda3e3a)(cherry picked from commit f70c98a2f5d993dc518efd606aa341eda99400ef)(cherry picked from commit 25392fac9488bcae5c451500df2e2945430484a6)(cherry picked from commit 2f4d91f9cb22fc65eb65407e8118b433a5d71976)(cherry picked from commit 4060e77f49d1b9fd2254f3f4da94fd64fce83f72) List of files: /freebsd-13.1/sys/netinet/libalias/alias_db.c

78d515b2 - libalias: Restructure

Tue, 25 May 2021 13:03:34 +0000

libalias: RestructureClean up the database handling in order to switch to more efficientdata structures. The development of this patch was artificially splitin to many small steps to ease reviewing.- Common search terms- Separate fully qualified search- Separate table for partial links- Cleanup _FindLinkIn- Factor out the outgoing search function- Factor out a common idiom to return found links- Reorder incoming links by grouping of common search terms- Remove LSNAT from outgoing search- Group internal structure semantically- Separate table for PPTP- Use AliasRange instead of PORT_BASE- Remove temporary state deleteAllLinks from global struct- Avoid uninitialized expirationDiscussed with: Dimitry LuhtionovDifferential Revision: https://reviews.freebsd.org/D30568Differential Revision: https://reviews.freebsd.org/D30569Differential Revision: https://reviews.freebsd.org/D30570Differential Revision: https://reviews.freebsd.org/D30571Differential Revision: https://reviews.freebsd.org/D30572Differential Revision: https://reviews.freebsd.org/D30573Differential Revision: https://reviews.freebsd.org/D30574Differential Revision: https://reviews.freebsd.org/D30575Differential Revision: https://reviews.freebsd.org/D30580Differential Revision: https://reviews.freebsd.org/D30581Differential Revision: https://reviews.freebsd.org/D30604Differential Revision: https://reviews.freebsd.org/D30582(cherry picked from commit d41044ddfdbc2a026570cae11d5fc2e18f5e4b92)(cherry picked from commit 32f9c2ceb3ec8266e48ec0f6d1556fd98ef12db6)(cherry picked from commit cac129e6030095c33e95c5ce1cdcb9c5c21efce9)(cherry picked from commit 19dcc4f2250b3850991366e3058ca8a64b2f135d)(cherry picked from commit d5419034381d0e8e8c99f0f678118b197144bfff)(cherry picked from commit d4ab07d2aeb13b1aae9ad5d73e5fe77131f2350c)(cherry picked from commit 492d3b7109b45ff30fd199b7eeed797447746e42)(cherry picked from commit 7b44ff4c52ce9e7a89e772566a249e5481fe0ac4)(cherry picked from commit 1178dda53d10b096e0b99e356d15b7c24390e099)(cherry picked from commit 9efcad61d8309ecad3c15392b277fd329a1e45e4)(cherry picked from commit fe83900f9fa931e3d0942ec9c0709896b887c3d7)(cherry picked from commit d989935b5bcd880353f0de89eda958c45e7e3342)(cherry picked from commit b50a4dce185481bebf8096c27588ae04a4a2fd7c)(cherry picked from commit f28455344483310cfd1aa5c0bdd4d014810c0e32) List of files: /freebsd-13.1/sys/netinet/libalias/alias_db.c

390866d4 - libalias: Promote per instance global variable timeStamp

Tue, 25 May 2021 07:07:21 +0000

libalias: Promote per instance global variable timeStampSummary:- Use LibAliasTime as a real global variable for central timekeeping.- Reduce number of syscalls in user space considerably.- Dynamically adjust the packet counters to match the second resolution.- Only check the first few packets after a time increase for expiry.Discussed with: hselaskyDifferential Revision: https://reviews.freebsd.org/D30566(cherry picked from commit ef828d39be8e4b6d922db080ed41611702dec56d) List of files: /freebsd-13.1/sys/netinet/libalias/alias_db.c

3423d44c - libalias: tidy up housekeeping

Sat, 15 May 2021 15:35:36 +0000

libalias: tidy up housekeepingReplace current expensive, but sparsly called housekeepingby a single, repetive action.This is part of a larger restructure of libalias in order to switch tomore efficient data structures. The whole restructure process issplit into 15 reviews to ease reviewing. All those steps will besquashed into a single commit for MFC in order to hide theintermediate states from production systems.Reviewed by: hselaskyDifferential Revision: https://reviews.freebsd.org/D30277(cherry picked from commit 294799c6b081faece556a5010a4f51552e131c2f) List of files: /freebsd-13.1/sys/netinet/libalias/alias_db.c

fc2d7fb6 - libalias: Remove unused function LibAliasCheckNewLink

Sat, 15 May 2021 13:24:12 +0000

libalias: Remove unused function LibAliasCheckNewLinkThe functionality to detect a newly created link after processing asingle packet is decoupled from the packet processing. Every newpacket is processed asynchronously and will reset the indicator, hencethe function is unusable. I made a Google search for third party code,which uses the function, and failed to find one.That's why the function should be removed: It unusable and unused.A much simplified API/ABI will remain in anything below 14.Discussed with: kpReviewed by: manpages (bcr)Differential Revision: https://reviews.freebsd.org/D30275(cherry picked from commit bfd41ba1fe1d0e40b6a813aeb0354cac8d884f5b) List of files: /freebsd-13.1/sys/netinet/libalias/alias_db.c

16adf789 - libalias: replace placeholder with static constant

Thu, 13 May 2021 21:47:57 +0000

libalias: replace placeholder with static constantThe field nullAddress in struct libalias is never set and never used.It exists as a placeholder for an unused argument only.Reviewed by: hselaskyDifferential Revision: https://reviews.freebsd.org/D30253(cherry picked from commit 189f8eea138a78b09c9f19114b1362b0df1cf87d)(cherry picked from commit b03a41befeaf17ef25da96fc7bc2dc19c9a6b253) List of files: /freebsd-13.1/sys/netinet/libalias/alias_db.c

738ebfa0 - libalias: Style cleanup

Fri, 14 May 2021 13:08:08 +0000

libalias: Style cleanuplibalias is a convolut of various coding styles modified by a seriesof different editors enforcing interesting convetions on spacing andcomments.This patch is a baseline to start with a perfomance rework oflibalias. Upcoming patches should be focus on the code, not on thestyle. That's why most annoying style errors should be fixedbeforehand.Reviewed by: hselaskyDiscussed by: emasteDifferential Revision: https://reviews.freebsd.org/D30259(cherry picked from commit effc8e57fbf03d7f1423c662caf2b63f0d1d21a9)At some places the ASSERT was inserted before variable declarations arefinished. This is fixed now.Reported by: kibReviewed by: kibDifferential Revision: https://reviews.freebsd.org/D30282(cherry picked from commit 2e6b07866f9e1520626a1523f6609cc411bdda1c) List of files: /freebsd-13.1/sys/netinet/libalias/alias_db.c

17cc6689 - MFC 9febbc454190:

Mon, 22 Feb 2021 10:58:46 +0000

MFC 9febbc454190:Fix for natd(8) sending wrong sequence number after TCP retransmission,terminating a TCP connection.If a TCP packet must be retransmitted and the data length has changed in theretransmitted packet, due to the internal workings of TCP, typically when ACKpackets are lost, then there is a 30% chance that the logic in GetDeltaSeqOut()will find the correct length, which is the last length received.This can be explained as follows:If a "227 Entering Passive Mode" packet must be retransmittet and the lengthchanges from 51 to 50 bytes, for example, then we have three cases for thelist scan in GetDeltaSeqOut(), depending on how many prior packets werereceived modulus N_LINK_TCP_DATA=3: case 1: index 0: original packet 51 index 1: retransmitted packet 50 index 2: not relevant case 2: index 0: not relevant index 1: original packet 51 index 2: retransmitted packet 50 case 3: index 0: retransmitted packet 50 index 1: not relevant index 2: original packet 51This patch simply changes the searching order for TCP packets, always startingat the last received packet instead of any received packet, inGetDeltaAckIn() and GetDeltaSeqOut().Else no functional changes.Discussed with: rscheff@Submitted by: Andreas Longwitz PR: 230755Sponsored by: Mellanox Technologies // NVIDIA Networking(cherry picked from commit 9febbc4541903bb8e6b0f1c84988c98b2f7c96ef) List of files: /freebsd-13.1/sys/netinet/libalias/alias_db.c

46539a7b - Allow setting alias port ranges in libalias and ipfw.

Tue, 02 Feb 2021 21:24:17 +0000

Allow setting alias port ranges in libalias and ipfw.This will allow a system to be a true RFC 6598 NAT444 setup, where eachnetwork segment (e.g. user, subnet) can have their own dedicated portaliasing ranges.Reviewed by: donner, kpApproved by: 0mp (mentor), donner, kpDifferential Revision: https://reviews.freebsd.org/D23450(cherry picked from commit a08cdb6cfb1c84b80b5337d46c574b55d0e15c63) List of files: /freebsd-13.1/sys/netinet/libalias/alias_db.c

bc596e56 - libalias: Fix -Wcast-align compiler warnings

Tue, 19 Jan 2021 11:32:32 +0000

libalias: Fix -Wcast-align compiler warningsThis fixes -Wcast-align warnings caused by the underaligned `struct ip`.This also silences them in the public functions by changing the functionsignature from char * to void *. This is source and binary compatible andavoids the -Wcast-align warning.Reviewed By: ae, gbe (manpages)Differential Revision: https://reviews.freebsd.org/D27882 List of files: /freebsd-13.1/sys/netinet/libalias/alias_db.c

662c1305 - net: clean up empty lines in .c and .h files

Tue, 01 Sep 2020 21:19:14 +0000

net: clean up empty lines in .c and .h files List of files: /freebsd-13.1/sys/netinet/libalias/alias_db.c

8e6b06be - netinet/libalias: Fix typo in debug message

Mon, 03 Feb 2020 05:19:44 +0000

netinet/libalias: Fix typo in debug messageNo functional change.PR: 243831Submitted by: Neel Chauhan Differential Revision: https://reviews.freebsd.org/D23365 List of files: /freebsd-13.1/sys/netinet/libalias/alias_db.c

fe267a55 - sys: general adoption of SPDX licensing ID tags.

Mon, 27 Nov 2017 15:23:17 +0000

sys: general adoption of SPDX licensing ID tags.Mainly focus on files that use BSD 2-Clause license, however the tool Iwas using misidentified many licenses so this was mostly a manual - errorprone - task.The Software Package Data Exchange (SPDX) group provides a specificationto make it easier for automated tools to detect and summarize well knownopensource licenses. We are gradually adopting the specification, notingthat the tags are considered only advisory and do not, in any way,superceed or replace the license texts.No functional change intended. List of files: /freebsd-13.1/sys/netinet/libalias/alias_db.c

99d628d5 - netinet: for pointers replace 0 with NULL.

Fri, 15 Apr 2016 15:46:41 +0000

netinet: for pointers replace 0 with NULL.These are mostly cosmetical, no functional change.Found with devel/coccinelle.Reviewed by: ae. tuexen List of files: /freebsd-13.1/sys/netinet/libalias/alias_db.c

535e0a09 - Cleanup alias module handler register/unregister.

Wed, 25 Dec 2013 03:24:20 +0000

Cleanup alias module handler register/unregister.- Remove locking, since all module(9) events are running under &Giant.- Use TAILQ for protocol handlers and fix a bug which led to infinite cycle. Bug found in VirtualBox [1]- Simplify code everywhere.- Fix documentation.[1] https://www.virtualbox.org/pipermail/vbox-dev/2013-November/011936.htmlPR: 183792 [1]Submitted by: Valery Ushakov [1]Sponsored by: Nginx, Inc. List of files: /freebsd-13.1/sys/netinet/libalias/alias_db.c

eedc7fd9 - Provide includes that are needed in these files, and before were read

Sat, 26 Oct 2013 18:18:50 +0000

Provide includes that are needed in these files, and before were readin implicitly via if.h -> if_var.h pollution.Sponsored by: NetflixSponsored by: Nginx, Inc. List of files: /freebsd-13.1/sys/netinet/libalias/alias_db.c

f4562a29 - Remove LIBALIAS_LOCK_ASSERT(), including a couple with an uninitialzed

Mon, 11 Mar 2013 12:22:44 +0000

Remove LIBALIAS_LOCK_ASSERT(), including a couple with an uninitialzedargument, in code that isn't compiled in kernel.PR: kern/176667Sponsored by: Nginx, Inc. List of files: /freebsd-13.1/sys/netinet/libalias/alias_db.c

05116753 - Export AddLink() function from libalias. It can be used when custom

Wed, 22 Jun 2011 20:00:27 +0000

Export AddLink() function from libalias. It can be used when customalias address needs to be specified.Add inbound handler to the alias_ftp module. It helps handle activeFTP transfer mode for the case with external clients and FTP server behindNAT. Fix passive FTP transfer case for server behind NAT using redirect withexternal IP address different from NAT ip address.PR: kern/157957Submitted by: Alexander V. Chernikov List of files: /freebsd-13.1/sys/netinet/libalias/alias_db.c

ca47294d - LibAliasInit() should allocate memory with M_WAITOK flag. Modify it

Mon, 18 Apr 2011 20:07:08 +0000

LibAliasInit() should allocate memory with M_WAITOK flag. Modify itand its callers. List of files: /freebsd-13.1/sys/netinet/libalias/alias_db.c