Changes in buffer.c

718cf2cc - sys/dev: further adoption of SPDX licensing ID tags.

Mon, 27 Nov 2017 14:52:40 +0000

sys/dev: further adoption of SPDX licensing ID tags.Mainly focus on files that use BSD 2-Clause license, however the tool Iwas using misidentified many licenses so this was mostly a manual - errorprone - task.The Software Package Data Exchange (SPDX) group provides a specificationto make it easier for automated tools to detect and summarize well knownopensource licenses. We are gradually adopting the specification, notingthat the tags are considered only advisory and do not, in any way,superceed or replace the license texts. List of files: /freebsd-13.1/sys/dev/sound/pcm/buffer.c

3f9dcc58 - Declare the "snd_fxdiv_table" once. This shaves around 24Kbytes of

Thu, 25 May 2017 05:23:47 +0000

Declare the "snd_fxdiv_table" once. This shaves around 24Kbytes ofbinary data from sound.ko and the kernel.MFC after: 3 days List of files: /freebsd-13.1/sys/dev/sound/pcm/buffer.c

8cf27a33 - Restore the check for non-NULL dmatag in sndbuf_free.

Mon, 23 Jun 2014 03:45:39 +0000

Restore the check for non-NULL dmatag in sndbuf_free.The sound drivers that use own buffer management can use sndbuf_setupand not do any busdma allocation, so the driver will end up with themanaged buffer but no valid dma map and tag for it. Avoid callingbus_dmamem_free in such cases.Reported by: acheMissed in review by: kan List of files: /freebsd-13.1/sys/dev/sound/pcm/buffer.c

86843ea8 - Fix various bugs with freeing static DMA allocations in sound drivers:

Tue, 17 Jun 2014 16:07:57 +0000

Fix various bugs with freeing static DMA allocations in sound drivers:- Don't compare the DMA map to NULL to determine if bus_dmamap_unload() should be called when releasing a static allocation. Instead, compare the bus address against 0.- Don't assume that the DMA map for static allocations is NULL. Instead, save the value set by bus_dmamem_alloc() so it can later be passed to bus_dmamem_free(). Also, add missing calls to bus_dmamap_unload() in these cases before freeing the buffer.- Use the bus address from the bus_dma callback instead of calling vtophys() on the address allocated by bus_dmamem_alloc().Reviewed by: kan List of files: /freebsd-13.1/sys/dev/sound/pcm/buffer.c

4754395c - Move sndbuf_setmap() output about buffer addresses from the general verbose

Fri, 23 Nov 2012 13:43:51 +0000

Move sndbuf_setmap() output about buffer addresses from the general verboseoutput to sound verbose output, where all other sndbuf messages live. List of files: /freebsd-13.1/sys/dev/sound/pcm/buffer.c

fd578f65 - Make sound(4) more flexible in setting soft buffer and block sizes when

Tue, 31 Jan 2012 21:46:28 +0000

Make sound(4) more flexible in setting soft buffer and block sizes whenhardware imposes strict limitations on hard buffer and block sizes.Previous code set soft buffer to be no smaller then hard buffer. On somecards with fixed 64K physical buffer that caused up to 800ms play latency.New code allows to set soft buffer size down to just two blocks of the hardbuffer and to not write more then that size ahead to the hardware buffer.As result of that change I was able to reduce full practically measuredrecord-playback loop delay in those conditions down to only about 115mswith theoretical playback latency of only about 50ms.New code works fine for both vchans and direct cases. In both cases sound(4)tries to follow hw.snd.latency_profile and hw.snd.latency values andapplication-requested buffer and block sizes as much as limitation of twohardware blocks allows.Reviewed by: silence on multimedia@ List of files: /freebsd-13.1/sys/dev/sound/pcm/buffer.c

496a7fca - Allocate the sound buffer DMA memory coherent. While NetBSD typically

Fri, 11 Mar 2011 22:42:04 +0000

Allocate the sound buffer DMA memory coherent. While NetBSD typicallyalso does this for sound drivers it's probably not necessary for allcombinations of controllers and drivers. However, given that our sounddrivers completely lack bus_dmamap_sync(9) calls this at least servesas a workaround when enabling use of the IOMMU streaming buffers onsparc64 and generally for arm and mips.MFC after: 2 weeks List of files: /freebsd-13.1/sys/dev/sound/pcm/buffer.c

240577c2 - Fix up a few more sysctl(9) mis-typing found in various LINT builds.

Thu, 13 Jan 2011 18:20:27 +0000

Fix up a few more sysctl(9) mis-typing found in various LINT builds. List of files: /freebsd-13.1/sys/dev/sound/pcm/buffer.c

c4879659 - MFC: r207330, r207620

Mon, 10 May 2010 19:21:50 +0000

MFC: r207330, r207620- Remove dead code. Calculated greatest common divisor was not used at all.- Prefer u_int32_t over unsigned int to make its intention more clearer.- Move the function to a header file and make it a static inline function. List of files: /freebsd-13.1/sys/dev/sound/pcm/buffer.c

c909aebc - - Remove more dead code[1]. Since r207330, we only need to check division

Tue, 04 May 2010 16:56:59 +0000

- Remove more dead code[1]. Since r207330, we only need to check divisionby zero of the second argument 'from'.- Prefer u_int32_t over unsigned int to make its intention more clearer.- Move the function to a header file and make it a static inline function.Pointed out by: Andrew Reilly (areilly at bigpond dot net dot au)[1]MFC after: 3 days List of files: /freebsd-13.1/sys/dev/sound/pcm/buffer.c

8c975e70 - Remove dead code. Calculated greatest common divisor was not used at all.

Wed, 28 Apr 2010 17:26:05 +0000

Remove dead code. Calculated greatest common divisor was not used at all.On top of that, LLVM+Clang mis-compiles this code because of its registerallocator bug.Analyzed by: Andrew Reilly (areilly at bigpond dot net dot au)Reviewed by: ariff, rdivackyMFC after: 3 days List of files: /freebsd-13.1/sys/dev/sound/pcm/buffer.c

90da2b28 - Sound Mega-commit. Expect further cleanup until code freeze.

Sun, 07 Jun 2009 19:12:08 +0000

Sound Mega-commit. Expect further cleanup until code freeze.For a slightly thorough explaination, please refer to [1] http://people.freebsd.org/~ariff/SOUND_4.TXT.html .Summary of changes includes:1 Volume Per-Channel (vpc). Provides private / standalone volume control unique per-stream pcm channel without touching master volume / pcm. Applications can directly use SNDCTL_DSP_[GET|SET][PLAY|REC]VOL, or for backwards compatibility, SOUND_MIXER_PCM through the opened dsp device instead of /dev/mixer. Special "bypass" mode is enabled through /dev/mixer which will automatically detect if the adjustment is made through /dev/mixer and forward its request to this private volume controller. Changes to this volume object will not interfere with other channels. Requirements: - SNDCTL_DSP_[GET|SET][PLAY|REC]_VOL are newer ioctls (OSSv4) which require specific application modifications (preferred). - No modifications required for using bypass mode, so applications like mplayer or xmms should work out of the box. Kernel hints: - hint.pcm.%d.vpc (0 = disable vpc). Kernel sysctls: - hw.snd.vpc_mixer_bypass (default: 1). Enable or disable /dev/mixer bypass mode. - hw.snd.vpc_autoreset (default: 1). By default, closing/opening /dev/dsp will reset the volume back to 0 db gain/attenuation. Setting this to 0 will preserve its settings across device closing/opening. - hw.snd.vpc_reset (default: 0). Panic/reset button to reset all volume settings back to 0 db. - hw.snd.vpc_0db (default: 45). 0 db relative to linear mixer value.2 High quality fixed-point Bandlimited SINC sampling rate converter, based on Julius O'Smith's Digital Audio Resampling - http://ccrma.stanford.edu/~jos/resample/. It includes a filter design script written in awk (the clumsiest joke I've ever written) - 100% 32bit fixed-point, 64bit accumulator. - Possibly among the fastest (if not fastest) of its kind. - Resampling quality is tunable, either runtime or during kernel compilation (FEEDER_RATE_PRESETS). - Quality can be further customized during kernel compilation by defining FEEDER_RATE_PRESETS in /etc/make.conf. Kernel sysctls: - hw.snd.feeder_rate_quality. 0 - Zero-order Hold (ZOH). Fastest, bad quality. 1 - Linear Interpolation (LINEAR). Slightly slower than ZOH, better quality but still does not eliminate aliasing. 2 - (and above) - Sinc Interpolation(SINC). Best quality. SINC quality always start from 2 and above. Rough quality comparisons: - http://people.freebsd.org/~ariff/z_comparison/3 Bit-perfect mode. Bypasses all feeder/dsp effects. Pure sound will be directly fed into the hardware.4 Parametric (compile time) Software Equalizer (Bass/Treble mixer). Can be customized by defining FEEDER_EQ_PRESETS in /etc/make.conf.5 Transparent/Adaptive Virtual Channel. Now you don't have to disable vchans in order to make digital format pass through. It also makes vchans more dynamic by choosing a better format/rate among all the concurrent streams, which means that dev.pcm.X.play.vchanformat/rate becomes sort of optional.6 Exclusive Stream, with special open() mode O_EXCL. This will "mute" other concurrent vchan streams and only allow a single channel with O_EXCL set to keep producing sound.Other Changes: * most feeder_* stuffs are compilable in userland. Let's not speculate whether we should go all out for it (save that for FreeBSD 16.0-RELEASE). * kobj signature fixups, thanks to Andriy Gapon * pull out channel mixing logic out of vchan.c and create its own feeder_mixer for world justice. * various refactoring here and there, for good or bad. * activation of few more OSSv4 ioctls() (see [1] above). * opt_snd.h for possible compile time configuration: (mostly for debugging purposes, don't try these at home) SND_DEBUG SND_DIAGNOSTIC SND_FEEDER_MULTIFORMAT SND_FEEDER_FULL_MULTIFORMAT SND_FEEDER_RATE_HP SND_PCM_64 SND_OLDSTEREOManual page updates are on the way.Tested by: joel, Olivier SMEDTS , too many unsung / unnamed heroes. List of files: /freebsd-13.1/sys/dev/sound/pcm/buffer.c

e4e61333 - Last (again ?!?) major commit for RELENG_7, featuring total Giant

Sat, 16 Jun 2007 03:37:28 +0000

Last (again ?!?) major commit for RELENG_7, featuring total Gianteradication in/from userland path, countless locking fixes, etc.- General sleep call through msleep(9) has been converted to condvar(9) with better consistencies.- Heavily guard every possible "slow path" entries (open(), close(), few ioctl()s, sysctls), but once it entering "fast path" (io, interrupt started), they are free to fly on their own.- Rearrange locking sequences, resulting better concurrency and serialization. Large part doesn't even need locking at all, and will be removed in future. Less clutter, except in few places due to lock ordering.- Anonymous mixer object creation/deletion to simplify mixer handling beyond typical mixer ioctls. Submitted by: chibis (with modifications)- Add few mix_[get|set|..] functions to avoid calling mixer_ioctl() directly using cryptic arguments.- Locking fixes to avoid possible deadlock with (still under Giant) USB.- Better simplex/duplex device handling.- Recover mmap() functionality for recording, which has been lost since 2.2.x - 3.x (the introduction of newpcm). Full-duplex mmap still doesn't work (due to VM/page design), but people still can mmap both by opening each direction separately. mmaped playback is guarantee to work either way.- New sysctl: "hw.snd.compat_linux_mmap" to allow PROT_EXEC page mapping, due to recent changes in linux compatibility layer which require it. All linux applications that using sound + mmap() (mostly games) require this to be enabled. Disabled by default.- Other goodies.. too many, that will increase releng7 shareholder value and make users of releng6 (and below) cry ;)* This commit should be atomic. If anything goes wrong (not counting problem originated from elsewhere), I will not hesitate to revert everything back within 12 hours. This substantial changes itself not a rocket science and the process has begun for almost 2 years, and lots of incremental changes are already in place during that period of time.* Some issues does occur in snd_emu10kx (note the 'x') due to various internal locking issues and it is currently being worked on by chibis.Tested by: chibis (Yuriy Tsibizov), joel, Alexandre Vieira, many innocent souls... List of files: /freebsd-13.1/sys/dev/sound/pcm/buffer.c

504e00af - Buffer optimization and locking cleanup. Don't resize/malloc

Thu, 14 Jun 2007 11:15:51 +0000

Buffer optimization and locking cleanup. Don't resize/mallocunless it is really necessary to ease down unlock/lock sequence. List of files: /freebsd-13.1/sys/dev/sound/pcm/buffer.c

bba4862c - Last major commit and updates for RELENG_7:

Thu, 31 May 2007 18:43:33 +0000

Last major commit and updates for RELENG_7:- Rework the entire pcm_channel structure: * Remove rarely used link placeholder, instead, make each pcm_channel as head/link of each own/each other. Unlock - Lock sequence due to sleep malloc has been reduced. * Implement "busy" queue which will contain list of busy/active channels. This greatly reduce locking contention for example while servicing interrupt for hardware with many channels or when virtual channels reach its 256 peak channels.- So I heard you like v chan ... O RLY? Welcome to Virtual **Record** Channels (vrec, rec vchans, vchans for recording, Rec-Chan, you decide), the ultimate solutions for your nagging O_RDWR full-duplex wannabe (note: flash plugins) monopolizing single record channel causing EBUSY. Vrec works exactly like Vchans (or, should I rename it to "Vplay" :) , except that it operates on the opposite direction (recording). Up to 256 vrecs (like vchans) are possible. Notes: * Relocate dev.pcm.%d.{vchans,vchanformat,vchanrate} to each of its respective node/direction: dev.pcm.%d.play.* for "play" (cdev = dsp%d.vp%d) dev.pcm.%d.rec.* for "record" (cdev = dsp%d.vr%d) * Don't expect that it will magically give you ability to split "recording source" (eg: 1 channel for cdrom, 1 channel for mic, etc). Just admit that you only have a *single* recording source / channel. Please bug your hardware vendor instead :)- Bump maxautovchans from 4 to 16. For a full-fledged multimedia desktop/workstation with too many soundservers installed (esound, artsd, jackd, pulse/polypaudio, ding-dong pling plong mudkip fuh fuh, etc), 4 seems inadequate. There will be no memory penalty here, since virtual channels are allocate only by demand.- Nuke/Rework the entire statically created cdev entries. Everything is clonable through snd own clone manager which designed to withstand many kind of abusive devfs droids such as: * while : ; do /bin/test -e /dev/dsp ; done * jot 16777216 0 | while read x ; do ls /dev/dsp0.$x ; done * hundreds (could be thousands) concurrent threads/process opening "/dev/dsp" (previously, this might result EBUSY even with just 3 contesting threads/procs). o Reusable clone objects (instead of creating new one like there's no tomorrow) after certain expiration deadline. The clone allocator will decide whether to reuse, share, or creating new clone. o Automatic garbage collector.- Dynamic unit magic allocator. Maximum attached soundcards can be tuned using tunable "hw.snd.maxunit" (Default to 512). Minimum is 16, and maximum is 2048.- ..other fixes, mostly related to concurrency issues.joel@ will do the manpage updates on sound(4).Have fun. List of files: /freebsd-13.1/sys/dev/sound/pcm/buffer.c

2e334adf - sndbuf_alloc() now accept dmaflags argument which will be forwarded to

Wed, 18 Apr 2007 18:26:41 +0000

sndbuf_alloc() now accept dmaflags argument which will be forwarded tointernal bus_dmammem_alloc() for greater flexibility on setting up DMA /page attributes. List of files: /freebsd-13.1/sys/dev/sound/pcm/buffer.c

703c934a - Memory leak killing spree, mostly bus_dma(9) related.

Wed, 21 Mar 2007 18:17:03 +0000

Memory leak killing spree, mostly bus_dma(9) related. List of files: /freebsd-13.1/sys/dev/sound/pcm/buffer.c

4dfcb057 - [stage: 2/9]

Fri, 16 Mar 2007 17:13:44 +0000

[stage: 2/9]Use inlined min() rather than MIN() macross. List of files: /freebsd-13.1/sys/dev/sound/pcm/buffer.c

4beb77e6 - Spring cleanup on irrelevant NULL checking over M_WAITOK allocations.

Thu, 15 Mar 2007 18:19:01 +0000

Spring cleanup on irrelevant NULL checking over M_WAITOK allocations. List of files: /freebsd-13.1/sys/dev/sound/pcm/buffer.c

9e4c8259 - Fix huge memory leak within sound buffer (during channel destruction,

Thu, 01 Feb 2007 09:46:03 +0000

Fix huge memory leak within sound buffer (during channel destruction,buffer resizing, etc.) that was here since eon. Free all (unmanaged)allocated buffer through sndbuf_destroy() in case we forgot to callsndbuf_free(). For a managed buffer (mostly hw specific managed buffer),either provide CHANNEL_FREE() method with appropriate return value toinvoke semi-automatic sndbuf_free() or simply do it on their own. Ifeverything is failed, sndbuf_destroy() will come to the rescue as afinal measure.MFC after: 3 days List of files: /freebsd-13.1/sys/dev/sound/pcm/buffer.c