Changes in ipmi_kcs.c

15242987 - The current IPMI KCS code is waiting 100us for all transitions (roughly

Wed, 12 Jun 2019 16:06:31 +0000

The current IPMI KCS code is waiting 100us for all transitions (roughlybetween each byte either sent or received). However, most transitionsactually complete in 2-3 microseconds.By polling the status register with a delay of 4us with exponentialbackoff, the performance of most IPMI operations is significantlyimproved: - A BMC update on a Supermicro x9 or x11 motherboard goes from ~1 hour to ~6-8 minutes. - An ipmitool sensor list time improves by a factor of 4.Testing showed no significant improvements on a modern server by usinga lower delay.The changes should also generally reduce the total amount of CPU orI/O bandwidth used for a given IPMI operation.Submitted by: Loic Prylli Reviewed by: jhbMFC after: 2 weeksSponsored by: NetflixDifferential Revision: https://reviews.freebsd.org/D20527 List of files: /freebsd-13.1/sys/dev/ipmi/ipmi_kcs.c

74800c5a - In cases where an application issues certain IPMI commands at a high

Fri, 06 Apr 2018 15:15:21 +0000

In cases where an application issues certain IPMI commands at a highenough rate, the IPMI code can print large numbers of messages to theconsole, such as: ipmi0: KCS: Failed to read completion code ipmi0: KCS error: ff ipmi0: KCS: Failed to read completion code ipmi0: KCS error: ffThese seem to be innocuous from a system standpoint, and the user-space code can deal with the failures. Therefore, suppress printingthese messages to the console unless bootverbose is enabled.Obtained from: Netflix, Inc. List of files: /freebsd-13.1/sys/dev/ipmi/ipmi_kcs.c

718cf2cc - sys/dev: further adoption of SPDX licensing ID tags.

Mon, 27 Nov 2017 14:52:40 +0000

sys/dev: further adoption of SPDX licensing ID tags.Mainly focus on files that use BSD 2-Clause license, however the tool Iwas using misidentified many licenses so this was mostly a manual - errorprone - task.The Software Package Data Exchange (SPDX) group provides a specificationto make it easier for automated tools to detect and summarize well knownopensource licenses. We are gradually adopting the specification, notingthat the tags are considered only advisory and do not, in any way,superceed or replace the license texts. List of files: /freebsd-13.1/sys/dev/ipmi/ipmi_kcs.c

9662eef5 - Watchdog drivers need to support rearming the watchdog in contexts which

Fri, 24 Apr 2015 16:56:23 +0000

Watchdog drivers need to support rearming the watchdog in contexts whichare not permitted to sleep. Only use the IPMI watchdog with backendswhich poll driver-initiated requests to meet this requirement.In practice this means that watchdogs will no longer be used on systemsthat use the SSIF backend.Differential Revision: https://reviews.freebsd.org/D2062MFC after: 2 weeks List of files: /freebsd-13.1/sys/dev/ipmi/ipmi_kcs.c

c869aa71 - Use direct hardware access for internal requests for KCS and SMIC. In

Fri, 06 Feb 2015 16:45:10 +0000

Use direct hardware access for internal requests for KCS and SMIC. Inparticular, updates to the watchdog should no longer sleep.- Add a new IPMI_IO_LOCK for low-level I/O access. Use this for kcs_polled_request() and smic_polled_request().- Add a new backend callback "ipmi_driver_request" to handle a driver request. The new callback performs the request sychronously for KCS and SMIC. SSIF still defers the work to the worker thread since the worker thread sleeps during request processing anyway.- Allocate driver requests on the stack rather than using malloc().Differential Revision: https://reviews.freebsd.org/D1723Tested by: scottlMFC after: 2 weeks List of files: /freebsd-13.1/sys/dev/ipmi/ipmi_kcs.c

51f25040 - Explicitly treat timeouts when waiting for IBF or OBF to change state as an

Mon, 22 Dec 2014 16:53:04 +0000

Explicitly treat timeouts when waiting for IBF or OBF to change state as anerror. This fixes occasional hangs in the IPMI kcs thread when usingipmitool locally.MFC after: 1 week List of files: /freebsd-13.1/sys/dev/ipmi/ipmi_kcs.c

58e8e6e6 - Unlock IPMI sc while performing requests via KCS and SMIC interfaces.

Mon, 25 Mar 2013 14:30:34 +0000

Unlock IPMI sc while performing requests via KCS and SMIC interfaces.It is already done in SSIF interface code.This reduces contention/spinning reported by many users.PR: kern/172166Submitted by: Eric van Gyzen MFC after: 2 weeks List of files: /freebsd-13.1/sys/dev/ipmi/ipmi_kcs.c

93269b71 - - Tweak an error message.

Thu, 28 Aug 2008 02:11:04 +0000

- Tweak an error message.- Fix a buglet where && was used instead of & to test if OBF was set in a couple of places.MFC after: 1 week List of files: /freebsd-13.1/sys/dev/ipmi/ipmi_kcs.c

3745c395 - Rename the kthread_xxx (e.g. kthread_create()) calls

Sat, 20 Oct 2007 23:23:23 +0000

Rename the kthread_xxx (e.g. kthread_create()) callsto kproc_xxx as they actually make whole processes.Thos makes way for us to add REAL kthread_create() and friendsthat actually make theads. it turns out that most of thesecalls actually end up being moved back to the thread versionwhen it's added. but we need to make this cosmetic change first.I'd LOVE to do this rename in 7.0 so that we can eventually MFC thenew kthread_xxx() calls. List of files: /freebsd-13.1/sys/dev/ipmi/ipmi_kcs.c

d72a0786 - Update the ipmi(4) driver:

Fri, 22 Sep 2006 22:11:29 +0000

Update the ipmi(4) driver:- Split out the communication protocols into their own files and use a couple of function pointers in the softc that the commuication protocols setup in their own attach routine.- Add support for the SSIF interface (talking to IPMI over SMBus).- Add an ACPI attachment.- Add a PCI attachment that attaches to devices with the IPMI interface subclass.- Split the ISA attachment out into its own file: ipmi_isa.c.- Change the code to probe the SMBIOS table for an IPMI entry to just use pmap_mapbios() to map the table in rather than trying to setup a fake resource on an isa device and then activating the resource to map in the table.- Make bus attachments leaner by adding attach functions for each communication interface (ipmi_kcs_attach(), ipmi_smic_attach(), etc.) that setup per-interface data.- Formalize the model used by the driver to handle requests by adding an explicit struct ipmi_request object that holds the state of a given request and reply for the entire lifetime of the request. By bundling the request into an object, it is easier to add retry logic to the various communication backends (as well as eventually support BT mode which uses a slightly different message format than KCS, SMIC, and SSIF).- Add a per-softc lock and remove D_NEEDGIANT as the driver is now MPSAFE.- Add 32-bit compatibility ioctl shims so you can use a 32-bit ipmitool on FreeBSD/amd64.- Add ipmi(4) to i386 and amd64 NOTES.Submitted by: ambrisko (large portions of 2 and 3)Sponsored by: IronPort Systems, Yahoo!MFC after: 6 days List of files: /freebsd-13.1/sys/dev/ipmi/ipmi_kcs.c