en Copyright 2015 Java http://172.16.0.5:8080/history/freebsd-13.1/sbin/pfctl/tests/Makefile#44ec023c Rewrite pfctl_test in C to reduce testsuite run timeThe new C test takes 25 seconds on QEMU-RISC-V, wheras the shell versiontakes 332 seconds.Even with the latest optimizations to atf-sh this test still takes a fewseconds to startup in QEMU. Re-writing it in C reduces the runtime for asingle test from about 2-3 seconds to less than .5 seconds. Since thereare ~80 tests, this adds up to about 3-4 minutes.This may not seem like a big speedup, but before the recent optimizationsto avoid atf_get_srcdir, each test took almost 100 seconds on QEMU RISC-Vinstead of 3. This also significantly reduces the time it takes to listthe available test cases, which speeds up running the tests via kyua:```root@qemu-riscv64-alex:~ # /usr/bin/time kyua test -k /usr/tests/sbin/pfctl/Kyuafile pfctl_test_old...158/158 passed (0 failed) 332.08 real 42.58 user 286.17 sysroot@qemu-riscv64-alex:~ # /usr/bin/time kyua test -k /usr/tests/sbin/pfctl/Kyuafile pfctl_test158/158 passed (0 failed) 24.96 real 9.75 user 14.26 sysroot@qemu-riscv64-alex:/usr/tests/sbin/pfctl # /usr/bin/time ./pfctl_test pf1001pfctl_test: WARNING: Running test cases outside of kyua(1) is unsupportedpfctl_test: WARNING: No isolation nor timeout control is being applied; you may get unexpected failures; see atf-test-case(4)Running pfctl -o none -nvf /usr/tests/sbin/pfctl/./files/pf1001.in---binat on em0 inet6 from fc00::/64 to any -> fc00:0:0:1::/64binat on em0 inet6 from any to fc00:0:0:1::/64 -> fc00::/64---passed 0.17 real 0.06 user 0.08 sysroot@qemu-riscv64-alex:/usr/tests/sbin/pfctl # /usr/bin/time ./pfctl_test_old pf1001pfctl_test_old: WARNING: Running test cases outside of kyua(1) is unsupportedpfctl_test_old: WARNING: No isolation nor timeout control is being applied; you may get unexpected failures; see atf-test-case(4)Id Refs Name141 1 pfExecuting command [ pfctl -o none -nvf - ]passed 1.73 real 0.25 user 1.41 sysroot@qemu-riscv64-alex:/usr/tests/sbin/pfctl # /usr/bin/time ./pfctl_test_old -l > /dev/null 24.36 real 2.26 user 21.86 sysroot@qemu-riscv64-alex:/usr/tests/sbin/pfctl # /usr/bin/time ./pfctl_test -l > /dev/null 0.04 real 0.02 user 0.01 sys```The speedups are even more noticeable on CHERI-RISC-V (since QEMU runsslower when emulating CHERI instructions):```root@qemu-cheri-alex:/usr/tests/sbin/pfctl # /usr/bin/time ./pfctl_test_new -l > /dev/null 0.51 real 0.49 user 0.00 sysroot@qemu-cheri-alex:/usr/tests/sbin/pfctl # /usr/bin/time ./pfctl_test -l > /dev/null 34.20 real 32.69 user 0.16 sysroot@qemu-cheri-alex:/usr/tests/sbin/pfctl # /usr/bin/time ./pfctl_test pf1001pfctl_test: WARNING: Running test cases outside of kyua(1) is unsupportedpfctl_test: WARNING: No isolation nor timeout control is being applied; you may get unexpected failures; see atf-test-case(4)Id Refs Name147 1 pfExecuting command [ pfctl -o none -nvf - ]passed 5.74 real 5.41 user 0.03 sysroot@qemu-cheri-alex:/usr/tests/sbin/pfctl # /usr/bin/time ./pfctl_test_new pf1001pfctl_test_new: WARNING: Running test cases outside of kyua(1) is unsupportedpfctl_test_new: WARNING: No isolation nor timeout control is being applied; you may get unexpected failures; see atf-test-case(4)Running pfctl -o none -nvf /usr/tests/sbin/pfctl/./files/pf1001.in---binat on em0 inet6 from fc00::/64 to any -> fc00:0:0:1::/64binat on em0 inet6 from any to fc00:0:0:1::/64 -> fc00::/64---passed 0.68 real 0.66 user 0.00 sysroot@qemu-cheri-alex:/usr/tests/sbin/pfctl #```Reviewed By: kpDifferential Revision: https://reviews.freebsd.org/D26779 List of files: /freebsd-13.1/sbin/pfctl/tests/Makefile Wed, 14 Oct 2020 17:39:50 +0000 Alex Richardson <arichardson@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-13.1/sbin/pfctl/tests/Makefile#92fd0827 pkgbase: pfctl: tests: Put tests files in the FreeBSD-tests packageReviewed by: kp, gjbDifferential Revision: https://reviews.freebsd.org/D21521 List of files: /freebsd-13.1/sbin/pfctl/tests/Makefile Thu, 05 Sep 2019 14:19:06 +0000 Emmanuel Vadot <manu@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-13.1/sbin/pfctl/tests/Makefile#c964e17b pfctl test: Add a test for macro names with a space in it List of files: /freebsd-13.1/sbin/pfctl/tests/Makefile Sun, 28 Oct 2018 05:50:04 +0000 Kristof Provost <kp@FreeBSD.org> http://172.16.0.5:8080/history/freebsd-13.1/sbin/pfctl/tests/Makefile#4d7709dd pfctl parser testsCopy the most important test cases from OpenBSD's correspondingsrc/regress/sbin/pfctl, those that run pfctl on a test input file and checkcorrectness of its output. We have also added some new tests using the sameformat.The tests consist of a collection of input files (pf*.in) andcorresponding output files (pf*.ok). We run pfctl -nv on the inputfiles and check that the output matches the output files. If anydiscrepancy is discovered during future development in the sourcetree, we know that a regression bug has been introduced into the tree.Submitted by: paggasSponsored by: Google, Inc (GSoC 2017)Differential Revision: https://reviews.freebsd.org/D11322 List of files: /freebsd-13.1/sbin/pfctl/tests/Makefile Sat, 15 Jul 2017 19:22:01 +0000 Kristof Provost <kp@FreeBSD.org>